21755 Commits

Author	SHA1	Message	Date
Ryan Zmuda	8f6607ffec	Merge branch 'master' into master	2020-11-30 21:42:15 -05:00
Ryan Zmuda	e102f2e8fa	Moved enum to bottom, change defualt bind to Shift-Tab, Fixed Notification	2020-11-30 21:38:16 -05:00
ekrctb	604619ba47	Generalize legacy skin player test.	2020-12-01 09:49:04 +09:00
ekrctb	588a5c2aff	Remove empty comment	2020-12-01 09:35:28 +09:00
Bartłomiej Dach	2c57deea2b	Trim double full-stop in xmldoc	2020-11-30 19:43:20 +01:00
Bartłomiej Dach	5fbe1823a0	Merge branch 'master' into editor-beat-snap-always	2020-11-30 18:39:22 +01:00
Dean Herbert	51741c4791	Merge branch 'master' into hit-sample-pooling	2020-11-30 22:25:28 +09:00
Dean Herbert	a852a27dfb	Fix current beatmap temporarily becoming empty during ruleset change ... When changing the ruleset at song select, there was a scenario where it would be set to default (empty) for one debounce length where this was not actually required. This occurs when the currently selected beatmap set has other difficulties which match the target ruleset, specifically.	2020-11-30 19:36:30 +09:00
Dan Balasescu	c0a9d88a14	Merge branch 'master' into settings-reduce-visual-clutter	2020-11-30 19:30:39 +09:00
Dan Balasescu	6c6540addf	Merge pull request #11008 from peppy/settings-remove-transparency ... Remove semi-transparent backgrounds from settings and notifications overlays	2020-11-30 19:29:53 +09:00
smoogipoo	c29ad8edf8	Better API for dealing with the contained drawable samples	2020-11-30 19:26:25 +09:00
smoogipoo	f5e8d1d14d	Lose old reference immediately on updateSample()	2020-11-30 19:19:24 +09:00
Dean Herbert	7f34e11467	Merge pull request #10962 from smoogipoo/improve-dho-time-offsets ... Fix judgement offsets in non-framestable contexts	2020-11-30 19:13:25 +09:00
ekrctb	51bddd4a0f	Rename functions, and add NextInt.	2020-11-30 18:46:28 +09:00
smoogipoo	afb8eb636d	Apply simple PR reviews	2020-11-30 18:40:22 +09:00
Dean Herbert	3ad2eeaff5	Fix outdated xmldoc	2020-11-30 18:35:30 +09:00
Dean Herbert	c17d67bc7d	Merge branch 'master' into editor-beat-snap-always	2020-11-30 18:34:38 +09:00
smoogipoo	4bbeb9ebd4	Merge branch 'master' into hit-sample-pooling	2020-11-30 18:31:58 +09:00
Dan Balasescu	b56e832e83	Merge pull request #10950 from ekrctb/pool-scrolling ... Support hit object pooling in ScrollingPlayfield	2020-11-30 18:29:34 +09:00
ekrctb	731e689f2d	Add summary tags to the doc comments	2020-11-30 18:07:37 +09:00
smoogipoo	8f48389f89	Merge branch 'master' into improve-dho-time-offsets	2020-11-30 18:01:48 +09:00
Dean Herbert	965cc1f511	Remove unnecessary usings #2	2020-11-30 17:57:25 +09:00
Dean Herbert	46cab04929	Merge branch 'settings-remove-transparency' into settings-reduce-visual-clutter	2020-11-30 17:57:10 +09:00
Dan Balasescu	a3ef858f3a	Remove unnecessary multiplication	2020-11-30 17:56:04 +09:00
Dean Herbert	fe48b2279c	Adjust various paddings and spacings in settings to make them easier to visually parse	2020-11-30 17:50:35 +09:00
Dean Herbert	a3dd22f5c2	Merge branch 'master' into settings-remove-transparency	2020-11-30 17:50:26 +09:00
Dean Herbert	bf2c6dc241	Remove unused usings rider couldn't see	2020-11-30 17:49:55 +09:00
smoogipoo	7ac2fba127	More reordering of public vs private methods	2020-11-30 17:44:58 +09:00
Dan Balasescu	b0637cebd1	Merge branch 'master' into song-select-track-selected-better-2	2020-11-30 17:26:15 +09:00
Dan Balasescu	52cb30dff2	Merge pull request #10999 from bdach/user-interface-settings-section ... Create "User Interface" settings section	2020-11-30 17:25:04 +09:00
Dean Herbert	a4e061cb11	Remove semi-transparent backgrounds from settings and notifications overlays ... I tried also updating the colours to the "new" versions from designs but they don't match due to colour profile differences (so I'm not yet sure if they are correct or not) and also don't look great without all the UI elements also being updated.	2020-11-30 17:19:55 +09:00
Dan Balasescu	11d1450c76	Merge branch 'master' into fruit-bindables	2020-11-30 16:48:22 +09:00
Dean Herbert	4e1e45f3e7	Move hold-to-confirm back to UI section	2020-11-30 16:15:35 +09:00
Dean Herbert	55c8aa5d5f	Move menu cursor size to UI section	2020-11-30 16:14:15 +09:00
Dean Herbert	e14db45374	Reorder settings to (probably) feel more correct	2020-11-30 16:09:38 +09:00
Dean Herbert	2745659986	Reword and xmldoc some comments	2020-11-30 15:54:20 +09:00
Dan Balasescu	69c2a18220	Merge branch 'master' into fix-drawable-judgement-animation-loss	2020-11-30 14:05:03 +09:00
Dan Balasescu	0c36a3c263	Merge branch 'master' into pool-scrolling	2020-11-30 14:04:54 +09:00
Dan Balasescu	5a276f8577	Merge branch 'master' into fix-editor-reapply-same-state-change	2020-11-30 13:34:03 +09:00
Ryan Zmuda	9145557522	Revert "Revert "forgot to remove something... sorry"" ... This reverts commit 6478bed431.	2020-11-29 23:15:12 -05:00
Ryan Zmuda	6478bed431	Revert "forgot to remove something... sorry" ... This reverts commit a780a8bbd8.	2020-11-29 23:14:43 -05:00
Dan Balasescu	30dc0bc019	Merge pull request #10993 from LittleEndu/star-scale ... Scale stars from 0.4 to 1	2020-11-30 13:05:44 +09:00
Ryan Zmuda	a780a8bbd8	forgot to remove something... sorry	2020-11-29 21:52:58 -05:00
Ryan Zmuda	3994cf082d	add keybind for in game overlay	2020-11-29 20:59:02 -05:00
Bartłomiej Dach	e0a84ff1dc	Move hold-to-confirm setting back to gameplay section	2020-11-29 22:07:34 +01:00
Bartłomiej Dach	a5c4a8d2e9	Create "User Interface" settings section	2020-11-29 22:07:33 +01:00
Bartłomiej Dach	4057ca0a57	Merge branch 'master' into fix-editor-unnecessary-object-updates	2020-11-29 21:34:17 +01:00
Bartłomiej Dach	a3afd88387	Use Interpolation.Lerp	2020-11-28 20:35:03 +01:00
Endrik Tombak	8ad4cf73f5	Scale stars from 0.4 to 1	2020-11-28 17:09:43 +02:00
Dean Herbert	7e34c5e239	Fix state application always checking newest state for early abort, rather than current	2020-11-27 16:57:11 +09:00
Dean Herbert	18bb0cb45b	Remove unnecessary schedule logic from Apply's local updateState call ... There were cases in the editor where rewinding of transforms would leave the `DrawableHitObject` in a non-`IsPresent` state, resulting in this scheduled logic never running. This would in turn cause ghost hitobjects, which disappear under certain circumstances. Reproduction: - Open editor to empty beatmap - Place single hitcircle at current point in time - Drag editor timeline backwards to seek before zero, and wait for return to zero - Select hitcircle in playfield - Drag hitcircle to right in timeline, triggering a start time change	2020-11-27 16:32:05 +09:00
Dean Herbert	7edbba58f7	Avoid updating hitobjects unnecessarily for start time changes ... This was firing regardless of whether the start time was changed, such as where beat snap provided the same time the object already has. The case where a change actually occurs is already handled by EditorBeatmap (see `startTimeBindables`), so it turns out this local handling is not required at all.	2020-11-27 16:31:06 +09:00
ekrctb	a7194e1bc3	add stateless RNG	2020-11-27 15:43:44 +09:00
Dean Herbert	b9b8857988	Update framework	2020-11-27 15:11:07 +09:00
Dean Herbert	bcc197f9fe	Merge branch 'master' into improve-dho-time-offsets	2020-11-27 15:03:56 +09:00
Dean Herbert	792934f2c4	Allow scroll type to be specified ... This brings back the ability for the carousel to scroll in a classic way. It turns out this is generally what we want for "seek" operations like "random", else it's quite hard to get the expected animation. I did experiment with applying the animation after the pooled panels are retrieved, but in a best-case scenario there is still a gap where no panels are displayed during the random seek operation.	2020-11-27 13:54:38 +09:00
ekrctb	6e40de58e9	Use new OnAdd and OnRemove to invalidate DHO	2020-11-27 13:36:40 +09:00
ekrctb	8f5129323d	Merge branch 'master' into pool-scrolling	2020-11-27 13:12:05 +09:00
Dean Herbert	018957c244	Merge branch 'master' into song-select-track-selected-better-2	2020-11-27 12:54:40 +09:00
ekrctb	e36bb7631d	Fix colour not updated when index changes	2020-11-27 11:41:39 +09:00
ekrctb	57454bbb1c	Remove hitObject argument from OnApply and OnFree	2020-11-27 10:13:05 +09:00
Dean Herbert	5a393b153b	Merge pull request #10952 from peppy/replay-pausing-support ... Add ability to pause/resume replay playback	2020-11-27 02:26:23 +09:00
Dean Herbert	94dc61150b	Merge branch 'master' into fix-drawable-judgement-animation-loss	2020-11-27 00:43:47 +09:00
Dean Herbert	b1864670a2	Merge pull request #10961 from smoogipoo/better-dho-rewind ... Rewind pooled DHOs into better states	2020-11-27 00:42:58 +09:00
Dan Balasescu	220657c2cc	Merge branch 'master' into replay-pausing-support	2020-11-27 00:09:40 +09:00
Dan Balasescu	882fcdb13a	Merge pull request #10975 from peppy/standardise-binding-description-case ... Standardise binding description case to sentence casing	2020-11-26 23:54:13 +09:00
smoogipoo	aa4da2a5f8	Add xmldoc on State	2020-11-26 23:42:05 +09:00
Dean Herbert	1e79cb498b	Standardise binding description case to sentence casing	2020-11-26 20:07:16 +09:00
Dean Herbert	3346c06aca	Rename variable/text to be more verbose as to toggle purpose	2020-11-26 20:04:44 +09:00
Dean Herbert	741902f1b3	Merge pull request #10971 from smoogipoo/fix-timeline-combo-colour ... Fix timeline blueprints sometimes not receiving combo colours	2020-11-26 19:47:21 +09:00
Dean Herbert	da6bccc812	Apply beat snap if positional snap doesn't give a time result	2020-11-26 19:20:51 +09:00
Dean Herbert	91592cf32d	Expose EditorClock for consumption	2020-11-26 19:20:39 +09:00
Dean Herbert	9811c46e35	Rename application method to better describe what it actually does	2020-11-26 19:16:18 +09:00
ekrctb	05e245d445	Allow non-pooled DHO to be reused	2020-11-26 19:07:09 +09:00
Dean Herbert	0a48dd8f76	Delegate scroll animation to panels themselves	2020-11-26 18:42:51 +09:00
Dean Herbert	ad258e2e52	Update scroll position before applying any panel animations ... In the case of automatic scroll requirements (ie. scroll to selected) we are delegating the animation logic to the panels themselves. In order to make this work correctly, the scroll operation needs to take effect before any animation updates are run.	2020-11-26 18:33:41 +09:00
Dean Herbert	6058c66edb	Move drawable carousel set movement logic into panels themselves	2020-11-26 18:32:43 +09:00
Dean Herbert	f8db7a9902	Remove ScrollableContent container from carousel ... This was causing multiple issues with masking and sizing and really didn't need to exist in the first place. Also not sure why the pool was nested inside the scroll container, but it isn't any more. Probably for the best.	2020-11-26 18:28:54 +09:00
Dean Herbert	02d5b1352b	Expose generic version of OsuScrollContainer	2020-11-26 18:25:56 +09:00
smoogipoo	e53f849aa0	Completely separate combo colours from DHOs	2020-11-26 18:14:25 +09:00
smoogipoo	f562854feb	Fix timeline objects sometimes not receiving combo colours	2020-11-26 17:22:22 +09:00
Dan Balasescu	aad6cf4ad3	Merge branch 'master' into editor-multiple-object-positional-snap	2020-11-26 17:06:47 +09:00
Dan Balasescu	a0e47ae13f	Merge pull request #10960 from peppy/fix-editor-volume-adjust ... Fix volume not being adjustable in the editor using alt-scroll	2020-11-26 15:37:57 +09:00
ekrctb	eae33fe74a	Fix format	2020-11-26 14:16:33 +09:00
ekrctb	e43f928588	Use DHO.HitObjectApplied to invalidate computation	2020-11-26 14:07:40 +09:00
ekrctb	f6faf95e33	Revert changes to HitObjectUsageBegan, not use it.	2020-11-26 14:01:46 +09:00
ekrctb	1a6e5bdaba	Merge branch 'master' into pool-scrolling	2020-11-26 13:52:52 +09:00
Bartłomiej Dach	8ff1688c4b	Merge branch 'master' into fix-drawable-judgement-animation-loss	2020-11-25 20:11:09 +01:00
smoogipoo	0414e5c550	Add MaximumJudgementOffset to DrawableHitObject, use in more places	2020-11-26 01:12:42 +09:00
smoogipoo	c744db1b57	Rewind pooled DHOs into better states	2020-11-26 00:42:25 +09:00
Dean Herbert	0ddeff648d	Fix incorrect index lookup on non-ordered selections	2020-11-25 17:25:54 +09:00
Dean Herbert	d4c6d6275e	Fix volume not being adjustable in the editor using alt-scroll ... We do this in other places so I think it's fine to handle like this for now (until we come up with a better global solution). Closes #10958.	2020-11-25 16:46:22 +09:00
Dean Herbert	c46d655832	Uncomment incorrectly commented lines	2020-11-25 12:11:44 +09:00
ekrctb	b8a5cd94f7	Invoke HitObjectUsageFinished before removal	2020-11-24 19:46:57 +09:00
Dan Balasescu	4311526c0a	Merge branch 'master' into on-drawable-hitobject-added	2020-11-24 19:23:54 +09:00
ekrctb	e34a205104	Rewrite hit object management, take three	2020-11-24 18:56:05 +09:00
ekrctb	7f6e4d5b21	Delay lifetime computation until loaded	2020-11-24 18:56:05 +09:00
ekrctb	d5f082e5fb	Comment about lifetime assumption	2020-11-24 18:56:05 +09:00
ekrctb	ce57e8ddfb	Separate Lifetime computation and layout update	2020-11-24 18:56:05 +09:00
ekrctb	cabc8aa63b	Revert "Simplify ScrollingHitObjectContainer logic" ... This reverts commit b4cc39149c117e6a0e95ee917a67cec8ba723d06.	2020-11-24 18:56:05 +09:00
ekrctb	8f39b54e58	Simplify ScrollingHitObjectContainer logic	2020-11-24 18:56:05 +09:00
ekrctb	5c743adbae	Support hit object pooling scrolling playfield	2020-11-24 18:56:05 +09:00
Dean Herbert	d5a4d46c6d	Merge pull request #10842 from EVAST9919/profile-overlay-graph-new ... Implement history charts for Profile Overlay	2020-11-24 18:05:17 +09:00
Dean Herbert	c9a41f9dae	Make all objects in selection candidates for spatial snapping ... Closes #10898.	2020-11-24 17:35:54 +09:00
Dan Balasescu	5d65665b42	Merge pull request #10943 from peppy/editor-setup-scroll-to-file-selector ... Scroll editor setup screen to file selector on display	2020-11-24 16:26:25 +09:00
Dan Balasescu	87ce8a53ff	Merge branch 'master' into on-drawable-hitobject-added	2020-11-24 16:09:57 +09:00
Dean Herbert	bd1dad5477	Remove null allowance for now	2020-11-24 15:54:27 +09:00
Dean Herbert	1d82557d9f	Avoid blocking global actions when skip overlay is not actually active	2020-11-24 15:42:14 +09:00
Dean Herbert	72b8eef36e	Add ability to pause/resume replay playback	2020-11-24 15:41:56 +09:00
Dean Herbert	1682260677	Remove left over logging line	2020-11-24 15:28:03 +09:00
Dean Herbert	ee33f62809	Fix DrawableJudgement not always animating correctly on skin change ... If the skin is changed before gameplay has started (at the loading screen) it is possible for a sequence of events to occur which results in the animation not being played: - `SkinReloadableDrawable` runs its BDL load (and calls `OnSkinChanged` once) - User changes skin, triggering `DrawableJudgement`'s skin change handling (binding directly on the `SkinSource` locally) - This will call `PrepareDrawables` and reinitialise the `SkinnableDrawable` child hierarchy, then immediately apply the animations to it. - The new `SkinnableDrawable` will then get the `SkinChanged` event and schedule a handler for it, which will run on its first Update call. - Any added animations will be lost as a result. Fixed by binding directly to the `SkinnableDrawable`'s `OnSkinChanged`. This has the added bonus of not needing to reinitialise the child hierarchy on skin change (which felt a bit weird in the first place).	2020-11-24 15:23:53 +09:00
Dan Balasescu	57ff150051	Merge pull request #10829 from Joehuu/music-osd-bindings ... Add music bindings to on screen display	2020-11-24 14:36:34 +09:00
Joehu	1fd4b04767	Just set music shortcut text locally	2020-11-23 20:43:46 -08:00
Dean Herbert	e36b1051c1	Add spacing between inline comments	2020-11-24 13:15:59 +09:00
Dean Herbert	82640418ba	Invert hide logic for readability	2020-11-24 13:12:04 +09:00
Dean Herbert	44ca67c534	Simplify fill logic and add xmldoc	2020-11-24 13:10:11 +09:00
Dean Herbert	37ea65de2a	Merge branch 'master' into profile-overlay-graph-new	2020-11-24 12:52:59 +09:00
Joehu	52f5473cc0	Set global action as a parameter in toast	2020-11-23 15:13:58 -08:00
Bartłomiej Dach	5701b32bae	Handle constant graphs better	2020-11-23 22:12:32 +01:00
Bartłomiej Dach	8347ecf494	Simplify row tick creation code	2020-11-23 21:52:47 +01:00
Bartłomiej Dach	7b0d3dfe0c	Refactor tick calculation code for readability	2020-11-23 21:38:04 +01:00
Bartłomiej Dach	bb5aa9a9c9	Guard against empty values early	2020-11-23 21:24:37 +01:00
Bartłomiej Dach	e9ffeb8b5d	Make missing date check more robust	2020-11-23 21:09:42 +01:00
Dean Herbert	060acb9010	Merge pull request #10935 from bdach/fix-mania-judgement-fade-in ... Rewind judgement transforms before clearing	2020-11-23 17:05:04 +09:00
Dean Herbert	5e014fc4fe	Merge pull request #10941 from LumpBloom7/improve-MenuVisualizer ... Improve LogoVisualisation looks when MenuGlow colors are used	2020-11-23 15:25:18 +09:00
Dean Herbert	19faa2b9bb	Add comment covering intentional call to ClearTransformsAfter	2020-11-23 15:20:59 +09:00
Andrei Zavatski	1b33d30039	Simplify horizontal ticks creation	2020-11-23 08:52:29 +03:00
Andrei Zavatski	42741895e6	Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-overlay-graph-new	2020-11-23 08:41:57 +03:00
Dean Herbert	898e2dae27	Restore kiai time flashing behaviour	2020-11-23 14:27:02 +09:00
Dean Herbert	5662e722ed	Merge pull request #10936 from bdach/fix-follow-points-getting-stuck ... Fix legacy follow point animations not playing after a while	2020-11-23 14:14:00 +09:00
Dean Herbert	3ed7868801	Scroll editor setup screen to file selector on display ... Previously the file selector would potentially display off-screen, making for confusing UX. Closes #10942.	2020-11-23 13:49:14 +09:00
Dean Herbert	ae609b9d48	Remove unnecessary local variable	2020-11-23 13:35:13 +09:00
Dean Herbert	2ae5a95d77	Change opacity value to match master implementation	2020-11-23 13:35:02 +09:00
Derrick Timmermans	61078e9ae1	Use 0.2f instead of .2f	2020-11-22 18:59:16 +01:00
Derrick Timmermans	ba7ce4c933	Make colour readonly	2020-11-22 18:37:49 +01:00
Derrick Timmermans	458016d17d	Remove AccentColour member variable from LogoVisualisation	2020-11-22 17:36:59 +01:00
Derrick Timmermans	1551402a8d	Change IntroWelcome visualiser to use Colour instead of AccentColour	2020-11-22 17:33:40 +01:00
Derrick Timmermans	b468f061f1	Remove unused using	2020-11-22 17:20:00 +01:00
Derrick Timmermans	cc33b0f2c6	Apply MenuGlow to Visualisation Colour instead of AccentColour	2020-11-22 16:53:53 +01:00
Bartłomiej Dach	827a089810	Merge branch 'master' into change-taiko-ez	2020-11-22 13:29:02 +01:00
Bartłomiej Dach	1c31a4a6b6	Expose animation start time as mutable in interface	2020-11-22 13:11:22 +01:00
Bartłomiej Dach	b62a873502	Merge branch 'master' into remove-default-retry-balue	2020-11-22 10:54:40 +01:00
ekrctb	666112cb5a	Address @bdach's minor suggestions	2020-11-22 18:51:16 +09:00
ekrctb	c506b438bf	Remove more code and make some methods private	2020-11-22 18:51:16 +09:00
Dean Herbert	a3b1d14f17	Apply similar fix to PoolableSkinnableSound	2020-11-22 14:44:39 +09:00
Andrei Zavatski	b745fb681a	Fix incorrect static using placement	2020-11-22 04:40:55 +03:00
Andrei Zavatski	4887132947	Adjustments for edge cases support	2020-11-22 04:28:17 +03:00
Andrei Zavatski	f07f8089d6	Adjust monthsPerTick value	2020-11-22 03:58:56 +03:00
Andrei Zavatski	e6c116f0ab	Rework horizontal ticks creation	2020-11-22 03:49:00 +03:00
Andrei Zavatski	6e581902cd	Simplify column ticks creation	2020-11-22 03:11:38 +03:00