tsrk
44297a7d0a
refactor: make KCD a CompositeDrawable
2023-03-08 00:47:16 +00:00
Bartłomiej Dach
72695f7c90
Merge branch 'master' into omit-barline-in-timing-control-point
2023-03-07 22:46:24 +01:00
Bartłomiej Dach
cfafa8af8c
Merge branch 'master' into hud/player-components
2023-03-07 19:44:12 +01:00
Cootz
5d41d343fd
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-03-07 15:46:52 +03:00
Dean Herbert
28520414aa
Move KeyCounter components to HUD namespace
2023-03-07 16:41:39 +09:00
Dean Herbert
15d65059b5
Tidy up Add method logic
2023-03-07 16:21:57 +09:00
Dean Herbert
8f6df5ea0f
Merge branch 'master' into gameplay/key-counter-abstraction
2023-03-07 16:09:45 +09:00
Dean Herbert
d2fcdf6e0e
Add test coverage of cyclic selection in skin editor
2023-03-07 15:11:47 +09:00
tsrk
952814604e
style: fix late night oopsies
2023-03-06 20:06:56 +00:00
Bartłomiej Dach
ec15e2b9cc
Merge branch 'master' into dont-filter-results-on-sort-mode
2023-03-06 17:57:47 +01:00
tsrk
ddee6400df
test: add coverage for Player{Avatar,Flag}
2023-03-05 23:46:51 +00:00
Bartłomiej Dach
9d4bb2ecf7
Add failing test coverage for clearing sidebar contents
2023-03-04 14:08:50 +01:00
Bartłomiej Dach
2f25fb4083
Move NonSkinnableScreenPlaceholder to outer scope
2023-03-04 13:22:43 +01:00
Bartłomiej Dach
3dd3b5e77a
Add failing test case
2023-03-04 13:17:54 +01:00
Cootz
322f3e86ba
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-03-03 20:02:09 +03:00
Dean Herbert
a14dede036
Ensure TestBeatmapCarousel.Items only returns actually visible items (and in correct order)
...
Turns out that items could be in an order that isn't the same as how
things look on the carousel, so this change ensures that for testing
purposes they are sorted by Y position.
Also uses the `CarouselItem.Visible` flag to ensure that we don't have
to wait for drawable fade transitions after a filter operation.
2023-03-03 17:18:34 +09:00
Dean Herbert
7a092ea995
Add better coverage and more comments explaining the structure of test setup
2023-03-03 17:18:14 +09:00
Dean Herbert
82293c0c86
Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
...
From a user's perspective, changing a sort / order mode shouldn't filter
away results, but we were doing this.
In terms of UX expectations, in stable this kind of scenario would
results in a group being added to the end of son select with "Not
ranked" or "Unknown". I think we should aim to match this eventually.
2023-03-03 16:36:18 +09:00
Dean Herbert
bd11d5d29a
Merge pull request #22743 from Joehuu/scroll-back-to-previous
...
Add ability to scroll back to previous position after scrolling to top via button on overlays
2023-03-01 22:55:47 +09:00
Dean Herbert
1250c1f0c1
Update test assertions to match stable expectations
...
These changes were taken from https://github.com/ppy/osu/pull/22582 .
Minor adjustments were applied to match stable expectations, which is to
say there cannot be an inherited control point with omit barline
specification (in the editor the setting is greyed out when inheritance
is turned on).
2023-02-28 19:28:21 +09:00
Dean Herbert
2615453b31
Rename SettingSource tests to match attribute name
2023-02-28 11:45:32 +09:00
Bartłomiej Dach
92edb0f868
Merge branch 'master' into skin-editor-depth-changing
2023-02-27 19:24:53 +01:00
Joseph Madamba
fa710ae1b0
Rename ScrollToTopButton to ScrollBackButton
2023-02-26 14:39:34 -08:00
Joseph Madamba
d98d330da2
Add expected behavior test for scroll back to previous position
2023-02-26 14:30:46 -08:00
Dan Balasescu
dd9748a25c
Adjust DrawNodes to use UBOs
2023-02-25 01:42:55 +09:00
tsrk
6307b3948a
style: use Trigger initialisation
2023-02-22 17:59:39 +00:00
Bartłomiej Dach
d679703fa2
Merge pull request #22659 from peppy/fix-taiko-drum-nested-sample-detection
...
Fix `GameplaySampleTriggerSource` not considering nested objects when determining the best sample to play
2023-02-22 18:56:59 +01:00
tsrk
1beec71037
refactor(KeyCounterDisplay): apply suggestions
...
I also took the freedom to add type checking, as we can't limit the
usage of `Add()` since it's a Container. The exception thrown also
advises of using the suggested `AddTrigger()` instead.
2023-02-22 14:58:27 +00:00
Dean Herbert
a8c692a215
Merge pull request #22635 from peppy/use-overlays-container-more
...
Use `Overlays` container rather than `KeyBindingInputManager` for flashlight
2023-02-22 18:30:21 +09:00
Dean Herbert
32a9c066df
Add test coverage of bring-to-front / send-to-back operations
2023-02-22 18:17:20 +09:00
Dean Herbert
90ca635a17
Fix weird nullability in TestSceneSkinEditor
2023-02-22 18:17:20 +09:00
Dean Herbert
f61fbcf3fc
Update assertion to also check GameplayClockContainer's current time
2023-02-22 15:26:09 +09:00
Dean Herbert
a511e64fa5
Seek using GameplayClockContainer
2023-02-22 14:41:20 +09:00
Bartłomiej Dach
d59d153654
Fix test compile failures from Audio hoisting
2023-02-21 21:03:00 +01:00
Bartłomiej Dach
3d2fcb0cca
Merge branch 'master' into fix-taiko-drum-nested-sample-detection
2023-02-21 20:53:06 +01:00
Bartłomiej Dach
ec1bf7b0b2
Merge branch 'master' into skin-editor-clipboard
2023-02-21 19:35:58 +01:00
Cootz
1fa6864500
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-02-21 18:47:59 +03:00
Cootz
90aa4288d0
Reduce the allowed length by 5 to account for (99) suffix. Move truncating logic to GetFilename. Update tests.
2023-02-21 18:35:53 +03:00
Dean Herbert
9321ec29dc
Update slider sample source asserts to match expected behaviour
...
As pointed out in review, if the current time is after the end of the
slider, the correct hit object to use for sample retrieval is the object
itself, not any nested object.
2023-02-21 14:04:38 +09:00
Dean Herbert
e686b4393e
Add wait steps to ensure frame-stable clock has caught up before checking state
2023-02-21 14:04:19 +09:00
Dean Herbert
5ba6059911
Merge branch 'master' into fix-taiko-drum-nested-sample-detection
2023-02-21 13:58:15 +09:00
Bartłomiej Dach
c9999bdeb1
Merge branch 'master' into skin-per-ruleset-layouts
2023-02-20 20:14:38 +01:00
Bartłomiej Dach
3183f5cee2
Merge branch 'master' into revert-result-in-playfield
2023-02-19 16:33:10 +01:00
Cootz
5fa75805cc
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-02-18 15:52:17 +03:00
Bartłomiej Dach
704dddf14b
Merge branch 'master' into skin-editor-clipboard
2023-02-17 22:59:18 +01:00
Bartłomiej Dach
6b9472c367
Merge branch 'master' into skin-per-ruleset-layouts
2023-02-17 22:58:38 +01:00
Bartłomiej Dach
6afa65bd3d
Merge branch 'master' into skinnable-clean-up-documentation
2023-02-17 20:59:18 +01:00
Dean Herbert
9793774377
Update SkinDeserialisationTest to work with new serialisation structure
2023-02-17 16:22:48 +09:00
Dean Herbert
6b3652f567
Change serialisation format of skin layouts to allow more flexibility
...
Also adds per-ruleset storage for each container type.
2023-02-17 14:19:19 +09:00
Dean Herbert
372b6b794c
I don't know what .ots is but let's not use random file extension that make no sense
2023-02-17 13:46:27 +09:00
Dean Herbert
8ef3fb26e0
More constants and assert fixes
2023-02-17 13:46:27 +09:00
Dean Herbert
86d110e893
Simplify test storage by removing nested storage
2023-02-17 13:43:42 +09:00
Dean Herbert
4560ae6b02
Mark test as fixture
2023-02-17 13:39:31 +09:00
Dean Herbert
99236f0ae8
Move long filename to fixture level
2023-02-17 13:39:24 +09:00
Dean Herbert
96b1498932
Rename max length variable to make sense (it's a filename limit, not path)
2023-02-17 13:33:22 +09:00
Dean Herbert
415220a447
Tidy up new test method code quality
2023-02-17 13:30:00 +09:00
Cootz
810712386d
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-02-17 01:51:24 +03:00
Cootz
f4038a49a1
Fix inspectCode issues
2023-02-17 01:50:24 +03:00
Cootz
1d8b348e4c
Improve naming
2023-02-17 01:46:15 +03:00
Cootz
6cb00cd42f
Add more test cases
2023-02-17 01:44:45 +03:00
tsrk
ddd6c1a1c6
refactor(KeyCounter): address bindables issues
...
`IsCounting` is back being an auto-property.
`countPresses` is now encapsulated and being exposed as an
`IBindable<int>` via `CountPresses`
2023-02-16 22:20:34 +00:00
Bartłomiej Dach
3ee046000e
Merge branch 'master' into revert-result-in-playfield
2023-02-16 21:54:29 +01:00
Bartłomiej Dach
2fdf1fd876
Merge branch 'master' into fix-taiko-drum-nested-sample-detection
2023-02-16 19:43:02 +01:00
Bartłomiej Dach
5bdc5dfadd
Add one more assert to keep coverage from previous implementation
2023-02-16 19:02:51 +01:00
Cootz
6819a45a1b
Improve code slightly
2023-02-16 16:42:07 +03:00
Cootz
f1da213bea
Add tests
2023-02-16 16:26:57 +03:00
Dean Herbert
b59ec551f6
Add test coverage of GameplaySampleTriggerSource not considering nested objects
2023-02-16 18:21:33 +09:00
Dean Herbert
979c079f8b
Refactor GameplaySampleTriggerSource test to not be realtime dependent
2023-02-16 17:58:44 +09:00
Dean Herbert
9d02a2ef0e
Apply NRT to GamepleSampleTriggerSource tests
2023-02-16 17:58:44 +09:00
Dean Herbert
2fbaf88a3c
Add clipboard dependency to SkinEditor specific tests
...
This is usually provided by the `SkinEditorOverlay`, which is not always
present in tests.
2023-02-16 15:24:38 +09:00
tsrk
076eb81b21
refactor: rename trigger classes
...
Makes it better to understand their purpose
2023-02-15 21:46:13 +00:00
tsrk
157bba7830
refactor: rename Trigger class to InputTrigger
2023-02-15 21:41:36 +00:00
Dean Herbert
a92e42bb84
Rename SkinnableTargetContainer to SkinComponentsContainer
...
Also use full `SkinComponentsContainerLookup` instead of the sub-type.
This will potentially be useful once we bring in per-ruleset targets.
2023-02-15 18:37:41 +09:00
Dean Herbert
b1cf6d83d8
Move extension methods closer to serialisation classes
2023-02-15 18:37:41 +09:00
Dean Herbert
d159d6b970
Rename ISkinnableDrawable to ISerialisableDrawable
2023-02-15 18:37:41 +09:00
Dean Herbert
856efd9fd9
Rename SkinnableDrawableInfo to SerialisedDrawableInfo
2023-02-15 18:23:19 +09:00
Dean Herbert
9e651a7ca2
Rename SkinnableInfo to SkinnableDrawableInfo
2023-02-15 18:23:17 +09:00
Dean Herbert
6010dde86e
Move SkinnableInfo to better namespace
2023-02-15 18:23:10 +09:00
Dean Herbert
d9b4d932c9
Fix test container lookup failure
2023-02-15 17:47:34 +09:00
Dean Herbert
ca75f0ec77
Apply NRT to TestSceneBeatmapSkinFallbacks
2023-02-15 17:30:21 +09:00
Dean Herbert
8bbd00822c
Simplify and rename SkinnableTargetComponentsContainer
2023-02-15 17:30:21 +09:00
Dean Herbert
51d4ae5241
Merge branch 'master' into footer_V2_implementation
2023-02-14 14:00:53 +09:00
Bartłomiej Dach
939144fb6c
Merge pull request #22628 from EVAST9919/letterbox-no-containers
...
Remove unnecessary containers in `LetterboxOverlay`
2023-02-13 23:54:48 +01:00
mk56-spn
6e6421caea
Change FooterV2.cs colour to use ColourProvider instead of OsuColour.
...
Remove unnecessary `FillFlowContainer`
2023-02-13 22:12:25 +01:00
Andrei Zavatski
006356e617
Add TestSceneLetterboxOverlay
2023-02-13 14:17:33 +03:00
tsrk
11d0e185b8
refactor: separate impl of KeyCounterDisplay
...
This allows for different layouts of display. Idk, maybe someone would
want to mix both variants? (don't do this please). This commit is mostly
prep for further changes.
2023-02-13 01:36:12 +00:00
Joseph Madamba
cb51b9e350
Use existing ModdingBeatmap activity
2023-02-12 15:01:50 -08:00
Joseph Madamba
bbeef53569
Add TestingBeatmap activity
2023-02-12 13:11:42 -08:00
Joseph Madamba
afb66d8af4
Make user activity class names more specific
2023-02-12 12:32:17 -08:00
Bartłomiej Dach
7b2c5ab7eb
Merge pull request #22608 from peppy/update-dependencies
...
Update realm and other dependencies
2023-02-11 12:37:02 +01:00
Dean Herbert
20f3ab167e
Re-centralise BannedApiAnalysers nuget package
2023-02-11 19:36:40 +09:00
Bartłomiej Dach
8292052dc2
Merge pull request #22598 from peppy/fix-skip-intro-replay
...
Fix "skip" key binding no longer working in replay playback
2023-02-11 11:27:10 +01:00
Dean Herbert
0c5dae5f26
Merge pull request #22529 from ItsShamed/dsc/presence
...
Add support for `Watching` and `Spectating` activities in `ReplayPlayer` and `SoloSpectatingPlayer`
2023-02-11 17:29:47 +09:00
Dean Herbert
86c8675910
Update realm and other dependencies
2023-02-11 13:52:24 +09:00
Dean Herbert
96fbd04698
Add failing test coverage of skip no longer working in replay playback
2023-02-10 18:57:04 +09:00
Dean Herbert
eccde923e5
Merge pull request #22554 from Walavouchey/ranking-accuracycircle-readability
...
Improve readability of `AccuracyCircle`
2023-02-10 17:03:46 +09:00
ekrctb
5ddaf8ea3c
Fix test setting invalid TimeOffset
2023-02-09 17:43:04 +09:00
Dean Herbert
92eb6b6717
Simplify TestSceneAccuracyCircle test specifications
2023-02-09 15:42:03 +09:00
Joseph Madamba
3b5d573db1
Display tournament banner on user profile
2023-02-08 17:16:09 -08:00
Walavouchey
9544a1d26d
use values closer to the extremities for test cases
2023-02-09 00:02:32 +01:00
