4914 Commits

• Merge branch 'master' into tidy-results-grid-usage
  Bartłomiej Dach · 2023-06-03 19:45:23 +02:00
  331e90f720
• Fix "bubbles" mod not adding pool to hierarchy (and constructing too early)
  Dean Herbert · 2023-06-02 23:01:03 +09:00
  a5fd833214
• Return StatisticItems rather than StatisticRows from ruleset

  There were no usages of more than one column being provided per row, so
  it seemed like unnecessarily complexity. I'm currently trying to reduce
  complexity so we can improve the layout of the results screen, which
  currently has up to three levels of nested `GridContainer`s.
  
  Of note, I can't add backwards compatibility because the method
  signature has not changed in `Ruleset` (only the return type). If we do
  want to keep compatibility with other rulesets, we could designate a new
  name for the updated method.

  Dean Herbert · 2023-06-01 14:35:15 +09:00
  985604fab5
• Add back required override to make AccuracyHeatmap work
  Dean Herbert · 2023-06-01 13:26:47 +09:00
  e830b96e61
• Merge pull request #23696 from peppy/fix-autopilot-ripples

  Fix cursor ripples appearing in a weird place when "autopilot" mod is enabled

  Bartłomiej Dach · 2023-05-30 23:29:30 +02:00
  aaf50c47a7
• Fix cursor ripples appearing in a weird place when "autopilot" mod is enabled
  Dean Herbert · 2023-05-30 15:18:23 +09:00
  3e94d4bb5a
• Merge branch 'master' into scorev2
  Dean Herbert · 2023-05-29 20:06:32 +09:00
  1558723420
• Merge branch 'master' into slider-control-point-no-distance-snap
  Bartłomiej Dach · 2023-05-26 19:52:54 +02:00
  53c91349fe
• Don't snap non-head slider nodes to distance grid during placement either

  1cd69220ef only disabled snapping the
  aforementioned nodes to distance grid for already-placed sliders.
  `SliderPlacementBlueprint` has its own logic for placement, so the fix
  needs to be mirrored there too.

  Bartłomiej Dach · 2023-05-26 19:51:20 +02:00
  e35201cb99
• Merge pull request #23577 from peppy/accuracy-heatmap-text-hints

  Show text hints on the accuracy heat map to better explain direction

  Bartłomiej Dach · 2023-05-25 17:00:25 +02:00
  e8db0739fa
• Fix slider path placement snapping non-head nodes to distanced snapping grid

  As discussed at https://github.com/ppy/osu/discussions/23531.

  Dean Herbert · 2023-05-25 21:41:43 +09:00
  1cd69220ef
• Split out grid snapping modes into "relative" and "global" types
  Dean Herbert · 2023-05-25 21:41:19 +09:00
  804671ca74
• Merge branch 'master' into scorev2
  Dan Balasescu · 2023-05-23 19:07:54 +09:00
  fee3d43596
• Adjust text and alignment
  Dean Herbert · 2023-05-23 16:21:56 +09:00
  c8303d55cd
• Merge pull request #23582 from peppy/placement-blueprint-timeline-combo-fixes

  Fix timeline blueprint display not showing correct combo number / colour during placement

  Bartłomiej Dach · 2023-05-20 15:02:55 +02:00
  afdddb0195
• Rename parameters
  Dan Balasescu · 2023-05-19 17:27:02 +09:00
  30a296bd09
• Refactor for safety
  Dan Balasescu · 2023-05-19 14:37:26 +09:00
  d74bf2a096
• Avoid NaN values during ApplyBeatmap processing()
  Dan Balasescu · 2023-05-19 14:14:34 +09:00
  2ae34530f7
• Remove ClassicScoreMultiplier and DefaultScoreProcessor
  Dan Balasescu · 2023-05-19 12:24:52 +09:00
  8b56a3f87d
• Make EditorClock non-nullable in PlacementBlueprint
  Dean Herbert · 2023-05-17 21:40:52 +09:00
  b58ab28765
• Add text hints to accuracy heat map to better describe travel direction
  Dean Herbert · 2023-05-17 15:22:48 +09:00
  3054348c73
• Enable NRT on AccuracyHeatmap
  Dean Herbert · 2023-05-17 15:03:59 +09:00
  9fe787acd8
• Rename GetSampleInfo to better describe what method does

  Also add full xmldoc

  Dean Herbert · 2023-05-17 14:07:48 +09:00
  dc51d5ecf3
• Merge branch 'master' into master
  Bartłomiej Dach · 2023-05-14 19:45:31 +02:00
  a6ddb107cd
• updates and add changes
  alix · 2023-05-14 13:37:44 -04:00
  d503312788
• Move blueprint validity conditions to allow more correct external usage of EndPlacement

  Until now, these were haphazardly enforce inline in blueprint
  implementations. The only thing stopping complete breakage is that
  `EndPlacement` wasn't called (too much) from outside the blueprint,
  leaving them responsible for their own placement.
  
  By moving this conditional out of the provided paramters to
  `EndPlacement`, it allows more flexible usage of that method externally.
  Coming in a future PR.

  Dean Herbert · 2023-05-12 16:02:22 +09:00
  f443cfb93e
• nest class outside of OsuModRandom
  alix · 2023-05-12 00:29:00 -04:00
  b3a5e4d305
• fix indents
  alix · 2023-05-11 23:50:45 -04:00
  53ab780796
• move class to the bottom of the file
  alix · 2023-05-11 23:48:31 -04:00
  e50cab9e81
• fix precision from making mouse input also go 0.5
  alix · 2023-05-11 23:45:41 -04:00
  a4954e64ac
• Copy SliderVelocity to strict tracking sliders
  js1086 · 2023-05-11 19:07:22 +01:00
  3bce7ac589
• fix angle sharpness slider value from not always scaling by 0.5
  alix · 2023-05-11 13:46:07 -04:00
  4732c8a06c
• Reimplement classic scoring mode
  Dan Balasescu · 2023-05-09 20:21:38 +09:00
  a7b623f52a
• Initial implementation of ScoreV2
  Dan Balasescu · 2023-05-09 19:33:33 +09:00
  3c3c812ed6
• Resolve code quality inspection
  Bartłomiej Dach · 2023-05-06 16:23:00 +02:00
  808a44ac0c
• Merge pull request #23372 from peppy/fix-slider-end-circle-appear-delay

  Fix fade in delay for first slider end circle being incorrect when snaking disabled

  Bartłomiej Dach · 2023-05-03 19:06:39 +02:00
  a45f0b65a1
• Merge pull request #23379 from peppy/legacy-skin-reverse-arrow-colour-flip

  Add support for flipping colour of reverse arrow on legacy default skin when combo colour is too bright

  Bartłomiej Dach · 2023-05-03 08:48:32 +02:00
  2add8e119f
• Merge pull request #23308 from OliBomby/sample-control-points

  Remove SampleControlPoint and DifficultyControlPoint from HitObject

  Dean Herbert · 2023-05-03 14:21:51 +09:00
  6b017ac05f
• Add support for flipping colour of reverse arrow on legacy default skin when combo colour is too bright
  Dean Herbert · 2023-05-03 12:37:07 +09:00
  9c4312b407
• Merge pull request #23370 from peppy/fix-editor-playfield-padding

  Add more padding around playfield in editor to avoid overlap with tool areas

  Dean Herbert · 2023-05-03 11:44:55 +09:00
  e42b0cc5b1
• Merge pull request #23371 from peppy/argon-slider-ball-fade-faster

  Increase the rate of slider ball fade on argon skins to match other implementations

  Bartłomiej Dach · 2023-05-02 19:03:47 +02:00
  03459a4f19
• Avoid using Schedule in transforms (doesn't handle rewind well)
  Dean Herbert · 2023-05-02 17:08:49 +09:00
  e44672bdd5
• Tidy up various code quality issues in OsuModBubbles
  Dean Herbert · 2023-05-02 17:08:37 +09:00
  7830711c8e
• Ensure lifetime start is also updated when reverting judgements
  Dean Herbert · 2023-05-02 17:07:12 +09:00
  fb0e90913d
• Merge branch 'master' into bubble_mod_implementation_clean
  Dean Herbert · 2023-05-02 16:59:55 +09:00
  b2b9f2a036
• Fix nullability and remove extra preempt from SliderEndCircle calculation
  Dean Herbert · 2023-05-02 16:36:43 +09:00
  a619812cab
• Fix fade in delay for first slider end circle being incorrect when snaking disabled
  Dean Herbert · 2023-05-02 16:27:17 +09:00
  1a04be15c7
• Increase the rate of slider ball fade on argon skins to match other implementations
  Dean Herbert · 2023-05-02 15:47:35 +09:00
  bd72c67d68
• Add more padding around playfield in editor to avoid overlap with tool areas

  Closes #23130.

  Dean Herbert · 2023-05-02 15:37:02 +09:00
  67f83f246b
• Merge branch 'master' into sample-control-points
  Dean Herbert · 2023-05-02 14:38:39 +09:00
  e3c384c6b5