127 Commits

• Fix incorrect catch grid specification
  Dean Herbert · 2023-05-26 10:41:29 +09:00
  3c69956b55
• Split out grid snapping modes into "relative" and "global" types
  Dean Herbert · 2023-05-25 21:41:19 +09:00
  804671ca74
• Move blueprint validity conditions to allow more correct external usage of EndPlacement

  Until now, these were haphazardly enforce inline in blueprint
  implementations. The only thing stopping complete breakage is that
  `EndPlacement` wasn't called (too much) from outside the blueprint,
  leaving them responsible for their own placement.
  
  By moving this conditional out of the provided paramters to
  `EndPlacement`, it allows more flexible usage of that method externally.
  Coming in a future PR.

  Dean Herbert · 2023-05-12 16:02:22 +09:00
  f443cfb93e
• remove redundant zero check in sv calculation
  OliBomby · 2023-05-02 12:29:11 +02:00
  d2d81bb82c
• fix 0 velocity juicestream
  OliBomby · 2023-04-30 16:43:26 +02:00
  79f3cfec91
• remove all regular usage of DifficultyControlPoint
  OliBomby · 2023-04-26 17:55:38 +02:00
  c44f71a737
• Move right-side editor toolbox to base HitObjectComposer

  Move right-side editor toolbox to base `HitObjectComposer`

  Dean Herbert · 2023-04-04 19:00:56 +09:00
  f9ebdadfe8
• Remove redundant canBeNull: true
  ekrctb · 2023-01-15 23:11:59 +09:00
  d664a66a37
• Remove #nullable disable from Catch.Edit namespace
  ekrctb · 2023-01-15 17:29:32 +09:00
  a75fc5108a
• Code Quality
  Dylan Nantz · 2023-01-13 10:16:52 -05:00
  6028abff39
• Merge branch 'master' of https://github.com/ppy/osu into 18469
  Dylan Nantz · 2023-01-13 09:54:29 -05:00
  5dd0aaccef
• Use PlacementState to check juice stream placement
  Dylan Nantz · 2023-01-13 09:37:23 -05:00
  e38075c4ef
• Use MaxBy in all locations that can and update inspection level to match dotnet-build
  Dean Herbert · 2022-12-19 16:47:10 +09:00
  4a7d7c6ed9
• Show distance snap for first juice stream object. Fixes #18469
  Dylan Nantz · 2022-12-05 15:12:50 -05:00
  4ab7ef9af9
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Remove nullable disable annotation in the cache ruleset.
  andy840119 · 2022-11-05 16:49:55 +08:00
  4d4d7cf863
• Add osu!catch read-distance-spacing implementation
  Dean Herbert · 2022-10-26 13:45:06 +09:00
  f8a4af5e0e
• Merge branch 'grid-momentary-shortcuts' into read-current-distance-snap
  Dean Herbert · 2022-10-26 13:28:04 +09:00
  7d59bc6e2f
• Move distance snap toggle button implementation to DistancedHitObjectComposer
  Dean Herbert · 2022-10-26 13:27:23 +09:00
  54ae16badc
• Simplify logic with new multi-grid snap support
  Dean Herbert · 2022-10-25 14:22:30 +09:00
  2f0283e4d4
• Display current distance snap and add button to update to use it
  Dean Herbert · 2022-10-21 22:58:36 +09:00
  645a84b1d6
• Remove unused using statement
  Dean Herbert · 2022-10-21 19:55:58 +09:00
  1e09a21279
• Apply same fix to osu!catch composer
  Dean Herbert · 2022-10-21 17:15:36 +09:00
  16f5c2a7c6
• Add momentary shortcuts to toggle grid/distance snap

  Matching osu!stable. I use these quite a lot while mapping and I'm sure
  others do as well.
  
  Hold `Shift` = invert grid snap
  Hold `Alt` = invert distance snap

  Dean Herbert · 2022-10-19 20:06:41 +09:00
  830b92d3ae
• Merge pull request #20593 from ekrctb/catch-editor-height

  Allow arbitrary height catch editor

  Dean Herbert · 2022-10-18 12:10:49 +09:00
  ccbac08985
• Add inline comment mentioning binding issues
  Dean Herbert · 2022-10-18 12:10:30 +09:00
  1778120f3e
• Avoid casting by accepting all Playfields but throwing on a bad choice
  Dean Herbert · 2022-10-11 16:54:41 +09:00
  f41b79688f
• Anchor drag box on time (catch, mania)

  Not done for taiko because I cannot figure out how it should work with the overlapping scroll algorithm.

  ekrctb · 2022-10-11 14:23:17 +09:00
  6ab29a62d0
• Allow changing scrolling speed in catch editor

  Scroll speed is not saved and doesn't affect gameplay.
  It is purely a feature for a better visualization.
  It is currently bind to scroll speed increase/decrease.
  Default F3/F4 crashes with editor shortcuts so it has to be changed.

  ekrctb · 2022-10-06 18:06:16 +09:00
  9247ff3e0a
• Allow arbitrary height catch editor

  Useful because can see more notes at once.

  ekrctb · 2022-10-06 17:26:03 +09:00
  e8cd9a5d11
• Update usages of RemoveInternal
  Dean Herbert · 2022-08-29 15:57:40 +09:00
  105aa01e7d
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Merge pull request #18236 from peppy/snap-unification

  Add `enum` to snap method as alternative to multiple nested invocations

  Dan Balasescu · 2022-05-20 11:35:05 +09:00
  64a371638e
• Add enum to snap method as alternative to mutliple nested invocations
  Dean Herbert · 2022-05-12 16:19:07 +09:00
  c0abce918f
• Merge branch 'master' into catch-editor-per-object-sv
  Dean Herbert · 2022-05-09 19:18:01 +09:00
  c7e9bd7751
• Merge pull request #18158 from ekrctb/fix-banana-shower-placement-negative-duration

  Fix duration is negative while placing banana shower in catch editor

  Dan Balasescu · 2022-05-09 11:26:06 +09:00
  45c6f5edef
• Fix duration is negative while placing banana shower in catch editor.

  Timeline blueprint is glitched when the hit object has negative duration.
  Negative duration is unwanted anyways so placement implementation is fixed instead of supporting it in timline blueprint.

  ekrctb · 2022-05-09 00:01:05 +09:00
  158f134260
• Fix BeginPlacement location.
  ekrctb · 2022-05-08 23:10:51 +09:00
  483a611c41
• Remove now-redundant velocity calculation

  Velocity is computed from the up-to-date SV now.

  ekrctb · 2022-05-08 22:36:33 +09:00
  7daa3d8eb7
• Make ScrollingPath use time instead of distance.

  This is consistent as other components now use time instead of distance.

  ekrctb · 2022-05-08 22:36:33 +09:00
  37c9aac49f
• Fix wrong resampling times are used for juice stream path
  ekrctb · 2022-05-08 22:36:33 +09:00
  0e98bb28bd
• Automatically set slider velocity from juice stream path
  ekrctb · 2022-05-08 22:36:33 +09:00
  9ffa90602b
• Make JuiceStreamPath time based instead of distance based.

  And remove the "slope limit" feature.
  TODO: for a juice stream with a large slope, the slider velocity of the hit object should be changed.

  ekrctb · 2022-05-08 22:36:33 +09:00
  4e0155fa4b
• Fix hit object not shown in timline while placement is waiting
  ekrctb · 2022-05-08 15:52:14 +09:00
  125628dd20
• Add xmldoc and rename methods in IPositionSnapProvider for legibility
  Dean Herbert · 2022-05-05 15:58:21 +09:00
  f6fc926f1a
• Clarify TODO comment
  Salman Ahmed · 2022-04-28 10:57:14 +03:00
  b6d2ca7709
• Let CatchHitObjectComposer inherit from DistancedHitObjectComposer and hide control
  Salman Ahmed · 2022-04-28 06:44:50 +03:00
  bfc6bfc91b
• Encapsulate distance spacing control handling to a "distance toolbox composite"

  Encapsulated in a way which can allow further extensibility for the
  right-side area of toolboxes.

  Salman Ahmed · 2022-04-24 08:33:03 +03:00
  8ed39009fd
• Add "distance spacing" multiplier for osu! ruleset

  While osu!catch also implements a distance snap grid, it doesn't rely on
  `GetBeatSnapDistanceAt` (unlike osu!), therefore it can't have the
  "distance spacing" multiplier yet.

  Salman Ahmed · 2022-02-15 02:21:53 +03:00
  19ee05c232