Dean Herbert
|
219cbec6bd
|
Split out DefaultScoreCounter and make ScoreCounter abstract
|
2020-10-15 16:32:30 +09:00 |
|
Dean Herbert
|
d5f2aab52e
|
Tidy up SkinnableComboCounter class slightly
|
2020-10-15 15:37:40 +09:00 |
|
Bartłomiej Dach
|
c3f1a30447
|
Merge branch 'master' into mod-customisation-absorb-mouse-input
|
2020-10-15 00:40:27 +02:00 |
|
Dean Herbert
|
e0210f5c4c
|
Ignore failed casts to make tests happy
|
2020-10-14 23:52:58 +09:00 |
|
Dean Herbert
|
ef2e2894a2
|
Merge branch 'master' into fix-mania-diffcalc
|
2020-10-14 23:49:14 +09:00 |
|
Dean Herbert
|
1684c4f412
|
Merge pull request #10503 from smoogipoo/fix-mod-combinations
Fix MultiMod difficulty calculator combinations not generating correctly
|
2020-10-14 23:42:59 +09:00 |
|
Dean Herbert
|
8b864c8c22
|
Merge branch 'master' into fix-multimod-copy
|
2020-10-14 22:29:38 +09:00 |
|
smoogipoo
|
ed57b1363f
|
Remove unused usings
|
2020-10-14 20:08:46 +09:00 |
|
smoogipoo
|
c4fdd35223
|
Fix same-type incompatibility through multimod
|
2020-10-14 19:53:37 +09:00 |
|
Dean Herbert
|
e3eaba7b2c
|
Move ISampleDisabler implementation to Player and FrameStabilityContainer
|
2020-10-14 19:39:48 +09:00 |
|
smoogipoo
|
e9ebeedbe2
|
Refactor generation
|
2020-10-14 19:32:30 +09:00 |
|
Dean Herbert
|
ac4f56403d
|
Adjust size/position
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
7f5ea57bd4
|
Clean-up pass (best effort) on LegacyComboCounter
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
9bb8a43bce
|
Combine LegacyComboCounter and ComboCounter classes
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
fbbea48c8c
|
Add score text skinnability
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
2fce064e32
|
Add basic legacy combo counter and updating positioning logic
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
6a6718ebab
|
Allow bypassing origin/anchor setting of skinnable components
It makes little sense to set these when using RelativeSizeAxes.Both
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
899bac6ca5
|
Rename catch combo counter for clarity
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
f5623ee21e
|
Setup skinnable combo counter component with default implementation
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
60603d2918
|
Add skin components and interfaces
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
98acf1e31d
|
Make field read only
|
2020-10-14 19:16:25 +09:00 |
|
smoogipoo
|
d7a52e97ff
|
Fix multimod difficulty combinations not generating correctly
|
2020-10-14 19:03:11 +09:00 |
|
Dean Herbert
|
a7f8e26e35
|
Adjust bottom-right elements positions based on song progress display
|
2020-10-14 18:51:53 +09:00 |
|
Dean Herbert
|
0cf3e90904
|
Update SongProgress height based on its dynamic height during resize
|
2020-10-14 18:44:22 +09:00 |
|
Dean Herbert
|
ace9fbc8d3
|
Confine available area for HUD components to excluse the song progress area
|
2020-10-14 18:44:22 +09:00 |
|
smoogipoo
|
f04aec538f
|
Fix MultiMod throwing exceptions when creating copies
|
2020-10-14 18:12:19 +09:00 |
|
Dean Herbert
|
207c409792
|
Merge branch 'master' into fix-mania-diffcalc
|
2020-10-14 15:26:32 +09:00 |
|
Dean Herbert
|
3e326a9234
|
Use bindable flow for event propagation
|
2020-10-14 15:22:17 +09:00 |
|
Dean Herbert
|
24eff8c66d
|
Rename container to match "settings" term used everywhere
|
2020-10-14 15:13:49 +09:00 |
|
Leon Gebler
|
3fd913b13f
|
rename customisation container class
|
2020-10-13 19:38:25 +02:00 |
|
Bartłomiej Dach
|
1af17fbd5e
|
Merge branch 'master' into fix-early-break-cull
|
2020-10-13 18:02:08 +02:00 |
|
Leon Gebler
|
663b806974
|
move ModSettingsContainer to seperate component
|
2020-10-13 17:45:40 +02:00 |
|
Bartłomiej Dach
|
68b505ab86
|
Extract helper function for pp value handling
|
2020-10-12 22:14:45 +02:00 |
|
Bartłomiej Dach
|
d4ba9d2682
|
Simplify implementation of CalculatePerformanceAsync
|
2020-10-12 22:10:02 +02:00 |
|
Bartłomiej Dach
|
7117fd0fba
|
Add xmldoc and nullability annotations
|
2020-10-12 21:44:04 +02:00 |
|
Bartłomiej Dach
|
779e6e10a7
|
Split ctors to avoid passing fields one by one
|
2020-10-12 21:43:14 +02:00 |
|
Leon Gebler
|
1a85123b89
|
rename container class to be more descriptive
|
2020-10-12 21:24:42 +02:00 |
|
Leon Gebler
|
7df9282727
|
CodeAnalysis fixes
|
2020-10-12 15:58:34 +02:00 |
|
Dean Herbert
|
5ff61142ad
|
Merge pull request #10489 from smoogipoo/fix-convert-difficulty-icons
Fallback to default ruleset star rating if conversion fails
|
2020-10-12 21:57:13 +09:00 |
|
smoogipoo
|
372761a46f
|
More/better commenting
|
2020-10-12 19:22:34 +09:00 |
|
smoogipoo
|
eb4ef157ca
|
Fix implicit segments not being constructed correctly
|
2020-10-12 19:16:37 +09:00 |
|
smoogipoo
|
48c0ae40ef
|
Fix multi-segment sliders not parsing correctly
|
2020-10-12 18:04:28 +09:00 |
|
smoogipoo
|
ccf7e2c49a
|
Fallback to default ruleset star rating if conversion fails
|
2020-10-12 16:31:42 +09:00 |
|
smoogipoo
|
379971578d
|
Remove culling notice from HasEffect
|
2020-10-12 15:28:16 +09:00 |
|
Leon Gebler
|
e5548a1216
|
Move ModSettingsContainer class inside ModSelectOverlay
|
2020-10-12 00:16:18 +02:00 |
|
Dean Herbert
|
8431a5a23c
|
Merge pull request #10483 from Joehuu/add-extended-stats-keyboard-shortcut
|
2020-10-11 22:48:42 +09:00 |
|
Dean Herbert
|
a246991c50
|
Merge pull request #10472 from LeNitrous/expose-player-isbreaktime
Expose BreakTracker.IsBreakTime in Player
|
2020-10-11 22:36:24 +09:00 |
|
Dean Herbert
|
de6fe34361
|
Bind to local bindable and combine dual bindings
|
2020-10-11 21:51:48 +09:00 |
|
Dean Herbert
|
5fcdee6fd8
|
Remove cast and expose as IBindable
|
2020-10-11 21:46:55 +09:00 |
|
Joehu
|
8faa86b048
|
Add ability to toggle extended statistics using space or enter
|
2020-10-10 18:32:22 -07:00 |
|
unknown
|
6a52c98a42
|
make IsBreakTime its own bindable and bind it to BreakTracker on load
|
2020-10-11 06:15:20 +08:00 |
|
Dean Herbert
|
16a78b3172
|
Merge pull request #10478 from bdach/fix-beatmap-difficulty-rating-rounding
Apply rounding when calculating beatmap difficulty rating
|
2020-10-11 03:36:59 +09:00 |
|
Lucas A
|
e845cc92b8
|
Round pp values to nearest integer.
|
2020-10-10 19:58:06 +02:00 |
|
Bartłomiej Dach
|
09f3c0f091
|
Merge branch 'master' into search-via-online-id
|
2020-10-10 19:40:25 +02:00 |
|
Lucas A
|
a0e6226b7a
|
Rename LocalId -> LocalScoreID
|
2020-10-10 19:19:24 +02:00 |
|
Lucas A
|
de522d53ea
|
Make CalculatePerformanceAsync() nullable.
|
2020-10-10 19:16:21 +02:00 |
|
Bartłomiej Dach
|
8af78656e4
|
Add precision tolerance to difficulty rating range checks
|
2020-10-10 18:15:52 +02:00 |
|
unknown
|
7bbdd6ab25
|
expose break time bindable
|
2020-10-10 21:07:17 +08:00 |
|
Dean Herbert
|
73c238fae3
|
Add the ability to search for local beatmaps via online IDs
Closes #10470.
|
2020-10-10 21:34:11 +09:00 |
|
Bartłomiej Dach
|
146b15371d
|
Merge branch 'master' into fix-slider-sample-parsing
|
2020-10-10 14:02:33 +02:00 |
|
Lucas A
|
6459ce28a3
|
Don't calculate performance if difficulty attributes aren't locally computable.
|
2020-10-09 18:32:03 +02:00 |
|
Dean Herbert
|
b0f8a7794a
|
Make SelectionHandler require EditorBeatmap presence
|
2020-10-09 21:44:10 +09:00 |
|
smoogipoo
|
8f37d2290a
|
Expose sorting of hitobjects
|
2020-10-09 21:43:46 +09:00 |
|
smoogipoo
|
485a951281
|
Expose current strain and retrieval of peak strain
|
2020-10-09 21:42:43 +09:00 |
|
smoogipoo
|
d536a1f75e
|
Fix breaks being culled too early
|
2020-10-09 21:04:56 +09:00 |
|
Dean Herbert
|
681e88af40
|
Merge branch 'master' into editor-fix-button-states-after-paste
|
2020-10-09 20:51:09 +09:00 |
|
smoogipoo
|
696e3d53af
|
Fix slider samples being overwritten by the last node
|
2020-10-09 20:50:09 +09:00 |
|
Dean Herbert
|
da03084251
|
Merge pull request #10449 from smoogipoo/ensure-conversion-stability
Ensure stable sorting order in beatmap conversion tests
|
2020-10-09 20:49:04 +09:00 |
|
smoogipoo
|
573336cb47
|
Ensure stable sorting order in beatmap conversion tests
|
2020-10-09 20:12:17 +09:00 |
|
Dan Balasescu
|
ecfb7e94c5
|
Merge branch 'master' into fix-editor-batch-handling
|
2020-10-09 20:06:06 +09:00 |
|
Dan Balasescu
|
07f19342d1
|
Merge pull request #10428 from peppy/editor-reset-newcombo-on-placement
Reset new combo button state after successful placement
|
2020-10-09 19:48:47 +09:00 |
|
Dan Balasescu
|
8515978acd
|
Merge pull request #10447 from peppy/update-framework
Update framework
|
2020-10-09 19:37:10 +09:00 |
|
Dan Balasescu
|
bcc096ee49
|
Merge pull request #10446 from peppy/fix-timeline-tick-bar-lines
Fix bar lines ("down beat" as people call it) showing up too often in timeline
|
2020-10-09 19:24:29 +09:00 |
|
Dan Balasescu
|
93f5ea57a5
|
Merge pull request #10427 from peppy/fix-hidden-first-object
Fix first hitobject in osu! hidden mod not getting correct fade applied
|
2020-10-09 19:23:47 +09:00 |
|
Dan Balasescu
|
62690e4873
|
Merge pull request #10432 from peppy/editor-reverse-pattern
Add "reverse pattern" support to editor selection handler
|
2020-10-09 19:19:24 +09:00 |
|
Dean Herbert
|
021777145f
|
Update framework
|
2020-10-09 18:51:52 +09:00 |
|
Dean Herbert
|
3838f405dd
|
Fix missed usages
|
2020-10-09 18:50:05 +09:00 |
|
Dean Herbert
|
edaf6db5c6
|
Reference EditorBeatmap directly for selected objects
|
2020-10-09 18:44:23 +09:00 |
|
Dean Herbert
|
21c6242f90
|
Fix bar lines ("down beat" as people call it) showing up too often in timeline
|
2020-10-09 18:35:44 +09:00 |
|
Dan Balasescu
|
a6d19cd2d6
|
Merge pull request #10431 from peppy/fix-distribution-graph-rounding
Fix incorrect timing distribution display due to lack of rounding
|
2020-10-09 18:12:29 +09:00 |
|
Dan Balasescu
|
6572ce5f36
|
Merge pull request #10441 from peppy/editor-selection-blueprint-performance
Improve performance of slider blueprints
|
2020-10-09 18:01:25 +09:00 |
|
Dan Balasescu
|
a1226ccaa2
|
Merge pull request #10440 from peppy/fix-editor-song-after-exit
Fix editor playing deleted beatmap's track on exit-without-save
|
2020-10-09 17:58:31 +09:00 |
|
Dan Balasescu
|
4881a13f4b
|
Merge pull request #10443 from peppy/editor-timeline-tick-display-performance
Improve TimelineTickDisplay performance
|
2020-10-09 17:53:12 +09:00 |
|
Dean Herbert
|
5d888f687a
|
Account for the width of points so they don't suddenly appear at timeline edges
|
2020-10-09 16:49:51 +09:00 |
|
Dean Herbert
|
ceb1494c33
|
Only run regeneration when passing a new min/max tick boundary
|
2020-10-09 16:47:29 +09:00 |
|
Dean Herbert
|
017a8ce496
|
Only recalculate when display actually changes
|
2020-10-09 15:57:31 +09:00 |
|
Dean Herbert
|
9baf704942
|
Add local pooling to TimelineTickDisplay
|
2020-10-09 15:48:24 +09:00 |
|
Dean Herbert
|
beec0e4193
|
Hide children of SelectionBlueprint when not selected
|
2020-10-09 14:03:13 +09:00 |
|
Dean Herbert
|
8be19fd820
|
Increase height of contracted score panel to fit mods again
|
2020-10-09 13:26:09 +09:00 |
|
Dean Herbert
|
389ffe7da5
|
Hide bonus result types from score table for the time being
|
2020-10-09 13:23:18 +09:00 |
|
Dean Herbert
|
07558b5bc0
|
Merge branch 'master' into ruleset-result-types
|
2020-10-09 13:17:05 +09:00 |
|
Dean Herbert
|
68039cff40
|
Set beatmap to sane default on exiting editor
|
2020-10-09 13:12:48 +09:00 |
|
Dean Herbert
|
c86b37f60d
|
Add check to ensure MusicController doesn't play a delete pending beatmap's track
|
2020-10-09 13:11:24 +09:00 |
|
Dean Herbert
|
6649cb2204
|
Fix incorrect first object logic
|
2020-10-09 06:41:53 +09:00 |
|
Dean Herbert
|
825e10ec8c
|
Add reverse handler button to selection box
|
2020-10-09 06:32:23 +09:00 |
|
Dean Herbert
|
eacc7dca9a
|
Fix SliderPath not handling Clear correctly
|
2020-10-09 06:31:59 +09:00 |
|
Dean Herbert
|
85b33fffd0
|
Fix incorrect comments
|
2020-10-09 05:14:44 +09:00 |
|
Dean Herbert
|
ff5a1937f5
|
Fix test logic and stabilise rounding direction
|
2020-10-09 05:04:03 +09:00 |
|
Dean Herbert
|
a5b2c4195e
|
Fix incorrect timing distribution display due to lack of rounding
|
2020-10-09 04:41:45 +09:00 |
|
Bartłomiej Dach
|
c867fb4985
|
Merge branch 'master' into update-check-improvements
|
2020-10-08 21:32:26 +02:00 |
|
Dean Herbert
|
5966205037
|
Fix ternary button states not updating correctly after a paste operation
|
2020-10-09 04:31:45 +09:00 |
|
Dean Herbert
|
e7eda19b07
|
Reset new combo button state after successful placement
|
2020-10-09 03:31:01 +09:00 |
|
Dean Herbert
|
2d0275ba95
|
Fix first hitobject in osu! hidden mod not getting correct fade applied
|
2020-10-09 03:07:01 +09:00 |
|
Lucas A
|
fa201be2ad
|
Simplify PerformanceCacheLookup
|
2020-10-08 18:31:29 +02:00 |
|
Dean Herbert
|
8dddd8aff5
|
Merge pull request #9883 from swoolcock/confine-during-gameplay
Add "During Gameplay" option for mouse confining
|
2020-10-08 20:25:27 +09:00 |
|
Dean Herbert
|
4ccd751604
|
Further simplify non-transactional change logic
|
2020-10-08 18:42:53 +09:00 |
|
Dean Herbert
|
3114174e09
|
Add missing non-transactional SaveState calls
|
2020-10-08 18:41:03 +09:00 |
|
Dean Herbert
|
dbdb25ccf7
|
Move reset logic to OsuGame
|
2020-10-08 18:29:19 +09:00 |
|
Dean Herbert
|
43a575484a
|
Remove pointless comments
|
2020-10-08 18:29:09 +09:00 |
|
Dean Herbert
|
0967db768f
|
Add xmldoc covering usage restrictions
|
2020-10-08 18:28:56 +09:00 |
|
Dean Herbert
|
afed832b19
|
Tidy up EditorBeatmap slightly
|
2020-10-08 18:06:49 +09:00 |
|
Dean Herbert
|
1027b608ff
|
Copy list content before firing events to avoid pollution
|
2020-10-08 18:04:07 +09:00 |
|
Dean Herbert
|
38babf3de5
|
Update usages of ChangeHandler to EditorBeatmap where relevant
|
2020-10-08 18:04:07 +09:00 |
|
Dean Herbert
|
b2d93f799f
|
Hook ChangeHandler to transactional events rather than individual ones
|
2020-10-08 18:04:07 +09:00 |
|
Dean Herbert
|
0781fbd443
|
Make EditorBeatmap implement TransactionalCommitComponent
|
2020-10-08 18:04:07 +09:00 |
|
Dean Herbert
|
a9bca671d0
|
Make component and add hooking events
|
2020-10-08 18:04:07 +09:00 |
|
Dean Herbert
|
ce04daf053
|
Split transaction handling code out into base class
|
2020-10-08 18:04:07 +09:00 |
|
Dean Herbert
|
ef092de9ba
|
Add missing UpdateHitObject calls and move local to usages (not via bindables)
|
2020-10-08 18:04:07 +09:00 |
|
Bartłomiej Dach
|
ac44f6f679
|
Ensure control point group exists after move
If the control point group moved was empty, it would not be created due
to a lack of ControlPointInfo.Add() calls.
|
2020-10-07 23:10:28 +02:00 |
|
Bartłomiej Dach
|
b1029a124c
|
Move event subscription to LoadComplete
Prevents attempting to read from the `colours` field before it is
actually injected.
|
2020-10-07 22:57:20 +02:00 |
|
Bartłomiej Dach
|
7109c3b6cd
|
Rename variable as suggested
|
2020-10-07 21:06:24 +02:00 |
|
Bartłomiej Dach
|
4ba8d823d3
|
Merge branch 'master' into fix-quick-retry-music-playback
|
2020-10-07 20:57:10 +02:00 |
|
Endrik Tombak
|
2b6e4e575e
|
Award max combo portion score if max achievable is 0
|
2020-10-07 17:04:55 +03:00 |
|
Endrik Tombak
|
74af7cc503
|
Rework ScoreProcessor
|
2020-10-07 17:00:00 +03:00 |
|
Dean Herbert
|
1989141968
|
Merge branch 'master' into tourney-asset-refactor
|
2020-10-07 21:34:07 +09:00 |
|
Lucas A
|
cd15f83f85
|
Update ScorePerformanceCalculator code path.
|
2020-10-07 14:10:25 +02:00 |
|
Lucas A
|
a425cf4a31
|
Fix broken class reference.
|
2020-10-07 13:29:10 +02:00 |
|
Lucas A
|
7f5cf04b2b
|
Fix merge conflicts.
|
2020-10-07 13:28:49 +02:00 |
|
Dean Herbert
|
1566882dc4
|
Merge pull request #10338 from Game4all/perf-calculator-remove-working-beatmap
Remove WorkingBeatmap from PerformanceCalculator
|
2020-10-07 20:04:24 +09:00 |
|
Dan Balasescu
|
6636b64cbd
|
Merge pull request #10407 from peppy/fix-sample-disposed-on-skin-change
Don't force playback of (non-looping) DrawableHitObject samples after skin change
|
2020-10-07 19:34:53 +09:00 |
|
Dean Herbert
|
94a6e28565
|
Add back second removed condition
|
2020-10-07 18:40:09 +09:00 |
|
Dean Herbert
|
3c3c1ce885
|
Don't force playback of (non-looping) DrawableHitObject samples after skin change
|
2020-10-07 18:18:01 +09:00 |
|
Dean Herbert
|
04fa0bff9d
|
Add CanBeNull spec and xmldoc
|
2020-10-07 17:46:57 +09:00 |
|
Dean Herbert
|
f1a3b6d0ba
|
Merge branch 'master' into perf-calculator-remove-working-beatmap
|
2020-10-07 17:43:17 +09:00 |
|
Dean Herbert
|
0f6eb9d4cb
|
Ensure music playback is stopped when retrying by any means
|
2020-10-07 17:40:54 +09:00 |
|
Dean Herbert
|
5171c18a4b
|
Merge branch 'master' into ruleset-result-types
|
2020-10-07 17:04:02 +09:00 |
|
Dean Herbert
|
f77ad8cf39
|
Remove unused using
|
2020-10-07 17:03:34 +09:00 |
|
Dan Balasescu
|
54ca544855
|
Merge pull request #10400 from peppy/fix-first-hitobject-must-be-combo
Ensure first hitobject is always a new combo
|
2020-10-07 17:01:31 +09:00 |
|
Dean Herbert
|
31d347be5c
|
Make extended score panel taller to better fit all information
|
2020-10-07 16:50:00 +09:00 |
|
Shane Woolcock
|
f88ba1734b
|
Remove ConfineMouseTracker field
|
2020-10-07 18:11:47 +10:30 |
|
Dan Balasescu
|
f206ea96ce
|
Merge pull request #10391 from peppy/editor-setup-screen-difficulty-adjust
Add difficulty adjustment settings to editor setup screen
|
2020-10-07 16:33:10 +09:00 |
|
Dean Herbert
|
67398b5d95
|
Move timestamp text out of flow and attach to bottom edge
|
2020-10-07 16:30:14 +09:00 |
|
Shane Woolcock
|
2e0a9f53c1
|
Add test coverage
|
2020-10-07 17:52:39 +10:30 |
|
Dan Balasescu
|
fbb10f6774
|
Merge branch 'master' into fix-first-hitobject-must-be-combo
|
2020-10-07 16:21:00 +09:00 |
|
Dean Herbert
|
6ac70945f2
|
Show bonus judgements on expanded panel
|
2020-10-07 16:17:28 +09:00 |
|
Dean Herbert
|
c0bc6a75b3
|
Show auxiliary judgements on next line
|
2020-10-07 16:17:17 +09:00 |
|
Dean Herbert
|
e281d724b8
|
Consume display name logic
|
2020-10-07 15:43:52 +09:00 |
|
Dean Herbert
|
3363c3399e
|
Allow rulesets to specify valid HitResult types (and display names for them)
|
2020-10-07 15:34:23 +09:00 |
|
Dean Herbert
|
d6d0bd90a3
|
Extract tuple into class
|
2020-10-07 15:34:03 +09:00 |
|
Dan Balasescu
|
338b4c56ce
|
Merge pull request #10399 from peppy/editor-beatmap-batch-change-support
Add editor beatmap batch change support
|
2020-10-07 14:57:51 +09:00 |
|