39287 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Naxess	a447f20095	Fix formatting of #nullable enable	2021-05-14 03:38:35 +02:00
Naxess	90e0b3374e	Add #nullable enable ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2021-05-14 03:34:50 +02:00
Naxess	94538b3842	Remove accidental whitespace	2021-05-13 12:56:36 +02:00
Naxess	19800f5f7f	Move IBeatmap arg into context	2021-05-13 11:24:22 +02:00
Naxess	b37cb3bdbe	Change interpreted difficulty from bindable to regular value ... There's no reason for why checks would need this to be bindable. A 1-directional binding is more appropriate.	2021-05-13 09:00:30 +02:00
Naxess	4eeeaf6a1a	Keep track of local bound copy	2021-05-13 07:57:32 +02:00
Naxess	e7c7786db3	Merge branch 'master' into beatmap-verifier-context	2021-05-13 07:40:33 +02:00
Dean Herbert	5b71d8ca37	Merge pull request #12758 from Naxesss/verify-settings-ui ... Add setting UI components to the verify screen	2021-05-13 14:35:35 +09:00
Dean Herbert	b81f86bd4d	Move DI resolution to inside BDL parameters	2021-05-13 13:54:06 +09:00
Dean Herbert	c6648112e5	Simplify binding flow in InterpretationSection	2021-05-13 13:51:41 +09:00
Dean Herbert	cdcbaf4291	Tidy up specification of SettingsSection	2021-05-13 13:45:10 +09:00
Naxess	47948d7b34	Set default for bindable in object initializer ... Fixes the CI failure.	2021-05-13 06:08:48 +02:00
Naxess	fb305130de	Also refresh when interpreted difficulty changes	2021-05-13 06:00:21 +02:00
Naxess	ee0a6ba93e	Use local bound copy in InterpretationSection as well ... Else we're relying on the `VerifyScreen`'s bindable instance, and by extension the `VerifyScreen` instance itself.	2021-05-13 05:59:49 +02:00
Naxess	e80d8f6922	Keep track of local bound copy	2021-05-13 05:46:47 +02:00
Naxess	04c1585eb2	Use more consistent lambda discards	2021-05-13 05:38:45 +02:00
Dean Herbert	8bf05e142b	Merge pull request #12754 from peppy/skin-instantiation-info ... Add `SkinInfo.InstantiationInfo` to allow creating different skin types	2021-05-13 12:34:14 +09:00
Dean Herbert	fb13ed52f7	Merge pull request #12777 from smoogipoo/fix-test-failure ... Fix possible multiplayer test failure	2021-05-13 12:33:59 +09:00
Naxess	e86834b740	Use local bound copy for HiddenIssueTypes	2021-05-13 05:25:20 +02:00
Naxess	c8d21f2c3f	Isolate refreshing to IssueList	2021-05-13 05:25:02 +02:00
smoogipoo	5b03092968	Fix possible test failure	2021-05-13 11:53:50 +09:00
Naxess	fbb76ba598	Split ShowIssueTypes dict into hidden and configurable lists ... This way `VerifyScreen` is decoupled from which options `VisibilitySection` provides. Bindings are a bit less neat, though.	2021-05-13 04:50:32 +02:00
Naxess	dd8423c4c4	Set interpreted difficulty to correct default	2021-05-13 04:36:20 +02:00
Naxess	6806e40ad9	Remove unnecessary local variable ... This now exists in `VerifyScreen`, which we can access from here.	2021-05-13 04:30:40 +02:00
Naxess	56bd897666	Move ShowIssueTypes to VerifyScreen	2021-05-13 04:29:27 +02:00
Bartłomiej Dach	27ca7d0f4f	Actually annotate the correct ctor	2021-05-12 23:53:39 +02:00
Bartłomiej Dach	a6aec6e007	Fix missed InstantiationInfo setter usages	2021-05-12 23:34:25 +02:00
Bartłomiej Dach	d31fa20e92	Merge branch 'master' into skin-instantiation-info	2021-05-12 23:23:57 +02:00
Bartłomiej Dach	1b579dd838	Extract invariant instantiation info extension method	2021-05-12 23:23:51 +02:00
Bartłomiej Dach	4464204e33	Mark all skin ctors used via reflection in SkinInfo.CreateInstance()	2021-05-12 23:23:42 +02:00
Dan Balasescu	4e7c079560	Merge pull request #12753 from peppy/health-bar-hud-overlay-dependency ... Remove downwards dependency from `HUDOverlay` to `HealthDisplay`	2021-05-12 19:27:02 +09:00
Dean Herbert	c6f0a6aed3	Merge pull request #12538 from smoogipoo/multiplayer-spectator-screen ... Implement the multiplayer spectator screen	2021-05-12 17:24:35 +09:00
Dean Herbert	d2e0e8ad94	Reverse direction of binding to allow for better abstract class definitions	2021-05-12 16:53:58 +09:00
Dean Herbert	17e3764576	Rename Settings to have a more localised name	2021-05-12 16:38:04 +09:00
smoogipoo	e1dacde314	Add combo to test streaming client	2021-05-12 14:22:15 +09:00
smoogipoo	273cd18b8a	Use test streaming client in gameplay leaderboard test	2021-05-12 14:19:36 +09:00
Dean Herbert	87dfd9672d	Merge pull request #12748 from smoogipoo/fix-mania-sample-crash ... Fix mania crashing on playing samples after skin change	2021-05-12 14:10:08 +09:00
Dean Herbert	90affa62cc	Merge pull request #12761 from smoogipoo/mania-hp-lenience ... Increase mania HP lenience	2021-05-12 14:09:09 +09:00
smoogipoo	05c21fb5b3	Increase mania HP lenience	2021-05-12 13:27:30 +09:00
smoogipoo	672108edcf	Use container instead of array for field	2021-05-12 13:27:12 +09:00
smoogipoo	f4c96b2675	Only update playing user states when users are watched	2021-05-12 13:10:59 +09:00
smoogipoo	e0e8f5ab80	Fix ordering + threading issues	2021-05-12 13:06:28 +09:00
smoogipoo	ad11818868	Remove watched users on stop watching	2021-05-12 13:05:02 +09:00
smoogipoo	21fc0ba43b	Combine test spectator streaming client implementations	2021-05-12 13:05:02 +09:00
Dean Herbert	3428056113	Remove unnecessary usage of ChildrenEnumerable for array assignment	2021-05-12 13:00:02 +09:00
Dean Herbert	bf44c09a91	Add name identifying container and rename index variable	2021-05-12 12:59:46 +09:00
Dean Herbert	7f015ee1d0	Merge branch 'master' into fix-mania-sample-crash	2021-05-12 12:56:53 +09:00
Dean Herbert	184dbaf202	Improve safety of bindings in HealthDisplay	2021-05-12 12:53:30 +09:00
smoogipoo	9b09361cc9	Add testable spectator streaming client	2021-05-12 12:16:41 +09:00
Naxess	b7bc42e0d3	Rename "playableBeatmap" check arg to "beatmap" ... The working beatmap is now in the context, so it's easier to distinguish beatmap type, hence no need for this prefix.	2021-05-12 02:34:16 +02:00