45041 Commits

This Branch

This Branch

All Branches

• Localise all URL generation for now to avoid weird Schedule logic
  Dean Herbert · 2021-06-01 13:56:59 +09:00
  3ff97f787a
• Fix relative URLs having a null argument after resolution to LinkDetails
  Dean Herbert · 2021-06-01 13:50:20 +09:00
  111bfd4d88
• Add test covering failure to resolve relative URLs
  Dean Herbert · 2021-06-01 13:50:04 +09:00
  1a05a5d2f0
• Apply code styling suggestions

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  ekrctb · 2021-06-01 13:17:30 +09:00
  d5714e63b9
• Merge pull request #13265 from ekrctb/remove-unused-file

  Remove unused `IScrollingHitObject` interface

  Dan Balasescu · 2021-06-01 00:45:07 +09:00
  2d530256f5
• Remove unused IScrollingHitObject interface
  ekrctb · 2021-05-31 23:17:26 +09:00
  86d1ba7ef2
• Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup
  Dean Herbert · 2021-05-31 21:39:04 +09:00
  00b3eea840
• Merge pull request #13257 from ekrctb/simplify-shoc

  Multiple `ScrollingHitObjectContainer` logic simplification

  Dan Balasescu · 2021-05-31 21:31:10 +09:00
  bd7814b487
• Fix weird taiko logic failing for weird reasons that probably should not have been a thing
  Dean Herbert · 2021-05-31 21:29:47 +09:00
  69c4ccad05
• Fix multiple issues with default lookups
  Dean Herbert · 2021-05-31 21:29:47 +09:00
  33577cbad5
• Fix incorrect fallback logic in LegacyBeatmapSkin
  Dean Herbert · 2021-05-31 21:29:47 +09:00
  1161378b6b
• Fix potential nullref in SkinProvidingContainer
  Dean Herbert · 2021-05-31 21:29:47 +09:00
  282c5a9177
• Make FindProvider non-default
  Dean Herbert · 2021-05-31 21:29:47 +09:00
  3ff9f9c89d
• Add ability for LegacySkins to customise the fallback provider
  Dean Herbert · 2021-05-31 21:29:47 +09:00
  8e489754cc
• Add FindProvider lookup function
  Dean Herbert · 2021-05-31 21:29:47 +09:00
  88ed95e012
• Add potential pathway for legacy lookups
  Dean Herbert · 2021-05-31 21:29:47 +09:00
  1d30791ab0
• Add new parameter for default fallback logic in LegacySkin
  Dean Herbert · 2021-05-31 21:29:47 +09:00
  4b27d43e26
• Change timing of HitObjectContainer.OnAdd/OnRemove

  Now, `OnAdd` is always invoked after the DHO is added to the container.
  This change is required by `ScrollingHitObjectContainer` to compute origin adjusted lifetime when origin position is relative to the parent drawable size.

  ekrctb · 2021-05-31 20:56:25 +09:00
  ff04942295
• Merge pull request #13260 from peppy/legacy-skin-resource-improvements

  Allow `LegacyDefaultSkin` to be constructed without extra resource store parameter

  Dan Balasescu · 2021-05-31 20:49:21 +09:00
  9036b13637
• Merge pull request #13262 from peppy/fix-broken-combo-colour-tests

  Fix usage of DI before it's ready in combo colour tests

  Dan Balasescu · 2021-05-31 20:43:30 +09:00
  77a57f8a41
• Fix test potentially not waiting for player to load
  smoogipoo · 2021-05-31 20:21:26 +09:00
  c787c008a5
• Remove weird override logic in TestCase methods
  Dean Herbert · 2021-05-31 20:00:47 +09:00
  f60e9cb085
• Fix usage of DI before it's ready in combo colour tests
  Dean Herbert · 2021-05-31 19:58:19 +09:00
  e78391db7a
• Merge branch 'master' into legacy-skin-resource-improvements
  Dean Herbert · 2021-05-31 19:36:09 +09:00
  17fa2426d4
• Fix spectator crashing when converting mania replay frames
  smoogipoo · 2021-05-31 19:24:22 +09:00
  7f24518004
• Expose GameplayBeatmap and GameplayRuleset from Player
  smoogipoo · 2021-05-31 19:22:20 +09:00
  d2d0896298
• Rename conflicting resources
  Dean Herbert · 2021-05-31 19:14:49 +09:00
  ebfc24a499
• Move leagcy resource store construction local to DefaultLegacySkin
  Dean Herbert · 2021-05-31 19:14:49 +09:00
  65709ec7d7
• Merge pull request #13230 from peppy/non-nullable-beatmapset-files

  Make `BeatmapSet.Files` non-nullable

  Dan Balasescu · 2021-05-31 19:10:03 +09:00
  46b6f49a92
• Merge pull request #12826 from frenzibyte/catch-hide-combo-workaround

  Hide legacy HUD combo counters on osu!catch ruleset

  Dean Herbert · 2021-05-31 19:04:25 +09:00
  d1ef5483bc
• Provide game-wide resources via IStorageResourceProvider
  Dean Herbert · 2021-05-31 18:57:47 +09:00
  b16d10bd95
• Change check order around to ensure re-fetches which return no results don't nullref
  Dean Herbert · 2021-05-31 18:35:18 +09:00
  675fe37446
• Merge branch 'master' into non-nullable-beatmapset-files
  Dean Herbert · 2021-05-31 18:19:57 +09:00
  d4cb70735d
• Merge pull request #13254 from peppy/fix-editor-beatmap-creation-test-failure-again

  Fix bindable lease failure in editor beatmap creation tests

  Dan Balasescu · 2021-05-31 17:38:19 +09:00
  d8768a8c01
• Merge branch 'simplify-shoc' into fix-scrolling-lifetime

  # Conflicts:
  #	osu.Game/Rulesets/UI/Scrolling/ScrollingHitObjectContainer.cs

  ekrctb · 2021-05-31 16:50:47 +09:00
  948a14a627
• Reset lifetime to initial lifetime when layout is invalidated
  ekrctb · 2021-05-31 16:47:10 +09:00
  86d1225aad
• Remove scrollLength caching field

  It was not clear when the field is updated.

  ekrctb · 2021-05-31 16:28:02 +09:00
  6d96846776
• Remove delay of lifetime update

  The scheduling is no longer necessary because `OnAdd` is changed to not invoked immediately for non-pooled DHOs.

  ekrctb · 2021-05-31 16:24:13 +09:00
  742c5b442b
• Don't add nested hit objects to the sets

  Only top-level hit objects are checked for layout computation caching.
  Also, lifetime of nested hit objects are not managed by the HitObjectContainer.

  ekrctb · 2021-05-31 16:20:35 +09:00
  3cedc0824d
• Make SetInitialLifetime public
  ekrctb · 2021-05-31 15:33:28 +09:00
  56a0a24cba
• Merge branch 'master' into fix-skin-sample-lookup
  Dean Herbert · 2021-05-31 15:27:39 +09:00
  de0e51a81d
• ContentVisible -> HiddenByRulesetImplementation
  Salman Ahmed · 2021-05-31 09:24:26 +03:00
  4e186b0cf5
• Merge branch 'master' into remove-hud-component-lookup
  Salman Ahmed · 2021-05-31 09:23:04 +03:00
  02d18c7a49
• Add failing test showing lifetime not recomputed with pooled objects
  ekrctb · 2021-05-31 14:48:52 +09:00
  771f3c48c0
• Test drawable lifetime change on entry lifetime change
  ekrctb · 2021-05-31 14:45:29 +09:00
  b7afea37c4
• Update drawable lifetime on entry lifetime change
  ekrctb · 2021-05-31 14:45:29 +09:00
  e25cca6fbe
• Merge pull request #13235 from ekrctb/update-lifetime-1

  Update hit object lifetime on `HitObject.DefaultsApplied`

  Dan Balasescu · 2021-05-31 14:44:40 +09:00
  8c6277f0d8
• Merge pull request #13218 from peppy/osu-game-base-cleanup

  Tidy up OsuGameBase

  Dan Balasescu · 2021-05-31 14:38:18 +09:00
  76f073ee83
• Fix bindable lease failure in editor beatmap creation tests
  Dean Herbert · 2021-05-31 14:24:46 +09:00
  5925beaf21
• Remove previous consumption logic in GetWorkingBeatmap

  This should not be required since the introduction of `workingCache`,
  which does the same thing in a more global way.

  Dean Herbert · 2021-05-31 14:11:58 +09:00
  06bd696cc2