Dean Herbert
30f17d5869
Disabling reporting users from in-game chat
...
Addresses #23684 .
Safer alternative to #23698 .
2023-06-07 14:03:06 +09:00
Dean Herbert
247ac3a5fd
Merge pull request #23781 from bdach/fix-progress-bar-blink
...
Fix triangles song progress bar blinking during gameplay
2023-06-07 13:44:43 +09:00
Bartłomiej Dach
92c2320689
Merge pull request #23776 from peppy/fix-scroll-time-decimal
...
Fix osu!mania scroll speed milliseconds having too much precision
2023-06-06 22:34:08 +02:00
Bartłomiej Dach
244e6cc008
Merge pull request #23767 from peppy/fix-playfield-border-animation-in-editor
...
Fix gameplay playfield border being affected by beatmap track time
2023-06-06 22:10:18 +02:00
Bartłomiej Dach
be59eb1116
Fix triangles song progress bar blinking during gameplay
...
Closes #23760 .
2023-06-06 18:36:25 +02:00
Dean Herbert
247fa088db
Add IHasNoTimedInputs interface to scope change further
2023-06-06 22:22:42 +09:00
Dean Herbert
d1300f75c0
Merge branch 'master' into no-offset-calibration-with-relax
2023-06-06 22:22:08 +09:00
Dean Herbert
e0e013cca1
Fix incorrect realm schema comment
...
Co-authored-by: timiimit <32331609+timiimit@users.noreply.github.com>
2023-06-06 22:17:05 +09:00
Dean Herbert
6b18f2f2bb
Fix osu!mania scroll speed milliseconds having too much precision
...
Closes #23750 .
2023-06-06 21:43:56 +09:00
Dean Herbert
c0016fa5d2
Fix gameplay playfield border being affected by beatmap track time
...
Closes https://github.com/ppy/osu/issues/23470 .
2023-06-06 16:08:24 +09:00
Dean Herbert
b8d9c9ff93
Move ApplyGameWideClock to extension method
...
I don't see an issue with applying this workaround to more places, even
though it is a workaround, because it marks each usage very clearly. If
we design a better solution in the future it should be easy to replace
the usages.
2023-06-06 16:07:50 +09:00
Dean Herbert
878cdb2ed3
Bump schema version
2023-06-06 15:11:37 +09:00
Dean Herbert
22f7fe1d79
Rename variable and ensure timestamp is updated even when not saving
2023-06-06 15:11:31 +09:00
Dean Herbert
3a50e0fb2f
Merge branch 'master' into add-last-edit-time
2023-06-06 15:07:20 +09:00
Dean Herbert
0c7ab8f971
Merge branch 'master' into hud/argon-kc-animations-poc
2023-06-06 14:43:08 +09:00
Dean Herbert
2f11bd5473
Adjust animations slightly
2023-06-06 14:42:42 +09:00
Dean Herbert
a0b3fd27a7
Merge pull request #23729 from jtbiddle/language-list-update
...
Update languages to match osu-web
2023-06-06 14:31:38 +09:00
Dean Herbert
c54670aee1
Add comment explaining implementation
2023-06-06 13:30:56 +09:00
tsrk
41b7eacc72
Merge branch 'master' into hud/argon-kc-animations-poc
2023-06-05 15:22:20 +02:00
Joseph Madamba
4eb0f0261c
Fix song select beatmap panels not displaying correct background shown in web
2023-06-04 22:54:15 -07:00
Bartłomiej Dach
25d0f0f3da
Merge pull request #23741 from peppy/fix-manage-collection-commit-on-focus-loss
...
Fix collection name changes not being reflected if enter is not pressed
2023-06-04 17:19:13 +02:00
Dean Herbert
eb7586b517
Ensure collection edit textbox commits on focus loss
...
As discussed in https://github.com/ppy/osu/discussions/23739
2023-06-04 12:51:03 +09:00
Bartłomiej Dach
4f5dfecbb8
Comment out Filipino due to satellite assembly copy failure
2023-06-03 23:55:05 +02:00
Bartłomiej Dach
14309ba951
Comment out Tajik due to lack of support on Windows ^<10
2023-06-03 23:42:08 +02:00
Bartłomiej Dach
a8a4c02bb3
Comment out languages with no glyph support
2023-06-03 21:48:03 +02:00
Bartłomiej Dach
a8b102ef72
Remove duplicated zh_tw language
...
`zh_hant` already covers it.
2023-06-03 21:32:12 +02:00
Bartłomiej Dach
331e90f720
Merge branch 'master' into tidy-results-grid-usage
2023-06-03 19:45:23 +02:00
Bartłomiej Dach
602d5db3bb
Simplify column dimensions code
...
`dimensions` would always receive exactly one item, so might as well
inline it.
And yes, at this point the grid container is mostly a glorified
`FillFlowContainer { Direction = FlowDirection.Vertical }`, but I am not
touching that in this pull pending further decisions with respect to
direction.
2023-06-03 19:40:01 +02:00
Bartłomiej Dach
474f7c2bc0
Fix code quality inspection
2023-06-03 16:50:58 +02:00
Bartłomiej Dach
a9d4556647
Merge branch 'master' into update-multiplayer-room-diff-range
2023-06-03 16:50:09 +02:00
Bartłomiej Dach
0b841eda71
Merge pull request #23719 from peppy/disable-tablet-support-on-error
...
Automatically disable tablet support on error
2023-06-03 12:25:06 +02:00
Dean Herbert
8063d50369
Merge pull request #23730 from smoogipoo/reduce-legacy-diffcalc-mod-init
...
Fix legacy mod difficulty calculation creating all mods unnecessarily
2023-06-02 22:22:19 +09:00
Dan Balasescu
bfe80fe143
Fix legacy diffcalc creating all mods unnecessarily
2023-06-02 17:37:43 +09:00
John Biddle
a44b208323
Updated languages in Language.cs to match what is in osu-web/resources/lang/. Added Catalan, Persian, Filipino, Hebrew, Croatian, Lithuanian, Latvian, Malay, Slovenian, Serbian, Tajik, and Sinhala.
2023-06-01 21:25:49 -07:00
Dean Herbert
c33ddedca0
Disable all tablet handlers to guard against a grim future
2023-06-02 08:48:47 +09:00
Bartłomiej Dach
f8289927d2
Merge pull request #23720 from peppy/fix-mouse-disappear-screenshot-fail
...
Fix mouse cursor potentially disappearing for good if screenshot capture fails
2023-06-01 23:09:23 +02:00
Bartłomiej Dach
8433813677
Merge branch 'master' into editor-timeline-fix
2023-06-01 21:18:08 +02:00
Bartłomiej Dach
c2d89a32a9
Adjust inline comment
2023-06-01 21:18:00 +02:00
Andrei Zavatski
03eb7c7830
Fix nullability
2023-06-01 21:21:01 +03:00
Andrei Zavatski
949fe32740
Use combined area of children as a mask instead
2023-06-01 15:32:17 +03:00
Dean Herbert
00bf79d51f
Merge pull request #23691 from smoogipoo/mania-scroll-speed
...
Replace mania scroll "time" with scroll "speed"
2023-06-01 17:23:27 +09:00
Dean Herbert
32207d4112
Remember the last used custom divisor when cycling divisor types
2023-06-01 17:11:49 +09:00
Dean Herbert
bcde2cbc73
Apply NRT to BeatDivisorControl
2023-06-01 16:58:14 +09:00
Dean Herbert
f52ed41f10
Use better defaults of 1/4 and 1/6 when cycling types
2023-06-01 16:28:03 +09:00
Dean Herbert
289f0e9862
Use FireAndForget to avoid unobserved exception
2023-06-01 15:50:37 +09:00
Dean Herbert
0a7d5a51d4
Fix mouse cursor potentially disappearing for good if screenshot capture fails
2023-06-01 15:50:13 +09:00
Dean Herbert
9f8a13480b
Automatically disable tablet support on error
...
Closes #23710 .
2023-06-01 15:16:48 +09:00
Dean Herbert
985604fab5
Return StatisticItems rather than StatisticRows from ruleset
...
There were no usages of more than one column being provided per row, so
it seemed like unnecessarily complexity. I'm currently trying to reduce
complexity so we can improve the layout of the results screen, which
currently has up to three levels of nested `GridContainer`s.
Of note, I can't add backwards compatibility because the method
signature has not changed in `Ruleset` (only the return type). If we do
want to keep compatibility with other rulesets, we could designate a new
name for the updated method.
2023-06-01 14:35:15 +09:00
Dean Herbert
dc595b83f1
Remove unused Dimension specification from StatisticItem
2023-06-01 14:25:18 +09:00
Dean Herbert
55a3847036
Merge pull request #23708 from peppy/labelled-slider-visibility
...
Adjust background colour used in `LabelledDrawable`s to allow visibility of some elements
2023-06-01 13:08:17 +09:00
Bartłomiej Dach
d78df0b084
Merge pull request #23695 from peppy/realm-startup-error-handling
...
Adjust realm startup for added reliability
2023-05-31 22:46:58 +02:00
timiimit
a58426dab6
Use LastEditTime in Editor
2023-05-31 19:07:04 +02:00
timiimit
659fb80c16
Add BeatmapInfo.LastEditTime property
2023-05-31 19:06:41 +02:00
Dean Herbert
7bc3b2072c
Update framework
2023-06-01 00:44:13 +09:00
Dean Herbert
20439e80f6
Adjust background colour used in LabelledDrawables to allow visibility of sliders
2023-05-31 23:24:21 +09:00
Dean Herbert
812def124f
Merge pull request #23661 from peppy/fix-multiplayer-present-crash
...
Fix `OnResume` / `OnSuspending` potentially getting called before `OnEntering` on a sub screen
2023-05-31 19:43:30 +09:00
Dean Herbert
18eb15bfa5
Gracefully handle failures in cleaning up pending file deletions
2023-05-31 19:39:43 +09:00
Bartłomiej Dach
2e81cae201
Move comment to more correct place
2023-05-30 23:18:34 +02:00
Bartłomiej Dach
62d1774407
Apply same comment & reworded condition to suspend too
2023-05-30 21:54:56 +02:00
Andrei Zavatski
d119447a10
Fix editor timeline hitobjects popping in
2023-05-30 16:41:42 +03:00
Dean Herbert
741ee84ed6
Add comment and use full conditional similar to extension method
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-05-30 18:38:28 +09:00
Dean Herbert
14a376c041
Merge branch 'master' into scorev2
2023-05-30 14:34:43 +09:00
Dean Herbert
4e0f40bee5
Split out multiplier retrieval into a function and use a default multiplier for all rulesets
2023-05-30 14:20:26 +09:00
Dean Herbert
fd919879c3
Merge branch 'master' into acc-challenge
2023-05-30 13:24:34 +09:00
Dean Herbert
a0be526266
Adjust realm backup procedure to hard fail if running out of attempts
...
Previously, if the backup procedure failed, startup would continue and
the user's realm database may be deleted. I think in such a fail case
I'd rather the game didn't startup so the user gets in touch (or reads
the log files themselves) rather than potentially losing data.
2023-05-30 13:04:34 +09:00
Dean Herbert
79694897be
Ensure a potential exception from cleanupPendingDeletions doesn't mark realm corrupt
...
The whole restructure here is to move the nested call out of the
`try-catch`. I noticed this while looking at a corrupt database issue a
user reported (https://github.com/ppy/osu/discussions/23694 ).
It's not the first time we've seen a corrupt database error where the
"corrupt" version works just fine on a second attempt.
Maybe this isn't the issue and it's just a transitive file access violation
but it definitely feels like this should be fixed regardless.
2023-05-30 13:00:17 +09:00
Dean Herbert
61d9b50993
Merge pull request #23640 from 17steen/make_pause_menu_translatable
...
Make GameplayMenuOverlay translatable
2023-05-30 09:36:19 +09:00
Bartłomiej Dach
5604dfb758
Merge branch 'master' into acc-challenge
2023-05-29 22:33:57 +02:00
Bartłomiej Dach
314a0f80f3
Reword setting name & description
2023-05-29 22:12:37 +02:00
Bartłomiej Dach
36f60def6d
Merge pull request #23679 from cdwcgt/percentage-format-slider
...
Format percentage based on significant decimal digits
2023-05-29 21:18:23 +02:00
Dan Balasescu
1c199b83e3
Replace mania scroll "time" with scroll "speed"
2023-05-29 21:22:23 +09:00
Dean Herbert
b3ca409339
Rename a few remaining CountAccuracyJudgement variable
2023-05-29 20:08:22 +09:00
Dean Herbert
1558723420
Merge branch 'master' into scorev2
2023-05-29 20:06:32 +09:00
Dean Herbert
df662afbd5
Pass ScoreProcessorStatistics to FrameHeader, rather than the full processor
2023-05-29 20:00:42 +09:00
Dean Herbert
1a6d9e9ff0
Apply NRT to GameplayLeaderboardScore and change GetDisplayedScore handling
...
I don't feel too confident with the default scoring function being
assigned in the constructor to a publicly settable delegate. This just
feels a bit more elegant, and handles the (likely-never-used) case where
we need to restore the default function.
An alternative would be to provide the function as a `ctor` argument,
but I believe that wasn't done here to allow using the
`ILeaderboardScore` interface.
2023-05-29 20:00:29 +09:00
Dean Herbert
fcd7a1d51a
Move GetDisplayScore xmldoc to interface and remove getter
2023-05-29 19:41:53 +09:00
Dean Herbert
9a886125ad
Ensure GameplayScoreCounter's display score is updated on ScoringMode change
...
This isn't strictly required, but only because of a kind of hacky
behaviour where `HUDOverlay` will recreate all components on a scoring
mode change currently (see
8f6df5ea0f/osu.Game/Screens/Play/HUDOverlay.cs (L410-L418)
2023-05-29 19:00:02 +09:00
Dean Herbert
22be045de3
Apply NRT to GameplayScoreCounter
2023-05-29 18:48:17 +09:00
Dean Herbert
a789d1e49c
Add xmldoc and change naming around ScoreProcessorStatistics a bit
2023-05-29 18:38:16 +09:00
Dean Herbert
b0501c4e5c
Actually use paused header
2023-05-29 10:24:59 +09:00
Dean Herbert
f5b258a044
Merge branch 'master' into make_pause_menu_translatable
2023-05-29 01:16:52 +09:00
cdwcgt
333e785f8b
Revert "Provides higher precision settings"
...
This reverts commit ec61840e7d😐
2023-05-28 09:50:11 +09:00
Bartłomiej Dach
ba5f76fcc8
Merge pull request #23667 from peppy/fix-taiko-editor-placement-before-first-control-poiunt
...
Fix placing objects before the first control point in the osu!taiko editor failing
2023-05-27 17:58:28 +02:00
cdwcgt
a05312c9a2
simplify format method
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-05-27 23:44:50 +09:00
cdwcgt
89c8ef3c9b
Format percentage based on significant decimal digits
2023-05-27 23:35:59 +09:00
cdwcgt
ec61840e7d
Provides higher precision settings
2023-05-27 23:25:01 +09:00
cdwcgt
318431a1b7
make MaximumAchievable to default
2023-05-27 21:27:32 +09:00
Robin Oger
cfa1280028
GameplayMenuOverlay.cs: add translatable strings for Retry count: and Song progress:
...
This makes the assumption that languages will prefer having the number on the right
2023-05-27 12:47:05 +02:00
Robin Oger
a01577cba5
Adapt changes to fit master
2023-05-27 12:29:14 +02:00
Robin Oger
d5bfbe2b89
Merge branch 'master' into make_pause_menu_translatable
...
# Conflicts:
# osu.Game/Screens/Play/FailOverlay.cs
# osu.Game/Screens/Play/GameplayMenuOverlay.cs
# osu.Game/Screens/Play/PauseOverlay.cs
2023-05-27 12:22:50 +02:00
Bartłomiej Dach
53c91349fe
Merge branch 'master' into slider-control-point-no-distance-snap
2023-05-26 19:52:54 +02:00
Bartłomiej Dach
574ecf939c
Merge pull request #23647 from peppy/pause-screen-progress
...
Show current progress on pause screen
2023-05-26 19:36:30 +02:00
Dean Herbert
725734bc03
Merge pull request #23649 from peppy/keep-selection-buttons-on-screen
...
Ensure editor selection buttons remain on screen when selection is near edge
2023-05-26 20:51:45 +09:00
Dean Herbert
6b0e215246
Add (int) flooring and handle potential NaN value
2023-05-26 20:44:13 +09:00
Dean Herbert
cb468fa4ec
Fix OverlappingScrollAlgorithm returning incorrect results for TimeAt before first control point
2023-05-26 19:59:19 +09:00
Bartłomiej Dach
96fe7cbe54
Merge branch 'master' into sample-set-controls
2023-05-25 21:58:16 +02:00
Bartłomiej Dach
7d8f08c0ea
Fix ComposeBlueprintContainer briefly assigning auto bank
...
Seems to have had no consequence due to the way
`AutomaticBankAssignment` works (that flag is checked in
`PlacementBlueprint.UpdateTimeAndPosition()`, which runs essentially
every frame), but let's avoid putting it there at all ever.
2023-05-25 21:49:29 +02:00
Bartłomiej Dach
adee624a8f
Change PlacementBlueprint.AutomaticBankAssignment to property
...
Mostly for consistency.
2023-05-25 21:32:21 +02:00
Bartłomiej Dach
b9be886ae1
Merge branch 'master' into pause-screen-progress
2023-05-25 20:34:11 +02:00
Bartłomiej Dach
6425a33b45
Merge branch 'master' into beatmap-length-calcualtions
2023-05-25 17:44:15 +02:00
