Dan Balasescu
807443b648
Add HitResult.SliderTailHit
2023-12-30 10:38:47 +09:00
Dean Herbert
0fa4cd5dfe
Merge pull request #26225 from peppy/new-menu-tips
...
Add some new menu tips (and reword some others)
2023-12-29 22:27:47 +09:00
Dean Herbert
61c46b78bd
Update MenuTip.cs
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2023-12-29 22:24:16 +09:00
Dean Herbert
9f0fe6c6ca
Fix common typos
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-12-29 22:20:29 +09:00
Dean Herbert
d00b7c9cdf
Add some new menu tips (and reword some others)
2023-12-29 22:14:51 +09:00
Bartłomiej Dach
f80f6a8c5b
Merge pull request #26207 from frenzibyte/fix-dropdown-colour
...
Fix dropdown colour not updating correctly on enabled state changes
2023-12-29 14:07:09 +01:00
Bartłomiej Dach
17753b8235
Remove opaque background from toolbar user button
...
Would close https://github.com/ppy/osu/issues/26223 , and generally seems
more consistent with the rest of toolbar anyhow?
2023-12-29 13:49:11 +01:00
Dean Herbert
490c584982
Merge pull request #26222 from bdach/i-cannot-into-offsets
...
Fix global audio offset suggestion feature not taking previous offset value into account
2023-12-29 21:14:52 +09:00
Dean Herbert
2b81f4f557
Merge pull request #26221 from bdach/system-title-only-on-top-level-menu
...
Do not display system title in inital menu state
2023-12-29 21:13:40 +09:00
Bartłomiej Dach
cdcb3ef4aa
Fix global audio offset suggestion feature not taking previous offset value into account
...
See https://osu.ppy.sh/comments/2989193 etc.
2023-12-29 12:20:58 +01:00
Dan Balasescu
9548818a1b
Merge pull request #26220 from bdach/no-version-manager-on-deployed-builds
...
Do not show main menu version display on deployed builds
2023-12-29 19:54:30 +09:00
Bartłomiej Dach
db78d73fa5
Do not display system title in inital menu state
...
Addresses https://github.com/ppy/osu/discussions/26199 .
2023-12-29 11:50:30 +01:00
Bartłomiej Dach
25fa76a1b2
Do not show main menu version display on deployed builds
...
See https://discord.com/channels/188630481301012481/188630652340404224/1190028102525530202 .
2023-12-29 11:14:28 +01:00
Bartłomiej Dach
99cddb6317
Use alternative workaround
2023-12-29 11:07:45 +01:00
Bartłomiej Dach
cd1f6b46c4
Fix crash after changing audio track in editor
...
Closes https://github.com/ppy/osu/issues/26213 .
Reproduction scenario: switch audio track in editor after timeline
loads.
Happens because `beatmap.Value.Track.Length` is 0 immediately after a
track switch, until BASS computes the actual track length on the audio
thread.
Yes this is a hack. No I have no better immediate ideas how to address
this otherwise.
2023-12-29 10:37:36 +01:00
Dan Balasescu
a6313c4ee8
Expose Mod.UsesDefaultConfiguration
2023-12-29 17:16:16 +09:00
Salman Ahmed
c147ec0a98
Update dropdown disabled state to match with other components
2023-12-29 05:31:13 +03:00
Salman Ahmed
150bf67064
Fix dropdown colour not updating correctly on enabled state changes
2023-12-29 05:30:50 +03:00
Nitrous
c68a850325
Make menu tip about mod select more up to date.
2023-12-29 08:51:54 +08:00
iminlikewithyou
51d26d2d71
make the hover scale bigger
...
as a consequence, the rotation needs to be tweaked to be lower
2023-12-28 17:20:44 -06:00
iminlikewithyou
f1f1221e0e
move text left to be visually centered in the skewed rectangle
2023-12-28 17:18:41 -06:00
iminlikewithyou
4760c6aaee
move icon upwards to be visually centered
2023-12-28 17:17:24 -06:00
iminlikewithyou
637119f7d4
increase the base size of button icons
2023-12-28 17:15:23 -06:00
Bartłomiej Dach
7a10e132ea
Fix crash when retrieval of system title image fails
...
Closes https://github.com/ppy/osu/issues/26194 .
2023-12-28 20:39:13 +01:00
Dean Herbert
8e3fe090f3
Merge pull request #26169 from bdach/universal-offset-from-session-plays
...
Implement automatic suggestion of global audio offset based on last plays
2023-12-28 22:57:30 +09:00
Dean Herbert
1de3e3771f
Merge pull request #26187 from peppy/dialog-overlay-design-update
...
Update popup dialog design
2023-12-28 22:39:42 +09:00
Bartłomiej Dach
93c7ebdae3
Remove unused using
2023-12-28 14:30:11 +01:00
Bartłomiej Dach
6d124513e7
Fix test failures due to player bailing early after failing to load beatmap
2023-12-28 14:15:15 +01:00
Bartłomiej Dach
619b0cc69b
Fix code quality inspection
2023-12-28 14:12:28 +01:00
Bartłomiej Dach
6718de01ec
Suggest audio adjust after one play
2023-12-28 14:11:08 +01:00
Bartłomiej Dach
e6f1d7db44
Move SessionAverageHitErrorTracker to more general namespace
2023-12-28 14:10:03 +01:00
Bartłomiej Dach
24a80da83f
Merge branch 'master' into universal-offset-from-session-plays
2023-12-28 14:07:46 +01:00
Bartłomiej Dach
e0279920b6
Merge pull request #26189 from peppy/fix-escape-key-spectator-fail
...
Fix using "Back" binding at spectator fail screen not working
2023-12-28 13:23:38 +01:00
Dean Herbert
f8347288c1
Add padding around text in dialogs
2023-12-28 20:29:56 +09:00
Bartłomiej Dach
a9c7131d47
Merge pull request #26184 from peppy/spectate-from-context-menu
...
Allow entering spectator mode from context menu on user panels
2023-12-28 12:24:29 +01:00
Dean Herbert
e1a376c0a7
Fix using "Back" binding at spectator fail screen not working
2023-12-28 20:14:18 +09:00
Bartłomiej Dach
0fc86a07cb
Merge pull request #26177 from peppy/fix-leaderboard-tab-ordering
...
Fix song select leaderboard tab ordering not matching stable
2023-12-28 12:02:46 +01:00
Dean Herbert
91af94086c
Remove offset wizard button for now
2023-12-28 20:02:08 +09:00
Dean Herbert
b7f3c83514
Expose the ability to update global offset from the player loader screen
2023-12-28 20:01:34 +09:00
Dean Herbert
28e220ca50
Update popup dialog design
...
Had to be done. I hated the old ones so much.
As usual, disclaimer that this is an iterative design and will probably
be replaced in the future.
2023-12-28 19:04:35 +09:00
Dean Herbert
22eced3300
Show local user in online users
2023-12-28 17:40:07 +09:00
Dean Herbert
2ec9343868
Add the ability to spectate a user by right clicking their user panel
2023-12-28 17:35:10 +09:00
Dean Herbert
bd0e2b4dde
Remove disclaimer screen completely
2023-12-28 17:21:29 +09:00
Dean Herbert
7dc50b9baf
Don't dismiss on hover, and allow dismissing via click
2023-12-28 17:20:01 +09:00
Dean Herbert
1f2339244e
Add supporter display to main menu
2023-12-28 17:20:01 +09:00
Dean Herbert
b19f72481b
Fade out quickly on game exit sequence
2023-12-28 17:19:41 +09:00
Dean Herbert
0ad6ac8b2a
Remove unused variable
2023-12-28 16:48:17 +09:00
Dean Herbert
932d03a4f8
Make toggle more immediately hide/show tips
2023-12-28 16:21:19 +09:00
Dean Herbert
222459d921
Add background and improve layout
2023-12-28 16:16:27 +09:00
Dean Herbert
a1867afbb4
Move menu tips to main menu
...
In preparation for removing the disclaimer screen.
2023-12-28 16:06:08 +09:00
Dean Herbert
be3fc45da5
Merge branch 'master' into system-title-basic
2023-12-28 15:19:33 +09:00
Dean Herbert
6684987289
Reduce refresh interval slightly
2023-12-28 15:19:09 +09:00
Dean Herbert
0ea62d0c5d
Add initial additive blending on fade in
2023-12-28 15:16:42 +09:00
Dean Herbert
972234b1e5
Move re-schedule inside continuation
2023-12-28 15:12:44 +09:00
Dean Herbert
481a251786
Use HandleLink to allow potentially opening wiki or otherwise
2023-12-28 15:11:02 +09:00
Dean Herbert
289e0f00f9
Add flash on click
2023-12-28 15:10:47 +09:00
Dean Herbert
c70e7d340d
Adjust animation and add delay to URL open
2023-12-28 15:10:47 +09:00
Dean Herbert
93a8afe96e
Add very simple cache-busting (30 minutes)
2023-12-28 14:40:10 +09:00
Dean Herbert
ffc8778d67
Fix song select leaderboard tab ordering not matching stable
2023-12-28 14:13:35 +09:00
Dean Herbert
f8d6b8e347
Adjust toolbar animations / layering to feel better
2023-12-28 14:10:52 +09:00
Felipe Marins
dce9204731
Select search box text on ModSelectOverlay when mod selection changes
2023-12-28 00:10:44 -03:00
Felipe Marins
cbfcda7929
Expose SelectAll() method on ShearedSearchTextBox
2023-12-28 00:10:01 -03:00
Bartłomiej Dach
ef39759813
More code quality inspections
2023-12-28 00:18:20 +01:00
Bartłomiej Dach
10106e20c7
Merge pull request #26162 from Gabixel/alternate-daycore-with-classic-hotkey
...
Cycle between Daycore and Half Time mod when using classic hotkeys style
2023-12-28 00:16:51 +01:00
Bartłomiej Dach
ac449131ed
CodeFileSanity does not like records in standalone files
2023-12-27 23:47:37 +01:00
Bartłomiej Dach
a3f720bc62
Retrieve system title from online source
2023-12-27 23:37:39 +01:00
Bartłomiej Dach
d9299a8a55
Implement visual appearance of "system title" message in main menu
2023-12-27 23:07:17 +01:00
Bartłomiej Dach
160342ceed
Implement automatic suggestion of audio offset based on last plays
2023-12-27 21:14:37 +01:00
Bartłomiej Dach
f51b5f5487
Add components to track average hit errors across session
2023-12-27 20:44:59 +01:00
Dean Herbert
cf5e3e8863
Breathe some colour and life into the toolbar
2023-12-28 04:12:55 +09:00
Dean Herbert
92c4c20a51
Adjust paddings and fills of toolbar buttons
2023-12-28 03:43:38 +09:00
Dean Herbert
70aa067eb1
Adjust gradient visibility and transition
2023-12-28 03:23:04 +09:00
Bartłomiej Dach
1b7af989ec
Migrate BeatmapOffsetControl to use session static directly
2023-12-27 19:19:27 +01:00
Bartłomiej Dach
d4423d4933
Store last set score to a SessionStatic
2023-12-27 19:13:42 +01:00
Dean Herbert
1f55ef211e
Rearrange buttons
2023-12-28 03:11:27 +09:00
Dean Herbert
5f7f1f771d
Reword tooltip text for dashboard
2023-12-28 03:09:20 +09:00
Dean Herbert
655528a537
Update resources
2023-12-28 03:04:13 +09:00
Bartłomiej Dach
89e2b6358a
Remove hexacons
2023-12-27 17:42:18 +01:00
Bartłomiej Dach
53766285ce
Remove remaining hexacons usages
2023-12-27 17:42:18 +01:00
Bartłomiej Dach
288ac930e4
Use new icons in editor
...
Some that exist on figma are purposefully not used due to an editorial
request from @peppy.
2023-12-27 17:42:18 +01:00
Bartłomiej Dach
2857322a8b
Use new icons in settings
2023-12-27 17:42:18 +01:00
Bartłomiej Dach
c45477bd1f
Use new icons in main menu wherever feasible
2023-12-27 17:42:18 +01:00
Bartłomiej Dach
28d9145a4c
Add more spacing to toolbar icons
2023-12-27 17:42:18 +01:00
Bartłomiej Dach
69baabee62
Replace hexacons in toolbar with new icons
2023-12-27 17:42:18 +01:00
Bartłomiej Dach
45143a6c17
Implement new icon store
2023-12-27 17:42:17 +01:00
Susko3
a6bed04e50
Update confine mode settings checkbox to match the new ConfineMouseTracker logic
...
Not too happy with the duplicated logic, but settings can't depend on `ConfineMouseTracker`
for testability reasons.
2023-12-27 16:54:01 +01:00
Susko3
0fde9cd6ae
Override confine mouse mode only when clicking outside the window would minimise it
2023-12-27 16:50:25 +01:00
Susko3
c9de6a383d
Add settings checkbox for MinimiseOnFocusLossInFullscreen
...
Shown only on desktop platforms in fullscreen.
"alt-tab" keyword also matches "alt" and "tab".
2023-12-27 16:21:54 +01:00
Gabriel
28a552f7b9
Merge branch 'ppy:master' into alternate-daycore-with-classic-hotkey
2023-12-27 15:12:13 +01:00
Bartłomiej Dach
13333f7575
Make room for OsuIcon to accept new icons
2023-12-27 15:04:28 +01:00
Gabriel Del Nero
14b37db3dd
Make ModDaycore sequential for ModHalfTime
2023-12-27 14:35:19 +01:00
Dean Herbert
1233533fb9
Update framework
2023-12-27 22:14:15 +09:00
Bartłomiej Dach
e9f350e763
Merge pull request #26147 from peppy/settings-expanded
...
Always show settings section text on buttons
2023-12-27 09:17:56 +01:00
Dean Herbert
768e10d55f
Adjust NotificationOverlay fades to match
2023-12-27 13:50:47 +09:00
Dean Herbert
81ba46216f
Speed up fades in transition to avoid ugliness
2023-12-27 13:49:00 +09:00
Dean Herbert
901674a130
Move back button inside sidebar to fix weird animation
2023-12-27 13:39:13 +09:00
Dean Herbert
8cd240fbec
Reduce size and fix alignment of back button
2023-12-27 13:20:19 +09:00
Bartłomiej Dach
af47f9fd70
Fix sidebar button text becoming masked away during fadeout
2023-12-26 20:24:43 +01:00
Bartłomiej Dach
c107bfcd31
Fix TestSceneSideOverlays test failure
2023-12-26 20:09:34 +01:00
Bartłomiej Dach
668ce937a8
Merge pull request #26138 from peppy/fix-audio-rate-playback-not-fail
...
Bail from score submission if audio playback rate is too far from reality
2023-12-26 19:13:46 +01:00
Dean Herbert
5d0b524794
Adjust back button to match style better
2023-12-27 02:54:24 +09:00
Dean Herbert
8e13f65c5d
Adjust hover effect slightly
2023-12-27 02:46:21 +09:00
Dean Herbert
5b1deb7c4b
Give buttons a touch of padding to make click effect feel better
2023-12-27 02:40:50 +09:00
Dean Herbert
5de8307918
Reduce width of sidebar buttons
2023-12-27 02:38:23 +09:00
Dean Herbert
9a1a97180d
Change settings overlay to always show expanded buttons
2023-12-27 02:33:17 +09:00
Dean Herbert
58476d5429
Allow ExpandingContainer to not auto expand on hover
2023-12-27 02:33:02 +09:00
Dean Herbert
c55458e49c
Remove pointless intermediary class
2023-12-27 02:32:47 +09:00
Dean Herbert
d70fddb6fd
Fix elapsed time being counted twice on first frame
2023-12-27 00:11:22 +09:00
Dean Herbert
03e2463b06
Add test coverage and refactor to better handle equality edge case
2023-12-26 21:21:08 +09:00
Dean Herbert
1f2f749db6
Fix selection not being retained in control point list when undoing / redoing
2023-12-26 21:04:42 +09:00
Dean Herbert
f2c0e7cf2e
Fix editor's control point list refreshing multiple times for a single change
2023-12-26 21:04:42 +09:00
Bartłomiej Dach
b1a26acdd0
Merge pull request #26136 from peppy/add-waveform-visual-offset
...
Add visual offset to better align editor waveforms with expectations
2023-12-26 12:57:13 +01:00
Nathan
6269c79c17
Merge branch 'master' into fix-rewind-backtracking
2023-12-26 03:10:00 -08:00
Dean Herbert
92f7a42fd7
Merge pull request #26131 from smoogipoo/fix-mania-scroll-difference
...
Make mania scroll speed independent of hit position
2023-12-26 19:27:43 +09:00
Dean Herbert
225528d519
Bail from score submission if audio playback rate is too far from reality
...
Closes https://github.com/ppy/osu/issues/23149 .
2023-12-26 19:20:58 +09:00
Dean Herbert
f9e47242db
Add visual offset to better align editor waveforms with expectations
2023-12-26 17:44:49 +09:00
Dan Balasescu
2ec6aa7fbb
Make mania scroll speed independent of hit position
2023-12-26 12:46:21 +09:00
Dean Herbert
b18b5b9977
Add inline note about deadlock
2023-12-26 12:06:56 +09:00
Nathan Tran
060bf8beff
Fix rewind backtracking
2023-12-25 15:27:32 -08:00
Bartłomiej Dach
f84b07e71a
Do not attempt to stop preview tracks when arriving from a "track completed" sync
...
This fixes an issue identified with the WASAPI implementation in
https://github.com/ppy/osu-framework/pull/6088 . It has no real effect
on current `master`, but fixes a deadlock that occurs with the
aforementioned framework branch when one lets a preview track play out
to the end - at this point all audio will stop and an attempt to perform
any synchronous BASS operation (playing another track, seeking) will
result in a deadlock.
It isn't terribly clear as to why this is happening precisely, but
there does not appear to be any need to stop and seek at that point,
so this feels like a decent workaround even if the actual issue is
upstream (and will unblock pushing out WASAPI support to users).
2023-12-25 19:01:06 +01:00
Bartłomiej Dach
4fa35d709c
Update resources
2023-12-25 14:56:40 +01:00
Bartłomiej Dach
3748541569
Merge branch 'master' into add-slider-tick-end-miss-sprites
2023-12-25 14:55:09 +01:00
Bartłomiej Dach
8142a7cb7e
Remove incorrect spec
2023-12-25 14:00:32 +01:00
Dean Herbert
8e6ea2dd9b
Update argon and triangles to match display style
2023-12-25 17:37:28 +09:00
Dean Herbert
b1d994b6ff
Add classic skin sprites for slider tick and slider end misses
2023-12-25 17:17:23 +09:00
Dean Herbert
ee00f7ea1f
Merge pull request #26086 from peppy/fix-toolbar-button-lag
...
Use a realm subscription to avoid overhead when hovering a toolbar button
2023-12-24 04:01:04 +09:00
Bartłomiej Dach
a0915a0dd1
Merge pull request #26076 from peppy/gameplay-offset-adjust
...
Add control to allow changing offset from gameplay
2023-12-23 19:41:57 +01:00
Bartłomiej Dach
68430d6ecd
Fix toolbar keybinding hint not clearing after unbinding the keybinding
2023-12-23 19:39:17 +01:00
Dean Herbert
5b03dc8d0b
Use a realm subscription to avoid overhead when hovering a toolbar button
...
Addresses https://github.com/ppy/osu/discussions/26018 .
2023-12-24 03:20:42 +09:00
Dean Herbert
686b2a4394
Disable positional interaction for now
2023-12-24 03:00:51 +09:00
Dean Herbert
72bec527fd
Add conditions to match stable offset adjust limitations
2023-12-24 02:36:27 +09:00
Dean Herbert
92b490f2e7
Don't bother with alt support for now
2023-12-24 01:59:48 +09:00
Dean Herbert
d72ec81684
Merge pull request #26083 from smoogipoo/try-improve-hp-drain
...
Replace recently-added HP drain density calculation with combo-end bonus
2023-12-24 01:30:49 +09:00
Dan Balasescu
ee0bd69e24
Merge pull request #26072 from peppy/fix-migration-hard-crash
...
Fix hard crash when attempting to change folder location during a large import
2023-12-24 00:09:13 +09:00
Dan Balasescu
0db2668026
Merge pull request #26069 from peppy/fix-legacy-version-checks
...
Change legacy version checks to account for users specifying incorrect versions
2023-12-24 00:07:01 +09:00
Dan Balasescu
807ea8a9a0
Merge pull request #26082 from bdach/relax-legacy-score-conversion
...
Fix standardised score conversion failing for scores set with 0.0x mod mutliplier
2023-12-24 00:04:10 +09:00
Bartłomiej Dach
fde0276db3
Merge pull request #26077 from peppy/profile-cover-pixel-fix
...
Fix user profile cover showing 1px line when contracted
2023-12-23 15:49:03 +01:00
Bartłomiej Dach
a011a1ebb8
Merge pull request #26080 from peppy/cinema-no-fail
...
Change "cinema" mod to never fail
2023-12-23 15:48:42 +01:00
Dan Balasescu
d1000b2e6c
remove HP density
2023-12-23 23:36:15 +09:00
Bartłomiej Dach
0cbf594a8c
Make cinema mod incompatible with no fail
2023-12-23 15:10:31 +01:00
Bartłomiej Dach
3a2ed3677b
Fix standardised score conversion failing for scores set with 0.0x mod mutliplier
...
Closes https://github.com/ppy/osu/issues/26073 .
2023-12-23 13:28:39 +01:00
Dean Herbert
644c981673
Fix "spectate" button not always being clickable in online users list
2023-12-23 21:21:34 +09:00
Dean Herbert
15a9740eb6
Change "cinema" mod to never fail
...
Addresses https://github.com/ppy/osu/discussions/26032 .
2023-12-23 21:12:47 +09:00
Bartłomiej Dach
007ea51e20
Add extra safety against returning negative total score in conversion operation
2023-12-23 13:07:29 +01:00
Dean Herbert
a2e5f62478
Fix user profile cover showing 1px line when contracted
...
Addresses https://github.com/ppy/osu/discussions/26068 .
2023-12-23 21:07:17 +09:00
Dean Herbert
6f11885d4b
Add control to allow changing offset from gameplay
2023-12-23 20:51:30 +09:00
Dean Herbert
7e9522a722
Allow external use of offset text explanation
2023-12-23 20:46:12 +09:00
Dean Herbert
27a9dcc5a1
Add basic hotkey offset adjust support (via existing offset control)
2023-12-23 19:55:05 +09:00
Dean Herbert
8349cb7bbe
Fix hard crash when attempting to change folder location during a large import
...
Closes https://github.com/ppy/osu/issues/26067 .
2023-12-23 17:03:58 +09:00
Dean Herbert
c5893f245c
Change legacy version checks to account for users specifying incorrect versions
2023-12-23 14:03:45 +09:00
Simon G
3487b5865e
Merge branch 'ppy:master' into adjust_beatmap_length_according_to_rate
2023-12-22 18:08:35 +01:00
Dean Herbert
21e9e103fd
Merge pull request #26039 from smoogipoo/hp-drain-density
...
Add basic density consideration to HP drain
2023-12-23 01:04:53 +09:00
Dean Herbert
7e09164d70
Merge pull request #26036 from smoogipoo/fix-perfect-mod-special-judgements
...
Fix perfect mod not failing with special judgements
2023-12-22 18:22:28 +09:00
Dan Balasescu
a0185508b7
Add basic consideration of density for HP drain
2023-12-22 18:08:26 +09:00
Dan Balasescu
5703546d71
Revert change to ModSuddenDeath
2023-12-22 16:43:17 +09:00
Dan Balasescu
88a5ba8167
Add mania/osu sudden death mod tests
2023-12-22 16:43:09 +09:00
Dan Balasescu
ea778c6e0a
Fix perfect/sudden death not working on slider tails
2023-12-22 14:02:25 +09:00
Dan Balasescu
9c35e25036
Add failing tests
2023-12-22 13:58:12 +09:00
Simon G
b31b9e96d0
adjust beatmap length and drain based on rate changing mods
2023-12-22 03:04:48 +01:00
Bartłomiej Dach
a7326e3891
Merge pull request #26004 from DanielPower/25049-fix-skin-element-bounding-box
...
Fix scale of skin element bounding box
2023-12-21 18:14:24 +01:00
Dean Herbert
716d866178
Merge pull request #25998 from peppy/add-score-version
...
Add versioning of local scores
2023-12-21 23:58:23 +09:00
Bartłomiej Dach
b4e71a0787
Fix slider tick / end misses displaying with full size on legacy skins with animated misses
...
Resolves https://github.com/ppy/osu/issues/25987 .
Structure is a bit clumsy but I'm not sure how to do better...
2023-12-21 13:58:12 +01:00
Daniel Power
d4731e0830
Fix scale of skin element bounding box
2023-12-21 08:56:39 -03:30
Bartłomiej Dach
fbf19ea598
Merge branch 'master' into add-score-version
2023-12-21 13:06:53 +01:00
Bartłomiej Dach
2baf579f7c
Serialise and deserialise ClientVersion to replays
2023-12-21 12:58:08 +01:00
Bartłomiej Dach
81bbdccee7
Rename ScoreInfo.{ -> Client}Version
2023-12-21 12:56:43 +01:00
Dean Herbert
a4baa0a716
Add versioning of local scores
...
For any potential future usage
2023-12-21 18:37:15 +09:00
Dan Balasescu
c3c1752a5a
Reconvert all legacy scores
2023-12-21 15:32:34 +09:00
Dan Balasescu
eb072a1d24
Add accuracy conversion, fix usages
2023-12-21 15:09:56 +09:00
Dan Balasescu
6b4b2a57fc
Expose only as one method
2023-12-21 14:58:23 +09:00
Dan Balasescu
4e3b994142
Relocate HitResult numeric score to ScoreProcessor
2023-12-21 14:52:31 +09:00
Bartłomiej Dach
b7cca788b5
Merge pull request #25964 from rushiiMachine/fix-export-replay-spam
...
Fix save & export failed replay hotkeys handling repeated keypresses
2023-12-20 21:07:36 +01:00
Bartłomiej Dach
53cca61e61
Merge pull request #25951 from peppy/show-tick-results
...
Show slider tick / slider end misses with a visible judgement
2023-12-20 20:44:04 +01:00
Bartłomiej Dach
975bacaeb7
Add back blank line to fix code quality inspection
2023-12-20 19:07:26 +01:00
Bartłomiej Dach
a763ad8473
Add remarks to Is{Hit,Miss}() to explain their simultaneous existence
2023-12-20 19:07:18 +01:00
rushiiMachine
ebbc8333e8
Prevent ExportReplay being spammed on fail by being held down
...
This was already handled in ReplayDownloadButton (98efff0bd6/osu.Game/Screens/Ranking/ReplayDownloadButton.cs (L114-L115)
2023-12-20 08:41:16 -08:00
Dean Herbert
eb8fb8092d
Attempt to standardise miss handling logic
2023-12-21 00:59:35 +09:00
Bartłomiej Dach
9515f7dbfa
Bump score version in order to recompute legacy scores
2023-12-20 16:01:59 +01:00
Bartłomiej Dach
8c06d3873d
Merge branch 'master' into mania-scorev2-values
2023-12-20 15:54:31 +01:00
Bartłomiej Dach
77d8bbf152
Merge pull request #25949 from peppy/fix-song-select-extra-selections
...
Fix beatmap updates causing one extra carousel selection
2023-12-20 15:30:38 +01:00
Bartłomiej Dach
83e885192b
Merge pull request #25931 from peppy/fix-thread-safety
...
Fix thread safety of `OnlineMetadataClient.UserStates`
2023-12-20 12:55:31 +01:00
Dean Herbert
d1ba2a4a64
Use orange for non-combo-breaking miss
2023-12-20 20:45:27 +09:00
Dean Herbert
d2716d8557
Improve animation for legacy skins
2023-12-20 20:34:05 +09:00
Bartłomiej Dach
6bddc56851
Merge branch 'master' into fix-song-select-extra-selections
2023-12-20 12:23:55 +01:00
Dean Herbert
9b383e3276
Add support for showing tick misses
2023-12-20 20:23:19 +09:00
Bartłomiej Dach
22513e0070
Merge pull request #25943 from peppy/fix-song-select-sound-at-gameplay
...
Fix song select running updates when screen is not active
2023-12-20 12:20:06 +01:00
Dan Balasescu
38d6b7f45b
Update total score conversion
2023-12-20 20:03:13 +09:00
Dean Herbert
5284b95bb8
Schedule even more
2023-12-20 19:42:05 +09:00
Dean Herbert
7fa4dcf0fb
Fix selection retention logic copy paste failure
2023-12-20 19:27:57 +09:00
Dean Herbert
e003462f7d
Fix beatmap updates causing one extra carousel selection
2023-12-20 19:15:02 +09:00
Dan Balasescu
72274041eb
Merge pull request #25876 from bdach/fix-standardised-score-conversion
...
Fix osu! standardised score conversion sometimes exceeding bounds
2023-12-20 18:54:33 +09:00
Dean Herbert
64f62e7d90
Fix song select running updates when screen is not active
...
Who would have guessed that `Schedule` calls were there for a reason!
I've tidied things up. Most of the changes I've made here are not
required – the schedule is the main thing here. The reason the sound was
playing is because one-too-many schedules was removed causing beatmap
updates to update carousel specifics while still at the player loader
screen.
Note that the selection sound still plays on returning to song select,
but this is not a regression. I'm looking at fixing this in a separate
PR because I'm in a good place as far as understanding the logic right
now and it would be a waste to leave it broken.
Closes https://github.com/ppy/osu/issues/25875 .
2023-12-20 17:31:09 +09:00
Dean Herbert
831c273b45
Merge pull request #25887 from smoogipoo/restore-taiko-accuracy
...
Restore taiko accuracy to ScoreV2 values
2023-12-20 17:29:40 +09:00
Dan Balasescu
188c463c9c
Merge pull request #25934 from peppy/adjust-classic-mod-multiplier
...
Adjust "classic" mod multiplier to 0.96x
2023-12-20 17:11:09 +09:00
Bartłomiej Dach
9a5027e556
Merge pull request #25900 from peppy/editor-from-any-carousel
...
Allow choosing "Edit" from any beatmap carousel item
2023-12-20 08:35:42 +01:00
Dean Herbert
98efff0bd6
Merge pull request #25917 from rushiiMachine/remove-relax-mod-exclusions
...
Allow failing with "relax" and "autopilot" mods
2023-12-20 15:48:21 +09:00
Dean Herbert
14d2d0d215
Remove ModBlockFail
...
Was only being used by `NoFail` now.
2023-12-20 14:50:45 +09:00
Dan Balasescu
3818977a36
Merge pull request #25898 from peppy/song-select-stats
...
Update song select to always show difficulty stats
2023-12-20 14:39:35 +09:00
Dean Herbert
d7603e8021
Adjust "classic" mod multiplier to 0.96x
...
Following discussions on discord, this seems like the most agreed upon
value. Increasing this is important so that imported legacy scores don't
lose too much value.
2023-12-20 14:33:14 +09:00
Dean Herbert
856c59f7f7
Fix thread safety of OnlineMetadataClient.UserStates
...
Closes https://github.com/ppy/osu-framework/issues/6081 .
2023-12-20 14:15:00 +09:00
Dean Herbert
85e5d74a16
Apply proposed changes
2023-12-20 12:42:06 +09:00
rushiiMachine
1b004dbebc
Allow Relax to fail and remove failable mod exclusions
...
Allows the Relax mod to fail, and remove NF/PF/SD mod exclusion
ref: https://github.com/ppy/osu/discussions/13229
2023-12-19 12:33:00 -08:00
OliBomby
c167f10ad5
fix crash from dragging near zero-length repeating object in timeline
2023-12-19 21:20:45 +01:00
OliBomby
ec578e1d9f
fix near-zero length sliders n stuff being placeable
2023-12-19 21:20:21 +01:00
Bartłomiej Dach
1ebb6262fd
Merge pull request #25895 from peppy/fix-beatmap-statsitics-reprocessing
...
Fix some beatmaps being reprocessed each startup
2023-12-19 18:05:40 +01:00
Bartłomiej Dach
322cfaae1d
Merge branch 'master' into fix-standardised-score-conversion
2023-12-19 17:41:38 +01:00
Bartłomiej Dach
3f41c20ac6
Use safer fix for now
2023-12-19 17:25:15 +01:00
Bartłomiej Dach
64b0534fb8
Merge pull request #25857 from peppy/fix-mod-settings-keyboard-adjust
...
Fix mod search textbox having focus while settings are visible
2023-12-19 15:44:17 +01:00
Bartłomiej Dach
e306cc35ba
Merge branch 'master' into fix-song-select-realm-refresh-performance
2023-12-19 14:14:46 +01:00
Dean Herbert
bbfdd6892d
Allow choosing "Edit" from any beatmap carousel item
2023-12-19 19:58:49 +09:00
Dean Herbert
c556475c2c
Revert to using a more manual approach to holding focus
2023-12-19 19:46:30 +09:00
Dean Herbert
502e3edac3
Add missing invalidation call
2023-12-19 19:39:48 +09:00
Dean Herbert
2c5ca9c1c8
Change default song select tab display to local leaderboard
2023-12-19 19:31:05 +09:00
Dean Herbert
3b848e8503
Tidy up visual look
2023-12-19 19:28:02 +09:00
Dean Herbert
07bb0805e9
Move advanced stats to a more permanent location on song select
2023-12-19 19:10:43 +09:00
Dean Herbert
0a64d631e2
Add support for dual-column advanced stats
2023-12-19 19:09:47 +09:00
Dean Herbert
f09c6b8c1b
Change default values of new object counts to -1 to identify non-processed values
2023-12-19 18:20:02 +09:00
Dean Herbert
8f5d21dc70
Actually fix realm selection retention regression
2023-12-19 18:10:55 +09:00
Dean Herbert
7e9c1b2acb
Use sender's realm (because we can)
2023-12-19 17:27:52 +09:00
Bartłomiej Dach
7c05d66bd7
Add more detail to exception
2023-12-19 08:57:18 +01:00
Bartłomiej Dach
ddb67c87a8
Roll back incorrect change in ShouldMigrateToNewStandardised()
2023-12-19 08:13:02 +01:00
Dean Herbert
44efa2c540
Fix incorrect ordering of items at song select when certain sort modes are used
2023-12-19 15:09:03 +09:00
Dan Balasescu
c1b55c7fac
Add ScoreProcessor methods to override numeric result
2023-12-19 13:50:31 +09:00
Bartłomiej Dach
9c8df4e6d1
Run score conversion for previously-imported scores
2023-12-18 22:27:51 +01:00
Bartłomiej Dach
017003deea
Fix osu! standardised score conversion sometimes exceeding bounds
...
Co-authored-by: Zyf <zyfarok@gmail.com>
Closes https://github.com/ppy/osu/issues/25860
Users reported that some stable scores would convert to large negative
total scores in lazer after the introduction of combo exponent. Those
large negative total scores were actually mangled NaNs.
The root cause of this was the following calculation going below zero
unexpectedly:
8e8d9b2cd9/osu.Game/Database/StandardisedScoreMigrationTools.cs (L323)8e8d9b2cd9/osu.Game/Database/StandardisedScoreMigrationTools.cs (L337)
2023-12-18 22:05:19 +01:00
Susko3
cc800a18b2
Fix opening log files from notification not presenting the correct file
2023-12-18 21:11:00 +01:00
Bartłomiej Dach
8e8d9b2cd9
Merge pull request #25832 from peppy/more-background-processing-progress-notifications
...
Show more comprehensive background processing progress notifications
2023-12-18 20:05:47 +01:00
Bartłomiej Dach
b8bcf7a097
Merge pull request #25856 from peppy/fix-keybaord-adjust-nc-dc
...
Fix keyboard precision of nightcore/daycore adjustments being incorrect
2023-12-18 19:54:17 +01:00
Dean Herbert
9594ae7802
Update framework
2023-12-19 03:22:22 +09:00
Dean Herbert
51f4c7254c
Fix mod search textbox having focus while settings are visible
...
Stopped arrow key adjust on slider bars from working.
Also just felt wrong that you could type into an off-screen textbox.
2023-12-19 01:32:34 +09:00
Dean Herbert
374425ea75
Fix keyboard precision of nightcore/daycore adjustments being incorrect
...
Closes https://github.com/ppy/osu/issues/25854 .
2023-12-19 01:07:33 +09:00
Dean Herbert
c466775f78
Merge pull request #25821 from bdach/fix-collection-dropdown-crash
...
Fix collections dropdown crashing during storage migration
2023-12-19 01:01:23 +09:00
Dean Herbert
c88c25e77f
Merge pull request #25848 from 65-7a/dropdown-search-padding
...
Fix padding on dropdown search bar
2023-12-19 00:36:14 +09:00
Dean Herbert
9aaaa12809
Don't show progress notifications when there are too few items to be worthwhile
2023-12-19 00:01:09 +09:00
Dean Herbert
d81cabc063
Revert "Improve performance of attemptSelection using new cached count and LastSelected"
...
This reverts commit 25df42630e
2023-12-18 22:46:02 +09:00
Dean Herbert
25e3a8e82e
Fix a few of silly issues
2023-12-18 22:45:58 +09:00
65-7a
17f1f8bb43
Fix padding on dropdown search bar
2023-12-19 00:28:23 +11:00
Bartłomiej Dach
eeeb5aa3d4
Fix crash when creating collections named "All beatmaps" or "Manage collections..."
...
Closes https://github.com/ppy/osu/issues/25834
The name fallback that was there previously since
https://github.com/ppy/osu/pull/11892 was half broken. This way should
be a lot less prone to failure.
2023-12-18 12:52:39 +01:00
Dean Herbert
25df42630e
Improve performance of attemptSelection using new cached count and LastSelected
2023-12-18 20:47:08 +09:00
Dean Herbert
5755fa214a
Cache non-filtered beatmap counts to massively improve count performance
2023-12-18 20:44:08 +09:00
Dean Herbert
034c5cd654
Debounce count updates for good measure
2023-12-18 20:43:23 +09:00
Dean Herbert
6fa1f5ef9b
Simplify invalidation logic
...
The only case where this was checking is guaranteed by realm to only be called once.
2023-12-18 20:31:02 +09:00
Dean Herbert
87b7699fcc
Avoid calling invalidation logic per beatmap set updated
...
Realm will batch the updates. We don't want to do expensive operations per set when we don't need to.
2023-12-18 20:31:02 +09:00
Dean Herbert
32cc3f9ef7
Combine multiple similar invalidation logic into single event
2023-12-18 20:31:02 +09:00
Dean Herbert
03ac2c3094
Remove some excessive logging
2023-12-18 19:20:57 +09:00
Dean Herbert
62444c3d04
Fix song select's carousel scroll position getting reset on background processing
...
This only happened for users using absolute right-click scroll.
2023-12-18 19:17:59 +09:00
Dean Herbert
e3251b40b3
Fix progress notifications queueing up infinite text changes when not visible
2023-12-18 19:00:44 +09:00
Dean Herbert
5ab3815123
Add logging of progress every so often
2023-12-18 18:45:49 +09:00
Dean Herbert
bfa90e9dcb
Also populate ObjectCounts when running a full beatmap process
...
Saves running things twice on an old install
2023-12-18 18:41:41 +09:00
Dean Herbert
e7d1cf7868
Add progress notifications for background tasks which don't already have them
2023-12-18 18:41:41 +09:00
