63111 Commits

This Branch

This Branch

All Branches

• Merge branch 'master' into taiko-beat-snap-grid
  Dean Herbert · 2023-10-19 23:53:01 +09:00
  52c2eb93de
• Merge pull request #25171 from bdach/distance-snapping-composition

  Replace `DistancedHitObjectComposer` with composition-based approach

  Dean Herbert · 2023-10-19 23:46:10 +09:00
  e8d0962197
• Inherit ScrollingHitObjectComposer in catch
  Bartłomiej Dach · 2023-10-19 11:58:25 +02:00
  0c4e74c82d
• Remove DistancedHitObjectComposer
  Bartłomiej Dach · 2023-10-19 11:46:30 +02:00
  144ef5a87c
• Remove DistancedHitObjectComposer inheritance from catch composer
  Bartłomiej Dach · 2023-10-19 11:46:30 +02:00
  31849192c3
• Remove DistancedHitObjectComposer inheritance from osu! composer
  Bartłomiej Dach · 2023-10-19 11:46:30 +02:00
  dcfd6a0a8a
• Split IPositionSnapProvider from IDistanceSnapProvider

  In preparation to remove `DistancedHitObjectComposer`, split off
  `IPositionSnapProvider` from `IDistanceSnapProvider`.
  
  `DistancedHitObjectComposer` was not touching `IPositionSnapProvider`'s
  only interface member at all, it was just forwarding it for subclasses
  to override to their own leisure.

  Bartłomiej Dach · 2023-10-19 11:45:24 +02:00
  3ab083b696
• Merge pull request #25169 from smoogipoo/fix-diffcalc-pr-command

  Fix invalid PR URL in diffcalc GitHub action

  Bartłomiej Dach · 2023-10-19 08:29:28 +02:00
  0b8b87d6bd
• Fix incorrect PR url in diffcalc workflow
  Dan Balasescu · 2023-10-19 15:19:51 +09:00
  832ba861bb
• Merge pull request #25159 from smoogipoo/improve-diffcalc-command

  Fix + improve diffcalc command for comment-based execution

  Dean Herbert · 2023-10-19 12:11:16 +09:00
  66421a55ab
• Pin third-party actions
  Dan Balasescu · 2023-10-19 02:39:34 +09:00
  14cadd1eeb
• Merge pull request #24640 from Givikap120/pitch_change

  Add an "Adjust pitch" switch to DT/HT

  Bartłomiej Dach · 2023-10-18 13:07:22 +02:00
  12f343f0e2
• Merge branch 'master' into pitch_change
  Bartłomiej Dach · 2023-10-18 12:27:27 +02:00
  f1a16c50b8
• Add inline commentary in Mod{Day,Night}core about different speed adjustments
  Bartłomiej Dach · 2023-10-18 12:27:16 +02:00
  cff69d63a6
• Merge pull request #25160 from bdach/repeat-arrow-hidden-fade

  Adjust slider repeat transforms to closer match stable

  Dean Herbert · 2023-10-18 18:03:48 +09:00
  54da6f1048
• Take in IBindables and tidy up multiplier handling
  Dean Herbert · 2023-10-18 17:39:13 +09:00
  9907adc337
• Move audio adjustment hookup to own method for clarity
  Dean Herbert · 2023-10-18 17:38:11 +09:00
  161890292f
• Also share ScoreMultiplier implementation
  Dean Herbert · 2023-10-18 17:23:50 +09:00
  e56ff33271
• Split common functionality from rate adjust mods into helper class
  Dean Herbert · 2023-10-18 17:23:50 +09:00
  43238b0cee
• Merge branch 'master' into pitch_change
  Dean Herbert · 2023-10-18 16:33:03 +09:00
  eabfcfbf2a
• Merge pull request #25163 from Joehuu/double-click-slider-nub-default

  Add ability to revert slider settings to default when double-clicking nub

  Dean Herbert · 2023-10-18 16:23:05 +09:00
  bf4aa3c118
• Add ability to revert slider settings to default when double-clicking nub
  Joseph Madamba · 2023-10-17 21:41:03 -07:00
  18e8ca6245
• Add slider nub double click revert to default test
  Joseph Madamba · 2023-10-17 21:41:03 -07:00
  1a3a81c33b
• Merge pull request #25155 from peppy/fix-new-inspections

  Fix various new rider EAP inspections

  Bartłomiej Dach · 2023-10-17 17:04:39 +02:00
  e927267c4d
• Fix legacy slider repeats becoming much too large on hit

  They had scale transforms applied to them in two places: the actual
  legacy pieces themselves (esp. `LegacyHitCirclePiece`), and on the
  `DrawableSliderRepeat` level.
  
  This change moves all of the scale transforms to the skinnable pieces.
  Argon and triangles have received a copy of the previous logic each,
  so behaviour on those skins should not change.

  Bartłomiej Dach · 2023-10-17 14:47:44 +02:00
  f3cda58474
• Instantly fade out slider repeats when hidden is active
  Bartłomiej Dach · 2023-10-17 14:15:21 +02:00
  30e5f47007
• Add test step for covering slider appearance with hidden active
  Bartłomiej Dach · 2023-10-17 14:15:21 +02:00
  f116854c9f
• Run timeout job on self-hosted runner
  Dan Balasescu · 2023-10-17 21:01:23 +09:00
  4946b437c9
• Delete comment on cancellation

  - Add always() pre-condition to force evaluation.
  
  - Message is set as it's required by the action for a non-error status code.

  Dan Balasescu · 2023-10-17 20:51:28 +09:00
  566b09ff20
• Use action for GHA diffcalc workflow permissions check
  Dan Balasescu · 2023-10-17 20:28:04 +09:00
  08845ec1c6
• Merge pull request #25152 from bdach/key-binding-deduplication

  Clear pre-existing bindings of same key combination to single action

  Dean Herbert · 2023-10-17 17:49:51 +09:00
  d9fc532a9f
• Fix various other inspections
  Dean Herbert · 2023-10-17 17:48:51 +09:00
  e081fa48a2
• Bypass Parent nullability checks for now
  Dean Herbert · 2023-10-17 17:48:45 +09:00
  5341a335a6
• Remove unused using directive
  Bartłomiej Dach · 2023-10-17 10:30:01 +02:00
  2192c9f2c2
• Remove unused field
  Bartłomiej Dach · 2023-10-17 10:27:16 +02:00
  22c1a963e7
• Remove redundant explicit array type specification
  Bartłomiej Dach · 2023-10-17 10:26:02 +02:00
  7abd7fe658
• Merge pull request #25153 from peppy/store-speed-change-config

  Persist the state of "show speed changes" between editor sessions

  Bartłomiej Dach · 2023-10-17 10:23:00 +02:00
  5833c20be5
• Merge branch 'master' into key-binding-deduplication
  Dean Herbert · 2023-10-17 17:17:44 +09:00
  4885c55ef0
• Combine selection and input handling logic for beat snap grids across all rulesets
  Dean Herbert · 2023-10-17 17:09:42 +09:00
  4381169a3f
• Add beat snap grid to osu!taiko editor

  Addresses https://github.com/ppy/osu/discussions/25150.

  Dean Herbert · 2023-10-17 16:59:56 +09:00
  2a89a25790
• Add backwards migration of catch dash binding
  Bartłomiej Dach · 2023-10-17 09:43:40 +02:00
  4cfc95c673
• Abstract out common implementation of BeatSnapGrid
  Dean Herbert · 2023-10-17 16:42:52 +09:00
  1b9acdf55c
• Cache IScrollingInfo at a HitObjectComposer level automatically
  Dean Herbert · 2023-10-17 16:42:22 +09:00
  d26d4b8b79
• Use left mouse as alternative default binding for catch dash

  This mirrors stable. Although the way stable does this is pretty dodgy,
  see:
  	https://github.com/peppy/osu-stable-reference/blob/master/osu!/GameModes/Play/Rulesets/Fruits/RulesetFruits.cs#L274-L275

  Bartłomiej Dach · 2023-10-17 09:31:29 +02:00
  79a4b985fe
• Persist the state of "show speed changes" between editor sessions

  Addresses https://github.com/ppy/osu/discussions/25149.

  Dean Herbert · 2023-10-17 16:01:02 +09:00
  165cd07428
• Merge pull request #25111 from peppy/mania-bonus-refactor

  Change osu!mania "perfect" judgements to only award bonus score

  Dan Balasescu · 2023-10-17 14:27:54 +09:00
  6f4a2b9889
• Merge branch 'master' into mania-bonus-refactor
  Dan Balasescu · 2023-10-17 13:28:04 +09:00
  d2a3f14d5b
• Merge pull request #25143 from peppy/split-spinner-fix

  Apply various fixes and cleanup to spinner logic

  Bartłomiej Dach · 2023-10-16 22:30:24 +02:00
  240d317928
• Fix bindings being cleared if multiple bindings for same action have the same combination

  This actually seems to be the case in catch (dash is bound to shift
  twice). This is annoying but harmless, so let's work around it for now
  to avoid ruining users' configs.

  Bartłomiej Dach · 2023-10-16 22:20:26 +02:00
  828cedea33
• Add failing case for two bindings of single action bound to same key
  Bartłomiej Dach · 2023-10-16 22:20:26 +02:00
  3aae07d1ca