1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-17 00:33:21 +08:00
Commit Graph

7004 Commits

Author SHA1 Message Date
Dean Herbert
8b85c2c8de
Merge pull request #15491 from peppy/remove-stupid-weak-reference-bindable-events
Revert weird event flow in model manager/importers
2021-11-08 15:19:58 +09:00
Susko3
cc286f165d Change font to default
Non-english letters look tiny with size 10
and don't fit into the look.
2021-11-08 06:56:57 +01:00
Susko3
c3069ad002 Change to use ReadableKeyCombinationProvider
Changes all usages of `KeyCombination.ReadableString()` to
`ReadableKeyCombinationProvider.GetReadableString()`.

Subscribing to `KeymapChanged` is only required in `KeyButton`.
All other places query `GetReadableString()` every time.
2021-11-08 06:55:26 +01:00
Dan Balasescu
1c40d5bc08
Merge branch 'master' into remove-stupid-weak-reference-bindable-events 2021-11-08 14:41:32 +09:00
Dean Herbert
6b6dd93e9e Fix LinkFlowContainer not creating user links supporting full IUser specification 2021-11-08 14:17:47 +09:00
Dean Herbert
dede0e56ce
Merge branch 'master' into user-lookup-by-username-cleanup 2021-11-08 13:38:26 +09:00
Dean Herbert
78aef9ce86
Merge branch 'master' into remove-stupid-weak-reference-bindable-events 2021-11-08 13:35:49 +09:00
Bartłomiej Dach
6d30248cef
Merge branch 'master' into use-class-rename 2021-11-07 15:41:00 +01:00
Dean Herbert
0ecf5f201c Rename User to APIUser and move to correct namespace 2021-11-07 11:26:01 +09:00
Bartłomiej Dach
6a1c27d67a
Merge branch 'master' into fix-more-null 2021-11-06 15:36:15 +01:00
Bartłomiej Dach
c40f887492
Remove unnecessary local variable 2021-11-06 15:20:29 +01:00
Salman Ahmed
34c8e53e94
Merge branch 'master' into update-cached-buffered-container-usage 2021-11-06 09:38:55 +03:00
Dean Herbert
bc17446055 Merge branch 'master' into user-lookup-by-username-cleanup 2021-11-06 14:38:30 +09:00
Salman Ahmed
51e7b9950e Define local current bindable to bind value change instead 2021-11-05 18:07:14 +03:00
Dean Herbert
54f72d68ca Revert weird event flow in model manager/importers 2021-11-05 19:12:49 +09:00
Salman Ahmed
f013a1e37f Move CreateContent() to BDL 2021-11-05 10:13:42 +03:00
Dean Herbert
6399c695e8 Update usages of BufferedContainer in line with framework changes 2021-11-05 15:54:49 +09:00
Salman Ahmed
3a3ec1436b Re-enable possible null refernece exception inspections and move code 2021-11-05 09:14:50 +03:00
Dean Herbert
9f9ef570ee Also propagate Status in temporary BeatmapInfo usage 2021-11-05 14:44:58 +09:00
Dean Herbert
b1f1cc0bf3 Perform all user profile displays using an IUser interface 2021-11-05 13:55:34 +09:00
Dean Herbert
ba74dd93b2 Remove weird fetchOnline logic 2021-11-05 13:55:34 +09:00
Salman Ahmed
f528488aa2 Mark as non-null and move current bind to BDL instead 2021-11-05 05:42:19 +03:00
Salman Ahmed
4245af28e1 Disable other false-positive null inspections with comment 2021-11-05 04:50:58 +03:00
Salman Ahmed
36d99a2e34 Move action to private named method to avoid null inspection 2021-11-05 03:51:08 +03:00
Dean Herbert
b9983add15 Rename User to APIUser and move to correct namespace 2021-11-04 18:21:31 +09:00
Dean Herbert
08d94f864f Update ScoresContainer to not use ToBeatmapInfo 2021-11-04 17:09:53 +09:00
Dean Herbert
5a078da4d9 Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues 2021-11-04 16:50:14 +09:00
Dean Herbert
8f459e6ce8 Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues 2021-11-04 16:44:17 +09:00
Bartłomiej Dach
494d582830
Fix PlaylistItem attempting to read from OsuColour dependency too early 2021-11-02 23:19:45 +01:00
Bartłomiej Dach
e4e8390a8a
Update ScreenEntry colour usage to update correctly on language change 2021-11-02 21:42:03 +01:00
Bartłomiej Dach
d218e7d935
Remove manual romanisation handling in PlaylistItem 2021-11-02 21:42:02 +01:00
Bartłomiej Dach
ed00cd9fc5
Remove simple localisable .ToString() calls 2021-11-02 21:42:02 +01:00
Bartłomiej Dach
11de924704
Use LocalisableStrings where possible to leverage localisable text flow 2021-11-02 21:42:02 +01:00
Bartłomiej Dach
98367fc482
Update usages of GetLocalised{-> Bindable}String 2021-11-02 21:42:01 +01:00
Dean Herbert
47914c49ba Fix missed null consideration 2021-11-03 04:54:36 +09:00
Dean Herbert
392559ae3e Fix beatmap download notifications not showing beatmap name correctly 2021-11-03 03:23:41 +09:00
Dean Herbert
caa9d8997b Merge branch 'master' into score-refactor/less-create-score-info 2021-11-01 22:59:11 +09:00
Bartłomiej Dach
793c384ecd
Remove unnecessary null-conditional access 2021-11-01 12:02:37 +01:00
Bartłomiej Dach
5dcff7d8b7
Merge branch 'master' into score-refactor/less-create-score-info 2021-11-01 11:41:20 +01:00
Dean Herbert
b21e0e7efb Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays 2021-11-01 18:07:51 +09:00
Bartłomiej Dach
f5feed138d
Merge branch 'master' into score-refactor/isolated-serialisation 2021-11-01 09:43:51 +01:00
Dean Herbert
63c9512ab1 Update dashboard components to use APIBeatmapSet 2021-11-01 16:04:01 +09:00
Dean Herbert
b98faf6159 Merge branch 'master' into score-refactor/isolated-serialisation 2021-11-01 15:49:25 +09:00
Dean Herbert
21e0074d3b Add missing AddInternal call for BeatmapSetHeaderContent's download tracker 2021-11-01 14:43:32 +09:00
Dean Herbert
19feae4a8e
Merge branch 'master' into beatmap-refactor/download-tracker 2021-11-01 13:15:36 +09:00
Bartłomiej Dach
8053b2c320
Merge branch 'master' into score-refactor/isolated-serialisation 2021-10-30 15:07:34 +02:00
Dean Herbert
e9473db77c
Reorder to have video settings next to renderer
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-10-30 20:37:55 +09:00
Opelkuh
4d988340eb Add hardware acceleration toggle 2021-10-30 01:02:53 +02:00
Dean Herbert
5311fe2d02
Merge branch 'master' into beatmap-refactor/beatmap-overlays 2021-10-29 22:37:29 +09:00
Dean Herbert
a16c8f1ebc Update all beatmap overlay views to use APIBeatmap/APIBeatmapSet 2021-10-29 18:50:55 +09:00
Dean Herbert
8ad33d43d0 Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays 2021-10-29 18:01:17 +09:00
Dean Herbert
31403daa20 Change DrawableProfileScore to use APIScoreInfo 2021-10-29 15:14:52 +09:00
Dean Herbert
3f030cebf4 Remove local score copying in GetScoresRequest to allow APIScoreInfo.Beatmap to be APIBeatmap 2021-10-29 14:14:25 +09:00
Dean Herbert
817369903a Rename API score classes 2021-10-29 13:40:56 +09:00
Bartłomiej Dach
6f863ca204
Adjust game-side text flow containers to part-based model 2021-10-29 06:34:08 +02:00
Dean Herbert
3b095e1626 Merge branch 'master' into beatmap-refactor/download-tracker 2021-10-29 11:50:54 +09:00
Dan Balasescu
e5a7589859
Merge pull request #15317 from peppy/beatmap-refactor/uncontested
Update `UpdateableBeatmapBackgroundSprite` to accept `IBeatmapInfo`
2021-10-28 17:24:49 +09:00
Dean Herbert
1e1f8c472a Add icons to various progress notification states 2021-10-28 16:34:12 +09:00
Dean Herbert
7245baba69 Remove IBeatmapSetOnlineInfo implementation from BeatmapSetInfo to avoid null cases 2021-10-28 00:50:45 +09:00
Dean Herbert
746d6a4c16 Fix some oversights and test failures 2021-10-27 23:42:27 +09:00
Dean Herbert
f014ceaead Update remaining usages of download tracking 2021-10-27 21:00:46 +09:00
Dean Herbert
6339064dbd Remove old versions of DownloadTrackingComposite 2021-10-27 21:00:46 +09:00
Dean Herbert
6944151486 Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
Dean Herbert
5e5b86a1f4
Merge pull request #15156 from Susko3/use-ShowFileInNativeExplorer
Update usages of `OpenInNativeExplorer` to use `PresentFileExternally` / `PresentExternally`
2021-10-26 15:53:03 +09:00
Dan Balasescu
efe6763226
Merge branch 'master' into move-online-beatmap-metrics 2021-10-26 14:24:40 +09:00
Dean Herbert
53ff0802cb Merge branch 'master' into use-ShowFileInNativeExplorer 2021-10-26 13:58:30 +09:00
Bartłomiej Dach
6802e9ec10
Remove FixedWidth and add AutoSizeAxes specs to all usages 2021-10-25 20:24:48 +02:00
Dean Herbert
2c308f3008 Rename BeatmapMetrics to APIFailTimes 2021-10-25 15:34:41 +09:00
Dean Herbert
045dd94a6e Move online metrics out of BeatmapSetInfo model 2021-10-25 15:12:39 +09:00
Bartłomiej Dach
5ab3337a10
Update beatmap set status pill appearance 2021-10-24 20:40:34 +02:00
Susko3
51c5d0aec7 Update to be in line with framework changes 2021-10-24 13:21:41 +02:00
Dean Herbert
c701579c69 Refactor BeatmapMetadataContainer and usages to use interface types 2021-10-22 21:38:50 +09:00
Dean Herbert
69e7810dad Enable nullable and switch classes to structs 2021-10-21 18:54:36 +09:00
Dean Herbert
32d01f022f Rename usages which rely on online backing 2021-10-21 16:58:42 +09:00
smoogipoo
2c979d6420 Merge branch 'master' into localise-toasts 2021-10-20 15:04:07 +09:00
Dean Herbert
37841ca3aa Remove incorrect ToString calls causing localisation to not actually apply 2021-10-20 10:41:34 +09:00
Bartłomiej Dach
80da153697
Recolour a few other existing dropdowns with same hover & selection colours 2021-10-19 22:47:18 +02:00
Bartłomiej Dach
ef03787fe0
Split dropdown accent colour into hover and selection colours 2021-10-19 22:09:51 +02:00
Dean Herbert
c97cfdd978 Merge branch 'master' into localise-toasts 2021-10-19 16:37:14 +09:00
Bartłomiej Dach
6d9d85685f
Fix settings item having zero height 2021-10-18 23:30:38 +02:00
Bartłomiej Dach
88a1b31fae
Remove grid usage in SettingsItem 2021-10-18 22:07:32 +02:00
Bartłomiej Dach
6c3637a62a
Remove grid usage in KeyBindingRow 2021-10-18 22:07:30 +02:00
Bartłomiej Dach
830f49bca6
Remove doubled-up opacity specification 2021-10-18 19:43:48 +02:00
Bartłomiej Dach
2a41e8bd1f
Remove unneeded extra padding from settings number box 2021-10-17 21:50:04 +02:00
Bartłomiej Dach
552fc1dc8a
Adjust key binding rows to accommodate new default value indicator 2021-10-17 21:50:04 +02:00
Bartłomiej Dach
f422ebb281
Adjust SettingsItem to accommodate new default value indicator 2021-10-17 21:50:03 +02:00
Bartłomiej Dach
818f35c35f
Restyle default value indicator 2021-10-17 21:50:03 +02:00
Bartłomiej Dach
ed2f9dd443
Adjust settings slider spacings 2021-10-15 00:31:06 +02:00
Dean Herbert
06249c4ab2 Fix incorrect usages of Scheduler.AddOnce 2021-10-14 17:52:19 +09:00
Bartłomiej Dach
d205483a36
Revert ThemedDropdown-related changes 2021-10-13 21:57:50 +02:00
Bartłomiej Dach
a2f3a7cba8
Add "themed" dropdown variant and use in settings sidebar 2021-10-12 21:58:43 +02:00
Bartłomiej Dach
1fba932e84
Adjust settings dropdown spacings 2021-10-12 21:41:33 +02:00
Dan Balasescu
cabbb1697a
Merge pull request #15054 from peppy/settings-ordering
Initial settings usability pass
2021-10-12 22:00:30 +09:00
Dean Herbert
24b87cf655 Change some icons to be more descriptive (still placeholder) 2021-10-12 15:09:59 +09:00
Dean Herbert
59202d27c7 Add some missing labels 2021-10-12 15:09:59 +09:00
Dean Herbert
5ca1d1d12c Reorder graphics settings and move gameplay related pieces out 2021-10-12 15:09:59 +09:00
Dean Herbert
c4347de57e Move ruleset settings to own section 2021-10-12 14:58:43 +09:00
Dean Herbert
8285f065c2 Reorganise gameplay settings into more sections 2021-10-12 14:58:43 +09:00
Dean Herbert
1d3d67c5f1 Move gameplay cursor settings to gameplay section 2021-10-12 13:56:10 +09:00
Dean Herbert
a986870a99 Reorder sections to be more in line with how often they are adjusted 2021-10-12 13:41:35 +09:00
Dean Herbert
e058214346
Merge branch 'master' into fix-audio-filter-test-failures 2021-10-12 12:06:12 +09:00
Bartłomiej Dach
ff382259ca
Use rounded buttons in tablet rotation preset settings 2021-10-11 23:17:09 +02:00
Joseph Madamba
4fc84e71cd Localise more toast related strings 2021-10-11 01:02:26 -07:00
Dean Herbert
484a95229e Update toast implementations temporarily to expedite getting tests back in line 2021-10-11 16:36:04 +09:00
Joseph Madamba
af9bb6f277 Fix padding of shortcut in toast when widest 2021-10-10 19:37:46 -07:00
Joseph Madamba
7b37b15976 Localise some music action toasts 2021-10-10 19:36:50 -07:00
Joseph Madamba
545cfc7bf1 Localise tracked setting toasts 2021-10-10 19:35:25 -07:00
Bartłomiej Dach
b30dd2d4ed
Use rounded button in settings sidebar 2021-10-10 21:45:41 +02:00
Dean Herbert
49b341daff Remove HoverTarget shared state update path
Felt quite convoluted to follow. Have just duplicated the single shared
line instead.
2021-10-10 11:55:47 +09:00
Dean Herbert
ccc6d8ff40 Improve the animation of the active indicator 2021-10-10 11:34:01 +09:00
Bartłomiej Dach
fe26d8e8df
Share sidebar colouring logic by splitting out SidebarIconButton 2021-10-10 00:34:12 +02:00
Bartłomiej Dach
b8616bf910
Adjust appearance of keybinding subpanel 2021-10-10 00:34:12 +02:00
Bartłomiej Dach
855a74b8a0
Adjust vertical spacings in individual subsections 2021-10-10 00:34:11 +02:00
Bartłomiej Dach
e23a54f1e6
Adjust setting section appearance & spacings 2021-10-10 00:31:01 +02:00
Bartłomiej Dach
4c293b637f
Restyle settings panel header 2021-10-09 23:40:15 +02:00
Bartłomiej Dach
315581f4c8
Adjust horizontal spacing in settings panel 2021-10-09 23:40:15 +02:00
Bartłomiej Dach
f6df93f013
Introduce basic parts of colour scheme to settings sidebar 2021-10-09 23:40:14 +02:00
Dan Balasescu
9be56829c9
Merge pull request #14935 from Susko3/fix-SettingsTextBox-using-null-as-default
Fix usages of `SettingsTextBox` having `null` as the default
2021-10-08 18:36:02 +09:00
Dean Herbert
9dc035757f Fix weird textbox behaviour when entering a random mod seed overflowing int backing 2021-10-08 14:01:36 +09:00
Dean Herbert
2856aef4eb Add exception to catch any incorrect defaults of Bindable<string> 2021-10-08 13:52:38 +09:00
Dean Herbert
e578046b20 Rename Filter -> AudioFilter 2021-10-07 18:50:08 +09:00
Dean Herbert
0348c6c7e5 Apply some renaming and code quality fixes 2021-10-07 18:49:22 +09:00
Dean Herbert
f98dd1b811
Merge branch 'master' into popup-filter-effect 2021-10-07 18:40:21 +09:00
Jamie Taylor
266e62794e
Tweak cutoff effect for new Q value 2021-10-06 11:52:05 +09:00
Dan Balasescu
4bbff2ebf7
Merge branch 'master' into new-interfaces 2021-10-06 11:38:17 +09:00
Dan Balasescu
9491e5a547
Merge pull request #14954 from peppy/rename-result-response
Rename `APIRequest.Result` to `Response`
2021-10-06 10:52:33 +09:00
Bartłomiej Dach
a5b07ce4fe
Fix backwards containment check in chat channel load callback 2021-10-05 20:53:06 +02:00
Dean Herbert
2be44188ef Add missing null checks 2021-10-05 17:59:38 +09:00
Dean Herbert
d3b9660148 Move common interface implementations to extension methods 2021-10-05 14:41:14 +09:00
Dean Herbert
b41fa41c85 Rename APIRequest.Result to Response 2021-10-05 14:28:56 +09:00
Dean Herbert
853cf6feaa Rename last remaining BeatmapInfo Beatmap usage 2021-10-04 17:35:53 +09:00
Dan Balasescu
5937a93e2d
Merge pull request #14949 from peppy/login-error-display
Show login failure messages on login form
2021-10-04 17:23:11 +09:00
smoogipoo
69c2b7dc59 Merge branch 'master' into rename-beatmap-info-beatmap-fields 2021-10-04 16:03:22 +09:00
Dean Herbert
266b4c7124 Expose login errors from IAPIProvider and show on the login form 2021-10-04 15:40:24 +09:00
Dean Herbert
5aaafce597 Make AuthenticateWithLogin throw instead of return a bool success status 2021-10-04 15:40:00 +09:00
smoogipoo
bc984dff4f Fix typo 2021-10-04 15:35:28 +09:00
Dean Herbert
c19c2335ec Remove added schedule due to changing flow 2021-10-04 14:58:54 +09:00
Dean Herbert
c6aba3e78b Ensure a DrawableChannel is not attempted to be added after disposal 2021-10-04 14:44:16 +09:00
Susko3
3e403cfe03 Add comment explaining the purpose of the empty FilterTerms 2021-10-02 19:16:46 +02:00
Dean Herbert
ec61c3c5ee Rename all remaining cases 2021-10-03 00:55:29 +09:00
Susko3
d55836c0b2 Make ResetButton no longer part of search filtering
The button will now appear if and only if all the bindings in its section are visible (not filtered out by the search)
2021-10-02 15:10:30 +02:00
Dean Herbert
973c31132b Rename BeatmapInfo variables which were named beatmap for clarity 2021-10-02 12:45:34 +09:00
Jamie Taylor
2a4a376b87
Refactor Filter to behave closer to a Transformable 2021-10-02 01:32:47 +09:00
Dean Herbert
9fa901f6aa Refine RealmContext implementation API 2021-09-30 23:56:38 +09:00
Jamie Taylor
f55c4ac640
IsLoaded check no longer required 2021-09-29 21:05:46 +09:00
Jamie Taylor
2608d193a9
Refactor Filter component to be more re-usable 2021-09-29 20:30:01 +09:00
Jamie Taylor
94e2dbd7e7
Add a low-pass filter effect to music when certain popup dialogs are shown 2021-09-29 20:30:00 +09:00
Dean Herbert
6b698047ab Fix DialogOverlay potentially not expiring dialogs as soon as it should 2021-09-23 19:19:03 +09:00
Bartłomiej Dach
ab213e2010
Add missing licence headers 2021-09-19 21:09:03 +02:00
Dean Herbert
50f155e4b9 Move login panel related files to own namespace and tidy up class nesting 2021-09-17 18:34:16 +09:00