1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-16 07:20:24 +08:00
Commit Graph

9404 Commits

Author SHA1 Message Date
Dean Herbert
e75c3b3f94 Rename SkinnableTarget to GlobalSkinLookup 2022-11-09 17:46:43 +09:00
Dean Herbert
c908969d9b Rename ISkinComponent to ISkinLookup 2022-11-09 17:46:43 +09:00
Dean Herbert
ab458320c4 Fix some lingering inspections 2022-11-09 17:46:24 +09:00
Dawid Sośnia
9549e55ef8
Merge branch 'ppy:master' into gameplay-leaderboard-fix 2022-11-08 20:04:13 +01:00
Piggey
9da57c66a2 add visual tests 2022-11-08 20:03:09 +01:00
Dean Herbert
b166e477c2
Merge branch 'master' into editor-background 2022-11-08 17:18:34 +09:00
Dean Herbert
4c15794694 Add test coverage of overlay interplay 2022-11-08 14:58:57 +09:00
maromalo
b7ef9b176d Make score type consistent 2022-11-06 19:59:27 -03:00
C0D3 M4513R
0c17571c58
Merge branch 'master' into beatmap-info 2022-11-06 18:53:14 +00:00
Dean Herbert
ee68f33e3c
Merge pull request #21109 from frenzibyte/fix-beatmap-duplicating-again
Fix beatmap cards still potentially showing twice in listing
2022-11-06 18:46:31 +09:00
Dean Herbert
e02c477008
Merge pull request #21017 from andy840119/remove-nullable-disable-in-the-checks
Remove nullable disable in the checks.
2022-11-06 18:39:03 +09:00
Bartłomiej Dach
84179fb087
Merge branch 'master' into combo-colour-brightness-limit 2022-11-05 16:48:56 +01:00
andy840119
e862ba5e04 Fix the wrong AsNonNull() usage. 2022-11-05 20:13:50 +08:00
andy840119
6062641bf4 Mark mock track as nun-nullable because technically it should not accept the null track. 2022-11-05 16:17:20 +08:00
andy840119
5931e965c5 Mark background prams in the getMockWorkingBeatmap() as nun-nullable because technically it should not accept the null background. 2022-11-05 16:16:26 +08:00
Dan Balasescu
fa18b5f701 Construct notifications client inside ChannelManager 2022-11-04 18:51:00 +09:00
Dean Herbert
eb836269e7 Allow testing settings panel with interactivity by default 2022-11-04 18:50:17 +09:00
Dean Herbert
923d44a769 Update dependencies 2022-11-04 17:00:58 +09:00
Dean Herbert
566738494f
Merge pull request #20952 from OliBomby/bezier-convert
Add conversion algorithm for lazer slider curves to work with stable
2022-11-04 16:49:51 +09:00
Dean Herbert
dd5a3b2bf3 Add one more complex test 2022-11-04 16:49:21 +09:00
Joseph Madamba
e11d44d14f Add url clicking support to profile badges 2022-11-03 18:12:32 -07:00
Salman Ahmed
37b5f48911 Adjust test scene to cover failure 2022-11-04 03:23:33 +03:00
Dean Herbert
1edde8f73c Merge branch 'master' into disabled-button-sfx 2022-11-03 20:27:41 +09:00
Dean Herbert
cdb3494418
Merge pull request #20765 from Feodor0090/comment-report
Implement comments reporting
2022-11-03 20:09:00 +09:00
Dean Herbert
486515ed90
Merge pull request #20758 from frenzibyte/maintain-common-mod-selection
Maintain selection of common mods when switching rulesets
2022-11-03 20:08:32 +09:00
Jamie Taylor
f1c17129eb
Add support for 'disabled' sample variation to HoverClickSounds 2022-11-03 17:47:49 +09:00
C0D3 M4513R
2ec29c0f26
Merge branch 'master' into beatmap-info 2022-11-03 07:09:02 +00:00
Dean Herbert
c48c9ecb6d
Merge pull request #20743 from frenzibyte/improve-beatmap-card-buttons
Improve clickable area of beatmap card icon buttons
2022-11-03 15:47:08 +09:00
Dean Herbert
e6c45b8ab5 Merge branch 'master' into comment-report 2022-11-03 15:35:42 +09:00
Dean Herbert
20dd405c2b
Merge branch 'master' into maintain-common-mod-selection 2022-11-03 15:32:40 +09:00
Dean Herbert
fb0bc597a0 Merge branch 'master' into improve-beatmap-card-buttons 2022-11-03 13:53:29 +09:00
Dean Herbert
5f2f6b84b2 Add failing test coverage of automated skip scenarios 2022-11-03 13:52:27 +09:00
Dean Herbert
aef3c7918c Add total skip count to SkipOverlay 2022-11-03 13:52:24 +09:00
C0D3 M4513R
75b5025e12
Fix Skin Deserialisation Test 2022-11-02 16:37:48 +01:00
Dean Herbert
3ec9686e58 Fix test failures and rename configuration value to match better 2022-11-02 18:15:18 +09:00
Dean Herbert
0e502de8b4 Rename field to match usage 2022-11-02 18:04:42 +09:00
Dean Herbert
c3eb0c6330 Merge branch 'master' into editor-background 2022-11-02 17:43:38 +09:00
Dan Balasescu
063a8bdf9e Remove messages from silenced users 2022-11-02 17:13:14 +09:00
Dan Balasescu
f688ed12d0 Add test for removing chat messages 2022-11-02 17:00:47 +09:00
Dan Balasescu
695104a666 Fix TestSceneChatOverlay messages not being unique 2022-11-02 16:59:03 +09:00
Dean Herbert
2b04e852be
Merge branch 'master' into websocket-chat-2 2022-11-02 14:56:13 +09:00
Dan Balasescu
5b25ef5f2f Construct notifications client via IAPIProvider 2022-11-01 21:34:34 +09:00
Dean Herbert
29bc653d24 Remove incorrect double multiplication and add missing test coverage 2022-11-01 17:17:54 +09:00
Dean Herbert
d807d9d822 Add failing test covering snap calculations with SV applied 2022-11-01 16:22:48 +09:00
Dean Herbert
e8b7914295 Add test coverage of new parameter 2022-11-01 15:13:05 +09:00
Dean Herbert
2a88409dfe Fix time snap of sliders not matching when SV is not 1.0x
This regressed with https://github.com/ppy/osu/pull/20850 because the
function was used in other places which expect it to factor slider
velocity into the equation.

Rather than reverting, I've added a new argument, as based on the method
naming alone it was hard to discern whether SV should actually be
considered.

The reason for the change in #20850 was to avoid the SV coming in from a
reference object which may not have a correct SV in the first place. In
such cases, passing `false` to the function will give the expected
behaviour.
2022-11-01 15:12:58 +09:00
Dean Herbert
17f482bfc3
Merge branch 'master' into websocket-chat-2 2022-10-31 16:11:58 +09:00
Dean Herbert
e38ba5e4c6 Apply nullability to new test scene 2022-10-31 15:46:57 +09:00
Dean Herbert
31ba77e378 Merge branch 'master' into bezier-convert 2022-10-31 15:41:08 +09:00
Dean Herbert
8399261c77 Add failing test showing hold for menu not working when HUD is hidden 2022-10-30 21:38:31 +09:00
Dean Herbert
f5e11343c2 Apply nullability to HUD test scene 2022-10-30 21:25:31 +09:00
andy840119
c8c76f2351 Use AsNonNull() because the type does not accept the null case. 2022-10-30 17:03:54 +08:00
andy840119
500bf90a34 Mark as accept the nullable stream. 2022-10-30 17:03:54 +08:00
andy840119
6ce3841686 Remove nullable disable annotation in the test case. 2022-10-30 17:03:54 +08:00
Bartłomiej Dach
71d87489ab
Merge branch 'master' into safe-area-toggle 2022-10-29 13:19:44 +02:00
Dean Herbert
19e0b9085c Remove redundant parameters 2022-10-29 00:24:33 +09:00
Dan Balasescu
169bcc2654 Use polling connector in tests 2022-10-28 18:08:08 +09:00
Dean Herbert
f9d2c30c3e Add user toggle for application of safe areas 2022-10-28 14:05:45 +09:00
Bartłomiej Dach
f787da892b
Merge branch 'master' into grid-momentary-shortcuts 2022-10-26 21:30:24 +02:00
OliBomby
86d5fcc26d Added tests 2022-10-26 19:30:42 +02:00
cdwcgt
6991195d69
let editor dim different from gameplay dim 2022-10-26 15:22:57 +09:00
Dean Herbert
7249542167
Merge pull request #20912 from LittleEndu/carousel-do-not-select-random
Make beatmap carousel select nearest to selection when selection was filtered
2022-10-26 11:40:56 +09:00
Bartłomiej Dach
48057412f5
Merge branch 'master' into grid-momentary-shortcuts 2022-10-25 22:17:08 +02:00
Bartłomiej Dach
bcdf24b972
Merge branch 'master' into add-editor-object-clone 2022-10-25 21:33:52 +02:00
Bartłomiej Dach
3d31c9bbc5
Merge branch 'master' into beat-snap-divisor-hotkey 2022-10-25 20:32:32 +02:00
Dean Herbert
2b850694fa Merge branch 'allow-distance-grid-snap' into grid-momentary-shortcuts 2022-10-25 14:10:45 +09:00
Dean Herbert
8e4f5381e3 Add top level test coverage of editor shortcuts 2022-10-25 12:03:46 +09:00
Dean Herbert
1b42f5ec6e Add test coverage of BeatDivisorControl key bindings 2022-10-25 11:51:31 +09:00
Dean Herbert
4d4f6e25ba Rename to "clone" instead of "duplicate" 2022-10-25 11:43:23 +09:00
Dean Herbert
da74690ec9 Add test coverage of clone operations 2022-10-25 11:38:58 +09:00
Dan Balasescu
f6f30eec0b
Merge pull request #20810 from peppy/scoring-test-scene
Add test scene as environment to test changes to score algorithms
2022-10-25 11:19:00 +09:00
Endrik Tombak
b95091fbb0 Move test to improve diff readability 2022-10-24 22:55:09 +03:00
Endrik Tombak
9def12c60b Write new tests 2022-10-24 22:50:56 +03:00
Dean Herbert
f08270f6b0 Fix incorrect maxBaseScore accounting due to silly oversight 2022-10-24 15:54:09 +09:00
Dean Herbert
247cf589aa
Merge branch 'master' into directoryselector-hidden-toggle 2022-10-24 15:33:10 +09:00
Salman Ahmed
90a9961a69 Add visual test case for report button
Makes it much easier to test button/popover design changes
2022-10-22 02:50:59 +03:00
ansel
15aeb4a137 Display text in buttons flow instead of toast 2022-10-21 17:25:41 +03:00
Dean Herbert
bace3df4ca Update test assertions in line with change 2022-10-21 22:58:10 +09:00
Dan Balasescu
703a8afb11
Merge pull request #20809 from peppy/fix-taiko-broken-drum-roll-ticks
Fix taiko drum roll ticks sometimes overflowing outside the drum roll itself
2022-10-21 12:56:14 +09:00
ansel
81bdf716ef Change test 2022-10-20 19:56:00 +03:00
Dean Herbert
6b26547d03
Merge pull request #20835 from frenzibyte/improve-hide-mouse-on-keyboard
Improve automatic cursor hiding logic and limit to gameplay screen
2022-10-20 11:44:20 +09:00
Salman Ahmed
212f15e2d2 Update existing test cases 2022-10-20 04:06:33 +03:00
Dean Herbert
2f8a4fd2d0
Merge branch 'master' into remove-current-item 2022-10-20 10:02:09 +09:00
Dean Herbert
bea136ce50 Adjust test assert ordering to read better 2022-10-19 23:59:40 +09:00
Dean Herbert
f23bc484dc Use better method of positioning mouse over visual settings area 2022-10-18 19:15:11 +09:00
Dean Herbert
d5666ca717 Add tooltip display of current values 2022-10-18 19:04:02 +09:00
Dean Herbert
d92aca7c22 Fix scoreV2 being higher than intended 2022-10-18 18:30:18 +09:00
Dean Herbert
74e1b5794b Add ability to add "OK" or 100s via right click 2022-10-18 18:27:05 +09:00
Dean Herbert
a7b3aa62fb Move lines to background to better visualise graphs at points of change 2022-10-18 18:13:13 +09:00
Dean Herbert
74986e0c8c Show final scores and change colouring again 2022-10-18 18:07:42 +09:00
Dean Herbert
4b2fe72a90 Add stable v2 algorithm 2022-10-18 18:02:42 +09:00
Dean Herbert
743ae10df5 Improve colouring 2022-10-18 17:50:59 +09:00
Dean Herbert
7360cca047 Add stable v1 algorithm 2022-10-18 17:50:58 +09:00
Dean Herbert
d694c8b771 Move test scene more correctly into visual folder 2022-10-18 17:10:53 +09:00
Dean Herbert
c77847b284 Improve layout and add combo text 2022-10-18 16:55:22 +09:00
Dean Herbert
19b4d2d25e Add vertical grid lines 2022-10-18 16:55:22 +09:00
Dean Herbert
1ea2a1ff04 Add basic legend and line colouring 2022-10-18 16:55:22 +09:00
Dean Herbert
94c57a459d Add ability to add miss locations by clicking 2022-10-18 16:55:22 +09:00
Dean Herbert
49d5931022 Initial setup with adjustable max combo 2022-10-18 16:55:19 +09:00
Dean Herbert
ec3761ced9 Standardise control point search logic in OverlappingScrollAlgorithm
Was using a very local algorithm which I cannot guarantee is correct.
I'd rather it just use the one used everywhere else.
2022-10-18 16:01:05 +09:00
ansel
3258a41ca3 Merge branch 'comment-report' of https://github.com/Feodor0090/osu into comment-report 2022-10-17 20:41:46 +03:00
ansel
18cc3b0bd3 Fix reason not set in test 2022-10-17 20:23:25 +03:00
Feodor0090
6efe7b5334
Merge branch 'master' into comment-report 2022-10-17 16:08:13 +03:00
ansel
3bcc91511f Update test 2022-10-17 13:46:13 +03:00
Dan Balasescu
28277dd880 Fix tests 2022-10-17 19:34:05 +09:00
ansel
e1785f73a2 Make report's comment not optional 2022-10-16 20:14:05 +03:00
Salman Ahmed
841e20c336 Remove unused usings 2022-10-15 17:16:08 +03:00
Salman Ahmed
7d53d35bf6 Remove duplicate & outdated test case 2022-10-15 16:23:54 +03:00
Salman Ahmed
421b81b6ca Fix broken test case 2022-10-15 00:41:14 +03:00
Salman Ahmed
45f590ca43 Add test case for hiding cursor on idle 2022-10-15 00:20:22 +03:00
Salman Ahmed
97c4282e55 Add test cases for hiding cursor on keyboard input 2022-10-15 00:20:22 +03:00
Salman Ahmed
ba72f13f54 Merge branch 'master' into hide-mouse-on-keyboard-input 2022-10-14 22:26:30 +03:00
Feodor0090
fb046e31c1
Merge branch 'master' into comment-report 2022-10-14 16:57:23 +03:00
ansel
dc0aa2295a Add test 2022-10-14 16:51:48 +03:00
ansel
c65a8a83f3 Add basic UI for reporting 2022-10-14 15:52:09 +03:00
Dan Balasescu
10aabfc650
Merge pull request #20739 from peppy/settings-toolbox
Adjust visuals of settings toolboxes (gameplay loading screen and editor)
2022-10-14 20:31:05 +09:00
Salman Ahmed
3e5e717fce Add failing test cases 2022-10-14 02:00:11 +03:00
Bartłomiej Dach
df66a0c2e9
Fix flaky update beatmap set test
It is generally not possible to click a button that's not yet there,
and it turns out that when the test in question is ran headless, it may
not necessarily be there immediately.
2022-10-13 21:03:52 +02:00
Salman Ahmed
6c316bcc9e Make beatmap card icon buttons fill up to the area 2022-10-13 16:09:54 +03:00
Dean Herbert
6608ada925 Fix test failures due to missing colour provider dependency 2022-10-13 17:05:11 +09:00
Dean Herbert
0f4a2a6059 Improve feel of settings toolbox group 2022-10-13 16:36:19 +09:00
Dean Herbert
ebc1088457
Merge pull request #20729 from frenzibyte/update-local-confirmation-dialog
Request user confirmation on updating locally-modified beatmaps
2022-10-13 12:36:37 +09:00
Dean Herbert
c9b4cacc20
Merge pull request #20724 from mk56-spn/Highest_Combo_Counter
Add "longest combo" counter to HUD components.
2022-10-13 12:26:49 +09:00
Dean Herbert
f573ee4521
Merge pull request #20512 from Feodor0090/comment-deletion
Add ability to delete own comments
2022-10-13 12:13:08 +09:00
Salman Ahmed
7db7bcc283 Add test coverage 2022-10-13 02:40:20 +03:00
Feodor0090
565de23222
Fix CQ (non-readonly field) 2022-10-12 21:26:33 +03:00
Dean Herbert
f1f323ee82 Add new deserialisation test including longest combo counter 2022-10-12 18:55:50 +09:00
Dean Herbert
19f3810020 Revert namespace change
Let's not
2022-10-12 18:50:47 +09:00
Dean Herbert
3da54814f8
Merge pull request #20641 from pfgithub/patch-fix-save-collections
Preserve collections when saving a beatmap
2022-10-12 18:36:45 +09:00
D.Headley
e2c80f09da Remove unnecesary directive 2022-10-12 11:05:22 +02:00
Dario Headley
b72c8970eb Max Combo Counter added 2022-10-12 09:50:01 +02:00
Dean Herbert
00d8398056 Update test scene to allow seeing loading spinner 2022-10-12 15:48:42 +09:00
Dean Herbert
47fe4eb0bd Merge branch 'master' into comment-deletion 2022-10-12 15:48:26 +09:00
Salman Ahmed
9b45a9cf76 Rename various cursor symbols
- `IProvideCursor.MenuCursor` -> `IProvideCursor.Cursor`
 - `MenuCursor` -> `MenuCursorContainer
2022-10-11 16:21:01 +03:00
Dan Balasescu
88e82d3154
Merge pull request #20681 from peppy/fix-hidden-hud-interaction
Fix HUD components being interactive even when the HUD is visually hidden
2022-10-11 17:19:27 +09:00
Dean Herbert
ece42de408 Fix variable naming in test 2022-10-11 15:53:48 +09:00
Dan Balasescu
ccab04d141
Merge pull request #20645 from frenzibyte/flag-markdown
Add support for inline country flags in wiki overlay
2022-10-11 14:01:24 +09:00
Dean Herbert
cb21126623
Merge pull request #20586 from ekrctb/time-based-selection
Use hit object time for timeline drag selection instead of relying on blueprint
2022-10-11 13:20:15 +09:00
Dean Herbert
d700040a0d Make country code parsing resilient to invalid cases 2022-10-11 01:39:53 +09:00
Dean Herbert
f6a8cc3f32 Add test showing broken input in HUD overlay when hidden 2022-10-10 16:05:41 +09:00
Dean Herbert
7726dda975 Remove whitespace 2022-10-10 15:31:45 +09:00
pfg
f219c0886d Add a test for realm preservation 2022-10-09 10:19:21 -04:00
Salman Ahmed
0309751d55 Add test coverage 2022-10-08 21:50:31 +03:00
Salman Ahmed
13083813bd Update hardcoded article page 2022-10-08 21:50:25 +03:00
ansel
e7b1f369a3 Revert unwanted changes in other tests 2022-10-08 18:55:58 +03:00
ansel
c384093802 Update main test and add failure scenario test 2022-10-08 18:53:41 +03:00
ansel
6e82ffbc6f Add check for spinner 2022-10-08 17:41:51 +03:00
ansel
c11258a7e9 Tidy up test reloading 2022-10-08 17:20:25 +03:00
ansel
abf56c27a1 Do not requere dialog overlay 2022-10-08 17:11:09 +03:00
Dean Herbert
072b64b8d4 Update all dependencies 2022-10-07 21:16:11 +09:00