Dean Herbert
|
a50284a5eb
|
Merge pull request #6019 from peppy/hit-window-refactor
Refactor HitWindows for legibility
|
2019-09-06 16:10:04 +09:00 |
|
Dean Herbert
|
c379480e7b
|
Merge branch 'master' into remove-judgement-occurred
|
2019-09-06 15:32:34 +09:00 |
|
Dean Herbert
|
f925e781a9
|
Refactor HitWindows for legibility
|
2019-09-06 15:24:14 +09:00 |
|
smoogipoo
|
07f662071d
|
Remove judgementOccurred
|
2019-09-04 18:14:55 +09:00 |
|
Dean Herbert
|
bebc3309ce
|
Refactor skin configuration to be infinitely extensible
|
2019-09-03 17:57:34 +09:00 |
|
Dean Herbert
|
1e7528c2b3
|
Merge remote-tracking branch 'upstream/master' into non-timeoffset-judgements
|
2019-09-02 19:13:00 +09:00 |
|
smoogipoo
|
f20e07136a
|
Add attribute to catch potential future nullrefs
|
2019-09-02 17:48:41 +09:00 |
|
smoogipoo
|
f6102b4d92
|
Adjust xmldoc
|
2019-09-02 17:15:36 +09:00 |
|
smoogipoo
|
0c73c5acf3
|
Expose full hitobject rather than hit windows
|
2019-09-02 17:14:40 +09:00 |
|
smoogipoo
|
f2bdf94a1d
|
Add HitWindows to JudgementResult to indicate timing errors
|
2019-09-02 16:28:14 +09:00 |
|
smoogipoo
|
8f8d35bd15
|
Delay initial hitobject state computation
|
2019-09-02 15:06:34 +09:00 |
|
Dean Herbert
|
741bd0a5cf
|
Fix incorrect colour sizes and simplify alignment specification
|
2019-08-30 18:35:17 +09:00 |
|
Dean Herbert
|
9a98f39f06
|
Share logic with other rulesets (and make default)
|
2019-08-28 18:12:47 +09:00 |
|
smoogipoo
|
9e926d44c0
|
Obsolete legacy UpdateState() method
|
2019-08-27 16:09:47 +09:00 |
|
Dean Herbert
|
dbb3b583cf
|
Log error for invalid beatmap/storyboard events instead of thro… (#5611)
Log error for invalid beatmap/storyboard events instead of throwing
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
|
2019-08-09 12:56:47 +09:00 |
|
Dean Herbert
|
7e9c100c9b
|
Apply new resharper refactors
|
2019-08-09 12:29:33 +09:00 |
|
smoogipoo
|
de4ad1f625
|
Fix bad log message
|
2019-08-08 14:44:49 +09:00 |
|
smoogipoo
|
ac2060f1cf
|
Throw exceptions and let LegacyDecoder handle them
|
2019-08-08 14:44:04 +09:00 |
|
smoogipoo
|
0ff1c6184b
|
Add generation comment
|
2019-08-01 17:36:20 +09:00 |
|
smoogipoo
|
a2468e599b
|
Fix ticks in repeat spans being returned in reverse order
|
2019-08-01 17:31:37 +09:00 |
|
Dean Herbert
|
894d573fbc
|
Cache DrawableHitObject for skinnables to access (#5463)
Cache DrawableHitObject for skinnables to access
|
2019-07-29 18:49:37 +09:00 |
|
iiSaLMaN
|
ba4045a761
|
Fix transforming mods not working properly
Hidden, Grow, Deflate, etc..
|
2019-07-27 00:22:40 +03:00 |
|
Dean Herbert
|
eb6bda3f08
|
Cache DrawableHitObject for skinnables to access
|
2019-07-25 16:03:07 +09:00 |
|
smoogipoo
|
4e7e2d1d52
|
Adjust comments
|
2019-07-23 21:16:09 +09:00 |
|
smoogipoo
|
74b09c72fa
|
Refactor state updates to convert State into an IBindable
|
2019-07-23 21:16:09 +09:00 |
|
Dean Herbert
|
d4d286c988
|
Add full documentation
|
2019-07-22 16:08:38 +09:00 |
|
Dean Herbert
|
c3b81bef4a
|
Flip default to the preferred method going forward
|
2019-07-22 15:55:38 +09:00 |
|
Dean Herbert
|
be170b4124
|
Naming and documentation improvements
|
2019-07-22 15:50:02 +09:00 |
|
Dean Herbert
|
91f86adb66
|
Move DrawableHitObject state management to base class
|
2019-07-22 15:07:12 +09:00 |
|
Dean Herbert
|
8327452fe1
|
Make AccentColour a bindable
|
2019-07-22 14:48:59 +09:00 |
|
Dean Herbert
|
3e57fcf5c5
|
Merge remote-tracking branch 'upstream/master' into cleanup-slider-bodies
|
2019-07-17 22:11:01 +09:00 |
|
Dean Herbert
|
1a19cf0739
|
Fix 0-length sliders not getting correct lengths (#5033)
Fix 0-length sliders not getting correct lengths
|
2019-07-17 18:01:57 +09:00 |
|
smoogipoo
|
a9286fee07
|
Recycle slider paths when the parenting slider dies
|
2019-07-17 16:20:27 +09:00 |
|
smoogipoo
|
ed203cb0ff
|
Delay intial hitobject updates
|
2019-07-16 13:45:59 +09:00 |
|
smoogipoo
|
5862eb172a
|
Merge remote-tracking branch 'origin/master' into fix-zero-length-sliders
# Conflicts:
# osu.Game/Rulesets/Objects/Legacy/Catch/ConvertHitObjectParser.cs
# osu.Game/Rulesets/Objects/Legacy/ConvertHitObjectParser.cs
# osu.Game/Rulesets/Objects/Legacy/Mania/ConvertHitObjectParser.cs
# osu.Game/Rulesets/Objects/Legacy/Osu/ConvertHitObjectParser.cs
# osu.Game/Rulesets/Objects/Legacy/Taiko/ConvertHitObjectParser.cs
|
2019-07-05 15:48:04 +09:30 |
|
Dean Herbert
|
60ea3d4e1a
|
Fix skinning support for combobreak
|
2019-06-30 21:58:30 +09:00 |
|
smoogipoo
|
a6ee83eac2
|
Merge remote-tracking branch 'origin/master' into fix-zero-length-sliders
|
2019-06-27 19:57:21 +09:00 |
|
Dean Herbert
|
ba48331fcb
|
Remove no longer necessary HandleInput overrides
|
2019-06-27 18:34:59 +09:00 |
|
smoogipoo
|
2e7922c3f9
|
Fix 0-length sliders not getting correct lengths
|
2019-06-15 23:53:28 +09:00 |
|
Dean Herbert
|
cf713fbacc
|
Merge branch 'master' into fix-stacking-shaking
|
2019-06-14 22:16:35 +09:00 |
|
smoogipoo
|
4818187d8f
|
Reset result timeoffset to 0 when rewound
|
2019-06-13 14:55:52 +09:00 |
|
smoogipoo
|
27fdda8b91
|
Don't update hitobject results when rewinding
|
2019-06-13 12:21:49 +09:00 |
|
Arphox
|
07e17518e9
|
Fix all "Maintainability" CodeFactor issues
|
2019-06-11 10:28:16 +02:00 |
|
smoogipoo
|
d7c09e7dbd
|
Merge remote-tracking branch 'origin/master' into fix-new-inspections
# Conflicts:
# osu.Game.Rulesets.Catch/Judgements/CatchDropletJudgement.cs
# osu.Game.Rulesets.Catch/Judgements/CatchJudgement.cs
# osu.Game.Rulesets.Mania/Scoring/ManiaScoreProcessor.cs
# osu.Game.Rulesets.Osu/Replays/OsuAutoGenerator.cs
# osu.Game.Rulesets.Osu/UI/Cursor/CursorTrail.cs
# osu.Game.Tests/Visual/SongSelect/TestCaseBeatmapScoresContainer.cs
# osu.Game/Graphics/OsuFont.cs
# osu.Game/Online/API/Requests/Responses/APILegacyScoreInfo.cs
# osu.Game/Overlays/Profile/Header/BadgeContainer.cs
# osu.Game/Overlays/Profile/ProfileHeader.cs
# osu.Game/Screens/Select/PlaySongSelect.cs
# osu.Game/Skinning/LegacySkinDecoder.cs
|
2019-05-07 13:20:17 +09:00 |
|
smoogipoo
|
0bd35ab7bb
|
Turn on warnings, resolve issues
|
2019-04-25 17:36:17 +09:00 |
|
Dean Herbert
|
c39c37a18d
|
Apply more missed cases
|
2019-04-01 12:44:46 +09:00 |
|
Dean Herbert
|
612db31c38
|
Apply newline additions
|
2019-04-01 12:16:32 +09:00 |
|
Dean Herbert
|
c97116c91a
|
Add safety against DrawableHitObject implementations clearing children
|
2019-03-25 13:34:22 +09:00 |
|
smoogipoo
|
6511234804
|
Fix catch spinners not being allowed for conversion
|
2019-03-20 13:53:22 +09:00 |
|
Dean Herbert
|
14af957599
|
Merge pull request #4468 from smoogipoo/fix-min-tick-distance
Fix ticks not being generated at the minimum tick distance
|
2019-03-15 12:12:48 +09:00 |
|
smoogipoo
|
71d79f0a39
|
Fix ticks not being generated at the minimum tick distance
|
2019-03-14 15:20:12 +09:00 |
|
Dean Herbert
|
8f00f2290a
|
Log issues
|
2019-03-13 14:56:41 +09:00 |
|
Dean Herbert
|
f8b5cf8c8e
|
Add extra clamping of endTime to startTime
|
2019-03-13 13:46:41 +09:00 |
|
Dan Balasescu
|
a35d9ccc09
|
Apply clamping suggestion
Co-Authored-By: peppy <pe@ppy.sh>
|
2019-03-13 12:35:05 +09:00 |
|
Dean Herbert
|
93b774104a
|
Fix NaN handling
|
2019-03-13 11:30:33 +09:00 |
|
Dean Herbert
|
cc09ecbfcf
|
Increase validation performed on .osu files to avoid hard crashes
|
2019-03-12 20:31:15 +09:00 |
|
Dean Herbert
|
63fea65c0c
|
Clarify repeat index
|
2019-03-11 14:53:21 +09:00 |
|
Dean Herbert
|
489153579a
|
Add xmldoc and clarify struct variables
|
2019-03-11 14:36:29 +09:00 |
|
Dean Herbert
|
2029cf93fd
|
Rename and reuse variables
|
2019-03-11 14:33:21 +09:00 |
|
Dean Herbert
|
93a999396e
|
LegacyFinalTick -> LegacyLastTick to match existing variable
|
2019-03-08 20:13:11 +09:00 |
|
Dean Herbert
|
355705f0a5
|
Fix legacy tick handling
|
2019-03-08 19:57:30 +09:00 |
|
Dean Herbert
|
973f29b765
|
Apply review
|
2019-03-08 15:14:57 +09:00 |
|
smoogipoo
|
a08086cc8a
|
Fix volume not being considered for file samples
|
2019-03-05 18:21:29 +09:00 |
|
Dean Herbert
|
26d53d06a9
|
Fix remaining issues
|
2019-02-28 13:31:40 +09:00 |
|
smoogipoo
|
f66fefb818
|
Adjust comment + accessibility
|
2019-02-27 16:30:10 +09:00 |
|
smoogipoo
|
a07d797d75
|
Merge remote-tracking branch 'Joehuu/master' into use-lifetime-optimization
|
2019-02-27 12:08:43 +09:00 |
|
Dean Herbert
|
3fe4b8fd1c
|
Update variable names
Also cleans up some weird code
|
2019-02-22 17:51:39 +09:00 |
|
smoogipoo
|
d8c55bc729
|
Adjust namespaces
|
2019-02-21 19:05:52 +09:00 |
|
smoogipoo
|
bca347427f
|
Update with framework bindable changes
|
2019-02-21 18:56:34 +09:00 |
|
ekrctb
|
8955d5de04
|
Update hit object result when lifetime is end
|
2019-01-29 15:25:27 +09:00 |
|
Dean Herbert
|
8617aaa2a7
|
Update licence header (and remove year)
|
2019-01-24 17:43:03 +09:00 |
|
Unknown
|
6eff79913b
|
remove blank lines
|
2019-01-11 10:34:56 +01:00 |
|
Ivan Pavluk
|
28b033bd99
|
Autodetect LowestSuccessfulHitResult
|
2018-12-12 17:15:59 +07:00 |
|
Ivan Pavluk
|
e49e2fda9e
|
Rename SuccessfulHitResult->LowestSuccessfulHitResult
|
2018-12-12 13:24:58 +07:00 |
|
Dean Herbert
|
ffb91b4afc
|
Update docstring
Co-Authored-By: pavlukivan <pavlukivan@outlook.com>
|
2018-12-12 13:11:03 +07:00 |
|
Dean Herbert
|
d86cbf66a9
|
Update docstring
Co-Authored-By: pavlukivan <pavlukivan@outlook.com>
|
2018-12-12 13:10:47 +07:00 |
|
Ivan Pavluk
|
a62b105fb5
|
Fix formatting
|
2018-12-10 05:06:18 +00:00 |
|
Ivan Pavluk
|
8457324044
|
SuccessfulHitWindow->SuccessfulHitResult
|
2018-12-10 09:04:12 +07:00 |
|
Dan Balasescu
|
77a544e475
|
formatting fix
Co-Authored-By: pavlukivan <pavlukivan@outlook.com>
|
2018-12-09 23:38:29 +07:00 |
|
Dan Balasescu
|
784a114eae
|
formatting fix
Co-Authored-By: pavlukivan <pavlukivan@outlook.com>
|
2018-12-09 23:38:19 +07:00 |
|
Ivan Pavluk
|
cb2444e01c
|
Remove Meh from TaikoHitWindows
|
2018-12-06 19:04:54 +07:00 |
|
smoogipoo
|
9fdd48ded2
|
Add 1ms offset to controlpoint lookup times
|
2018-12-04 12:08:46 +09:00 |
|
smoogipoo
|
eb88768bd0
|
Fix incorrect controlpoint being applied to samples
|
2018-12-03 17:21:27 +09:00 |
|
smoogipoo
|
aea84f737b
|
Fix taiko hitobjects potentially disappearing before being judged
|
2018-11-29 12:12:29 +09:00 |
|
smoogipoo
|
f27bd3ef3e
|
OpenTK -> osuTK
|
2018-11-20 17:14:59 +09:00 |
|
smoogipoo
|
f3ba429701
|
Make sure control points is internally initialised
|
2018-11-12 17:14:06 +09:00 |
|
smoogipoo
|
f4fd6189f8
|
Implement IEquatable
|
2018-11-12 16:53:30 +09:00 |
|
smoogipoo
|
0220ed21b0
|
Ignore distance for json serialisation
|
2018-11-12 16:38:49 +09:00 |
|
smoogipoo
|
0e92b385f0
|
Define default json deserialisation constructor
|
2018-11-12 16:38:33 +09:00 |
|
smoogipoo
|
8ad9b6a02a
|
Safety for default(SliderPath)
|
2018-11-12 16:38:14 +09:00 |
|
smoogipoo
|
d594ce3530
|
Revert "Make SliderPath.ControlPoints read-only"
This reverts commit 3b88d94793.
# Conflicts:
# osu.Game/Rulesets/Objects/SliderPath.cs
|
2018-11-12 16:20:38 +09:00 |
|
smoogipoo
|
77d16aa968
|
Add xmldocs
|
2018-11-12 14:16:21 +09:00 |
|
smoogipoo
|
4eef1134a6
|
Re-order file
|
2018-11-12 14:08:36 +09:00 |
|
smoogipoo
|
3aba462e52
|
Make Path.Distance a property again
|
2018-11-12 14:07:48 +09:00 |
|
smoogipoo
|
3b88d94793
|
Make SliderPath.ControlPoints read-only
|
2018-11-12 14:03:54 +09:00 |
|
smoogipoo
|
54ab256c8e
|
Instantiate a new path rather than setting properties on it
# Conflicts:
# osu.Game.Rulesets.Catch/Beatmaps/CatchBeatmapConverter.cs
# osu.Game.Rulesets.Catch/Objects/JuiceStream.cs
# osu.Game.Rulesets.Osu/Beatmaps/OsuBeatmapConverter.cs
# osu.Game/Rulesets/Objects/Legacy/Catch/ConvertHitObjectParser.cs
# osu.Game/Rulesets/Objects/Legacy/Mania/ConvertHitObjectParser.cs
# osu.Game/Rulesets/Objects/Legacy/Osu/ConvertHitObjectParser.cs
# osu.Game/Rulesets/Objects/Legacy/Taiko/ConvertHitObjectParser.cs
# osu.Game/Rulesets/Objects/SliderPath.cs
|
2018-11-12 13:50:19 +09:00 |
|
smoogipoo
|
cf4dad0fe8
|
Fix hitobjects not updating IsMaskedAway after being judged
|
2018-11-07 15:42:40 +09:00 |
|
smoogipoo
|
ace1dce281
|
Merge remote-tracking branch 'origin/master' into fix-slider-samples
# Conflicts:
# osu.Game.Tests/Beatmaps/Formats/LegacyBeatmapDecoderTest.cs
|
2018-11-05 18:10:22 +09:00 |
|
smoogipoo
|
92d570342c
|
Fix sample additions not falling back to non-addition bank
|
2018-11-05 17:35:24 +09:00 |
|
smoogipoo
|
a4caaf56ef
|
Merge remote-tracking branch 'origin/master' into fix-slider-samples
# Conflicts:
# osu.Game.Tests/Beatmaps/Formats/LegacyBeatmapDecoderTest.cs
# osu.Game/Rulesets/Objects/Legacy/Catch/ConvertHitObjectParser.cs
# osu.Game/Rulesets/Objects/Legacy/ConvertHitObjectParser.cs
# osu.Game/Rulesets/Objects/Legacy/Mania/ConvertHitObjectParser.cs
# osu.Game/Rulesets/Objects/Legacy/Osu/ConvertHitObjectParser.cs
# osu.Game/Rulesets/Objects/Legacy/Taiko/ConvertHitObjectParser.cs
|
2018-11-05 16:38:28 +09:00 |
|