Joppe27
f9a9ab1d9b
Use BeatSyncedContainer and adjust values to be in line with stable
2022-11-30 19:50:47 +01:00
Joppe27
f3fa39f254
Add legacy taiko kiai glow element
2022-11-30 00:44:20 +01:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Bartłomiej Dach
6e9d163c72
Specify canBeNull: true in [Resolved] for now
2022-11-22 20:56:07 +01:00
Bartłomiej Dach
ce7af0df63
Always use current timing point for circle piece animation
...
Using `LifetimeStart` seemed arbitrary and wrong not only in a
compatibility-with-stable sense, but also in a general sanity sense (why
would each object potentially be using a different timing point to
animate?)
2022-11-22 20:39:22 +01:00
Bartłomiej Dach
38f2a27f53
Split animation logic to its own method
...
Also add a guard, to bypass all of it if the foreground layer is not in
fact animatable.
2022-11-22 20:39:05 +01:00
Joppe27
5343f6922c
Add legacy circle piece animations based on combo
2022-11-22 17:22:00 +01:00
Dean Herbert
45f47cce77
Add basic osu!taiko "argon" swell visual
2022-11-16 16:13:52 +09:00
Dean Herbert
233d45e185
Fix argon swells incorrectly flashing on every hit
2022-11-15 18:28:13 +09:00
Bartłomiej Dach
8b8147c321
Rename {catch -> taiko}Component
2022-11-12 03:05:03 +09:00
Bartłomiej Dach
6a4c97b4f1
Fix code inspection
2022-11-12 02:20:19 +09:00
Bartłomiej Dach
7ef11cab8b
Adjust taiko argon transformer to new naming
2022-11-12 02:10:10 +09:00
Bartłomiej Dach
7379f6fe20
Merge branch 'master' into argon-taiko
2022-11-12 01:56:30 +09:00
Dan Balasescu
fe58329478
Merge pull request #21151 from peppy/taiko-judgement-fixes
...
Fix various issues surrounding hit judgements
2022-11-11 16:41:46 +09:00
Dan Balasescu
8063dcd74a
Merge pull request #21148 from peppy/taiko-barline-separation
...
Move major barline portion to default implementation to allow for further customisation
2022-11-11 16:40:51 +09:00
Dan Balasescu
5bdbf56f43
Merge branch 'master' into taiko-judgement-fixes
2022-11-11 15:48:33 +09:00
Dan Balasescu
1a1a186d22
Merge branch 'master' into taiko-barline-separation
2022-11-11 15:47:06 +09:00
Dan Balasescu
f25a8ee4a6
Merge branch 'master' into taiko-tick-trackiung
2022-11-11 15:41:06 +09:00
Susko3
6303b88e56
Fix NRT causing CI failure
2022-11-10 14:31:24 +01:00
Dan Balasescu
606d42c679
Merge pull request #21184 from peppy/skinnable-things-cleanup
...
Skinnable class naming pass
2022-11-10 12:52:08 +09:00
Dan Balasescu
20520e7290
Merge pull request #21171 from peppy/unpollute-taiko-drawable-hit
...
Remove triangles skin specific implementation from base osu!taiko `DrawableHit`
2022-11-10 12:47:36 +09:00
Dean Herbert
1aa0e40f2f
Add "Component" prefix to lookup naming
2022-11-09 17:46:43 +09:00
Dean Herbert
c908969d9b
Rename ISkinComponent to ISkinLookup
2022-11-09 17:46:43 +09:00
Dean Herbert
20b8ab324f
Apply nullability to osu!taiko skinning classes
2022-11-09 13:37:06 +09:00
Dean Herbert
30890644a8
Flash piece when hit
2022-11-08 15:31:45 +09:00
Dean Herbert
aa7d0e2c96
Remove triangles skin specific implementation from base DrawableHit
2022-11-08 15:22:00 +09:00
Dean Herbert
01803c3f13
Adjust judgement text to be more visible
2022-11-08 15:08:52 +09:00
Dean Herbert
d57ec4b227
Add argon input drum implementation
2022-11-07 18:32:12 +09:00
Dean Herbert
b15d1bc333
Add argon result display implementation
2022-11-07 18:32:12 +09:00
Dean Herbert
d5c375b139
Add argon hit explosion implementation
2022-11-07 18:32:12 +09:00
Dean Herbert
37cb187d2e
Move strong hit scale to DefaultHitExplosion
2022-11-07 18:32:12 +09:00
Dean Herbert
e2046791c2
Add argon drum roll ticks
2022-11-07 18:32:12 +09:00
Dean Herbert
f1556c98e3
Add drum roll implementation
2022-11-07 18:32:12 +09:00
Dean Herbert
6636545195
Move taiko argon hit icon to respective centre/rim pieces
2022-11-07 18:32:12 +09:00
Dean Herbert
529e3217cf
Add barline implementation
2022-11-07 18:32:12 +09:00
Dean Herbert
f1a1f29da7
Add hit target implementation
2022-11-07 18:32:12 +09:00
Dean Herbert
421bdd2c1a
Add playfield background implementations
2022-11-07 18:32:12 +09:00
Dean Herbert
bc0e9375af
Add basic argon hits
2022-11-07 18:32:12 +09:00
Dean Herbert
baf8db8de4
Add basic setup for taiko argon skinning
2022-11-07 18:32:12 +09:00
Dean Herbert
2648175275
Merge branch 'taiko-barline-separation' into taiko-fixes-combined
2022-11-07 18:32:09 +09:00
Dean Herbert
688f50e086
Merge branch 'taiko-tick-trackiung' into taiko-fixes-combined
2022-11-07 18:32:07 +09:00
Dean Herbert
564d078517
Fix much brokenness with kiai and justment sizing
2022-11-07 17:19:32 +09:00
Dean Herbert
8745c2f016
Split out taiko DefaultJudgementPiece and move animations across
2022-11-07 17:19:32 +09:00
Dean Herbert
1975385cc7
Move first tick tracking logic inside TickPiece
2022-11-07 15:26:34 +09:00
Dean Herbert
c69a4f9333
Move major barline portion to default implementation to allow for further customisation
...
Of note, this removes the "major" barline triangles from legacy skins. I
think this is more correct, as they did not display in stable.
2022-11-07 14:29:58 +09:00
Dean Herbert
bfa5d41d89
Fix one more case
2022-11-02 17:39:45 +09:00
Dan Balasescu
5dfaf27722
A bit more cleanup
2022-11-02 17:23:45 +09:00
Dean Herbert
bc3382f373
Apply NRT to many taiko classes
2022-11-02 17:15:25 +09:00
Dean Herbert
910dd3ad01
Move more default classes to correct namespace
2022-11-02 17:15:25 +09:00
Dean Herbert
2407eb063d
Simplify Circle usage in default CentreHitCirclePiece
2022-11-02 17:15:25 +09:00
Dean Herbert
9c758e5425
Move DefaultInputDrum to correct location
2022-11-02 17:15:25 +09:00
Dean Herbert
d441e98af7
Adjust kiai flash period in line with stable
2022-10-21 15:34:25 +09:00
Joppe27
d83c398b58
Apply review: changed DelayUntilTransformsFinished to ArmedState check
2022-10-19 23:31:23 +02:00
Joppe27
9b123e7365
Adjust flash intensity and fade values to feel better
2022-10-19 00:51:44 +02:00
Joppe27
003e4247f9
Implement kiai flashing for "triangles" taiko skin
2022-10-18 23:55:40 +02:00
Joppe27
a21acdb5bc
Implement kiai flashing for legacy taiko skins
2022-10-18 23:55:02 +02:00
Dean Herbert
8bf4ca4b53
Add legacy skin fallback when beatmap skin is providing resources
2022-10-12 17:47:20 +09:00
Dean Herbert
ad28bfc9b2
Fix taiko blueprints displaying incorrectly for drum rolls
2022-08-18 17:18:11 +09:00
Dan Balasescu
b4e55f7309
Apply IRenderer changes
2022-08-02 19:50:57 +09:00
Salman Ahmed
b32ff68a95
Enable NRT on taiko legacy skin transformer and tests
2022-07-30 09:43:51 +03:00
Salman Ahmed
0940e703b3
Fix normal skin hitsounds prioritised over default taiko hitsounds
2022-07-30 09:15:28 +03:00
Dean Herbert
4279ac866c
Tidy up unnecessary changes and remove unused classes
2022-07-22 17:58:52 +09:00
Dean Herbert
c32af3c041
Merge branch 'master' into hongaaronc/master
2022-07-22 15:55:38 +09:00
Salman Ahmed
28150dc15d
Merge branch 'master' into taiko-target-classic-position
2022-07-18 20:45:29 +03:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Dean Herbert
859a83ac90
Remove unused field and fix typo
2022-06-02 14:48:26 +09:00
Aaron Hong
f6e9dfe7bf
Fix naming rule violations
2022-06-01 01:03:21 -07:00
Aaron Hong
2471c242b4
Merge branch 'master' of https://github.com/ppy/osu into ppy-master
2022-05-31 21:01:04 -07:00
Salman Ahmed
61078910a6
Handle all skin component types explicitly
2022-04-23 03:34:05 +03:00
Salman Ahmed
b84a3b7834
Rewrite input drum measurements to autosize on X axis
2022-04-07 21:39:53 +03:00
Salman Ahmed
ce70957fbf
Remove redundant code
2022-04-06 02:38:56 +03:00
Salman Ahmed
55c56c03a5
Propagate legacy input drum size to main piece
2022-04-06 02:34:07 +03:00
Dean Herbert
2d020e756d
Merge pull request #17621 from frenzibyte/taiko-target-size
...
Adjust osu!taiko legacy hit target size to match osu!(stable)
2022-04-05 12:37:40 +09:00
Salman Ahmed
534cc18ff9
Adjust osu!taiko legacy hit target size to match osu!(stable)
2022-04-03 01:21:48 +03:00
Salman Ahmed
4ce69890d4
Use TaikoHitObject.DEFAULT_SIZE for default circle piece symbol size
2022-04-03 00:21:23 +03:00
Aaron Hong
6f99455d94
Improve centre input size fitting for legacy skins
2022-03-12 05:17:45 -08:00
Aaron Hong
7336c2c0bd
Fix osu!taiko alignment issue with legacy skins on Touch Controls
2022-03-11 02:48:08 -08:00
Aaron Hong
38c61b2c1d
Fix crash when loading legacy osu!taiko skins with touch input
2022-03-11 00:14:33 -08:00
Bartłomiej Dach
735414bc49
Replace TimeSignatures enum with struct for storage of arbitrary meter
2022-01-22 20:50:31 +01:00
Susko3
19467e58c1
Remove unused params from BDL methods
2022-01-15 01:06:39 +01:00
Dean Herbert
add39fbd4f
Merge branch 'master' into fix-skin-layout-editor-crash
2021-10-28 06:24:24 +09:00
Dean Herbert
6944151486
Apply batch fixing of built-in types using var
2021-10-27 13:04:41 +09:00
Dean Herbert
93482414d6
Remove SkinConfiguration subclasses and allow configuration parsing for all skin types
2021-10-22 14:42:23 +09:00
Dean Herbert
32afd3f426
Replace all basic usages
2021-10-02 02:22:23 +09:00
smoogipoo
f9d5abff8a
Update with keybinding changes
2021-09-16 18:26:12 +09:00
Dean Herbert
90e81a595d
Move DrumSampleTriggerSource into its own class to avoid nested references
2021-08-26 17:19:46 +09:00
Dean Herbert
8e0a04c4e5
Update taiko InputDrum to use new trigger logic
2021-08-25 16:56:44 +09:00
Dean Herbert
4b45d8318e
Merge branch 'master' into transformers-per-skin
2021-06-16 16:37:28 +09:00
Salman Ahmed
fbb856d84b
Call base when overriding lookup methods
...
Rather than arbitrarily accessing `Skin` here and there.
2021-06-11 12:44:44 +03:00
Dean Herbert
9c34cb0777
Share colour constants with default drawable piece implementations
2021-06-11 14:20:08 +09:00
Salman Ahmed
cf40282f1f
Convert LegacySkinTransformers to accept raw ISkins rather than a full ISkinSource
2021-06-09 22:49:31 +03:00
Dean Herbert
2e2281c7d2
Revert disabling taiko sample tests and fix logic
2021-06-01 18:57:19 +09:00
Dean Herbert
17574833fb
Update other transformers with similar refactored logic
2021-05-30 19:15:59 +09:00
Salman Ahmed
fbc316ea1d
Fix legacy skin transformers potentially ignoring source implementations
2021-05-29 21:23:22 +03:00
Bartłomiej Dach
f716fb0968
Remove bogus InternalChildren null-check
...
`InternalChildren` can't viably be `null`, and if it were, we have
bigger problems. The removed null-check was triggering false-positive
inspections further down.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
aec859b4d1
Merge branch 'master' into fix-unsafe-skinnable-sample-play
2021-03-18 19:51:46 +01:00
smoogipoo
0c3c8141da
Remove Expires and RemoveWhenNotAlive override
2021-03-18 19:39:42 +09:00
Bartłomiej Dach
3bfde7341f
Revert "Remove unnecessary overrides"
...
This reverts commit f4e508b570
2021-03-17 17:14:53 +01:00
Bartłomiej Dach
f4e508b570
Remove unnecessary overrides
2021-03-15 20:43:30 +01:00
Bartłomiej Dach
58220481db
Rename I{-> Animatable}HitExplosion
2021-03-15 20:39:02 +01:00
