1
0
mirror of https://github.com/ppy/osu.git synced 2025-02-08 04:12:55 +08:00
Commit Graph

71436 Commits

Author SHA1 Message Date
Dean Herbert
2356d3e2d0
Refactor OsuContextMenu to avoid code duplication 2025-02-05 16:34:15 +09:00
Dean Herbert
099ce39531
Use same delay in context menus 2025-02-04 23:21:41 +09:00
Dean Herbert
df51d345c5
Change menus to fade out with a slight delay so settings changes are visible
Useful for cases like https://github.com/ppy/osu/pull/31778, where a
change to one setting can affect another.
2025-02-03 17:38:17 +09:00
Dean Herbert
5668a90781
Merge pull request #31737 from bdach/fix-post-refactor
Fix distance snap time part ceasing to work when grid snap is also active
2025-02-03 16:56:28 +09:00
Dean Herbert
b9f840c32e
Merge pull request #31742 from smoogipoo/fix-results-persistent-sounds
Fix results screen sounds persisting after exit
2025-02-03 16:39:47 +09:00
Dan Balasescu
9033a4d480
Remove unused using 2025-02-03 14:20:56 +09:00
Dan Balasescu
210fa14759
Play sound via results screen instead 2025-02-03 14:15:46 +09:00
Dean Herbert
f65be009a3
Merge pull request #31747 from bdach/do-not-reset-online-info-on-save
Do not reset online information when saving beatmap
2025-02-02 22:24:56 +09:00
Dean Herbert
cf3a379b1c
Merge pull request #31368 from frenzibyte/mobile-fix-mania
Improve osu!mania playability on mobile devices
2025-02-01 14:49:46 +09:00
Dean Herbert
cc3bb590c9
Remove pointless comment 2025-02-01 14:48:13 +09:00
Dean Herbert
334b578fb6
Merge pull request #31733 from bdach/bss/abstract-out-wizard
Abstract out `WizardOverlay` for multi-step wizard type screens
2025-02-01 14:10:35 +09:00
Bartłomiej Dach
7ef8616703
Fix broken user-facing messaging when beatmap hash mismatch is detected 2025-01-31 12:22:05 +01:00
Bartłomiej Dach
c3981f1097
Do not reset online info on beatmap save 2025-01-31 12:21:42 +01:00
Dan Balasescu
cf2d0e6911
Fix results screen sounds persisting after exit 2025-01-31 16:22:37 +09:00
Bartłomiej Dach
261a7e537b
Fix distance snap time part ceasing to work when grid snap is also active
As pointed out in
https://github.com/ppy/osu/pull/31655#discussion_r1935536934.
2025-01-30 14:42:44 +01:00
Bartłomiej Dach
d3b233b08f
Merge pull request #31732 from KareVulli/fix-timeline-selection
Fix stacked objects selection order on editor timeline
2025-01-30 14:31:42 +01:00
Salman Alshamrani
64b67252a2 Enable NRT on Column 2025-01-30 08:22:35 -05:00
Dean Herbert
d673344b30
Merge pull request #31731 from bdach/prosecuting-mirror-directions
Change mirror mod direction setting description & tooltip to hopefully be less confusing
2025-01-30 20:33:13 +09:00
Dean Herbert
8a887abe51
Merge pull request #31663 from nekodex/friend-notification-samples
Add unique samples for friend online/offline notifications
2025-01-30 19:45:30 +09:00
Bartłomiej Dach
d8c63a443f
Merge pull request #31685 from frenzibyte/two-factor-authentication-code
Do not display autocorrect suggestions in two factor verification code text box
2025-01-30 11:15:09 +01:00
Dean Herbert
5f2532932e
Merge branch 'master' into friend-notification-samples 2025-01-30 18:29:26 +09:00
Bartłomiej Dach
31c4461fbb
Abstract out WizardOverlay for multi-step wizard type screens
To be used in the editor, for the beatmap submission wizard.

I've recently been on record for hating "abstract" as a rationale to do
anything, but seeing this commit ~3 months after I originally made it,
it still feels okay to do for me in this particular case. I think the
abstraction is loose enough, makes sense from a code reuse and UX
consistency standpoint, and doesn't seem to leak any particular
implementation details. That said, it is both a huge diffstat and also
potentially controversial, which is why I'm PRing first separately.
2025-01-30 09:39:08 +01:00
Marvin Helstein
ec99fc1141 Move ApplySelectionOrder override from EditorBlueprintContainer to ComposeBlueprintContainer 2025-01-30 10:27:36 +02:00
Bartłomiej Dach
bad2959d5b
Change mirror mod direction setting tooltip to hopefully be less confusing
See https://github.com/ppy/osu/issues/29720,
https://discord.com/channels/188630481301012481/188630652340404224/1334294048541904906.

This removes the tooltip due to being zero or negative information, and
also changes the description of the setting to not contain the word
"mirror", which will hopefully quash the "this is where I would place a
mirror to my screen to achieve what I want" interpretation which seems
to be a minority interpretation.

The first time this was complained about I figured this was probably a
one guy issue, but now it's happened twice, and I never want to see this
conversation again.
2025-01-30 08:59:33 +01:00
Dan Balasescu
48b1c7398e
Merge pull request #31655 from bdach/deabstractify-editor-snap
Refactor editor object snapping to remove bad abstractions
2025-01-30 01:38:42 +09:00
Dan Balasescu
7750468e31
Merge pull request #31726 from peppy/room-settings-button
Make multiplayer change room settings more obvious as to what it does
2025-01-30 00:42:00 +09:00
Dan Balasescu
007bf87a6b
Merge pull request #31723 from peppy/fix-unstable-rate-incrementatl
Fix incremental unstable rate calculation not matching expectations
2025-01-29 23:54:59 +09:00
Dan Balasescu
ca7a36d3d6
Remove unused usings 2025-01-29 23:32:44 +09:00
Bartłomiej Dach
75ef67e959
Merge branch 'master' into two-factor-authentication-code 2025-01-29 13:15:30 +01:00
Bartłomiej Dach
9a9f42c3ff
Merge pull request #31590 from frenzibyte/fix-editor-textbox-regressions
Fix recent editor textbox regressions
2025-01-29 12:08:42 +01:00
Dean Herbert
a6814d1a8a
Make multiplayer change room settings more obvious as to what it does
"Edit" felt really weird.
2025-01-29 19:48:04 +09:00
Bartłomiej Dach
d87720da1b
Merge branch 'master' into fix-editor-textbox-regressions 2025-01-29 11:25:16 +01:00
Bartłomiej Dach
c079969e72
Merge pull request #31417 from peppy/enable-sentry-caching
Enable sentry caching to avoid sentry writing outside of game directory
2025-01-29 11:19:56 +01:00
Dean Herbert
facc9a4dc3
Fix reference hashsets getting emptied before used 2025-01-29 19:15:28 +09:00
Dean Herbert
e8d20fb402
Fix skin SourceChanged event never being unbound 2025-01-29 18:16:04 +09:00
Dean Herbert
9db8e0b7ac
Merge branch 'master' into friend-notification-samples 2025-01-29 17:43:56 +09:00
Dean Herbert
bf40f071eb
Code quality pass 2025-01-29 17:43:49 +09:00
Dean Herbert
4c83ef83ee
Update resources 2025-01-29 17:34:03 +09:00
Dean Herbert
fd1d90cbd9
Update framework
Update framework
2025-01-29 17:32:05 +09:00
Dean Herbert
d8ec3b77e4
Fix incremental unstable rate calculation not matching expectations
The `EventCount` variable wasn't factoring in that some results do not
affect unstable rate. It would therefore become more incorrect as the
play continued.

Closes https://github.com/ppy/osu/issues/31712.
2025-01-29 17:11:12 +09:00
Dean Herbert
6c4b4166ac
Add fail cases to unstable rate incremental testing 2025-01-29 17:10:05 +09:00
Dean Herbert
a3685da250
Merge branch 'master' into enable-sentry-caching 2025-01-29 11:55:23 +09:00
Bartłomiej Dach
b84a9f7820
Merge pull request #31711 from peppy/change-friend-notification-icons
Change friend online notifications' icon and colours
2025-01-28 15:38:27 +01:00
Bartłomiej Dach
99d898326c
Merge pull request #31709 from peppy/catch-od-hide
Remove "Accuracy" from osu!catch editor setup
2025-01-28 15:33:50 +01:00
Dean Herbert
a3a08832b4
Add keywords to make lighten-during-breaks setting discoverable to stable users
See https://github.com/ppy/osu/discussions/31671.
2025-01-28 21:31:51 +09:00
Dean Herbert
017d38af3d
Change friend online notifications' icon and colours
The previous choices made it seem like potentially destructive actions
were being performed. I've gone with neutral colours and more suiting
icons to attempt to avoid this.

---

Addresses concerns in
https://github.com/ppy/osu/discussions/31621#discussioncomment-11948377.

I chose this design even though it wasn't the #1 most popular because I
personally feel that using green/red doesn't work great for these.
2025-01-28 21:29:17 +09:00
Dean Herbert
1aa1137b09
Remove "Accuracy" and "Stack Leniency" from osu!catch editor setup 2025-01-28 21:22:51 +09:00
Dean Herbert
6d39ee2918
Merge pull request #31696 from bdach/do-not-bundle-explicit-beatmaps
Do not bundle explicit beatmaps
2025-01-28 20:39:21 +09:00
Dan Balasescu
a863230983
Merge pull request #31697 from bdach/corrupt-mp3s-should-not-crash-game
Catch and display user-friendly errors regarding corrupted audio files
2025-01-28 14:00:01 +09:00
Dan Balasescu
a075f76344
Merge pull request #31698 from bdach/weird-zips
Work around rare sharpcompress failure to extract certain archives
2025-01-28 13:21:58 +09:00