Bartłomiej Dach
bb8f58f6d6
Work around rare sharpcompress failure to extract certain archives
...
Closes https://github.com/ppy/osu/issues/31667 .
See https://github.com/ppy/osu/issues/31667#issuecomment-2615483900 for
explanation.
For whatever it's worth, I see rejecting this change and telling
upstream to fix it as an equally agreeable outcome, but after I spent an
hour+ tracking this down, writing this diff was nothing in comparison.
2025-01-27 12:28:53 +01:00
Bartłomiej Dach
be9c96c041
Fix infinite loop when switching audio tracks fails on an existing beatmap
...
Bit ugly, but appears to work in practice...
2025-01-27 10:27:06 +01:00
Bartłomiej Dach
01ae1a58f1
Catch and display user-friendly errors regarding corrupted audio files
...
Addresses lack of user feedback as indicated by
https://github.com/ppy/osu/issues/31693 .
2025-01-27 10:25:22 +01:00
Bartłomiej Dach
e24af4b341
Add inline comments for sets that are not marked FA but should be
2025-01-27 09:40:53 +01:00
Bartłomiej Dach
836a9e5c25
Remove explicit beatmap set from list of bundled beatmap sets
2025-01-27 09:40:20 +01:00
Salman Alshamrani
4d7b071027
Specifiy second-factor authentication code text box with Code type
2025-01-25 23:58:56 -05:00
Salman Alshamrani
c18128e974
Remove OrientationManager and the entire mobile namespace
2025-01-25 20:01:18 -05:00
Salman Alshamrani
bb7daae080
Simplify orientation locking code magnificently
2025-01-25 19:12:43 -05:00
Salman Alshamrani
ffc37cece0
Avoid extra unnecessary DI
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2025-01-25 19:12:42 -05:00
Salman Alshamrani
8151c3095d
Revert unnecessary inheritance
...
Everyone is right, too much inheritance and polymorphism backfires very badly.
2025-01-25 19:12:37 -05:00
Salman Alshamrani
dac7d21302
Be explicit on nullability in RequiresPortraitOrientation
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2025-01-25 19:12:36 -05:00
Salman Alshamrani
129ab03ec4
Merge pull request #31664 from ThePooN/ios-non-exempt-encryption
...
🔧 Specify we're not using non-exempt encryption
2025-01-24 13:00:08 -05:00
ThePooN
354126b7f7
🔧 Specify we're not using non-exempt encryption
2025-01-24 18:14:55 +01:00
Bartłomiej Dach
3c763971ff
Merge pull request #31652 from peppy/beatmap-carousel-v2-split-panels
...
Split out beatmap and set panels in beatmap carousel v2
2025-01-24 16:00:04 +01:00
Jamie Taylor
79df094f17
Add unique samples for friend online/offline notifications
2025-01-24 23:20:04 +09:00
Bartłomiej Dach
092c7b4253
Merge branch 'master' into beatmap-carousel-v2-split-panels
2025-01-24 15:16:23 +01:00
Bartłomiej Dach
55ab3c72f6
Remove unused field
2025-01-24 15:15:50 +01:00
Dean Herbert
82c5f37c2c
Remove selection animation on set panel
2025-01-24 22:45:08 +09:00
Bartłomiej Dach
b0136f98a9
Fix test failures
2025-01-24 14:24:16 +01:00
Bartłomiej Dach
7845c5cfb7
Merge pull request #31645 from peppy/offset-adjust-more-lenience
...
Make offset adjust more lenient
2025-01-24 14:01:25 +01:00
Bartłomiej Dach
daec91f61d
Refactor further to avoid weird non-virtual common method
2025-01-24 13:14:31 +01:00
Bartłomiej Dach
b04144df54
Fix behavioural change in interaction between grid & distance snap
2025-01-24 13:14:26 +01:00
Bartłomiej Dach
589035c534
Simplify code
2025-01-24 13:14:06 +01:00
Dean Herbert
a94681158d
Merge pull request #31623 from Layendan/room-context-menu
...
Add view in browser context menu functionality to multiplayer/playlist rooms
2025-01-24 20:31:49 +09:00
Dean Herbert
da762384f8
Fix breakage from reordering co-reliant variable sets (and guard against it)
2025-01-24 20:20:18 +09:00
Dean Herbert
175eb82ccf
Split out beatmaps and set panels into two separate classes
2025-01-24 20:10:41 +09:00
Dean Herbert
0164a2e4dc
Move pool item preparation / cleanup duties to Carousel
2025-01-24 20:10:41 +09:00
Bartłomiej Dach
269ade178e
Fix tests
2025-01-24 11:59:07 +01:00
Bartłomiej Dach
32d341a468
Remove IPositionSnapProvider
2025-01-24 11:59:07 +01:00
Bartłomiej Dach
a6987f5c95
Remove dependence of placement blueprints on IPositionSnapProvider
2025-01-24 11:59:07 +01:00
Bartłomiej Dach
15b6e28ebe
Remove dependence of blueprint containers on IPositionSnapProvider
2025-01-24 11:59:05 +01:00
Bartłomiej Dach
2d46da1520
Merge pull request #31634 from peppy/beatmap-carousel-v2-selection
...
Add selection support to beatmap carousel v2
2025-01-24 11:43:17 +01:00
Dean Herbert
9366bfbf0d
Move activation drawable flow portion to ICarouselPanel
2025-01-24 18:40:48 +09:00
Dean Herbert
92429b2ed9
Adjust comments on ICarouselPanel to imply external use
2025-01-24 18:34:04 +09:00
Bartłomiej Dach
2f84aec88d
Merge pull request #31644 from peppy/fix-beatmap-offset-crash
...
Fix potential crash when adjusting offset
2025-01-24 10:20:29 +01:00
Dean Herbert
721b2dfbba
Fix average button not correctly becoming disabled where it previously would
2025-01-24 17:17:34 +09:00
Dean Herbert
56a611b47e
Merge branch 'master' into mobile-fix-mania
2025-01-24 17:03:00 +09:00
Dean Herbert
28a59f4e29
Move line to correct location
2025-01-24 16:45:14 +09:00
Dean Herbert
05b1002e9d
Adjust layout and code quality slightly
2025-01-24 15:57:13 +09:00
Dean Herbert
8f8a6455b4
Bypass offset disallowed status when handling realm callbacks
...
Hopefully don't need to overthink this one.
2025-01-24 15:49:47 +09:00
Dean Herbert
ee78e1b223
Add safeties against attempting to apply previous play while offset adjust is not allowed
...
This should theoretically not be possible, but while we are sharing this
control's implementation between gameplay and non-gameplay usages, let's
ensure nothing weird can occur.
2025-01-24 15:49:47 +09:00
Dean Herbert
fb10996951
Consume GameplayStartTime for more lenient offset adjustments
2025-01-24 15:30:02 +09:00
Dean Herbert
5cc8181bad
Expose GameplayStartTime in IGameplayClock
2025-01-24 15:29:49 +09:00
Dean Herbert
4ae6dfd790
Merge pull request #31640 from frenzibyte/discord-rpc-ux
...
Hide Discord RPC error messages away from user attention
2025-01-24 14:36:13 +09:00
Salman Alshamrani
61a818e4ed
Hide Discord RPC error messages away from user attention
2025-01-23 21:22:35 -05:00
Layendan
d326f23576
Remove unused method
2025-01-23 15:39:18 -07:00
Layendan
b0a7237fd6
Fix formatting
2025-01-23 15:37:30 -07:00
Layendan
13c64b59af
Inherit menu items from parent class
2025-01-23 15:36:20 -07:00
Dean Herbert
c3269013d9
Merge pull request #31633 from bdach/thanks-for-nothing-github-actions
...
Roll back windows build image to 2019 on android build job
2025-01-24 00:35:58 +09:00
Dean Herbert
f4270ab3b9
Simplify selection handling logic
2025-01-23 23:58:51 +09:00
