OverlayColourProvider
DrawablePage
.Result
.WaitSafelyForResult
Wait
WaitSafely
TestStoryboardSkipOutro
Aims to resolve failures as seen at https://github.com/peppy/osu/runs/4677353822?check_suite_focus=true. Have run quite a lot locally with no failures (while removing the skip step 100% fails).
TestSceneMultiSpectatorLeaderboard
Fix OsuAnimatedButton animating when initially disabled
There was previously a potential in headless runs for timing discrepancies to cause the volume to never get adjusted. As seen at https://github.com/peppy/osu/runs/4604610951?check_suite_focus=true.
Tidy up `WorkingBeatmap`
BeatmapSetInfo
Metadata
There were very few accesses to this, and after realm they should all be done via the `BeatmapInfo`, so let's remove this.
Fix multiplayer test failures when checking for parted room
Fix delete button showing on current item before beatmap retrieval
Can be tested by adding a Thread.Sleep() in DrawableRoomPlaylistItem.load().
Rename beatmap card-related classes
Fix intermittent test failures on `TestSceneResultsScreen` due to long delay step
BeatmapCard{ => Normal}
Implement "extra" beatmap card size
TestSceneResultsScreen
Using real time delays of 3 seconds doesn't play well with headless runs.
Fix intermittent failures on `TestSceneBeatmapListingOverlay`
TestSceneBeatmapListingOverlay
In the specific method, there was no wait step after the initial fetch (unlike all of the rest), meaning the fetch may not have finished in time for the follow-up steps. As seen at https://github.com/ppy/osu/runs/4588058438?check_suite_focus=true.
TestSceneMultiplayerQueueList
This adds the "wait for enabled" check in a way that can be easily reused, as it keeps getting missed in test implementations. This particular commit hopefully fixes https://github.com/ppy/osu/runs/4583845033?check_suite_focus=true.
TestMultiplayerScreenStack
TestMultiplayerComponents