8043 Commits

• Name some screen stacks for better logging context
  Dean Herbert · 2021-12-20 18:24:14 +09:00
  6907a9a3cc
• Add better defined steps to TestLoseHostWhileReady ready button test

  Not 100% sure this will solve the issue but it's worth a try. The button
  state checks are using `Until` everywhere else so this brings the test
  in line with the standards.
  
  As seen
  https://github.com/ppy/osu/runs/4579641456?check_suite_focus=true.

  Dean Herbert · 2021-12-20 17:47:06 +09:00
  87051d5d61
• Chooser earlier items in song select tests to avoid potentially not having enough
  Dean Herbert · 2021-12-20 17:11:15 +09:00
  5c8e317a6e
• Fix weird loop logic
  Dean Herbert · 2021-12-20 17:09:08 +09:00
  af78a3e99d
• Add wait step to TestScenePlaylistResultScreen explicitly for screen load
  Dean Herbert · 2021-12-20 16:58:36 +09:00
  d79602a912
• Merge pull request #16164 from smoogipoo/fix-intermittent-background-test

  Fix intermittent background screen test failures

  Dean Herbert · 2021-12-20 14:00:53 +09:00
  2e47c4e25d
• Better fix for intermittent multiplayer tests
  Dan Balasescu · 2021-12-20 13:10:13 +09:00
  9316abc278
• Wait for previous screen to be hidden in test
  Dan Balasescu · 2021-12-20 12:44:23 +09:00
  11f3ec0cb5
• Add test for ranked/unranked user display
  Bartłomiej Dach · 2021-12-19 13:40:22 +01:00
  097402677d
• Bring profile header test in line with modern conventions

  - Removed online code that didn't work anyway after the introduction of
    the development web instance.
  
  - Removed some weird test steps.
  
  - Fixed online/offline test steps not working at all due to identical
    user ID.

  Bartłomiej Dach · 2021-12-19 13:40:21 +01:00
  c112177559
• Fix tests
  Bartłomiej Dach · 2021-12-17 11:45:01 +01:00
  883fcf2604
• Merge branch 'master' into beatmap-card/extra-wip
  Bartłomiej Dach · 2021-12-17 11:11:36 +01:00
  c6d0b5d200
• Merge branch 'master' into fix-realm-post-storage-migration-failure
  Bartłomiej Dach · 2021-12-17 00:19:46 +01:00
  54790bb758
• Don't show multiplayer channels in chat overlay
  Dan Balasescu · 2021-12-16 16:41:47 +09:00
  488374b4a2
• Merge branch 'master' into beatmap-card-expanded-state-fix
  Bartłomiej Dach · 2021-12-15 22:20:30 +01:00
  cbb65e1e07
• Merge branch 'master' into forego-resetting-spectate-state
  Dean Herbert · 2021-12-15 18:05:06 +09:00
  9e82a3e79a
• Don't reset spectating state if gameplay is finished
  Dan Balasescu · 2021-12-15 17:40:30 +09:00
  18d7b79207
• Add test coverage of same scenario without deletion
  Dean Herbert · 2021-12-15 17:30:09 +09:00
  39a0a21132
• Add another until step to guard against async test issues
  Dan Balasescu · 2021-12-15 17:00:06 +09:00
  d22e1b9001
• Fix exception when updating the room's visual playlist
  Dan Balasescu · 2021-12-15 16:53:25 +09:00
  740a6f16c7
• Add failing test showing expanded state being unexpectedly lost
  Dean Herbert · 2021-12-15 16:26:19 +09:00
  e9187cc3cf
• Merge pull request #16083 from peppy/fix-online-availability-after-reimport

  Fix `OnlinePlayBeatmapAvailabilityTracker` failng after modified reimport of existing beatmap

  Dan Balasescu · 2021-12-15 08:31:02 +09:00
  2cea39a92a
• Remove whitespace
  Dan Balasescu · 2021-12-15 07:33:49 +09:00
  da00c020be
• Merge branch 'master' into fix-menu-background-desync
  Bartłomiej Dach · 2021-12-14 21:31:10 +01:00
  00154fe86d
• Add back PlaylistRoomCreation test

  Was spiritually removed in https://github.com/ppy/osu/pull/16045.
  
  This implementation is mostly taken from that PR's comment thread
  verbatim, and now works due to the associated changes to
  `OnlinePlayBeatmapAvailabilityTracker`.

  Dean Herbert · 2021-12-14 19:16:52 +09:00
  0950d8d327
• Merge pull request #16080 from smoogipoo/fix-storyboard-start-time

  Fix incorrect storyboard life time start with looping commands

  Dean Herbert · 2021-12-14 18:33:56 +09:00
  04551ea61e
• Merge pull request #16045 from smoogipoo/multiplayer-local-beatmap-query

  Rework multiplayer's current item tracking

  Dean Herbert · 2021-12-14 18:33:30 +09:00
  cebfeb5220
• Remove pointless/broken test steps

  These aren't accurate and are tested via a more accurate means directly
  above.

  Dean Herbert · 2021-12-14 16:40:50 +09:00
  25a056dfad
• Add failing test coverage of BackgroundScreeNDefault's beatmap background tracking when active/non-active
  Dean Herbert · 2021-12-14 16:40:34 +09:00
  b6a272e31a
• Fix incorrect test
  Dan Balasescu · 2021-12-14 15:08:00 +09:00
  eb3050b2ac
• Provide a realm factory to usages of ToLive/RealmLive
  Dean Herbert · 2021-12-14 14:26:34 +09:00
  441b7baa93
• Remove weird test
  Dan Balasescu · 2021-12-14 06:38:57 +09:00
  6e3558b222
• Use new method in more places that can benefit from it
  Dean Herbert · 2021-12-13 16:56:43 +09:00
  309290a3c9
• Move "excess mods" test behaviour to local usages

  There were only two of these, so it doesn't make sense to add extra
  complexity in the test resources class.

  Dean Herbert · 2021-12-13 16:41:30 +09:00
  654b47c7ec
• Simplify usages where the ruleset being used is osu! ruleset
  Dean Herbert · 2021-12-13 16:37:20 +09:00
  99ac71c1fe
• Move test ScoreInfo creation to TestResources

  The main goal here is to remove the inheritance, since realm doesn't
  like that. Unfortunate that we can't use object initialisers in a few of
  these places, but no real way around that.

  Dean Herbert · 2021-12-13 16:34:50 +09:00
  b0d14526ea
• Merge branch 'master' into multiplayer-local-beatmap-query
  Dean Herbert · 2021-12-13 13:27:34 +09:00
  3ea07b426b
• Fix results sometimes showing incorrect score position
  Dan Balasescu · 2021-12-13 06:54:57 +09:00
  2cd2b10ce1
• Merge branch 'master' into multiplayer-local-beatmap-query
  Dan Balasescu · 2021-12-12 16:37:41 +09:00
  bf3abb2455
• Fix test failures from async item loading
  Dan Balasescu · 2021-12-12 16:11:48 +09:00
  9f792fec49
• Resolve some test failures due to async population
  Dan Balasescu · 2021-12-11 22:52:08 +09:00
  99cd36d2f6
• Fix starting gameplay too early after import
  Dan Balasescu · 2021-12-11 22:47:50 +09:00
  25b274c323
• Merge pull request #16029 from peppy/editor-mod-reset

  Fix editor not resetting mods when entering

  Dan Balasescu · 2021-12-11 20:20:11 +09:00
  1aac978a7b
• Merge branch 'master' into pre-realm-score-tidy
  Dan Balasescu · 2021-12-11 19:25:39 +09:00
  cdb8237a4b
• Move playlist item beatmap population to MatchSubScreen
  Dan Balasescu · 2021-12-10 20:08:59 +09:00
  6057037e35
• Add test coverage of editor resetting mods on entering
  Dean Herbert · 2021-12-10 18:57:33 +09:00
  5e9510be36
• Rename APIScoreInfo to APIScore
  Dean Herbert · 2021-12-10 16:11:49 +09:00
  bff02bedbf
• Use OnlineID for set operations
  Dean Herbert · 2021-12-10 16:11:48 +09:00
  dbb08f7d46
• Use OnlineID instead of legacy IDs for equality and lookups
  Dean Herbert · 2021-12-10 16:11:48 +09:00
  bf1418bafc
• Avoid touching ScoreInfo.User directly
  Dean Herbert · 2021-12-10 15:39:29 +09:00
  261847bbec