1038 Commits

• Fix possible IndexOutOfRangeException
  Pasi4K5 · 2023-08-16 01:19:41 +02:00
  58bffa13cd
• Replace .Distinct() with truncateEndingDuplicates()
  Pasi4K5 · 2023-08-16 01:14:25 +02:00
  e7e0c49f42
• Improve code readability and add assertion to test scene
  Pasi4K5 · 2023-08-15 23:27:12 +02:00
  6346872c39
• Code cleanup
  Pasi4K5 · 2023-08-14 21:56:08 +02:00
  449bee98cc
• Remove unnecessary circle arc approximation
  Pasi4K5 · 2023-08-14 21:09:58 +02:00
  19c8b74a47
• Fix IndexOutOfRangeException when trying to reverse a zero-length slider
  Pasi4K5 · 2023-08-14 14:09:08 +02:00
  55ac942e7a
• Fix linear sliders sometimes being reversed incorrectly

  Extract control point reversing to separate method

  Pasi4K5 · 2023-08-14 14:08:02 +02:00
  f42b3603b3
• Fix sliders being reversed incorrectly in the editor.
  Pasi4K5 · 2023-08-12 20:30:48 +02:00
  8912a0e91e
• Fix DrawableHitObject state not synchronizing with hitobject edits
  OliBomby · 2023-08-11 22:34:04 +02:00
  d2f5e696e7
• Merge branch 'master' into edit-nodesample
  Dean Herbert · 2023-07-31 14:06:38 +09:00
  f06b203067
• Merge remote-tracking branch 'upstream/master' into legacy-export
  OliBomby · 2023-07-18 12:18:49 +02:00
  5d82190b70
• legacy export broken
  OliBomby · 2023-07-11 02:30:16 +02:00
  06e5ef88c0
• Fix GenerateTicks being lost during osu! beatmap conversion process
  Bartłomiej Dach · 2023-07-08 23:24:38 +02:00
  56a2ba4ac0
• Replace various local implementations of rewinding checks with new property
  Dean Herbert · 2023-07-07 15:21:24 +09:00
  e0fc97bb93
• Fix fallback for Judged to be more correct

  Without this change, when the `Judged` value is checked on an
  `HitObjectLifetimeEntry` it would return `true` if a `DrawableHitObject`
  has not yet been associated with the entry. Which is completely wrong.
  
  Of note, the usage in `DrawableHitObject` will have never fallen through
  to this incorrect value as they always have a result populated:
  
  https://github.com/ppy/osu/blob/f26f001e1d01ca6bb53225da7bf06c0ad21153c5/osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs#L721-L726

  Dean Herbert · 2023-07-05 18:03:58 +09:00
  3f8dfc7cb0
• Redirect judgement-related flags from DHO to HOLE
  Bartłomiej Dach · 2023-07-04 23:45:08 +02:00
  6c4e52821d
• Ensure synthetic entries from non-pooled DHO are linked to parents
  Bartłomiej Dach · 2023-07-04 23:45:08 +02:00
  0ceaf3c451
• Redirect HitObjectEntryManager child mapping to HOLE
  Bartłomiej Dach · 2023-07-04 23:41:06 +02:00
  bae7670855
• Add HitObjectLifetimeEntry.NestedEntries
  Bartłomiej Dach · 2023-07-04 23:39:56 +02:00
  6dc8c7b617
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Remove redundant nullable suppression directives
  Salman Ahmed · 2023-06-07 08:20:41 +03:00
  62cb6a98ca
• Adjust CreateHitSampleInfo to handle additions correctly, rather than implementing locally
  Dean Herbert · 2023-05-30 14:04:02 +09:00
  114f12a790
• Merge pull request #23582 from peppy/placement-blueprint-timeline-combo-fixes

  Fix timeline blueprint display not showing correct combo number / colour during placement

  Bartłomiej Dach · 2023-05-20 15:02:55 +02:00
  afdddb0195
• Move combo information updating to an interface level helper method
  Dean Herbert · 2023-05-17 17:26:19 +09:00
  8d925c8a8a
• Fix weird optional usage in HitSampleInfo.With
  Dean Herbert · 2023-05-17 14:11:52 +09:00
  510ebe1f23
• Rename GetSampleInfo to better describe what method does

  Also add full xmldoc

  Dean Herbert · 2023-05-17 14:07:48 +09:00
  dc51d5ecf3
• Fix bank not correctly being assigned when adding sample additions in editor
  Dean Herbert · 2023-05-16 18:52:52 +09:00
  d9ae822966
• Make HitSampleInfo.Bank non-nullable
  Dean Herbert · 2023-05-16 18:12:56 +09:00
  83dcd78826
• Add an IAnimationTimeReference to DrawableHitObject to synchronise all animations
  Dean Herbert · 2023-05-08 18:56:29 +09:00
  64498e95a4
• Fix one incorrect namespace syntax file
  Dean Herbert · 2023-05-05 21:15:26 +09:00
  490df8073c
• Fix comment 2 osu.Game/Rulesets/Objects/Types/IHasGenerateTicks.cs

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  OliBomby · 2023-05-02 08:41:47 +02:00
  2e018c8b06
• Fix comment 1 osu.Game/Rulesets/Objects/Types/IHasGenerateTicks.cs

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  OliBomby · 2023-05-02 08:41:30 +02:00
  c2ad8c2320
• add sample info to Banana and SpinnerBonusTick
  OliBomby · 2023-05-01 14:54:06 +02:00
  27cfadca16
• fix sample of drumroll ticks being bankless
  OliBomby · 2023-04-29 23:52:24 +02:00
  92efd04f31
• fix legacy parser incorrectly assigning sample info for sliders
  OliBomby · 2023-04-29 23:51:49 +02:00
  ffcc8e91b2
• removed all usage of hitobject's DifficultyControlPoint
  OliBomby · 2023-04-26 18:17:02 +02:00
  354cd23874
• remove all regular usage of DifficultyControlPoint
  OliBomby · 2023-04-26 17:55:38 +02:00
  c44f71a737
• remove all test usages of SampleControlPoint
  OliBomby · 2023-04-26 14:21:52 +02:00
  c6fc180659
• Remove IContext & add IHasGenerateTicks
  OliBomby · 2023-04-26 13:10:57 +02:00
  6c70948681
• Invoke ApplyDefaultsToSelf
  OliBomby · 2023-04-26 11:46:05 +02:00
  e27c4dfa10
• fix implementations of IHasSliderVelocity
  OliBomby · 2023-04-25 18:22:22 +02:00
  66eda40cdf
• Fixed DifficultyPointPiece
  OliBomby · 2023-04-25 18:12:53 +02:00
  065464d90c
• remove other usages of hitobject SampleControlPoint
  OliBomby · 2023-04-25 16:01:43 +02:00
  ebe1d852f5
• remove unused directives
  OliBomby · 2023-04-25 13:06:37 +02:00
  97910d6be6
• remove ApplyLegacyInfo method
  OliBomby · 2023-04-25 12:52:21 +02:00
  891b87a5ff
• Add LegacyContext
  OliBomby · 2023-04-25 12:12:46 +02:00
  ea1e6e9798
• made the SampleControlPoint and DifficultyControlPoint obsolete
  OliBomby · 2023-04-25 11:34:09 +02:00
  a4c6850ab2
• Invoke RevertResult on parent DHO when nested DHO is reverted

  The behaviour described above was removed in
  812a4b412a, thus henceforth
  contradicting `RevertResult`'s xmldoc. As it is relied on by some
  external rulesets, bring it back to unbreak them.

  Bartłomiej Dach · 2023-04-11 18:29:08 +02:00
  db86ced4b4
• Move OmitFirstBarLine to TimingControlPoint
  Dean Herbert · 2023-02-28 19:29:31 +09:00
  044b0604b2