h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 20:13:21 +08:00
Code Issues Releases Wiki Activity

Fix fallback for Judged to be more correct

Browse Source 
Without this change, when the `Judged` value is checked on an
`HitObjectLifetimeEntry` it would return `true` if a `DrawableHitObject`
has not yet been associated with the entry. Which is completely wrong.

Of note, the usage in `DrawableHitObject` will have never fallen through
to this incorrect value as they always have a result populated:

f26f001e1d/osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs (L721-L726)
This commit is contained in:
Dean Herbert 2023-07-05 18:02:03 +09:00
parent 674ade0c24
commit 3f8dfc7cb0
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs
View File

@ -112,12 +112,12 @@ namespace osu.Game.Rulesets.Objects.Drawables
/// Whether this <see cref="DrawableHitObject"/> has been judged.
/// Note: This does NOT include nested hitobjects.
/// </summary>
public bool Judged => Entry?.Judged ?? true;
public bool Judged => Entry?.Judged ?? false;
/// <summary>
/// Whether this <see cref="DrawableHitObject"/> and all of its nested <see cref="DrawableHitObject"/>s have been judged.
/// </summary>
public bool AllJudged => Entry?.AllJudged ?? true;
public bool AllJudged => Entry?.AllJudged ?? false;
/// <summary>
/// The relative X position of this hit object for sample playback balance adjustment.

2
osu.Game/Rulesets/Objects/HitObjectLifetimeEntry.cs
View File

@ -36,7 +36,7 @@ namespace osu.Game.Rulesets.Objects
/// Whether <see cref="HitObject"/> has been judged.
/// Note: This does NOT include nested hitobjects.
/// </summary>
public bool Judged => Result?.HasResult ?? true;
public bool Judged => Result?.HasResult ?? false;
/// <summary>
/// Whether <see cref="HitObject"/> and all of its nested objects have been judged.