408 Commits

• Fix editor player sometimes crashing because of instantiating wrong judgement result type for object

  Closes https://github.com/ppy/osu/issues/33231.
  
  I'm not sure how to reproduce the instances of this reported to sentry
  with `Drawable{Slider,Spinner}`, but this bug is about to be made worse
  by `DrawableHoldNote` in mania getting its own `JudgementResult` subtype
  in https://github.com/ppy/osu/pull/33194 - for that one to reproduce
  just start gameplay test while editor is seeked to a time instant where
  a hold note is mid-hold.
  
  There's possibly an argument here that `CreateResult()` should live on
  `HitObject` and not `DrawableHitObject`, and I'd even be partial to such
  an argument, but doing that would be a rather hard ruleset API break
  (albeit trivial one to resolve), and also may dredge up past
  conversations about `Judgement` and `JudgementResult` (cf.
  https://github.com/ppy/osu/pull/26563) that I would rather not get into
  again.
  
  Notably this is not source-breaking for rulesets. It may be
  binary-breaking, I haven't tested.

  Bartłomiej Dach · 2025-05-22 10:20:39 +02:00
  70c6ddbe30
• Remove obsoleted overload of ApplyResult
  Dean Herbert · 2025-04-08 15:47:30 +09:00
  5d572e1ab2
• Remove left-over scheduling thing
  Dean Herbert · 2025-04-03 16:17:29 +09:00
  b471750812
• Avoid large sample depool overhead on drawable hitobjects with many nested objects

  Closes https://github.com/ppy/osu/issues/32588.

  Dean Herbert · 2025-03-26 18:45:12 +09:00
  78de898f7f
• Adjust behaviour of hit animations toggle to match user expectations
  Bartłomiej Dach · 2024-06-20 13:42:32 +02:00
  ad2cd0ba8f
• Revert "Temporary rollback of framework / SDL3"

  This reverts commit d7d569cf4e.

  Dean Herbert · 2024-05-22 16:29:39 +08:00
  d0b1ebff5a
• Temporary rollback of framework / SDL3
  Dean Herbert · 2024-05-21 14:36:16 +08:00
  d7d569cf4e
• Apply required changes after framework masking updates
  Dan Balasescu · 2024-05-09 20:18:53 +09:00
  3b8b56cbcb
• Reduce allocations in DrawableSpinner
  Andrei Zavatski · 2024-02-24 20:18:30 +03:00
  1fb19e7129
• Cache created judgement in HitObject
  Andrei Zavatski · 2024-02-09 23:20:31 +03:00
  c500264306
• Merge branch 'master' into hit-object-result-allocations
  Bartłomiej Dach · 2024-02-05 13:24:10 +01:00
  39fe078984
• Improve xmldoc of state param
  Bartłomiej Dach · 2024-02-05 13:22:58 +01:00
  2976f225e0
• Refactor result application around again to remove requirement for fields

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-02-05 13:21:01 +01:00
  efe6bb25b1
• Update R# + fix inspections
  Dan Balasescu · 2024-02-02 21:00:28 +09:00
  b44f77cee1
• Clean up DrawableHitObject events on Dispose

  This is just general safeties to avoid cases where
  components don't correctly unbind events.

  Dean Herbert · 2024-01-29 15:28:20 +09:00
  de32e7815b
• Add note about using static callback
  Dean Herbert · 2024-01-26 16:21:48 +09:00
  347e88f597
• update DrawableHitCircle.ApplyResult to pass this to its callback
  Chandler Stowell · 2024-01-25 11:25:41 -05:00
  93bd3ce5ae
• use stack to pass action state when applying hit results

  this removes closure allocations

  Chandler Stowell · 2024-01-24 13:13:45 -05:00
  d2775680e6
• Reduce precision of audio balance adjustments during slider sliding
  Dean Herbert · 2024-01-05 02:26:30 +09:00
  e9289cfbe7
• Use better fallback

  Seems better to use the rate from a non-gameplay clock than to arbitrarily apply 1.

  Poyo · 2023-11-21 15:18:04 -08:00
  0cf925dadf
• Use rate fallback in DrawableHitObject
  Poyo · 2023-11-18 12:09:37 -08:00
  d9cd546377
• Allow GameplayRate to be nullable and assert before use
  Poyo · 2023-11-15 17:00:35 -08:00
  a73c870712
• Use soft-cast to access IGameplayClock
  Poyo · 2023-11-14 13:51:55 -08:00
  f5e1734de9
• Allow gameplayClock to be null
  Poyo · 2023-11-12 13:29:40 -08:00
  f794d4dc83
• Use IGameplayClock for rate
  Poyo · 2023-11-12 12:14:19 -08:00
  e67725f5d6
• Calculate unstable rate using rate-adjusted offsets
  Poyo · 2023-11-10 19:57:44 -08:00
  064857c40b
• Enforce minimum gameplay sample volume of 5%
  Bartłomiej Dach · 2023-10-20 15:50:13 +02:00
  b321d556b6
• Move validation to DHO.ApplyResult()
  Dan Balasescu · 2023-10-10 21:42:37 +09:00
  a1a46e58fc
• Reword comment to be better
  Bartłomiej Dach · 2023-08-22 09:37:54 +02:00
  5be5335784
• Update inline comments
  OliBomby · 2023-08-21 13:09:31 +02:00
  e283aa2843
• Fix DrawableHitObject state not synchronizing with hitobject edits
  OliBomby · 2023-08-11 22:34:04 +02:00
  d2f5e696e7
• Replace various local implementations of rewinding checks with new property
  Dean Herbert · 2023-07-07 15:21:24 +09:00
  e0fc97bb93
• Fix fallback for Judged to be more correct

  Without this change, when the `Judged` value is checked on an
  `HitObjectLifetimeEntry` it would return `true` if a `DrawableHitObject`
  has not yet been associated with the entry. Which is completely wrong.
  
  Of note, the usage in `DrawableHitObject` will have never fallen through
  to this incorrect value as they always have a result populated:
  
  https://github.com/ppy/osu/blob/f26f001e1d01ca6bb53225da7bf06c0ad21153c5/osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs#L721-L726

  Dean Herbert · 2023-07-05 18:03:58 +09:00
  3f8dfc7cb0
• Redirect judgement-related flags from DHO to HOLE
  Bartłomiej Dach · 2023-07-04 23:45:08 +02:00
  6c4e52821d
• Ensure synthetic entries from non-pooled DHO are linked to parents
  Bartłomiej Dach · 2023-07-04 23:45:08 +02:00
  0ceaf3c451
• Add an IAnimationTimeReference to DrawableHitObject to synchronise all animations
  Dean Herbert · 2023-05-08 18:56:29 +09:00
  64498e95a4
• remove other usages of hitobject SampleControlPoint
  OliBomby · 2023-04-25 16:01:43 +02:00
  ebe1d852f5
• Invoke RevertResult on parent DHO when nested DHO is reverted

  The behaviour described above was removed in
  812a4b412a, thus henceforth
  contradicting `RevertResult`'s xmldoc. As it is relied on by some
  external rulesets, bring it back to unbreak them.

  Bartłomiej Dach · 2023-04-11 18:29:08 +02:00
  db86ced4b4
• Merge branch 'master' into revert-result-in-playfield
  Bartłomiej Dach · 2023-02-16 21:54:29 +01:00
  3ee046000e
• Merge branch 'master' into maximum-judgement-offset-in-hit-object
  Dean Herbert · 2023-02-15 14:48:15 +09:00
  da8ab7143b
• Move taiko-specific property out of DrawableHitObject
  Dean Herbert · 2023-02-12 16:09:28 +09:00
  9d09141ab7
• Change snapping to only apply to classic mod
  Dean Herbert · 2023-02-09 18:22:14 +09:00
  34d1890f1c
• Store RawTime in JudgementResult
  ekrctb · 2023-02-09 17:15:37 +09:00
  258de3b2d8
• Merge branch 'maximum-judgement-offset-in-hit-object' into revert-result-in-playfield
  ekrctb · 2023-02-09 16:47:58 +09:00
  5f0636c330
• Refactor SkinnableSound.Samples to be non-nullable
  Dean Herbert · 2023-01-27 19:32:30 +09:00
  74ab036f3e
• Store Result.TimeAbsolute separately from offset

  Calculating from TimeOffset is bad because it loses precision.
  The result time won't change anymore
  even If `HitObject.GetEndTime()` changes later.

  ekrctb · 2023-01-24 15:35:06 +09:00
  efef97d5be
• Move MaximumJudgementOffset to HitObject

  We want to access this property for computing lifetime

  ekrctb · 2023-01-19 21:23:55 +09:00
  11e1b22bf5
• Move judgement result revert logic to Playfield

  Previously, some judgement results were not reverted
  when the source DHO is not alive (e.g. frames skipped in editor).
  Now, all results are reverted in the exact reverse order.

  ekrctb · 2023-01-19 19:57:13 +09:00
  812a4b412a
• Use new ArgumentNullException.ThrowIfNull throw-helper API
  Berkan Diler · 2022-12-22 21:27:59 +01:00
  08d2fbeb8e
• Rename method
  Bartłomiej Dach · 2022-11-30 22:54:14 +01:00
  2e19e93036