150 Commits

• Apply code feedback and also resize catcher trails when any is shown
  Darius Wattimena · 2024-10-24 23:17:47 +02:00
  5e642cbce7
• Fix an issue where changing the CircleSize wouldn't adjust the catcher size and represent hyperdashes incorrectly
  Darius Wattimena · 2024-10-15 21:47:22 +02:00
  b75437ee13
• Fix fruit positions getting mangled when exploded
  Dan Balasescu · 2024-08-13 18:42:09 +09:00
  fbfe3a4887
• Remove behaviour of flipping catcher plate on direction change
  Salman Ahmed · 2024-02-14 07:17:05 +03:00
  02de9122d4
• Prioritise hyperfruit over non-hyperfruit if simultaneous

  In case of simultaneous hyperfruit and non-hyperfruit - which happen to
  occur on some aspire maps - the desired behaviour is to hyperdash. This
  did not previously occur, due to annoying details in how
  `HitObjectContainer` is structured.
  
  `HitObjectContainer`'s drawable comparer determines the order of
  updating the objects. One could say that forcing the hyperfruit to be
  updated last, after normal fruit, could help; unfortunately this is
  complicated by the existence of juice streams and the fact that while a
  juice stream can be terminated by a normal fruit that is coincidental
  with a hyperfruit, the two are not comparable directly using the
  comparer in any feasible way.
  
  Therefore, apply a `Catcher`-level workaround that intends to handle
  this locally; in short, if a hyperdash was toggled in a given frame, it
  cannot be toggled off again in the same frame. This yields the desired
  behaviour.

  Bartłomiej Dach · 2023-12-04 09:30:18 +01:00
  fcb6f40666
• Move helper method to LegacyRulesetExtensions and stop applying rounding allowance to catch

  As discussed, it isn't used in stable like this. Was a mistake.

  Dean Herbert · 2023-10-20 18:57:14 +09:00
  3fb74cb5f9
• Fix Catcher code change not accounting for double sizing requirement
  Dean Herbert · 2023-10-18 23:56:17 +09:00
  42087037ae
• Centralise and repair circle size calculations game-wide
  Dean Herbert · 2023-10-18 19:50:42 +09:00
  3a5490892c
• Add brief explaination of BASE_SIZE
  Salman Ahmed · 2023-10-10 01:26:59 +03:00
  fed0deac02
• fixed missed bit and comments
  Terochi · 2023-04-22 10:54:50 +02:00
  bb1ed387ef
• fix
  Terochi · 2023-04-21 22:44:31 +02:00
  847b63066b
• Fix circle-size based scale being applied twice to caught fruit

  Closes #22968.

  Dean Herbert · 2023-03-29 18:03:22 +09:00
  836c884aae
• Move judgement result revert logic to Playfield

  Previously, some judgement results were not reverted
  when the source DHO is not alive (e.g. frames skipped in editor).
  Now, all results are reverted in the exact reverse order.

  ekrctb · 2023-01-19 19:57:13 +09:00
  812a4b412a
• Remove #nullable disable from Catch.UI
  ekrctb · 2023-01-15 17:29:35 +09:00
  b88091262d
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Update Remove/RemoveRange/RemoveAll calls in line with framework changes
  Dean Herbert · 2022-08-29 15:57:40 +09:00
  a215d009fe
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Moved the logic to the bottom as placeCaughtObject is otherwise not called yet
  Darius Wattimena · 2021-11-18 20:24:40 +01:00
  38edeac710
• Moved clear plate logic to Catcher class
  Darius Wattimena · 2021-11-18 20:03:41 +01:00
  95891bc655
• Merge branch 'master' into var-inspections-update
  Dan Balasescu · 2021-10-27 14:02:49 +09:00
  cab254dc81
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Don't assume catcher dash speed is 2x the walk speed
  ekrctb · 2021-10-26 20:09:48 +09:00
  e5050b90a5
• Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
  Dean Herbert · 2021-10-01 16:55:50 +09:00
  a92d499d7a
• Reorder constructor arguments for HitExplosionEntry
  Bartłomiej Dach · 2021-08-12 21:48:08 +02:00
  e79150d4da
• Add legacy hit lighting implementation
  Bartłomiej Dach · 2021-08-11 21:23:33 +02:00
  8c8a64fe6e
• Store judgement directly in hit explosion entry
  Bartłomiej Dach · 2021-08-11 21:23:33 +02:00
  95a58ca366
• Replace "end glow" terminology with "hyper-dash after-image"

  Because the is "end glow" is when a hyper-dash is *started*, the name was confusing.
  The "after-image" was already used in the code as a synonym of "end glow" inconsistently.

  ekrctb · 2021-07-28 19:11:22 +09:00
  a960a28d06
• Merge pull request #14024 from ekrctb/trail-generation

  Move catcher trail generation logic to `CatcherArea` to remove mutual dependency of `Catcher` and `CatcherTrailDisplay`

  Dean Herbert · 2021-07-28 19:06:44 +09:00
  2b107d624a
• Move catcher trail generation logic to CatcherArea
  ekrctb · 2021-07-27 19:07:37 +09:00
  da69867fd4
• Move catcher trail colouring logic to CatcherTrailDisplay
  ekrctb · 2021-07-27 19:07:37 +09:00
  de68fd12b3
• Remove outdated comment and simplify code
  ekrctb · 2021-07-26 18:18:24 +09:00
  8045534fa5
• Make Catcher.body private as it is no longer needed by CatcherTrailDisplay
  ekrctb · 2021-07-26 17:58:34 +09:00
  4282442278
• Add some comments
  ekrctb · 2021-07-26 17:58:34 +09:00
  c08130398c
• Move catcher trail generation logic to Catcher

  It resolves mutual dependency of `Catcher` and `CatcherTrailDisplay`.
  Trail generation logic is moved to `Catcher`.
  The generation logic no longer uses delayed scheduling because the hidden state is hard to manage.
  Instead, the last time a trail is generated is calculated and used.
  The new logic has a different behavior when the dash key is pressed in succession under 50ms, but it is not noticeable for normal plays.

  ekrctb · 2021-07-26 17:51:59 +09:00
  bb046fa3b8
• Move catcher base size constant to Catcher.
  ekrctb · 2021-07-21 16:43:24 +09:00
  d9f9ad35be
• Add [NotNull]
  ekrctb · 2021-07-19 20:20:10 +09:00
  41169fbdaf
• Pass DroppedObjectContainer via constructor instead of DI

  It is now just one level deep, so it is not beneficial to use DI here.
  This effectively reverts ae09c23e.

  ekrctb · 2021-07-19 20:11:49 +09:00
  b88ee3c1a1
• Merge pull request #13747 from ekrctb/catcher-flip

  Don't flip catcher plate contents when catcher changes direction

  Dean Herbert · 2021-07-06 00:02:23 +09:00
  01961fe4f9
• Don't flip catcher plate contents in legacy skin
  ekrctb · 2021-07-02 23:23:21 +09:00
  83c80291d4
• Decouple direction of catcher from its scale
  ekrctb · 2021-07-02 23:22:39 +09:00
  fbba32647e
• Move caught object stack vertical offset logic
  ekrctb · 2021-07-02 20:43:47 +09:00
  170513568b
• Resolve DroppedObjectContainer via DI
  ekrctb · 2021-06-24 16:09:13 +09:00
  ae09c23e4e
• Add DroppedObjectContainer class
  ekrctb · 2021-06-24 15:51:54 +09:00
  16d5893535
• Remove CurrentTexture from catcher
  ekrctb · 2021-06-14 20:26:33 +09:00
  df16d4bacc
• Factor out SkinnableDrawable component of the catcher to SkinnableCatcher
  ekrctb · 2021-06-14 19:41:51 +09:00
  ca061c4b93
• Move catcher movement logic of Catcher to CatcherArea
  ekrctb · 2021-06-11 15:39:06 +09:00
  7f7c2c73e0
• Merge pull request #13379 from ekrctb/catcher-sprite

  Refactor osu!catch catcher sprite to factor out skinning logic

  Dean Herbert · 2021-06-10 16:52:17 +09:00
  05b46b4743
• ICatcherPiece -> ICatcherSprite
  ekrctb · 2021-06-08 22:10:13 +09:00
  7df971a970
• Make current state bindable protected
  ekrctb · 2021-06-08 22:08:54 +09:00
  194c78f67a