osu-lazer

Merge pull request #27114 from EVAST9919/judgements-rework

Cache created judgement in `HitObject`

Dean Herbert · 2024-02-18 18:07:58 +08:00

4d4d69521f

Adjust xmldoc slightly

Dean Herbert · 2024-02-18 17:54:29 +08:00

9655e8c48a

Reduce allocations during beatmap selection

Andrei Zavatski · 2024-02-17 15:46:38 +03:00

22f5a66c02

Make CreateJudgement public again and add remarks

Andrei Zavatski · 2024-02-16 20:24:02 +03:00

060b01eee8

Cache created judgement in HitObject

Andrei Zavatski · 2024-02-09 23:20:31 +03:00

c500264306

Merge pull request #26694 from chandler14362/hit-object-result-allocations

Avoid closure allocations when applying hit object results

Dan Balasescu · 2024-02-06 17:49:26 +09:00

c18cd65081

Merge branch 'master' into scrolling-alloc

Bartłomiej Dach · 2024-02-05 19:59:47 +01:00

f65449375e

Merge branch 'master' into hit-object-result-allocations

Bartłomiej Dach · 2024-02-05 13:24:10 +01:00

39fe078984

Improve xmldoc of state param

Bartłomiej Dach · 2024-02-05 13:22:58 +01:00

2976f225e0

Refactor result application around again to remove requirement for fields

Co-authored-by: Dean Herbert <pe@ppy.sh>

Bartłomiej Dach · 2024-02-05 13:21:01 +01:00

efe6bb25b1

Use SlimReadOnlyDictionaryWrapper for AliveEntries

Andrei Zavatski · 2024-02-03 19:54:08 +03:00

4aa27482a9

Update R# + fix inspections

Dan Balasescu · 2024-02-02 21:00:28 +09:00

b44f77cee1

Expose as ReadOnlyDictionary

Dan Balasescu · 2024-01-31 22:52:57 +09:00

0642d74014

Make AliveDrawableMap public

Andrei Zavatski · 2024-01-31 07:54:07 +03:00

3aefc91967

Clean up DrawableHitObject events on Dispose

This is just general safeties to avoid cases where
components don't correctly unbind events.

Dean Herbert · 2024-01-29 15:28:20 +09:00

de32e7815b

Add note about using static callback

Dean Herbert · 2024-01-26 16:21:48 +09:00

347e88f597

update DrawableHitCircle.ApplyResult to pass this to its callback

Chandler Stowell · 2024-01-25 11:25:41 -05:00

93bd3ce5ae

use stack to pass action state when applying hit results

this removes closure allocations

Chandler Stowell · 2024-01-24 13:13:45 -05:00

d2775680e6

Fix FollowPointConnection pool filling up when follow points are hidden

Closes https://github.com/ppy/osu/issues/26642.

I think this applied to all pooling cases here.

Dean Herbert · 2024-01-21 10:31:27 +09:00

1999e772f6

Fix incorrect score conversion on selected beatmaps due to incorrect difficultyPeppyStars rounding

Fixes issue that occurs on *about* 246 beatmaps and was first described
by me on discord:

    https://discord.com/channels/188630481301012481/188630652340404224/1154367700378865715

and then rediscovered again during work on
https://github.com/ppy/osu/pull/26405:

    https://gist.github.com/bdach/414d5289f65b0399fa8f9732245a4f7c#venenog-on-ultmate-end-by-blacky-overdose-631

It so happens that in stable, due to .NET Framework internals, float
math would be performed using x87 registers and opcodes.
.NET (Core) however uses SSE instructions on 32- and 64-bit words.
x87 registers are _80 bits_ wide. Which is notably wider than _both_
float and double. Therefore, on a significant number of beatmaps,
the rounding would not produce correct values due to insufficient
precision.

See following gist for corroboration of the above:

    https://gist.github.com/bdach/dcde58d5a3607b0408faa3aa2b67bf10

Thus, to crudely - but, seemingly accurately, after checking across
all ranked maps - emulate this, use `decimal`, which is slow, but has
bigger precision than `double`. The single known exception beatmap
in whose case this results in an incorrect result is

    https://osu.ppy.sh/beatmapsets/1156087#osu/2625853

which is considered an "acceptable casualty" of sorts.

Doing this requires some fooling of the compiler / runtime (see second
inline comment in new method). To corroborate that this is required,
you can try the following code snippet:

    Console.WriteLine(string.Join(' ', BitConverter.GetBytes(1.3f).Select(x => x.ToString("X2"))));
    Console.WriteLine(string.Join(' ', BitConverter.GetBytes(1.3).Select(x => x.ToString("X2"))));
    Console.WriteLine();

    decimal d1 = (decimal)1.3f;
    decimal d2 = (decimal)1.3;
    decimal d3 = (decimal)(double)1.3f;

    Console.WriteLine(string.Join(' ', decimal.GetBits(d1).SelectMany(BitConverter.GetBytes).Select(x => x.ToString("X2"))));
    Console.WriteLine(string.Join(' ', decimal.GetBits(d2).SelectMany(BitConverter.GetBytes).Select(x => x.ToString("X2"))));
    Console.WriteLine(string.Join(' ', decimal.GetBits(d3).SelectMany(BitConverter.GetBytes).Select(x => x.ToString("X2"))));

which will print

    66 66 A6 3F
    CD CC CC CC CC CC F4 3F

    0D 00 00 00 00 00 00 00 00 00 00 00 00 00 01 00
    0D 00 00 00 00 00 00 00 00 00 00 00 00 00 01 00
    8C 5D 89 FB 3B 76 00 00 00 00 00 00 00 00 0E 00

Note that despite `d1` being converted from a less-precise floating-
-point value than `d2`, it still is represented 100% accurately as
a decimal number.

After applying this change, recomputation of legacy scoring attributes
for *all* rulesets will be required.

Bartłomiej Dach · 2024-01-10 19:30:18 +01:00

7c9adc7ad3

Reduce precision of audio balance adjustments during slider sliding

Dean Herbert · 2024-01-05 02:26:30 +09:00

e9289cfbe7

fix near-zero length sliders n stuff being placeable

OliBomby · 2023-12-19 21:20:21 +01:00

ec578e1d9f

Fix handling of combo offset without new combo, and incorrect lazer tests

Dan Balasescu · 2023-11-24 09:46:06 +09:00

10e16e4b04

Merge branch 'master' into fix-combo-handling

Dan Balasescu · 2023-11-23 16:22:01 +09:00

7bc2d6e6cd

Fix combo/combo colouring issues around spinners

Dan Balasescu · 2023-11-23 13:54:05 +09:00

7998204cfe

Merge pull request #25415 from Poyo-SSB-forks/unify-ur

Change unstable rate calculation to account for rate-change mods

Dan Balasescu · 2023-11-23 09:53:28 +09:00

30309cdf11

Fix first object after break not starting a new combo

Dan Balasescu · 2023-11-22 17:22:48 +09:00

cb4568c4a1

Improve commenting around IHasCombo interfaces

Following discusion with smoogi IRL.

Dean Herbert · 2023-11-22 10:44:29 +09:00

04640b6fb0

Use better fallback

Seems better to use the rate from a non-gameplay clock than to arbitrarily apply 1.

Poyo · 2023-11-21 15:18:04 -08:00

0cf925dadf

Add ToString on PathType for better test output

Dean Herbert · 2023-11-21 15:38:12 +09:00

4b2d8aa6a6

Fix incorrect parsing of BSpline curve types

Dean Herbert · 2023-11-21 15:38:12 +09:00

3d094f84ad

Adjust casing of curve type menu items

The "Perfect curve" one in particular... fixes test failures, as some
tests were relying on this particular casing. But the new version feels
more correct anyway, so it's whatever.

Bartłomiej Dach · 2023-11-20 15:42:55 +09:00

8e39dbbff1

Fix incorrect legacy conversion when B-splines are used

Bartłomiej Dach · 2023-11-20 15:08:58 +09:00

6d7d826b8b

Use static BEZIER instead of allocating new every time

Bartłomiej Dach · 2023-11-20 13:35:07 +09:00

80a3225bb2

Remove pattern matching syntax usage in switch