65868 Commits

This Branch

This Branch

All Branches

• Merge branch 'master' into hitposition
  cdwcgt · 2024-02-20 19:36:32 +09:00
  098ade2cfa
• Remove dependencies on ScoreProcesser
  cdwcgt · 2024-02-20 19:34:45 +09:00
  0b5251fcf4
• Merge pull request #27249 from EVAST9919/editor-alloc

  Reduce osu editor allocations with many objects selected

  Dean Herbert · 2024-02-20 15:06:25 +08:00
  ef413c08f1
• Merge pull request #27258 from Loreos7/storage-error-localisation

  Localise storage error popup dialog

  Dean Herbert · 2024-02-20 13:37:10 +08:00
  3ea47e64f0
• Reduce allocations in HitCircleOverlapMarker
  Andrei Zavatski · 2024-02-19 20:55:43 +03:00
  3791ab30c4
• Reduce allocations in ComposerDistanceSnapProvider
  Andrei Zavatski · 2024-02-19 20:49:56 +03:00
  c758640311
• Reduce allocations in SliderSelectionBlueprint
  Andrei Zavatski · 2024-02-19 20:26:15 +03:00
  29900353d9
• Merge pull request #27243 from myQwil/beatmap_offset_virtual

  Change `userBeatmapOffsetClock` to a `FramedOffsetClock`

  Dean Herbert · 2024-02-20 01:06:01 +08:00
  fc34c5a505
• Change userBeatmapOffsetClock to a FramedOffsetClock

  Assuming that the global audio offset is set perfectly, such that
  any audio latency is fully accounted for, if a specific beatmap
  still sounds out of sync, that would no longer be a latency issue.
  
  Instead, it would indicate a misalignment between the beatmap's
  track and time codes, the correction for which should be a
  virtual-time offset, not a real-time offset.

  Mike Will · 2024-02-19 09:14:49 -05:00
  012d6b7fe1
• Merge pull request #27180 from bdach/better-submission-failure-messaging

  Add better submission failure messaging

  Dean Herbert · 2024-02-19 21:38:23 +08:00
  2024.219.0 c87bc8b597
• Use different wording
  Bartłomiej Dach · 2024-02-19 13:56:21 +01:00
  ec26ab51d1
• Merge pull request #27226 from peppy/no-audio-filter-funny-business

  Ensure audio filters can't be attached before load (or post-disposal)

  Bartłomiej Dach · 2024-02-19 13:01:34 +01:00
  d7b1e3ba50
• Merge pull request #27238 from bdach/disable-nested-managers-when-skin-editor-open

  Disable nested input managers on edited screen when skin editor is open

  Dean Herbert · 2024-02-19 19:27:26 +08:00
  398eaee5d0
• Merge pull request #27239 from peppy/fix-cached-beatmap

  Fix `WorkingBeatmapCache` caching beatmap in wrong state leading to crash

  Bartłomiej Dach · 2024-02-19 12:06:45 +01:00
  f5666185ab
• Disable nested input managers on edited screen when skin editor is open
  Bartłomiej Dach · 2024-02-19 10:19:25 +01:00
  1ca566c6b0
• Fix beatmap potentially loading in a bad state

  Over-caching could mean that a beatmap could load and cause a late
  crash. Let's catch it early to avoid such a crash occurring.

  Dean Herbert · 2024-02-19 17:18:07 +08:00
  7f82f10317
• Add failing test coverage
  Bartłomiej Dach · 2024-02-19 09:59:25 +01:00
  444ac5ed4d
• Merge pull request #27224 from peppy/fix-logo-tracking-single-thread

  Fix logo tracking container being behind by one frame

  Salman Ahmed · 2024-02-19 01:20:53 +03:00
  bdf91209b6
• Ensure audio filters can't be attached before load (or post-disposal)

  Will probably fix https://github.com/ppy/osu/issues/27225?

  Dean Herbert · 2024-02-19 00:25:01 +08:00
  998d820666
• Apply NRT to LogoTrackingContainer
  Dean Herbert · 2024-02-18 23:35:26 +08:00
  6b6a6aea54
• Fix logo tracking container being off by one frame

  This was especially visible at the main menu when running in single thread mode.

  Dean Herbert · 2024-02-18 23:19:57 +08:00
  882f11bf79
• Add failing tests for beatmap inconsistencies
  Dean Herbert · 2024-02-18 19:32:21 +08:00
  415a65bf59
• Merge pull request #27114 from EVAST9919/judgements-rework

  Cache created judgement in `HitObject`

  Dean Herbert · 2024-02-18 18:07:58 +08:00
  4d4d69521f
• Adjust xmldoc slightly
  Dean Herbert · 2024-02-18 17:54:29 +08:00
  9655e8c48a
• Merge pull request #27206 from EVAST9919/selection-enumerators

  Reduce allocations during beatmap selection

  Dean Herbert · 2024-02-18 10:02:35 +08:00
  715236765a
• Fix failing tests related to slider ticks
  Andrei Zavatski · 2024-02-17 23:28:35 +03:00
  572f693eec
• Merge pull request #26895 from vmfunc/ordinal-sorting

  Consider case sensitivity when sorting beatmaps in song select

  Dean Herbert · 2024-02-18 04:05:22 +08:00
  6960f87509
• Merge pull request #27199 from EVAST9919/link-compiler-alloc

  Fix `DrawableLinkCompiler` allocations

  Dean Herbert · 2024-02-18 04:04:34 +08:00
  71afb8881a
• Merge pull request #27193 from bdach/fix-not-working-metadata-hub-cleanup

  Fix a few issues in metadata hub's disconnection requested flow

  Dean Herbert · 2024-02-18 03:46:02 +08:00
  520576a0fd
• Revert BeatmapCarousel changes
  Andrei Zavatski · 2024-02-17 22:42:47 +03:00
  dd82de473a
• Remove list allocations in UpdateNestedSamples
  Dean Herbert · 2024-02-18 03:23:34 +08:00
  0df6e8f595
• Revert sample lookup logic that was not allocating anything
  Dean Herbert · 2024-02-18 03:18:50 +08:00
  0714a4fc1e
• Update framework
  Dean Herbert · 2024-02-18 03:11:29 +08:00
  62a7e315bf
• Reduce allocations during beatmap selection
  Andrei Zavatski · 2024-02-17 15:46:38 +03:00
  22f5a66c02
• Merge pull request #27205 from Joehuu/fix-star-counter-animation-above-10

  Fix star counter decrease animation being delayed when current is over displayed star count

  Dean Herbert · 2024-02-17 18:16:48 +08:00
  2adc8b15e7
• Fix star counter decrease animation being delayed when current is over displayed star count
  Joseph Madamba · 2024-02-16 22:47:38 -08:00
  7a74eaa2de
• Move ternary inside Math.Max()
  Joseph Madamba · 2024-02-16 22:47:38 -08:00
  6e8d8b977e
• Add twenty star counter in visual test
  Joseph Madamba · 2024-02-16 22:47:38 -08:00
  8169d1ac80
• Merge pull request #27200 from frenzibyte/fix-cursor-ripple-in-replay

  Fix cursor ripples displaying on release positions in replays

  Dean Herbert · 2024-02-17 14:40:30 +08:00
  5fda3a3091
• Fix cursor ripples being added on release positions in replays
  Salman Ahmed · 2024-02-17 00:53:53 +03:00
  ce903987e7
• Fix DrawableLinkCompiler allocations
  Andrei Zavatski · 2024-02-17 00:45:30 +03:00
  b0f334c39e
• Merge pull request #26951 from myQwil/mute_detection

  Improve silence detection in `MutedNotification`

  Salman Ahmed · 2024-02-16 23:49:54 +03:00
  4bbb1bc67e
• Merge branch 'master' into mute_detection
  Salman Ahmed · 2024-02-16 23:22:57 +03:00
  bbd770687d
• Make CreateJudgement public again and add remarks
  Andrei Zavatski · 2024-02-16 20:24:02 +03:00
  060b01eee8
• Merge branch 'master' into judgements-rework
  Andrei Zavatski · 2024-02-16 20:08:57 +03:00
  dd32c0a226
• Add extended xmldoc to DisconnectRequested()

  Just expounds on what the previous commit message said.

  Bartłomiej Dach · 2024-02-16 13:09:36 +01:00
  1049be7d72
• Do not attempt to stop watching user presence when requested to disconnect

  First of all, this sort of cleanup isn't really the client's
  responsibility, and secondly, at the point the client received this
  request to disconnect, *none of its requests will be honored anymore*
  (currently the only scenario of this if another client has connected
  - the server-side concurrency filter will reject this request).
  
  When disconnection is requested, the only valid thing to do with respect
  to talking to the server is to stop doing it.
  
  This will be moved server-side in a follow-up change, although I'm not
  even strictly sure that's required - I'd like to think signalr would
  know to clean up a disconnecting client from all groups they were in.

  Bartłomiej Dach · 2024-02-16 13:08:39 +01:00
  b4aa247032
• Actually disconnect from metadata hub when requested to

  Nothing in this override, on in the base implementation, would actually
  attempt to disconnect.

  Bartłomiej Dach · 2024-02-16 12:58:50 +01:00
  9fa60b169e
• Fix missing RPC method mapping

  Thanks, signalr.

  Bartłomiej Dach · 2024-02-16 12:58:13 +01:00
  171270d99c
• Always bring master/music volume to 50%
  Salman Ahmed · 2024-02-16 11:20:07 +03:00
  583e71634f