Salman Ahmed
|
24d8e336e2
|
Remove width limit on room status text in favour of cell distribution
|
2023-06-14 07:55:09 +03:00 |
|
Joseph Madamba
|
05bdc92426
|
Add right padding according to right detail shear
|
2023-06-13 14:00:56 -07:00 |
|
Joseph Madamba
|
2a3f2ff122
|
Truncate room name text
|
2023-06-13 13:56:29 -07:00 |
|
Joseph Madamba
|
df49a48d4d
|
Put left and right details inside GridContainer
|
2023-06-13 13:48:47 -07:00 |
|
Joseph Madamba
|
0adb399ea8
|
Use anchor instead of FillFlowContainer
|
2023-06-13 00:09:58 -07:00 |
|
Joseph Madamba
|
a5c3c9a93f
|
Use FillFlowContainer instead of GridContainer for drawable room background gradient
|
2023-06-12 23:30:08 -07:00 |
|
Cootz
|
036479dd9d
|
Merge branch 'master' into add-mod-search-option
|
2023-06-09 16:27:18 +03:00 |
|
Dean Herbert
|
a842f79ad4
|
Refactor IWorkingBeatmap.Background to GetBackground()
|
2023-06-08 16:19:32 +09:00 |
|
Salman Ahmed
|
62cb6a98ca
|
Remove redundant nullable suppression directives
|
2023-06-07 08:20:41 +03:00 |
|
Cootz
|
3ebc801484
|
Move (de)select all mods hotkeys handling to ModSelectOverlay
|
2023-06-05 13:49:07 +03:00 |
|
Bartłomiej Dach
|
a9d4556647
|
Merge branch 'master' into update-multiplayer-room-diff-range
|
2023-06-03 16:50:09 +02:00 |
|
Dean Herbert
|
812def124f
|
Merge pull request #23661 from peppy/fix-multiplayer-present-crash
Fix `OnResume` / `OnSuspending` potentially getting called before `OnEntering` on a sub screen
|
2023-05-31 19:43:30 +09:00 |
|
Bartłomiej Dach
|
62d1774407
|
Apply same comment & reworded condition to suspend too
|
2023-05-30 21:54:56 +02:00 |
|
Dean Herbert
|
741ee84ed6
|
Add comment and use full conditional similar to extension method
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
|
2023-05-30 18:38:28 +09:00 |
|
Dean Herbert
|
1558723420
|
Merge branch 'master' into scorev2
|
2023-05-29 20:06:32 +09:00 |
|
Dean Herbert
|
b3c2d120bf
|
Fix OnResume / OnSuspending potentially getting called before OnEntering on a sub screen
|
2023-05-25 20:39:11 +09:00 |
|
Dean Herbert
|
609c7227ee
|
Fix changes to font weight in a couple of combined implementations
|
2023-05-25 19:55:11 +09:00 |
|
Dan Balasescu
|
c33e4fe75e
|
Remove unnecessary override
|
2023-05-18 20:10:28 +09:00 |
|
Dean Herbert
|
730bc3a961
|
Apply NRT and simplify some remaining code
|
2023-05-17 16:18:13 +09:00 |
|
Dean Herbert
|
e97d027230
|
Make OnlinePlayPill class abstract
|
2023-05-17 16:13:03 +09:00 |
|
timiimit
|
cc6e4df93e
|
Remove wrongly added back namepspace
|
2023-05-16 10:27:46 +02:00 |
|
timiimit
|
4ef74eb3f9
|
Fix RoomStatusPill text colour
|
2023-05-16 10:22:52 +02:00 |
|
timiimit
|
81b7737660
|
Fix text colour of RoomSpecialCategoryPill
|
2023-05-16 10:20:16 +02:00 |
|
timiimit
|
a9991d9dd4
|
Remove another unused namespace
|
2023-05-16 10:14:14 +02:00 |
|
timiimit
|
40daa41a52
|
Fix naming & namespaces
|
2023-05-16 10:06:48 +02:00 |
|
timiimit
|
04893064f0
|
Make used pills inherit from a common one
|
2023-05-16 09:53:11 +02:00 |
|
timiimit
|
10d6f9ea5a
|
Create common online play pill
|
2023-05-16 09:52:26 +02:00 |
|
timiimit
|
fd80ffd52b
|
Fix display update condition
|
2023-05-14 12:09:15 +02:00 |
|
Dan Balasescu
|
3c3c812ed6
|
Initial implementation of ScoreV2
|
2023-05-09 19:33:33 +09:00 |
|
Joseph Madamba
|
3e0bbb2432
|
Fix select beatmap button not highlighting when creating a multiplayer room using keyboard
|
2023-03-26 16:03:21 -07:00 |
|
mk56-spn
|
a6b6fb864e
|
Make carousel non nullable and ensure pre load usages of methods that reference it are protected against failure
|
2023-01-13 13:10:29 +01:00 |
|
mk56-spn
|
403ca05e5e
|
Enable nullability for song select
|
2023-01-13 00:52:14 +01:00 |
|
Dean Herbert
|
54b2fe9df3
|
Merge branch 'master' into fix-op-non-current-onexiting
|
2023-01-09 19:12:42 +09:00 |
|
Joseph Madamba
|
5fb6f220e6
|
Fix playlist items not animating when rearranging
|
2023-01-03 11:10:02 -08:00 |
|
Joseph Madamba
|
5dfd4180c8
|
Fix playlist selecting random item when not allowed after deleting
|
2023-01-03 11:10:02 -08:00 |
|
Joseph Madamba
|
0dba25e0ab
|
Refactor to just exit sub screens until lounge sub screen
Co-Authored-By: Salman Ahmed <frenzibyte@gmail.com>
|
2022-12-25 21:56:22 -08:00 |
|
Joseph Madamba
|
5232588a1f
|
Use PerformFromScreen to exit sub screens instead
|
2022-12-24 20:04:45 -08:00 |
|
Joseph Madamba
|
00ed5d6f92
|
Merge remote-tracking branch 'upstream/master' into fix-op-non-current-onexiting
|
2022-12-24 14:01:11 -08:00 |
|
Dean Herbert
|
4a7d7c6ed9
|
Use MaxBy in all locations that can and update inspection level to match dotnet-build
|
2022-12-19 16:47:10 +09:00 |
|
Dean Herbert
|
27c497145f
|
Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0
|
2022-12-16 18:16:26 +09:00 |
|
Dan Balasescu
|
7b48c91fe2
|
Only show local results in multi-spectator results screen
|
2022-12-12 18:56:43 +09:00 |
|
Bartłomiej Dach
|
894ef15e79
|
Merge branch 'master' into update-framework
|
2022-11-26 16:19:36 +01:00 |
|
Dan Balasescu
|
7bc8908ca9
|
Partial everything
|
2022-11-27 00:00:27 +09:00 |
|
Bartłomiej Dach
|
bbbc1d0428
|
Darken colour of playlists create button
To match d0c4637683.
|
2022-11-25 18:23:28 +01:00 |
|
Dean Herbert
|
d0c4637683
|
Lighten colour of multiplayer create game button
|
2022-11-25 20:18:21 +09:00 |
|
Dean Herbert
|
6ad432b311
|
Use RoundedButton in more places
|
2022-11-24 16:33:01 +09:00 |
|
Dean Herbert
|
53b03df93d
|
Combine TriangleButton and RoundedButton classes
|
2022-11-24 16:26:57 +09:00 |
|
Dean Herbert
|
bea2acc60e
|
Remove local specifications of triangle colouring
|
2022-11-24 16:18:15 +09:00 |
|
Dean Herbert
|
06ce8130c2
|
Apply changes in line with framework NRT updates
|
2022-11-18 18:13:15 +09:00 |
|
maromalo
|
b7ef9b176d
|
Make score type consistent
|
2022-11-06 19:59:27 -03:00 |
|
Dan Balasescu
|
dcb6357964
|
Add ability to remove the current item in multiplayer
|
2022-10-14 20:23:55 +09:00 |
|
Dan Balasescu
|
525f98c158
|
Fix max combo missing from playlists results screen
|
2022-10-14 18:01:54 +09:00 |
|
Dan Balasescu
|
da8d94c4b4
|
Fix test failures due to scheduled operations
|
2022-09-27 20:24:44 +09:00 |
|
Dean Herbert
|
3ece7205ed
|
Fix potential crash when losing network connectivity at online play screen
Addresses #20448.
|
2022-09-27 17:52:34 +09:00 |
|
Dan Balasescu
|
c969afcb71
|
Merge branch 'master' into leaderboard-nrt
|
2022-09-26 17:12:19 +09:00 |
|
Dean Herbert
|
20da1051d9
|
Apply NRT to GameplayLeaderboard hierarchy
Just some cleanup work that I wanted to do as part of my last changes.
|
2022-09-26 16:21:24 +09:00 |
|
Dean Herbert
|
5fc836d1f0
|
Apply NRT to BeatmapLeaderboard / MatchLeaderboard
|
2022-09-26 16:17:28 +09:00 |
|
Dean Herbert
|
a65a76f7de
|
Fix off-thread drawable mutation in multiplayer settings overlay when an error occurs
Closes #20413.
|
2022-09-23 20:05:32 +09:00 |
|
Dean Herbert
|
29c4d06d36
|
Merge branch 'fix-gameplay-leaderboard-layout' into gameplay-leaderboards
|
2022-09-21 14:58:58 +09:00 |
|
Dean Herbert
|
0ac28cbecc
|
Fix potential crash from missing DownloadProgress
|
2022-09-18 23:42:16 +09:00 |
|
Dan Balasescu
|
2dcaf7cfd8
|
Fix memory leak due to missing event unbind
|
2022-09-18 14:25:31 +09:00 |
|
Dean Herbert
|
678eec1c67
|
Move LeaderboardFlow to HUDOverlay to share positioning logic
|
2022-09-13 18:45:11 +09:00 |
|
Dean Herbert
|
5894d2f0bc
|
Ensure gameplay leaderboard hides with rest of HUD when it should
|
2022-09-13 18:45:11 +09:00 |
|
Dean Herbert
|
d251c0b2ac
|
Move leaderboard implementation to Player itself
|
2022-09-13 18:00:21 +09:00 |
|
Dean Herbert
|
ac034bffeb
|
Fix potential crash if multiplayer spectator load is aborted early
|
2022-09-13 14:21:54 +09:00 |
|
Dean Herbert
|
6945c43e0d
|
Merge pull request #20178 from smoogipoo/fix-match-creation-beatmap-select
Fix several weird scenarios with online play song selection
|
2022-09-08 23:07:09 +09:00 |
|
Dan Balasescu
|
9aab502adc
|
Merge pull request #20157 from peppy/true-gameplay-rate
Refactor `TrueGameplayRate` to account for only gameplay adjustments, no matter what
|
2022-09-08 19:54:32 +09:00 |
|
Dan Balasescu
|
4fc03998a1
|
Merge pull request #20189 from peppy/fix-playlist-item-download-button-visibility
Fix playlist items showing download button briefly during initial display
|
2022-09-08 19:47:35 +09:00 |
|
Dean Herbert
|
13d9b2188b
|
Merge pull request #20145 from smoogipoo/multiple-countdowns
Implement support for multiple active countdowns in multiplayer
|
2022-09-08 19:15:30 +09:00 |
|
Dan Balasescu
|
76eae73fa4
|
Revert unintended change
|
2022-09-08 17:41:23 +09:00 |
|
Dan Balasescu
|
c61c596c1f
|
Expose as readonly IAggregateAudioAdjustment
|
2022-09-08 17:37:02 +09:00 |
|
Dan Balasescu
|
b559d4ecdf
|
Rename GameplayAdjustments -> AdjustmentsFromMods
|
2022-09-08 17:14:06 +09:00 |
|
Dean Herbert
|
ed81297611
|
Fix playlist items showing download button briefly during initial local presence checks
|
2022-09-08 17:10:45 +09:00 |
|
Dan Balasescu
|
b0b4da533a
|
Expose gameplay adjustments via MultiSpectatorPlayer instead
|
2022-09-08 16:59:20 +09:00 |
|
Dan Balasescu
|
83c0cb1acc
|
Fix beatmap set to null after exiting song select
|
2022-09-07 21:34:29 +09:00 |
|
Dan Balasescu
|
fcea244537
|
Remove initial selection from OnlinePlaySongSelect
This stuff never really worked anyway - every case except with an
already created multiplayer room was broken anyway.
|
2022-09-07 21:34:29 +09:00 |
|
Dan Balasescu
|
208bd0f391
|
Give OnlinePlaySongSelect a reference PlaylistItem
|
2022-09-07 21:34:29 +09:00 |
|
Dan Balasescu
|
cb9bae1f5c
|
Enable NRT
|
2022-09-07 19:54:55 +09:00 |
|
Dean Herbert
|
1be3b74ff3
|
Fix multiplayer spectator not getting gameplay adjustments applied
|
2022-09-07 19:12:34 +09:00 |
|
Dan Balasescu
|
2923c10cd8
|
Rewrite rooms to store multiple active countdowns
Update test to the new structure
|
2022-09-05 19:03:26 +09:00 |
|
Dan Balasescu
|
07d4a025b0
|
Merge pull request #20109 from frenzibyte/online-play-room-status-inconsistency
Fix room status dropdown placement inconsistent between multiplayer and playlists
|
2022-09-05 11:19:56 +09:00 |
|
Salman Ahmed
|
e8fa872f61
|
Fix room status dropdown position inconsistent on online-play screens
|
2022-09-03 16:14:21 +03:00 |
|
Dean Herbert
|
6a35b233e5
|
Merge branch 'master' into remove-dispose-updates
|
2022-09-01 23:03:19 +09:00 |
|
Dan Balasescu
|
c852c54055
|
Consume auto skip setting during play
|
2022-08-31 20:24:15 +09:00 |
|
Dan Balasescu
|
b5ec7d06dd
|
Add auto-skip setting
Default to auto skip
|
2022-08-31 20:24:06 +09:00 |
|
Dean Herbert
|
a215d009fe
|
Update Remove/RemoveRange/RemoveAll calls in line with framework changes
|
2022-08-29 15:57:40 +09:00 |
|
Dan Balasescu
|
423f6f90f2
|
Remove async calls from ScoreManager
|
2022-08-29 15:34:08 +09:00 |
|
Dan Balasescu
|
c0b13c7e1f
|
Refactor ScoreProcessor ComputeScore() methods
|
2022-08-29 13:51:10 +09:00 |
|
Dean Herbert
|
b9d9bf3004
|
Merge pull request #19938 from frenzibyte/fix-multi-spectator-results-screen
Fix multi-spectator potentially getting stuck for passed players
|
2022-08-26 21:53:17 +09:00 |
|
Dean Herbert
|
a546aa2673
|
Clamp SpectatorPlayerClock's elapsed calculation to avoid player clocks getting too far ahead
|
2022-08-25 21:33:33 +09:00 |
|
Dean Herbert
|
27b57947e4
|
Rename PlayerArea.GameplayClock to SpectatorPlayerClock for clarity
|
2022-08-24 17:13:14 +09:00 |
|
Dean Herbert
|
5f01f461b3
|
Ensure elapsed time is always non-zero when advancing SpectatorPlayerClock
|
2022-08-24 17:13:14 +09:00 |
|
Dean Herbert
|
af56cd0126
|
Fix merge breakage
|
2022-08-24 16:52:36 +09:00 |
|
Dean Herbert
|
5079e0d83d
|
Merge branch 'master' into no-gameplay-clock-gameplay-offset
|
2022-08-24 16:52:10 +09:00 |
|
Salman Ahmed
|
8f4a2b4936
|
Separate passed/failed states from calling EndGameplay
|
2022-08-24 10:36:13 +03:00 |
|
Dean Herbert
|
7f9246637a
|
Simplify MultiSpectatorScreen hierarchy construction
|
2022-08-24 16:08:48 +09:00 |
|
Dean Herbert
|
7c1fc4814e
|
Remove unused CreateMasterGameplayClockContainer method
|
2022-08-24 16:03:38 +09:00 |
|
Dean Herbert
|
871365bbb0
|
Inline ReadyToStart action binding for added safety
|
2022-08-24 16:03:38 +09:00 |
|
Dean Herbert
|
6c50f618a3
|
Don't use bindable flow for masterState
|
2022-08-24 16:03:38 +09:00 |
|
Dean Herbert
|
683d49c608
|
Move MasterClockState handling in to SpectatorSyncManager
|
2022-08-24 16:03:38 +09:00 |
|
Dean Herbert
|
d33d705684
|
Make WaitingOnFrames non-bindable
|
2022-08-24 16:03:38 +09:00 |
|
Dean Herbert
|
d05d8aeb22
|
Simplify interface implementations
|
2022-08-24 16:03:38 +09:00 |
|
Dean Herbert
|
2f5be6efca
|
Tidy up ProcessFrame and privatise const
|
2022-08-24 16:03:38 +09:00 |
|
Dean Herbert
|
b564c34dbc
|
Don't process master clock (is a noop)
|
2022-08-24 16:03:38 +09:00 |
|
Dean Herbert
|
b4eede61fb
|
Use readonly instead of get-only
|
2022-08-24 15:28:18 +09:00 |
|
Dean Herbert
|
0b271fe4b3
|
Fix incorrect IsRunning value
|
2022-08-24 15:27:31 +09:00 |
|
Dean Herbert
|
b6254a1f25
|
Remove unnecessary casting
|
2022-08-24 15:23:31 +09:00 |
|
Dean Herbert
|
a86fc6f248
|
Change running state of SpectatorPlayerClock using IsRunning
|
2022-08-24 15:17:56 +09:00 |
|
Dean Herbert
|
0c9a4ec13c
|
Don't expose MasterClock in SpectatorClockSyncManager
|
2022-08-24 15:13:08 +09:00 |
|
Dean Herbert
|
995e6664b6
|
Rename spectator clock sync classes
|
2022-08-24 15:13:08 +09:00 |
|
Dean Herbert
|
31f657fe01
|
Remove ISpectatorPlayerClock interface
Too many levels of redirection.
One interface with one implementation is not useful, IMO.
|
2022-08-24 15:12:57 +09:00 |
|
Dean Herbert
|
882dd93942
|
Remove ISyncManager interface
Too many levels of redirection.
One interface with one implementation is not useful, IMO.
|
2022-08-24 15:12:57 +09:00 |
|
Dean Herbert
|
22963ab951
|
Fix multiplayer spectator getting stuck
|
2022-08-24 15:12:57 +09:00 |
|
Dean Herbert
|
ec31f37ff7
|
Accept MasterGameplayClockContainer rather than generic clock
|
2022-08-24 14:51:14 +09:00 |
|
Dean Herbert
|
85fbe7abca
|
Fix multiplayer spectator getting stuck
|
2022-08-24 13:11:53 +09:00 |
|
Dean Herbert
|
ec61a94dc9
|
Merge branch 'master' into no-gameplay-clock-gameplay-offset
|
2022-08-23 17:36:06 +09:00 |
|
Dean Herbert
|
553897f2f0
|
Remove AddClock method to CreateManagedClock
|
2022-08-23 13:52:43 +09:00 |
|
Dean Herbert
|
1191b6c080
|
Remove unused Source_Set implementation on ISpectatorPlayerClock
|
2022-08-23 13:44:41 +09:00 |
|
Dan Balasescu
|
c59298f0ce
|
Enable NRT
|
2022-08-22 21:55:04 +09:00 |
|
Dan Balasescu
|
5d3d8681d4
|
Invert creation of clocks in multi spectator
|
2022-08-22 19:14:06 +09:00 |
|
Dean Herbert
|
af2e82d7d5
|
Move operation of setting GameplayClockContainer.StartTime to Reset call
|
2022-08-22 14:11:06 +09:00 |
|
Dean Herbert
|
0e228791c0
|
Remove unnecessary Reset call in MultiSpectatorScreen
|
2022-08-19 01:39:01 +09:00 |
|
Dean Herbert
|
37799e3b31
|
Allow preparing preview point without looping
|
2022-08-17 13:20:24 +09:00 |
|
Dean Herbert
|
6d78218142
|
Update usages of GameplayClockContainer.GameplayClock to access properties directly
|
2022-08-15 18:08:49 +09:00 |
|
Dean Herbert
|
224f3eaa84
|
Make GameplayClockContainer non-abstract and use in MultiSpectatorPlayer
|
2022-08-15 18:08:49 +09:00 |
|
Dan Balasescu
|
41af03dec5
|
Merge pull request #19597 from frenzibyte/hotfix-multi-spectator-results-screen
Fix multi-spectator potentially getting stuck for passed players (hotfix)
|
2022-08-09 21:11:10 +09:00 |
|
Dean Herbert
|
f1691882e2
|
Fix incorrect argument passing to ToMod
|
2022-08-08 12:56:18 +09:00 |
|
Salman Ahmed
|
84ef24c341
|
Fix multi-spectator potentially getting stuck for passed players
|
2022-08-06 05:41:26 +03:00 |
|
Salman Ahmed
|
7e9d11ee24
|
Enable NRT on playlists settings overlay
|
2022-08-01 20:15:08 +03:00 |
|
Salman Ahmed
|
c851e3d8f3
|
Fix playlist settings reference leak due to unsafe callback binding
|
2022-08-01 20:08:18 +03:00 |
|
Joseph Madamba
|
1dbb2a4d37
|
Fix online play screen only accounting for current sub screen onexiting blocks
|
2022-08-01 07:57:30 -07:00 |
|
notmyname
|
fa3b9ee32f
|
remove unneded guard
|
2022-07-31 23:42:20 +02:00 |
|
notmyname
|
57b43e0065
|
Stop capturing arrow keys on Playlist
|
2022-07-31 19:12:29 +02:00 |
|
Salman Ahmed
|
8ca8484f0e
|
Fix failing tests
|
2022-07-30 11:49:33 +03:00 |
|
Salman Ahmed
|
369ab10212
|
Fix exit confirmation dialog not blocking all exit cases
|
2022-07-30 11:00:31 +03:00 |
|
Dean Herbert
|
9d457535c6
|
Add confirmation dialog when about to discard a playlist
The confirmation will only show if items have been added to the
playlist.
Closes https://github.com/ppy/osu/issues/19444.
|
2022-07-29 17:11:37 +09:00 |
|
Dean Herbert
|
525e4a2019
|
Fix crash in DrawableRoomPlaylistItem context menu creation due to incorrect enumeration casting
|
2022-07-28 15:51:18 +09:00 |
|
Dean Herbert
|
438067a18b
|
Convert realm data propagation to more correctly use Live<T>
wip
|
2022-07-27 19:35:09 +09:00 |
|
Dean Herbert
|
41393616d8
|
Replace BeatmapCollection with RealmBeatmapCollection
|
2022-07-27 19:35:09 +09:00 |
|
Dean Herbert
|
9c543fef48
|
Remove CollectionManager
|
2022-07-27 18:45:33 +09:00 |
|
Adam Baker
|
cecf654a7b
|
Update osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerMatchSubScreen.cs
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
|
2022-07-19 18:58:59 -05:00 |
|
Salman Ahmed
|
ae6aab2555
|
Merge branch 'master' into edit-map-carousel
|
2022-07-20 02:43:47 +03:00 |
|
Adam Baker
|
4164f260b3
|
Fix code quality errors
|
2022-07-19 08:12:12 -05:00 |
|
Adam Baker
|
5008a73774
|
Make add item button open to the last beatmap in queue
|
2022-07-19 02:04:19 -05:00 |
|
Dan Balasescu
|
c07f78409e
|
Merge pull request #19189 from peppy/peform-actions-after-reconnect
Fix creating multiplayer game during server migration not joining new room correctly
|
2022-07-19 14:46:29 +09:00 |
|
Adam Baker
|
59018ab5ba
|
Fix multiplayer queue edit button opening to the wrong beatmap
|
2022-07-18 23:21:16 -05:00 |
|
Salman Ahmed
|
2befcfedbb
|
Merge branch 'master' into fix-multiplayer-participant-panel-null-ruleset
|
2022-07-18 12:24:47 +03:00 |
|
Dean Herbert
|
a036632c8b
|
Fix potential crash when attempting to create mod display using null ruleset
|
2022-07-18 15:30:21 +09:00 |
|
Dean Herbert
|
21bf7ee448
|
Turn on nullability in ParticipantPanel
|
2022-07-18 15:27:55 +09:00 |
|
Salman Ahmed
|
100c53f9ef
|
Country -> CountryCode
|
2022-07-18 08:40:34 +03:00 |
|