66234 Commits

This Branch

This Branch

All Branches

• Merge pull request #27520 from smoogipoo/missing-event-unbind

  Fix missing event unbinds

  Dean Herbert · 2024-03-07 21:54:58 +08:00
  f7d470ce33
• Fix missing event unbinds
  Dan Balasescu · 2024-03-07 21:10:11 +09:00
  ca92a31cf9
• Merge pull request #27214 from Givikap120/freemod_mapinfo_fix

  Fix mod selection in online-play rooms not accounting for mods of selected item

  Bartłomiej Dach · 2024-03-07 12:45:14 +01:00
  fba44e67a0
• Merge pull request #27501 from turbedi/throw_helper

  Use ThrowHelper methods in more places

  Bartłomiej Dach · 2024-03-07 11:36:21 +01:00
  3d8fdc52a4
• Merge pull request #27516 from frenzibyte/editor-screen-selector

  Change editor screen switcher control design and behaviour to act like a button

  Bartłomiej Dach · 2024-03-07 11:04:18 +01:00
  e99030c515
• Merge pull request #27517 from Joehuu/fix-failed-s-accuracy-circle

  Fix results screen accuracy circle not showing correctly for failed S with no flair

  Bartłomiej Dach · 2024-03-07 10:46:24 +01:00
  74e3c47c2f
• Use slightly nicer parameterisation in test
  Bartłomiej Dach · 2024-03-07 09:49:20 +01:00
  039520d55d
• Merge pull request #27453 from frenzibyte/mania-key-gaps

  Fix osu!mania key images potentially showing gaps between columns

  Bartłomiej Dach · 2024-03-07 09:32:50 +01:00
  64dc3d728e
• Merge branch 'master' into freemod_mapinfo_fix
  Bartłomiej Dach · 2024-03-07 09:24:44 +01:00
  644553d5b4
• Fix results screen accuracy circle not showing correctly for failed S with no flair
  Joseph Madamba · 2024-03-07 00:10:30 -08:00
  c36232bc02
• Add visual test for failed S display
  Joseph Madamba · 2024-03-07 00:10:30 -08:00
  56caf19350
• Merge pull request #27513 from bdach/osu-score-conversion-bad-very-not-good

  Fix osu! standardised score estimation algorithm violating basic invariants

  Dan Balasescu · 2024-03-07 17:05:32 +09:00
  e0fe33a7a7
• Adjust editor screen switcher control design and behaviour
  Salman Ahmed · 2024-03-07 08:20:46 +03:00
  0fe139a189
• Expose TRANSITION_LENGTH from tab control
  Salman Ahmed · 2024-03-07 08:20:20 +03:00
  336a6180e5
• Fix broken english
  Bartłomiej Dach · 2024-03-06 21:30:31 +01:00
  aa3cd402ca
• Bump score version
  Bartłomiej Dach · 2024-03-06 21:30:09 +01:00
  3121cf81e6
• Clamp only on horizontal sides
  Salman Ahmed · 2024-03-06 18:40:20 +03:00
  672f645cba
• Merge pull request #27454 from EVAST9919/sb-lifetime-improvements

  Improve storyboard performance by better handling sprites lifetime

  Dean Herbert · 2024-03-06 20:23:22 +08:00
  0881e7c8c1
• Merge branch 'master' into sb-lifetime-improvements
  Dean Herbert · 2024-03-06 19:27:40 +08:00
  13f7480d79
• Move optimisation to isolated method
  Dean Herbert · 2024-03-06 19:25:13 +08:00
  5b6703ec0d
• Merge pull request #27491 from bdach/f-rank-appearance

  Update F rank badge colours to match latest designs

  Dean Herbert · 2024-03-06 18:55:20 +08:00
  29a37e3585
• Fix osu! standardised score estimation algorithm violating basic invariants

  As it turns out, the "lower" and "upper" estimates of the combo portion
  of the score being converted were misnomers. In selected cases
  (scores with high accuracy but combo being lower than max by more than
  a few objects) the janky score-based math could overestimate the count
  of remaining objects in a map. For instance, in one case the numbers
  worked out something like this:
  
  - Accuracy: practically 100%
  - Max combo on beatmap: 571x
  - Max combo for score: 551x
  
  The score-based estimation attempts to extract a "remaining object
  count" from score, by doing something along of sqrt(571^2 - 551^2). That
  comes out to _almost 150_. Which leads to the estimation overshooting
  the total max combo count on the beatmap by some hundred objects.
  
  To curtail this nonsense, enforce some basic invariants:
  
  - Neither estimate is allowed to exceed maximum achievable
  - Ensure that lower estimate is really lower and upper is really upper
    by just looking at the values and making sure that is so rather than
    just saying that it is.

  Bartłomiej Dach · 2024-03-06 11:40:10 +01:00
  08609e19d6
• Merge pull request #27489 from bdach/fix-catch-pp-mismatch

  Fix catch pp calculator not matching live with respect to miss handling

  Dan Balasescu · 2024-03-06 19:39:20 +09:00
  d8003ab8e8
• Merge pull request #27504 from peppy/replay-state-sanity-1

  Never set `waitingOnFrames` if a replay is not attached

  Bartłomiej Dach · 2024-03-06 09:51:09 +01:00
  b740481eaf
• Merge pull request #27506 from peppy/update-framework

  Update framework

  Bartłomiej Dach · 2024-03-06 08:43:24 +01:00
  0d4515d26e
• Remove unused using directives
  Bartłomiej Dach · 2024-03-06 07:57:59 +01:00
  53fffc6a75
• Merge branch 'master' into update-framework
  Dean Herbert · 2024-03-06 12:36:05 +08:00
  06c7483347
• Merge pull request #27276 from bdach/medals

  Add flow for displaying achieved medals

  Dean Herbert · 2024-03-06 12:31:55 +08:00
  85364d25dc
• Update various packages which shouldn't cause issues
  Dean Herbert · 2024-03-06 12:17:00 +08:00
  3a224211aa
• Update framework
  Dean Herbert · 2024-03-06 12:13:41 +08:00
  4c7678225e
• Update ImageSharp usages
  Dean Herbert · 2024-03-06 12:13:12 +08:00
  0696e7de52
• Update usage of MathUtils
  Dean Herbert · 2024-03-06 12:13:12 +08:00
  b53b752e54
• Update usage of CircularProgress.Current
  Dean Herbert · 2024-03-06 12:13:10 +08:00
  6455c0583b
• Never set waitingOnFrames if a replay is not attached
  Dean Herbert · 2024-03-06 04:37:11 +08:00
  65ce4ca390
• Add logging for GameplayClockContainer starting or stopping
  Dean Herbert · 2024-03-06 04:37:11 +08:00
  57daaa7fed
• Merge pull request #27497 from frenzibyte/mod-select-overlay-fix-ux

  Fix mod select overlay settings order not always matching mod panels

  Bartłomiej Dach · 2024-03-05 19:40:13 +01:00
  09c6c5d79b
• Merge pull request #27242 from Susko3/log-global-statistics

  Log `GlobalStatistics` when exporting logs from settings

  Bartłomiej Dach · 2024-03-05 19:32:54 +01:00
  429fa8dfae
• Revert some changes
  Berkan Diler · 2024-03-05 17:18:59 +01:00
  d0f7ab3316
• Merge pull request #27456 from frenzibyte/catch-hr-issues

  Fix catch fruit position getting randomised when last fruit has zero position

  Bartłomiej Dach · 2024-03-05 14:23:27 +01:00
  f91423a775
• Merge pull request #27502 from turbedi/ToDictionary_overload

  Use new ToDictionary() overload without delegates

  Dean Herbert · 2024-03-05 20:25:31 +08:00
  b4bc34d8a1
• Use new ToDictionary() overload without delegates
  Berkan Diler · 2024-03-05 10:27:12 +01:00
  6fabbe2616
• Use ArgumentException.ThrowIfNullOrEmpty throw helper
  Berkan Diler · 2024-03-05 10:20:57 +01:00
  5965db4fd7
• Use ArgumentOutOfRangeException throw helper methods
  Berkan Diler · 2024-03-05 10:20:30 +01:00
  a891303484
• Use ArgumentNullException.ThrowIfNull in more places
  Berkan Diler · 2024-03-05 10:19:47 +01:00
  9bac60a98f
• Use ObjectDisposedException.ThrowIf throw helper
  Berkan Diler · 2024-03-05 09:58:46 +01:00
  43841e210d
• Fix mod select overlay settings order not always matching panels order
  Salman Ahmed · 2024-03-04 23:36:45 +03:00
  9543908c7a
• Update F rank badge colours to match latest designs
  Bartłomiej Dach · 2024-03-04 14:47:49 +01:00
  6080c14dd5
• Add test scene for drawable ranks
  Bartłomiej Dach · 2024-03-04 14:43:53 +01:00
  405958f73c
• Fix catch pp calculator not matching live with respect to miss handling
  Bartłomiej Dach · 2024-03-04 11:53:59 +01:00
  b896d97a4f
• Fix incorrect implementation of GetCountMiss() for catch
  Bartłomiej Dach · 2024-03-04 11:49:12 +01:00
  dcd6b02809