60005 Commits

This Branch

This Branch

All Branches

• Remove unnecessary local variable
  Dean Herbert · 2023-05-05 16:31:48 +09:00
  f2dd457b3d
• Remove need for TestRealmLive nonsense
  Dean Herbert · 2023-05-05 16:30:43 +09:00
  6a4933a31c
• Rename class back to original name so I can read the diff
  Dean Herbert · 2023-05-05 16:19:10 +09:00
  0158102467
• Merge branch 'master' into export
  cdwcgt · 2023-05-04 00:18:01 +09:00
  4549a865d9
• Merge pull request #23388 from peppy/fix-song-select-drawable-carousel-beatmap-leak

  Fix runaway memory usage at song select when opening many beatmaps many times

  Bartłomiej Dach · 2023-05-03 14:32:13 +02:00
  0ba31c5709
• Move to base class for added safety
  Dean Herbert · 2023-05-03 18:46:30 +09:00
  444f66b0ee
• Fix event subscriptions not being cleaned up in DrawableCarouselBeatmap

  The handling of cleanup is performed only the `Item_Set` method. This
  was already correctly called for `DrawableCarouselBeatmapSet`, but not
  for the class in question here.
  
  This would cause runaway memory usage at song select when opening many
  beatmaps to show their difficulties. For simplicity, we don't yet pool
  these (and generate the drawables each time a set is opened) which isn't
  great but likely will be improved upon when we update the visual /
  filtering of the carousel. But this simplicity caused the memory usage
  to blow out until exiting back to the main menu when cleanup would
  finally occur.

  Dean Herbert · 2023-05-03 18:41:30 +09:00
  cd31cff8cd
• Merge pull request #23384 from peppy/fix-incorrect-transform-thread

  Fix potentially incorrect thread access in `OsuTabControlCheckbox`

  Bartłomiej Dach · 2023-05-03 10:37:27 +02:00
  88135a3be8
• Merge pull request #23385 from Joehuu/scroll-back-button-block-hover

  Fix overlay scroll back button not absorbing hover from behind

  Dean Herbert · 2023-05-03 16:28:05 +09:00
  ff28d941b3
• Fix incorrect initial state of checkbox

  This only ever barely used to work without the `(..., true)`
  in `master` because of haphazard operation ordering.

  Bartłomiej Dach · 2023-05-03 09:27:23 +02:00
  de1b28bcb2
• Move callback to LoadComplete()

  Is the more correct place for `BindValueChanged()` callbacks.

  Bartłomiej Dach · 2023-05-03 09:26:54 +02:00
  5f781bd6de
• Merge pull request #23383 from peppy/fix-multi-freemod-overlays-test-failure

  Fix test failure in `MultiplayerMatchSongSelect` due to multiple overlays present

  Bartłomiej Dach · 2023-05-03 09:09:41 +02:00
  29a943d514
• Merge pull request #23379 from peppy/legacy-skin-reverse-arrow-colour-flip

  Add support for flipping colour of reverse arrow on legacy default skin when combo colour is too bright

  Bartłomiej Dach · 2023-05-03 08:48:32 +02:00
  2add8e119f
• Fix regressed button hover fade in
  Joseph Madamba · 2023-05-02 22:54:42 -07:00
  1c74f6e8ea
• Fix overlay scroll back button not absorbing hover from behind
  Joseph Madamba · 2023-05-02 22:40:37 -07:00
  bede1292de
• Fix potentially incorrect thread access in OsuTabControlCheckbox

  https://github.com/ppy/osu/actions/runs/4868337922/jobs/8681736829.

  Dean Herbert · 2023-05-03 14:33:32 +09:00
  a3efae3690
• Fix test failure in MultiplayerMatchSongSelect due to multiple overlays present

  https://github.com/ppy/osu/actions/runs/4868337922/jobs/8681736995?pr=23308.

  Dean Herbert · 2023-05-03 14:30:58 +09:00
  384693a431
• Merge pull request #23308 from OliBomby/sample-control-points

  Remove SampleControlPoint and DifficultyControlPoint from HitObject

  Dean Herbert · 2023-05-03 14:21:51 +09:00
  6b017ac05f
• Move struct to bottom of file
  Dean Herbert · 2023-05-03 13:33:31 +09:00
  f930c4bd0a
• Split out default and sample application
  Dean Herbert · 2023-05-03 13:30:45 +09:00
  48fd99818e
• Refactor applyLegacyInfoAndDefaults for legibility
  Dean Herbert · 2023-05-03 13:26:50 +09:00
  cca15f930c
• Move pragma disable to top of LegacyBeatmapDecoder

  Makes more sense as it's used multiple times in the class.

  Dean Herbert · 2023-05-03 13:19:14 +09:00
  588a4e6196
• Ensure static banana samples are not mutated
  Dean Herbert · 2023-05-03 13:02:37 +09:00
  16c624fb61
• Add support for flipping colour of reverse arrow on legacy default skin when combo colour is too bright
  Dean Herbert · 2023-05-03 12:37:07 +09:00
  9c4312b407
• Merge pull request #23370 from peppy/fix-editor-playfield-padding

  Add more padding around playfield in editor to avoid overlap with tool areas

  Dean Herbert · 2023-05-03 11:44:55 +09:00
  e42b0cc5b1
• Merge pull request #23371 from peppy/argon-slider-ball-fade-faster

  Increase the rate of slider ball fade on argon skins to match other implementations

  Bartłomiej Dach · 2023-05-02 19:03:47 +02:00
  03459a4f19
• Adjust composer tests to new screen layout

  `TestSceneHitObjectComposer.TestPlacementFailsWhenClickingButton()` was
  attempting to cover the case of the user clicking a toolbox button which
  was in front of the playfield, and ensure that the click did not result
  in a placement. However, since the paddings in
  67f83f246b were added, it is impossible
  for a toolbox button to be in front of the playfield in the collapsed
  state, which the test was relying on.
  
  The test scenario is still however relevant in the case of the toolbox
  being expanded, as in that state the toolbux buttons may very well end
  up being in front of the playfield, and they still should not result in
  a hitobject being placed. To ensure that this is the case, add a few
  extra test steps ensuring that the toolbox is expanded first before
  trying to retrieve an overlapping button.

  Bartłomiej Dach · 2023-05-02 18:45:45 +02:00
  95badb9455
• Merge pull request #23367 from peppy/fix-uo-tooltip

  Fix slider bar tooltips potentially showing negative zero

  Bartłomiej Dach · 2023-05-02 18:03:09 +02:00
  ec8362c6fc
• Merge pull request #23369 from peppy/beatmap-attribute-text-unicode-preference

  Fix `BeatmapAttributeText` not supporting unicode artist/title

  Bartłomiej Dach · 2023-05-02 17:32:55 +02:00
  48dd42407b
• Merge pull request #23357 from OliBomby/fix-reverse-crash

  Prevent infinite repeat count when adjusting repeats of 0 length slider

  Dean Herbert · 2023-05-02 19:53:26 +09:00
  94ae9d7664
• Merge pull request #21789 from mk56-spn/bubble_mod_implementation_clean

  Add "bubble" mod to osu! ruleset

  Dean Herbert · 2023-05-02 19:52:32 +09:00
  1b565ab9e8
• Merge pull request #23374 from EVAST9919/ruleset-shaders-test

  Add missing ruleset shader tests

  Dean Herbert · 2023-05-02 19:52:09 +09:00
  2aaa52e904
• remove constructor argument from Banana
  OliBomby · 2023-05-02 12:41:39 +02:00
  90d98cd329
• remove redundant zero check in sv calculation
  OliBomby · 2023-05-02 12:29:11 +02:00
  d2d81bb82c
• Add missing ruleset shader tests
  Andrei Zavatski · 2023-05-02 11:55:05 +03:00
  ba5088f71a
• Update test shaders
  Andrei Zavatski · 2023-05-02 11:51:05 +03:00
  8160d56264
• Avoid using Schedule in transforms (doesn't handle rewind well)
  Dean Herbert · 2023-05-02 17:08:49 +09:00
  e44672bdd5
• Tidy up various code quality issues in OsuModBubbles
  Dean Herbert · 2023-05-02 17:08:37 +09:00
  7830711c8e
• Ensure lifetime start is also updated when reverting judgements
  Dean Herbert · 2023-05-02 17:07:12 +09:00
  fb0e90913d
• Change flashlight depth in a more standard way
  Dean Herbert · 2023-05-02 17:00:54 +09:00
  414b80d44e
• Merge branch 'master' into bubble_mod_implementation_clean
  Dean Herbert · 2023-05-02 16:59:55 +09:00
  b2b9f2a036
• Increase the rate of slider ball fade on argon skins to match other implementations
  Dean Herbert · 2023-05-02 15:47:35 +09:00
  bd72c67d68
• Fix comment 2 osu.Game/Rulesets/Objects/Types/IHasGenerateTicks.cs

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  OliBomby · 2023-05-02 08:41:47 +02:00
  2e018c8b06
• Fix comment 1 osu.Game/Rulesets/Objects/Types/IHasGenerateTicks.cs

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  OliBomby · 2023-05-02 08:41:30 +02:00
  c2ad8c2320
• Add more padding around playfield in editor to avoid overlap with tool areas

  Closes #23130.

  Dean Herbert · 2023-05-02 15:37:02 +09:00
  67f83f246b
• Merge pull request #23038 from cdwcgt/scale-background-dim

  Add feature to adjust `ScalingContainer` background dim

  Dean Herbert · 2023-05-02 15:36:52 +09:00
  4a97c2c105
• Merge pull request #22950 from Joehuu/fix-initial-playlist-highlight

  Fix now playing playlist not highlighting selected item on initial open

  Dean Herbert · 2023-05-02 15:36:34 +09:00
  ce4a6c38a0
• Fix non-block namespace usage
  Dean Herbert · 2023-05-02 15:09:24 +09:00
  8a536c1cdb
• Merge pull request #23284 from Hy0tic/multiplier-doesnt-update-with-preset-mod

  Fix issue where multiplier show wrong value when adjusting speed on preset

  Dean Herbert · 2023-05-02 14:59:41 +09:00
  1e4a628cb1
• Merge branch 'master' into sample-control-points
  Dean Herbert · 2023-05-02 14:38:39 +09:00
  e3c384c6b5