237 Commits

• Add some nullability annotations for good measure
  Bartłomiej Dach · 2021-01-06 13:15:15 +01:00
  43b9fde457
• Add null check on beatmapContainer for safety
  Dean Herbert · 2021-01-06 21:06:33 +09:00
  99701a6d9b
• Fix carousel beatmap set panels applying transforms to difficulties while they are loading
  Dean Herbert · 2021-01-05 18:41:45 +09:00
  83dbba3cbf
• Select recommended beatmap if last selection is filtered
  Endrik Tombak · 2020-12-03 23:13:14 +02:00
  c25e2c3dd5
• Fix song select panels not loading if partially offscreen
  smoogipoo · 2020-12-03 15:13:20 +09:00
  31f7f7072d
• Move drawable carousel set movement logic into panels themselves
  Dean Herbert · 2020-11-26 18:32:43 +09:00
  6058c66edb
• Rename BeatmapDifficultyManager to BeatmapDifficultyCache
  Dean Herbert · 2020-11-06 13:14:29 +09:00
  5113d4af8f
• Resolve CA2249 inspections

  "Use `string.Contains` instead of `string.IndexOf` to improve
  readability"

  Bartłomiej Dach · 2020-11-01 18:54:44 +01:00
  3090b6ccb5
• Fix a potential null reference when loading carousel difficulties
  Dean Herbert · 2020-10-25 20:28:24 +09:00
  8b04cd2cb0
• Merge pull request #10497 from peppy/beatmap-carousel-less-diffcalc-stutter

  Disable difficulty calculation for set-level difficulty icons

  Dan Balasescu · 2020-10-20 14:57:34 +09:00
  1fe987d4b3
• Reduce alloc overhead of DrawableCarouselBeatmapSet using new function-based ctor
  Dean Herbert · 2020-10-14 15:10:50 +09:00
  30e1fce7a4
• Disable difficulty calculation for set-level difficulty icons
  Dean Herbert · 2020-10-14 14:16:22 +09:00
  07e6609e6d
• Add missing licence headers
  Dean Herbert · 2020-10-13 20:57:26 +09:00
  e662dc5342
• Fix formatting issues
  Dean Herbert · 2020-10-13 20:50:36 +09:00
  8057ea1097
• Clean up beatmapSet resolution in DrawableCarouselBeatmapSet
  Dean Herbert · 2020-10-13 19:31:29 +09:00
  3d416f4d64
• Remove unnecessary hack (fixed via framework update)
  Dean Herbert · 2020-10-13 19:31:29 +09:00
  75b6a5e17e
• Locallise ChildItems to DrawableCarouselBeatmapSet for clarity
  Dean Herbert · 2020-10-13 19:31:29 +09:00
  5d11db7753
• Remove outdated comment
  Dean Herbert · 2020-10-13 19:12:33 +09:00
  37daefc2b5
• Adjust fade duration to be slightly shorter
  Dean Herbert · 2020-10-13 18:50:10 +09:00
  834b0186f4
• Switch DelayedLoadUnloadWrappers to DelayedLoadWrappers

  Due to pooling usage, there is no time we need to unload. Switching to
  DelayedLoadWrapper cleans up the code and reduces overhead
  substantially.

  Dean Herbert · 2020-10-13 18:47:40 +09:00
  2346644c04
• Remove unnecessary fade (already applied by base DrawableCarouselItem)
  Dean Herbert · 2020-10-13 18:28:28 +09:00
  4f4f222514
• Remove logging
  Dean Herbert · 2020-10-13 18:18:22 +09:00
  83358d487f
• Remove masking override (no longer needed as our size is now correct)
  Dean Herbert · 2020-10-13 18:14:23 +09:00
  3d9ea852ec
• Simplify vertical position calculations by including spacing in height definition
  Dean Herbert · 2020-10-13 18:13:36 +09:00
  69650c16fc
• Fix right click context menus appearing in incorrect locations
  Dean Herbert · 2020-10-13 18:01:12 +09:00
  b1ddb08a4e
• Split content out into own class
  Dean Herbert · 2020-10-13 18:01:12 +09:00
  d9a6a6b245
• Fix main content DelayedLoadUnloadWrapper not getting a valid size before load
  Dean Herbert · 2020-10-13 17:45:41 +09:00
  9b2ebb8f0f
• Fix masking issues with certain aspect ratio displays
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  f3b937e358
• Fix difficulties being at incorrect vertical positions after filter is applied
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  fdd4d95cdc
• Move header height propagation to update for safety
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  b536f571fd
• Avoid usage of AutoSize for DrawableCarouselItems in general
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  ded09b78cb
• Avoid reconstructing beatmap difficulties that were recently displayed
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  cecdf14f53
• Calculate content height automatically
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  1da49073ab
• Align beatmap difficulties correctly
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  c08b5e8d03
• Extract header element from base DrawableCarouselItem class
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  cfec4f4fc1
• Move transform clean-up to pooling free call
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  20b54fb904
• Store y positions inside items rather than in a separate array
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  f6aa448523
• Add logging
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  b92c22ad42
• Split classes out to reduce loc burder on DrawableCarouselBeatmapSet
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  9814e9ba7f
• Add back beatmap difficulty appear/disappear movement
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  975cd5a840
• Add back difficulty panel spacing
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  fd8654cff3
• Bind to filter event changes in base drawable item
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  82f9ca3de9
• Use existing event flow for rendering beatmap difficulties
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  813ee19728
• Temporarily disable masking temporarily to fix panels disappearing at extents
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  bb03c5d77c
• Fix filtered items being considered for height calculation
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  524419d5e4
• Correctly free panels after use to avoid finalizer disposal of subtree
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  0a144a1388
• Fix multiple difficulties being expanded at once
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  5c29aa8cce
• Add back left offset for selected set
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  5c2f134665
• Add safeties to beatmap panel loading code
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  3cfc0dc82d
• Debounce state application events
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  954d43ef56