Salman Ahmed
7acc1772cb
Add test coverage
2024-08-13 13:07:21 +03:00
Dean Herbert
14a00621f8
Fix occasional test failures in TestSceneBetmapRecommendations
...
The game was being constructed befor the API was setup, which could mean
depending on test execution ordering and speed, the recommendations
array would not be filled.
Easy to reproduce by `[Solo]`ing `TestCorrectStarRatingIsUsed`.
See https://github.com/ppy/osu/runs/28689915929#r0s0 .
2024-08-13 17:28:16 +09:00
Dan Balasescu
58354e3e68
Fix another test
...
The last two PRs didn't interact well together.
2024-08-13 17:18:11 +09:00
Dan Balasescu
4b4f0ecf7d
Merge pull request #29342 from cl8n/remove-mania-action-special
...
Remove "Special" `ManiaAction`s for center columns
2024-08-13 15:36:36 +09:00
Dan Balasescu
cd76f474d8
Merge pull request #29388 from cl8n/fix-mania-replay
...
Fix error on parsing osu!mania replays with 18 or more keys
2024-08-13 15:29:53 +09:00
Bartłomiej Dach
92bd123ebc
Merge pull request #29363 from peppy/fix-daily-challenge-notification-spam
...
Fix daily challenge notification spam
2024-08-12 12:18:38 +02:00
Bartłomiej Dach
041c70e4eb
Fix tests
2024-08-12 11:19:02 +02:00
clayton
2233602184
Update mania replay decode test to include 18K keypress
2024-08-11 09:45:42 -07:00
Dan Balasescu
104942ccf6
Merge pull request #29362 from peppy/dont-truncate-floating-point-positioning
...
Fix hit object coordinates being truncated to `int` values
2024-08-09 19:10:24 +09:00
Dean Herbert
c8a7727199
Make ID retrieval global to all tests and fix multiple other usages
2024-08-09 17:46:51 +09:00
Dean Herbert
18c80870d8
Update one more RNG usage in same tests
2024-08-09 17:40:48 +09:00
Dean Herbert
0a8e342830
Fix occasionally ChatOverlay test failures due to RNG usage
...
See https://github.com/ppy/osu/actions/runs/10302758137/job/28517150950 .
Same ID gets chosen twice for PM channel.
2024-08-09 17:38:17 +09:00
Dean Herbert
2114f092c7
Add failing test coverage showing coordinate truncation
2024-08-09 16:34:39 +09:00
Dean Herbert
80c814008f
Update in line with new changes
2024-08-09 14:55:01 +09:00
Dean Herbert
e645651ef4
Merge branch 'master' into mania-combo-counter
2024-08-09 00:19:17 +09:00
Dean Herbert
dcafee7cb7
Merge pull request #26249 from frenzibyte/ruleset-specific-combo-counter
...
Move combo counter to ruleset-specific HUD components container
2024-08-08 17:41:58 +09:00
Dean Herbert
278d887ee5
Fix test failures due to missing room name
2024-08-08 15:10:14 +09:00
Dean Herbert
1ee5522a25
Merge branch 'master' into daily-challenge-intro-screen-part-2
2024-08-08 14:08:14 +09:00
clayton
48d9bc982f
Fix tests
2024-08-07 14:36:04 -07:00
Dean Herbert
3c572abaa7
Merge branch 'master' into ruleset-specific-combo-counter
2024-08-08 03:21:52 +09:00
Bartłomiej Dach
e6d5389608
Merge branch 'master' into hover-open-mod-customise
2024-08-07 14:05:19 +02:00
Bartłomiej Dach
518c1aa5a0
Remove weird Expanded / ExpandedState duality
2024-08-07 14:01:30 +02:00
Bartłomiej Dach
437812eebe
Merge pull request #29279 from normalid-awa/bugfix/editor/delete-operation-wont-close-the-menu
...
Close context menus when deselecting items in editor
2024-08-07 13:25:13 +02:00
Salman Ahmed
a0615a8f18
Frenzi's WIP animation
2024-08-07 19:07:45 +09:00
Dean Herbert
6870311c1e
Remove requirement of specifying animateOnnter in BackgroundScreen ctor
2024-08-07 19:07:44 +09:00
Dean Herbert
b081b47714
Add test of daily challenge flow from main menu
2024-08-07 19:07:44 +09:00
Dean Herbert
b1488fd5b7
Merge pull request #29027 from normalid-awa/feature/skin/legacy-input-overlay
...
Add legacy key counter support
2024-08-07 17:48:30 +09:00
Dean Herbert
1aea8e911c
Add test coverage of chat mentions
2024-08-07 01:33:56 +09:00
Dean Herbert
f7b45a26de
Improve test coverage and segregation
2024-08-06 19:32:00 +09:00
Dean Herbert
9ccd8c906d
Merge branch 'master' into hover-open-mod-customise
2024-08-06 18:35:35 +09:00
Dean Herbert
8619bbb943
Fix legacy key counter's background being visible when intended to be hidden
2024-08-06 16:12:00 +09:00
Dan Balasescu
c574551ee0
Simplify caching
2024-08-06 16:02:36 +09:00
Dean Herbert
60fc02bb9b
Merge branch 'master' into feature/skin/legacy-input-overlay
2024-08-06 14:05:33 +09:00
Dan Balasescu
d637bbf752
Merge pull request #29286 from peppy/middle-click-delete
...
Allow object deletion with middle mouse
2024-08-06 13:38:56 +09:00
jkh675
59ff549b4d
Remove unused using
2024-08-05 16:46:56 +08:00
jkh675
3c8d0ce59f
Revert the unit test changes
2024-08-05 16:40:31 +08:00
Dean Herbert
17eb134797
Merge branch 'master' into bugfix/visual/long-commet-tooltip-overflow
2024-08-05 17:01:20 +09:00
Dean Herbert
24a0ead62e
Make tests actually show what value they are testing
2024-08-05 17:01:00 +09:00
Dean Herbert
9c5e29b2c9
Fix test being disabled for cases which should pass
2024-08-05 16:58:00 +09:00
Dean Herbert
c0814c2749
Add test of existing slider placement behaviour for safety
2024-08-05 14:25:10 +09:00
Dean Herbert
9673985e2c
Add test coverage of right/middle click behaviours with placement blueprints
2024-08-05 14:25:09 +09:00
Dan Balasescu
136cdcfb29
Merge pull request #29059 from frenzibyte/fix-results-fetching-twice
...
Fix results screen fetching scores twice when scrolled to edge
2024-08-05 14:23:47 +09:00
Dean Herbert
419d5a76ce
Merge branch 'master' into fix-pause-in-osu-again
2024-08-05 12:00:21 +09:00
jkh675
2098fb8a9d
Fix code quality
2024-08-05 00:08:02 +08:00
jkh675
1b25633e47
Fix headless test
2024-08-04 23:45:42 +08:00
jkh675
2720bcf285
Fix ruleset unit test
2024-08-04 22:37:54 +08:00
jkh675
7cebf4c3d2
Fix code quality
2024-08-04 21:18:03 +08:00
jkh675
38dacfeaa2
Fix unit test
2024-08-04 21:12:09 +08:00
jkh675
273bd73a99
Fix unit test error
2024-08-04 19:50:57 +08:00
jkh675
6f9866d542
Add unit test for OsuTooltip
2024-08-04 18:56:19 +08:00
Dean Herbert
7765d0ff70
Merge pull request #29157 from frenzibyte/user-profile-daily-challenge-streak-display
...
Add daily challenge stats display to user profile overlay
2024-08-03 23:57:19 +09:00
Dean Herbert
531cf64ddb
Add failing test showing date added changing when importing as update with no change
2024-08-02 20:46:02 +09:00
Caiyi Shyu
c85dc40f91
Merge branch 'master' into hover-open-mod-customise
2024-08-02 19:07:27 +08:00
Salman Ahmed
dc9f6a07cb
Fix inspections
2024-08-02 11:16:32 +03:00
Salman Ahmed
c3b2d81066
Add failing test case
2024-08-02 10:19:44 +03:00
Dean Herbert
310def64f4
Merge branch 'master' into user-profile-daily-challenge-streak-display
2024-08-02 15:40:46 +09:00
Dean Herbert
816dee181a
Rename classes to remove "streak" terminology
...
Since the primary display isn't showing a streak.
2024-08-02 15:33:30 +09:00
Caiyi Shyu
051d52c23f
Update ModCustomisationPanel to use ExpandedState enum
2024-08-01 19:25:45 +08:00
Dean Herbert
e9ed9ff58b
Merge pull request #29188 from bdach/daily-challenge/better-messaging
...
Add notification on daily challenge conclusion & start of new one
2024-07-31 13:35:25 +09:00
Dean Herbert
5ebb5ad670
Fix test failure due to TestMetadataClient providing null statistics array
2024-07-31 02:53:10 +09:00
Dean Herbert
d75c170ba1
Merge branch 'master' into daily-challenge/better-messaging
2024-07-30 19:04:48 +09:00
Dean Herbert
71649005bf
Elongate usernames in DrawableChannel test
2024-07-30 17:52:55 +09:00
Dean Herbert
71acb7e9fc
Merge pull request #29137 from normalid-awa/feature/visual/chatline-background-altering
...
Alternate background colour of chat lines to better visually distinguish wrapped lines
2024-07-30 17:51:41 +09:00
Bartłomiej Dach
1b57a2a136
Show new daily challenge notification globally
2024-07-30 10:36:26 +02:00
Bartłomiej Dach
a05f810724
Attempt to fix tests more
2024-07-30 10:07:38 +02:00
Bartłomiej Dach
ae38e66036
Add failing test coverage
2024-07-30 08:39:01 +02:00
Salman Ahmed
91dfe4515b
Fix daily challenge display showing incorrect statistic
2024-07-30 08:12:03 +03:00
Salman Ahmed
7c3d592a84
Fix user profile overlay test scene being broke
2024-07-30 07:06:59 +03:00
Bartłomiej Dach
5032a149e7
Merge pull request #29187 from peppy/daily-challenge-pieces-not-always-present
...
Favour updating daily challenge statistics when they come on screen
2024-07-29 15:48:26 +02:00
Bartłomiej Dach
b77a10b6db
Fix tests maybe
2024-07-29 15:28:52 +02:00
Dean Herbert
1daeb7ebd0
Rename typo in test naming
2024-07-29 22:19:38 +09:00
Bartłomiej Dach
b46f3c97da
Add notification on daily challenge conclusion & start of new one
...
Because I wish to stop seeing "DAILY CHALLENGE WHERE" every day
on #general.
The notifications are constrained to the daily challenge screen only to
not spam users who may not care.
2024-07-29 14:30:10 +02:00
Dean Herbert
7afcd72872
Fix potentially too many scores displaying in breakdown while in gameplay
2024-07-29 20:58:42 +09:00
Dean Herbert
76cd2df699
Add ability to test daily challenge carousel items when hidden
2024-07-29 20:43:47 +09:00
Dean Herbert
997b3eb498
Fix typos and visuals
2024-07-29 20:24:51 +09:00
Shreyas Kadambi
ae61df0abe
Add back accidentally removed test
2024-07-28 11:47:00 -04:00
Shreyas Kadambi
1c9c3c92fd
Add tests for expected timestamp format
2024-07-28 11:30:42 -04:00
normalid
e58bdbb8a9
Improve unit test
2024-07-28 15:08:36 +08:00
Salman Ahmed
82fbd5b045
Rename file
2024-07-28 06:40:16 +03:00
Salman Ahmed
e82c54a31c
Integrate daily challenge streak display with user profile overlay
2024-07-28 05:58:30 +03:00
Salman Ahmed
17f5d58be2
Add daily challenge streak display and tooltip
2024-07-28 05:58:27 +03:00
Joseph Madamba
bc25e5d706
Remove unnecessary depth and padding set
2024-07-27 19:13:11 -07:00
Joseph Madamba
850bcaef7a
Merge remote-tracking branch 'upstream/master' into pr/28991
2024-07-27 19:09:02 -07:00
Joseph Madamba
b4ca07300a
Use same size button for everything
2024-07-27 18:43:54 -07:00
normalid
4e44a6e7f8
Clean up code
2024-07-27 18:55:17 +08:00
normalid
73a98b45e9
FIx code quality
2024-07-27 18:48:45 +08:00
normalid
7f4bfb25a9
Implement unit test
2024-07-27 18:24:32 +08:00
Caiyi Shyu
bd017aea38
fix TestPreexistingSelection failing
2024-07-26 23:58:52 +08:00
Caiyi Shyu
a3576a55c2
add test for hovering ModCustomisationPanel
2024-07-26 22:45:12 +08:00
Dean Herbert
4fa6a19409
Merge pull request #29108 from bdach/daily-challenge/better-breakdown
...
Improve score breakdown on daily challenge
2024-07-26 23:12:04 +09:00
Dean Herbert
1607075e0c
Merge pull request #29099 from bdach/daily-challenge/totals-display
...
Implement component for displaying running totals in daily challenge
2024-07-26 21:44:58 +09:00
Bartłomiej Dach
fc0ade2c61
Highlight where local user's best is on the breakdown
2024-07-26 14:32:01 +02:00
Bartłomiej Dach
174dc91f4b
Implement component for displaying running totals in daily challenge
...
Total pass count and cumulative total score, to be more precise.
2024-07-26 09:51:39 +02:00
Bartłomiej Dach
e489ae8f72
Merge pull request #29055 from peppy/event-feed-improvements
...
Improve daily challenge event feed
2024-07-26 08:37:47 +02:00
Bartłomiej Dach
09a1fd2cd1
Merge pull request #29057 from frenzibyte/daily-challenge-replay-download-button
...
Fix daily challenge not showing a replay button in results screen
2024-07-26 08:03:17 +02:00
Salman Ahmed
3e8917cadb
Add test case against resetting score in download button
2024-07-26 05:08:13 +03:00
Salman Ahmed
f3dd1facf1
Add failing test case
2024-07-25 09:16:09 +03:00
Salman Ahmed
e1ccf68801
Revert "Add failing test case"
...
This reverts commit 0182f3d7c3
2024-07-25 08:51:48 +03:00
Dean Herbert
f1dda4ab1e
Fix too many event rows displaying after spending a long time in gameplay/results
2024-07-25 14:31:22 +09:00
Dean Herbert
bba151a776
Make event feed test show more realistic content automatically
2024-07-25 14:31:21 +09:00
Salman Ahmed
0182f3d7c3
Add failing test case
2024-07-25 07:39:58 +03:00
Salman Ahmed
b3e3bf7cec
Add lenience to avoid floating point errors
2024-07-24 23:26:23 +03:00
Salman Ahmed
6645dac71d
Fix dragging number boxes overwritten by select-all-on-focus feature
2024-07-24 23:19:04 +03:00
Bartłomiej Dach
12a9086aa3
Fix test failure
...
After the legacy key counter was moved to ruleset-specific component
containers, `TestSceneSkinnableHUDOverlay` no longer had a key counter,
because it wasn't creating a ruleset-specific HUD component container
due to
4983e5f33e/osu.Game/Screens/Play/HUDOverlay.cs (L131-L133)
2024-07-24 18:30:18 +02:00
Dean Herbert
4983e5f33e
Merge pull request #29039 from bdach/multiple-selection-sample-popover
...
Make sample popover change properties of all samples in multiple selection
2024-07-24 22:49:20 +09:00
Bartłomiej Dach
087dd759be
Adjust layout to ballpark-match stable
...
I dunno what the wiki is claiming with the "24px" figure or why
but I'm not playing conversion games either. Dimensions ballparked
via screenshots captured at x768 resolution.
Also removes a weird homebrew method to keep the text upright.
There is one canonical way to do this, namely
`UprightAspectMaintainingContainer`. And the other key counters
were already using it.
2024-07-24 14:52:56 +02:00
Bartłomiej Dach
ace5071d88
Add better test scene
2024-07-24 14:25:51 +02:00
Bartłomiej Dach
55382a4ba6
Add test coverage for expected sample popover behaviour
2024-07-24 12:08:13 +02:00
normalid
0306ef4096
Update test assets
2024-07-24 14:13:45 +08:00
normalid
95f287104e
Add visual test seane
2024-07-24 12:24:58 +08:00
normalid
661f58a397
Add test coverage
2024-07-24 12:18:05 +08:00
Bartłomiej Dach
c2fa30bf81
Add test coverage for break generation respecting pre-empt time
2024-07-23 13:38:25 +02:00
Bartłomiej Dach
25d63ac6a5
Move editor beatmap processor test cases off of OsuHitObjects
...
Most of them are about to become obsolete once consideration for
`TimePreempt` is re-added.
2024-07-23 13:28:49 +02:00
Bartłomiej Dach
dd8be62d07
Merge pull request #28849 from frenzibyte/custom-profile-colour
...
Add custom hue support to user profile overlay
2024-07-22 09:41:32 +02:00
Bartłomiej Dach
088b8aff11
Merge pull request #28881 from smoogipoo/fix-judgement-cut
...
Fix judgement animation getting cut early
2024-07-22 09:24:57 +02:00
Layendan
6a4872faa8
Remove nullable disable
2024-07-21 23:56:47 -07:00
Layendan
e4cccb5e31
Fix lint errors
2024-07-22 12:22:52 +09:00
Layendan
a575566638
Add tests
2024-07-22 12:22:51 +09:00
Salman Ahmed
d7651ef387
Add extensive test cases for correct input handling while paused in osu! & non-osu!
2024-07-19 18:48:35 +03:00
Dean Herbert
d9297438ba
Merge pull request #28900 from smoogipoo/fix-more-tests
...
Fix more test failures
2024-07-19 19:38:52 +09:00
Dan Balasescu
7a4758d8cc
Attempt to fix TestSelectableMouseHandling test failure
...
https://github.com/ppy/osu/pull/28900/checks?check_run_id=27652166871
This is an attempt. Going frame-by-frame I noticed that there's one
frame in which the text is loaded but the
FillFlowContainer/GridContainer haven't properly validated so the text
is not positioned correctly (it's overflowing the panel to the left). If
the cursor is moved at this exact time, then it may not be properly
positioned for the following assertion, even though it is _somewhere_ on
the panel.
If the above is the case, then this is a known o!f issue, but not a
simple one to solve.
I haven't reproed this locally.
2024-07-19 17:49:16 +09:00
Dan Balasescu
d7ae9505b2
Fix TestCancelNavigationToEditor test failure
...
https://github.com/ppy/osu/actions/runs/10002179087/job/27648253709
The editor could be pushed before the exit actually
occurs.
2024-07-19 15:04:21 +09:00
Bartłomiej Dach
79cf644b8d
Enable NRT while we're here
2024-07-19 07:34:00 +02:00
Bartłomiej Dach
73edb32440
Add failing test coverage
2024-07-19 07:30:57 +02:00
Dan Balasescu
3f4e56be3c
Fix TestPostAsOwner test failure
...
https://github.com/smoogipoo/osu/actions/runs/9990112749/job/27610257309
Comments are loaded asynchronously, both from the initial request and
the following message-post request. By sheer timing luck, these could be
out of order and the assertion on the posted message could fail.
2024-07-18 20:54:05 +09:00
Dan Balasescu
33a81d8181
Use constraint to improve assertion message
2024-07-18 18:34:08 +09:00
Dan Balasescu
f3cd3d7d3b
Fix TestAllSamplesStopDuringSeek test failure
...
https://github.com/smoogipoo/osu/actions/runs/9986761756/job/27599851263
This is a bit of a workaround, likely timing related. I don't foresee an
until step in this case to cause false-passes.
2024-07-18 16:26:42 +09:00
Dan Balasescu
1906c2f725
Fix TestTouchScreenDetectionAtSongSelect test failure
...
https://github.com/ppy/osu/actions/runs/9985890747/job/27597501295
In this case, the settings overlay is taking a very long time to load
(on a background thread), and pops in when it finishes loading because
it's been requested to open.
The opens the settings overlay, closes it (by pressing escape, this does
not actually close it because it's not loaded yet), and then enters song
select by pressing 'P' 3 times. The settings overlay finishes loading at
just the right opportune moment to eat one of the 'P' key presses.
2024-07-18 16:26:16 +09:00
Salman Ahmed
7a39435017
Fix intermitent test failure in TestSceneArgonHealthDisplay
2024-07-18 01:20:50 +03:00
Bartłomiej Dach
53b6f9e385
Fix test not waiting properly for background processing to complete
2024-07-16 14:04:51 +02:00
Bartłomiej Dach
6db135279f
Restore test coverage of original fail case
2024-07-16 14:04:50 +02:00
Dan Balasescu
ae5b0aa54b
Fix BackgroundDataStoreProcessor test failure
2024-07-16 19:59:13 +09:00
Bartłomiej Dach
76d016df34
Fix code inspection
2024-07-16 11:31:16 +02:00
Dan Balasescu
d4ea604ad0
Add test
2024-07-16 18:19:00 +09:00
Dean Herbert
2c102fc9d0
Fix test failure in TestMetadataTransferred
2024-07-14 01:36:51 +09:00
Salman Ahmed
be1d3c0ea4
Add test coverage
2024-07-13 11:58:54 +03:00
Dean Herbert
eb3f480a2a
Merge pull request #28683 from frenzibyte/footer-v2-integration
...
Replace local footer in existing sheared overlays (e.g. mod select & first-run setup) with `ScreenFooter`
2024-07-12 22:45:06 +09:00
Bartłomiej Dach
518dc17518
Merge pull request #28788 from bdach/timeline-redesign
...
Redesign editor timelines to address most frequent user complaints
2024-07-12 10:58:59 +02:00
Bartłomiej Dach
452fbed681
Merge pull request #28808 from frenzibyte/fix-all-notifications
...
Fix confirm exit dialog potentially showing incorrect number of ongoing operations
2024-07-12 10:56:29 +02:00
Dean Herbert
43addc8400
Fix test regression
2024-07-12 16:29:41 +09:00
Salman Ahmed
3ea0f58daa
Update TestSceneFreeModSelectOverlay to work again
2024-07-11 15:31:23 +03:00
Salman Ahmed
7a5624fd0e
Add screen footer to ScreenTestScene
2024-07-11 15:30:07 +03:00
Bartłomiej Dach
f1fa34e5d5
Merge pull request #28800 from peppy/file-mounting-v3
...
Add ability to edit beatmap content externally
2024-07-11 10:47:36 +02:00
Dean Herbert
c139478aa2
Merge pull request #28805 from frenzibyte/select-all-on-focus
...
Select all text when focusing sample bank/volume textboxes in editor (and number boxes in general)
2024-07-11 17:33:30 +09:00
Bartłomiej Dach
a859978efd
Add failing test steps for locally modified state not being set
2024-07-11 09:43:00 +02:00
Dean Herbert
b5bb94e4ec
Merge branch 'master' into file-mounting-v3
2024-07-11 15:54:54 +09:00
Bartłomiej Dach
a9c8c6e74d
Attempt to fix test failures by forcing refresh
2024-07-11 08:18:16 +02:00
Salman Ahmed
8ca8648a09
Add failing test case
2024-07-10 16:14:12 +03:00
Salman Ahmed
7d667ac46b
Fix confirm exit dialog overflowing from too many ongoing operations
2024-07-10 16:06:53 +03:00
Salman Ahmed
94f51c92e0
Select all text when focusing a number box
2024-07-10 15:16:10 +03:00
