1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-16 11:57:30 +08:00
Commit Graph

1678 Commits

Author SHA1 Message Date
Salman Ahmed
d039b56562 Add test case for running with high number of loops 2024-03-10 09:01:37 +03:00
Salman Ahmed
8a1c5a7547 Adjust time values 2024-03-10 07:23:22 +03:00
Andrei Zavatski
e08651668c Fix TestSceneSkinnableSound failing 2024-03-09 21:55:00 +03:00
Salman Ahmed
82048df9f1 Add basic test scene for asserting storyboard commands behaviour
Pending actual test coverage.
2024-03-09 04:43:10 +03:00
Salman Ahmed
c1649b76d6 Reorder command properties to match general format
I had them shuffled around in the middle of the refactor.
2024-03-08 21:33:53 +03:00
Salman Ahmed
8d3e502262 Merge branch 'master' into storyboard-loops-v2 2024-03-08 20:22:19 +03:00
Dean Herbert
d9cc619693
Merge branch 'master' into argon-pp-counter 2024-03-08 10:32:16 +08:00
Salman Ahmed
fa9b2f0cd5 Add generics to ApplyInitialValue/ApplyTransforms for ability to return custom transform sequences
*sigh*
2024-03-08 03:07:39 +03:00
Salman Ahmed
585ab59768 Apply major refactor to the storyboard commands flow structrure 2024-03-08 01:10:09 +03:00
Dean Herbert
06c7483347
Merge branch 'master' into update-framework 2024-03-06 12:36:05 +08:00
Dean Herbert
85364d25dc
Merge pull request #27276 from bdach/medals
Add flow for displaying achieved medals
2024-03-06 12:31:55 +08:00
Dean Herbert
0696e7de52
Update ImageSharp usages 2024-03-06 12:13:12 +08:00
Salman Ahmed
49b3e81e8a Migrate DefaultPerformancePointsCounter and rename it 2024-03-05 04:35:39 +03:00
Salman Ahmed
3ee57cdfba Refactor performance points test scene to support skinning 2024-03-05 03:34:25 +03:00
Dan Balasescu
6635d9be04
Add countdown display 2024-03-04 16:50:24 +09:00
Andrei Zavatski
4a7635e488 Fix broken tests 2024-03-03 23:04:06 +03:00
Dean Herbert
59b9d29a79
Fix formatting? 2024-02-29 23:29:50 +08:00
Dean Herbert
4184a5c1ef
Add flag to allow backwards seeks in tests 2024-02-29 23:05:28 +08:00
Dean Herbert
5495c2090a
Add test coverage of gameplay only running forwards 2024-02-29 14:15:32 +08:00
Salman Ahmed
232ca5778f Improve spectator fail test 2024-02-29 00:09:58 +03:00
Joseph Madamba
8e462fbb38 Apply NRT to touched files 2024-02-27 23:58:28 -08:00
Joseph Madamba
e8a1061777 Add test for spectator player exit 2024-02-27 23:24:16 -08:00
Joseph Madamba
dee57c7e72 Refactor test to only allow init of actions 2024-02-27 23:24:16 -08:00
Bartłomiej Dach
e5be8838e6
Fix yet another failure 2024-02-20 18:42:01 +01:00
Bartłomiej Dach
b334b78b63
Make medal overlay respect overlay disable via activation mode 2024-02-20 16:31:31 +01:00
Bartłomiej Dach
e4971ae121
Add display queueing when multiple medals are granted in quick succession 2024-02-20 16:31:31 +01:00
Bartłomiej Dach
2e5b61302a
Implement basic medal display flow 2024-02-20 16:31:31 +01:00
Bartłomiej Dach
4911f5208b
Demote medal "overlay" to animation
I need the actual overlay to be doing way more things (receiving the
actual websocket events, queueing the medals for display, handling
activation mode), so the pre-existing API design of the overlay just
will not fly.
2024-02-20 16:31:31 +01:00
Joseph Madamba
8169d1ac80 Add twenty star counter in visual test 2024-02-16 22:47:38 -08:00
Salman Ahmed
583e71634f Always bring master/music volume to 50% 2024-02-16 11:20:07 +03:00
Salman Ahmed
6a1d118b21 Adjust tests again 2024-02-16 10:52:27 +03:00
Mike Will
22dafd8e9c fix typo 2024-02-15 18:56:09 -05:00
Salman Ahmed
df40f55c07
Merge branch 'master' into mute_detection 2024-02-16 01:35:02 +03:00
Salman Ahmed
6751f95eb6 Adjust test cases and approximate equality 2024-02-16 01:28:53 +03:00
Bartłomiej Dach
39fe078984
Merge branch 'master' into hit-object-result-allocations 2024-02-05 13:24:10 +01:00
Bartłomiej Dach
efe6bb25b1
Refactor result application around again to remove requirement for fields
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-02-05 13:21:01 +01:00
Dan Balasescu
b44f77cee1
Update R# + fix inspections 2024-02-02 21:00:28 +09:00
Mike Will
e4ec8c111b give better volume names to addVolumeSteps 2024-02-02 05:48:57 -05:00
Mike Will
906560f66d Fix mute button test
Lowering the master volume in the previous test meant that the
volume levels would end up being modified.
2024-02-02 04:06:22 -05:00
Mike Will
5d9200b4fe Update tests to reflect new restore target volume 2024-02-02 02:59:02 -05:00
Mike Will
dfd966e039 Improve silence detection in MutedNotification
Instead of checking the master and music volumes separately to
see if they're <= 1%, check the aggregate of the two volumes to
see if it's <= -60 dB.

When muted notification is activated, restore the aggregate volume
level to -30 dB.
2024-02-02 00:48:42 -05:00
Salman Ahmed
5a1b0004db Add failing test case 2024-02-02 01:26:03 +03:00
Dean Herbert
cbbe2f9dc0
Merge pull request #25480 from peppy/2fa
Add two factor authentication flow
2024-01-29 19:14:55 +09:00
Bartłomiej Dach
a41ba7c381
Fix more nullable inspections 2024-01-29 08:44:27 +01:00
Dean Herbert
fb24c66342
Mark ResultsScreen.Score as nullable
Is nullable in playlist results at very least.
2024-01-29 16:43:26 +09:00
Chandler Stowell
93bd3ce5ae update DrawableHitCircle.ApplyResult to pass this to its callback 2024-01-25 11:25:41 -05:00
Bartłomiej Dach
0d7834af5f
Ensure all remaining test usages of IAPIAccess.Login() also authenticate with second factor 2024-01-23 18:04:41 +01:00
Dean Herbert
2ab0be7606
Merge pull request #26669 from bdach/fix-score-submission-test-failures-again-aaaaaaaaAAAAAA
Fix score submission test failures due to checking audio playback validity (again)
2024-01-22 20:07:51 +09:00
Bartłomiej Dach
9b2740f8a4
Fix score submission test failures due to checking audio playback validity (again)
As seen in https://github.com/ppy/osu/actions/runs/7607899979/job/20716013982?pr=26662#step:5:75

In https://github.com/ppy/osu/pull/26484, I went "well if I'm moving the
enabling of validation of playback rate to `SubmittingPlayer` context,
then surely I can remove the local override in the test scene, right?"

Reader: Apparently I did not notice that `FakeImportingPlayer :
TestPlayer : SoloPlayer : SubmittingPlayer`. So no, I could not remove
the local override in the test scene.

You could probably attempt to conjure up some excuse about deep
inheritance hierarchies here but nah. Really just a failure to read
on my behalf as usual.
2024-01-22 11:15:42 +01:00
Bartłomiej Dach
77ef12ebb0
Merge branch 'master' into frame-stable-catchup-zoom 2024-01-22 10:37:06 +01:00
Dean Herbert
c4e9bcd140
Remove test guarantee of audio time not advancing 2024-01-18 20:06:53 +09:00
Dean Herbert
799c74cfe5
Simplify gameplay pause sequence 2024-01-18 14:17:19 +09:00
Dean Herbert
fb4efd992d
Add a fake load to visual test to restore previous testing behaviour 2024-01-18 14:01:37 +09:00
Dean Herbert
c362a93a36
Change frame stable catch-up method to allow for much faster sync 2024-01-18 14:01:37 +09:00
Bartłomiej Dach
5cb17bcacf
Merge pull request #26502 from frenzibyte/prevent-submission-with-invalid-mods
Add guard against submitting score with invalid mod instances
2024-01-17 11:39:32 +01:00
Salman Ahmed
485195d4c2 Fix submission test not asserting properly 2024-01-16 14:27:40 +03:00
Salman Ahmed
d346dd0650 Fix TestModReinstantiation failing due to custom mod being used 2024-01-15 15:01:13 +03:00
Dean Herbert
e6453853c2
De-dupe displayed hits in judgement counter 2024-01-15 16:02:59 +09:00
Dean Herbert
2d5a39b234
Add failing test coverage of duplicates in judgement counter display 2024-01-15 16:02:58 +09:00
Salman Ahmed
b1fae2bc6a Add failing test case 2024-01-13 16:24:49 +03:00
Bartłomiej Dach
6572fa4378
Only validate playback rate when in submission context
Temporary workaround for https://github.com/ppy/osu/issues/26404.

It appears that some audio files do not behave well with BASS, leading
BASS to report a contradictory state of affairs (i.e. a track that is
in playing state but also not progressing). This appears to be related
to seeking specifically, therefore only enable the validation of
playback rate in the most sensitive contexts, namely when any sort of
score submission is involved.
2024-01-12 14:59:15 +01:00
Bartłomiej Dach
600e4b6ef3
Adjust skinnable health display test scene for usability 2024-01-11 10:17:32 +01:00
Bartłomiej Dach
861080d3ae
Move simulated drain to separate test case
Having it on at all times was causing other tests to fail.
2024-01-11 10:04:37 +01:00
Dean Herbert
c2706ca91b
Also show drain on argon health display test 2024-01-11 00:31:31 +09:00
Dean Herbert
49d13cda6b
Fix failing test by setting health on source of truth 2024-01-10 23:09:43 +09:00
Dean Herbert
f1b4c305b0
Change skinnable health test scene to drain 2024-01-09 17:09:19 +09:00
Bartłomiej Dach
e686a6a1dd
Fix player submission test intermittent failures due to audio playback discrepancy logic kicking in
See https://github.com/ppy/osu/actions/runs/7384457927/job/20087439457#step:5:133.
2024-01-03 09:17:01 +01:00
Salman Ahmed
78cb6b6851 Abstractify LegacyComboCounter to re-use for mania 2023-12-30 05:29:22 +03:00
Salman Ahmed
e469e06271 Refactor CatchLegacySkinTransformer logic and remove HiddenByRulesetImplementation entirely 2023-12-30 03:55:45 +03:00
Bartłomiej Dach
1b7af989ec
Migrate BeatmapOffsetControl to use session static directly 2023-12-27 19:19:27 +01:00
Bartłomiej Dach
81bbdccee7
Rename ScoreInfo.{ -> Client}Version 2023-12-21 12:56:43 +01:00
Dean Herbert
a4baa0a716
Add versioning of local scores
For any potential future usage
2023-12-21 18:37:15 +09:00
Dean Herbert
43dc908257
Fix test value getting clobbered due to stupid stuff
Don't even ask. Just smile and nod.
2023-12-06 15:59:29 +09:00
Dean Herbert
79826dee58
Fix tests which were relying on SliderMultiplier==1 2023-12-06 13:50:10 +09:00
Salman Ahmed
c55bfc03ee Move private method 2023-12-05 22:06:53 +03:00
Salman Ahmed
20fd458fac Perserve miss animation when followed by a hit at same frame 2023-12-05 21:59:28 +03:00
Salman Ahmed
986f4fa407 Add test scenarios for same-frame judgements 2023-12-05 21:59:28 +03:00
Salman Ahmed
17577a6606 Add visual test case for late miss in argon health display 2023-12-04 23:01:11 +03:00
Dean Herbert
7ceb49fbc0
Add extra test coverage and handle case where still at loading screen 2023-11-24 15:05:39 +09:00
Dean Herbert
ef5dd24589
Update failing test coverage and fix onFail being called too often 2023-11-24 14:44:57 +09:00
Dean Herbert
51e2ce500d
Add test coverage of remote user failing immediately failing locally 2023-11-24 14:38:02 +09:00
Dean Herbert
73ad92189b
Add test coverage of remote player quitting immediately quitting locally 2023-11-24 14:26:09 +09:00
Dean Herbert
e06d79281d
Update tests to work with nested screen 2023-11-24 14:26:09 +09:00
Dean Herbert
dabbdf674b
Rename SoloSpectator to SoloSpectatorScreen 2023-11-24 14:26:08 +09:00
Dean Herbert
5d367c247c
Merge pull request #25547 from bdach/skin-editor-paste-catching-fire
Fix skin editor crashing when pasting with nothing in clipboard
2023-11-23 16:15:11 +09:00
Bartłomiej Dach
4edaaa3083
Add test coverage of skin editor copy-paste 2023-11-23 09:55:16 +09:00
Dan Balasescu
30309cdf11
Merge pull request #25415 from Poyo-SSB-forks/unify-ur
Change unstable rate calculation to account for rate-change mods
2023-11-23 09:53:28 +09:00
Bartłomiej Dach
b6e3e42445
Merge branch 'master' into bspline-sliders 2023-11-20 12:03:29 +09:00
Bartłomiej Dach
71714f8f6e
Add back test step for testing out argon health bar width 2023-11-15 13:33:14 +09:00
cs
fa976a5aa0 Fix code style/quality issues 2023-11-13 08:25:27 +01:00
Poyo
8c36604e58 Add rate-change UR tests 2023-11-12 11:16:06 -08:00
Poyo
d123ba5bce Fix broken tests 2023-11-12 11:13:38 -08:00
Bartłomiej Dach
3e8c89e282
Fix one more reference to removed setting 2023-11-12 07:42:41 +09:00
cs
54b8244a18 CI Fixup 2023-11-11 15:02:06 +01:00
Thomas Müller-Höhne
926636cc03 Generalize Bezier curves to BSplines of Nth degree 2023-11-11 13:32:53 +01:00
Bartłomiej Dach
ea556abad8
Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters 2023-11-11 21:28:29 +09:00
Bartłomiej Dach
ee56b4d205
Use barely better assertion fail message in test 2023-11-11 20:56:05 +09:00
Bartłomiej Dach
b7972e3c84
Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters 2023-11-11 20:16:14 +09:00
Bartłomiej Dach
b247b94ecb
Revert test changes
They were broken because `SerialisedDrawableInfo` is a reference type
and as such equality checks will use reference equality rather than
member equality.
2023-11-11 19:32:46 +09:00
Bartłomiej Dach
21e1d68b15
Remove unused using directive 2023-11-11 15:52:24 +09:00