573 Commits

Author	SHA1	Message	Date
Berkan Diler	08d2fbeb8e	Use new ArgumentNullException.ThrowIfNull throw-helper API	2022-12-22 21:27:59 +01:00
Bartłomiej Dach	0a49c8c5d6	Add missing unsubscriptions in multiple mania components	2022-12-21 20:22:40 +01:00
Dylan Nantz	ee945c9b58	disable mouse input to touchscreen controls	2022-12-14 10:34:21 -05:00
Dan Balasescu	7bc8908ca9	Partial everything	2022-11-27 00:00:27 +09:00
Dean Herbert	1aa0e40f2f	Add "Component" prefix to lookup naming	2022-11-09 17:46:43 +09:00
Dean Herbert	c908969d9b	Rename ISkinComponent to ISkinLookup	2022-11-09 17:46:43 +09:00
Dean Herbert	e1e12f41e9	Add more comprehensive inline comment	2022-10-07 21:00:11 +09:00
Dan Balasescu	d63f196626	Merge branch 'master' into fix-mania-rewinding	2022-10-07 20:45:56 +09:00
Dan Balasescu	b5746f5f20	Merge pull request #20602 from peppy/mania-fix-object-colouring ... Fix osu!mania not colours not always updating when switching skins	2022-10-07 19:22:55 +09:00
Dean Herbert	4b772643e9	Use bindable flow for transfer of accent colour from columns to hit objects ... This fixes the case where changing a skin during gameplay runtime does not correctly convey colour information to off-screen `DrawableHitObject`s.	2022-10-07 18:25:08 +09:00
Dean Herbert	42afc8e568	Merge branch 'master' into fix-mania-rewinding	2022-10-07 18:17:19 +09:00
Dan Balasescu	721189b23a	Merge branch 'master' into argon-mania-note	2022-10-07 17:34:11 +09:00
Dean Herbert	c7405d1c1c	Add missing immediate application of AccentColour in DefaultKeyArea ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2022-10-07 17:00:10 +09:00
Dean Herbert	207c76bdec	Fix column lighting and key area not handling rewind correctly	2022-10-07 15:46:11 +09:00
Dean Herbert	e81f550150	Fix hit explosions not being cleaned up correctly when rewinding	2022-10-07 15:46:11 +09:00
Dean Herbert	a543222a2b	Add ability to pad stage vertically	2022-10-07 15:45:35 +09:00
Dean Herbert	f1ea61b1a2	Remove unused colour code	2022-10-07 15:24:37 +09:00
Dean Herbert	9a92ff1681	Fix SourceChanged unbind directionality and add null check	2022-10-07 15:24:37 +09:00
Dean Herbert	dee01abab1	Add method to get stage from column index	2022-10-07 15:24:37 +09:00
Dean Herbert	0d21c0e49c	Remove StageDefinition from configuration lookups ... I added this for future usage, but it turns out I can get the definitions directly from `ManiaBeatmap`.	2022-10-07 15:24:36 +09:00
Dean Herbert	6b79f16461	Make Column.AccentColour bindable	2022-10-07 15:24:36 +09:00
Dean Herbert	532d101080	Remove unused class	2022-10-07 15:24:36 +09:00
Dean Herbert	276395f1af	Fix column colour not updating on skin change	2022-10-07 15:24:36 +09:00
Dean Herbert	5c48d8931a	Add StageDefinition to ManiaSkinConfigurationLookup and make column background colour lookup work	2022-10-07 15:24:36 +09:00
Dean Herbert	9c979044dc	Move AccentColour assignment to inside Column	2022-10-07 15:24:36 +09:00
Dean Herbert	46c3cfe54d	Remove StageDefinition flow in ManiaSkinComponent	2022-10-07 15:24:36 +09:00
Dean Herbert	7796a4c109	Cache StageDefinition for consumption (and remove ColumnType)	2022-10-07 15:24:36 +09:00
Dean Herbert	df3ad618e1	Move ColumnType to constructor	2022-10-07 15:24:36 +09:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Bartłomiej Dach	e4028b8fc1	Remove index ctor param from ColumnHitObjectArea ... No longer used since 5692cecaa4.	2022-02-01 21:49:52 +01:00
Dean Herbert	2f88efd3c3	Pass column in rather than accessing parent	2022-02-01 00:53:56 +09:00
Dean Herbert	0e764538e0	Retrieve KeyBindingContainer via DI rather than traversal lookup	2022-01-31 17:05:04 +09:00
Dean Herbert	cc7fb0e559	Add mouse click support and increase area to full column height	2022-01-31 16:37:02 +09:00
pikokr	b0d61a18b0	Load keyBindingContainer once on LoadComplete() & make touch area height to const	2022-01-07 15:57:30 +09:00
pikokr	4cb8272d14	Column Touch area & highlighting on start	2021-12-30 17:37:19 +09:00
pikokr	dec1f31749	Make KeyBindingContainer public	2021-12-28 22:43:07 +09:00
파링	9ed7139582	Merge branch 'master' into master	2021-12-28 22:36:55 +09:00
pikokr	62d6bb8c2e	Trigger touch on click key area	2021-12-28 22:35:45 +09:00
pikokr	59b4aea5f9	Make method and property name to match class name	2021-12-28 21:52:46 +09:00
Joseph Madamba	0bd928b5cd	Fix incorrect naming / apply review	2021-12-27 21:44:19 -08:00
Joseph Madamba	7de43e3aba	Fix most open compound words in identifiers being closed	2021-12-27 20:26:28 -08:00
Joseph Madamba	98524d60a4	Fix clear identifier typos	2021-12-27 20:26:28 -08:00
pikokr	58994b790c	Get key binding container once instead of getting on every touch	2021-12-27 21:20:52 +09:00
pikokr	327822de5b	Add touchscreen support for osu!mania ruleset	2021-12-27 19:41:36 +09:00
Dean Herbert	1eed2436e6	Clean up unused resolved properties	2021-12-03 18:49:49 +09:00
smoogipoo	bc37cb6f43	Merge branch 'master' into no-more-difficulty-control-points-info	2021-10-08 18:41:17 +09:00
Dean Herbert	b339c149d8	Copy BaseDifficulty to Beatmap<T> and move all write operations across	2021-10-06 15:10:45 +09:00
Dean Herbert	46bafb6252	Merge branch 'master' into no-more-difficulty-control-points-info	2021-09-28 13:53:56 +09:00
smoogipoo	f9d5abff8a	Update with keybinding changes	2021-09-16 18:26:12 +09:00
Dean Herbert	d587dc6203	Populate new approach rate where required	2021-09-03 17:11:12 +09:00
Dean Herbert	b907c2f4f6	Fix osu! judgements getting scaled twice over different durations	2021-09-02 16:31:43 +09:00
Dean Herbert	6aa894e55e	Split out separate component	2021-08-25 16:56:44 +09:00
smoogipoo	3ac58d6838	Fix min/max values not being passed to inner time range	2021-07-16 19:32:31 +09:00
smoogipoo	fa8e5013c5	Adjust mania speed range	2021-07-16 18:22:34 +09:00
Dean Herbert	70a844ac10	Remove allowFallback parameters completely	2021-05-27 14:50:42 +09:00
Dean Herbert	cc5c702a92	Apply all properties after cast (looks cleaner)	2021-05-19 17:31:47 +09:00
smoogipoo	98e77a30d3	Move column changing logic to ManiaSelectionHandler	2021-05-13 20:13:50 +09:00
smoogipoo	0fa3027ab9	Increase pool sizes a bit	2021-05-12 17:37:59 +09:00
smoogipoo	7913189aa9	Turn on pooling	2021-05-12 16:56:23 +09:00
smoogipoo	789025a7ce	Update playfield/stage/column implementations for pooling	2021-05-12 16:56:07 +09:00
smoogipoo	5692cecaa4	Initial implementation of DHO pooling	2021-05-12 16:35:05 +09:00
smoogipoo	672108edcf	Use container instead of array for field	2021-05-12 13:27:12 +09:00
Dean Herbert	3428056113	Remove unnecessary usage of ChildrenEnumerable for array assignment	2021-05-12 13:00:02 +09:00
Dean Herbert	bf44c09a91	Add name identifying container and rename index variable	2021-05-12 12:59:46 +09:00
Bartłomiej Dach	d706073e01	Trim empty remarks xmldoc tag	2021-05-11 23:08:50 +02:00
smoogipoo	713c169332	Fix mania crashing on playing samples after skin change	2021-05-11 16:21:21 +09:00
Dean Herbert	f86f323625	Add a basic guard against setting ScrollMethod too late in initialisation	2021-02-04 22:28:17 +09:00
smoogipoo	8295fb9081	Implement mania constant speed mod	2021-02-03 16:28:22 +09:00
Dean Herbert	1793385e96	Pass a score to the replay recorder to allow reading more general scoring data	2020-12-14 16:52:14 +09:00
smoogipoo	1794bfeddb	Move offset into legacy mania judgement	2020-12-14 13:07:55 +09:00
smoogipoo	ca11eeefdf	Merge branch 'master' into mania-legacyskin-scoreposition	2020-12-14 11:25:34 +09:00
Firmatorenio	cf7303e072	dotnet format	2020-12-13 22:54:01 +06:00
Firmatorenio	3741c2339a	simplify implementation and adjust the default values	2020-12-13 22:43:36 +06:00
Firmatorenio	2108844319	apply ScorePosition to the judgement container	2020-12-13 22:01:08 +06:00
Firmatorenio	f14e49c72e	fetch ScorePosition from the skin	2020-12-13 21:59:04 +06:00
Firmatorenio	60379b09db	added a container for the judgements to move up or down	2020-12-13 18:14:41 +06:00
ekrctb	e3c035fe9c	Adjust namespace	2020-12-07 12:32:52 +09:00
ekrctb	f3f5ec7665	Fix Column not calling base.Add	2020-11-26 18:08:40 +09:00
Bartłomiej Dach	24d7fa03d8	Merge branch 'master' into legacy-jugement-match-stable-transforms	2020-11-18 20:33:58 +01:00
Bartłomiej Dach	5156de3a10	Merge branch 'master' into fix-judgement-transform-logic	2020-11-18 19:20:11 +01:00
Dean Herbert	20bb64c627	Fix mania misses not correctly animating (temporary solution)	2020-11-18 19:34:00 +09:00
Dean Herbert	94886a09b2	Remove fades from DrawableJudgement itself	2020-11-18 19:03:34 +09:00
Dean Herbert	8247e6ce91	Move result type to ctor	2020-11-17 15:43:54 +09:00
Dean Herbert	f465dd5a5e	Move all extended animation logic out of DrawableJudgement	2020-11-17 14:59:34 +09:00
smoogipoo	77942af3a6	Fix hold note judgements displaying incorrectly	2020-11-17 13:37:58 +09:00
smoogipoo	626231d906	Completely remove check as it can occur for hits too	2020-11-11 12:53:32 +09:00
smoogipoo	1173ef0890	Fix mania notelock crashing with overlapping hitwindows	2020-11-11 12:37:00 +09:00
smoogipoo	e789e06c86	Don't display hold note tick judgements	2020-09-29 16:33:38 +09:00
smoogipoo	aa151e4cd7	Merge branch 'master' into mania-notelock	2020-08-31 13:31:41 +09:00
smoogipoo	7a5292936e	Add some xmldocs	2020-08-27 21:15:05 +09:00
smoogipoo	6f93df0b9d	Fix ticks causing hold note misses	2020-08-27 21:05:12 +09:00
smoogipoo	deb172bb6c	Implement basic mania hit order policy	2020-08-27 20:24:21 +09:00
smoogipoo	0800e43796	Remove padding from columns	2020-08-25 19:57:49 +09:00
smoogipoo	ff72ccabd8	Rename method	2020-08-25 18:44:32 +09:00
smoogipoo	723e5cafb6	Fix column potentially added at wrong indices	2020-08-25 14:49:04 +09:00
smoogipoo	018523a43a	Rework to remove cross-class pollutions	2020-08-25 01:21:27 +09:00
Jihoon Yang	138dc5929e	Changed MIN_TIME_RANGE as well	2020-08-18 01:46:41 -07:00
Jihoon Yang	4ddc04793f	Changed MAX_TIME_RANGE instead of the single instance	2020-08-18 01:44:30 -07:00
Dean Herbert	f139423786	Merge branch 'master' into mania-hitexplosion-pooling	2020-07-30 10:40:29 +09:00
smoogipoo	5df406a035	Add pooling for mania judgements	2020-07-29 16:41:10 +09:00