Dean Herbert
e9b97f7937
Fix tournament crashing when osu!(stable) is at ranking screen at startup
2021-08-28 14:28:33 +09:00
Dean Herbert
7fbeb9ecc7
Add failing test coverage for tournament startup states
2021-08-28 14:28:30 +09:00
Salman Ahmed
589f2863ca
Move incompatibility tooltip logic to local player mod select overlays
...
This one turned out to be a bit more involved, due to tooltips being
shared and having the potential of being used somewhere where it
shouldn't be, due to the same content type matching.
That's the reason I've defined a protected `TargetContentType`, to be
able to separate "local player mod tooltips" and regular mod tooltips
apart.
Definitely unsure about the solution, but that's as far as I can think
of right now.
2021-08-28 02:38:46 +03:00
Salman Ahmed
e527bfd4bf
Move incompatibility icon logic to local player mod select overlays
2021-08-28 02:37:46 +03:00
Salman Ahmed
69f5705ca0
Merge pull request #14526 from peppy/update-framework
...
Update framework
2021-08-28 01:42:50 +03:00
Dean Herbert
681a87d4ec
Update framework
2021-08-28 07:08:06 +09:00
Dean Herbert
804ca88d63
Update framework
2021-08-27 19:52:45 +09:00
Salman Ahmed
378734a7f8
Separate solo spectator player and "exit on restart" logic to own class
2021-08-27 13:24:37 +03:00
Salman Ahmed
1650fbb8be
Add failing test steps
2021-08-27 13:24:37 +03:00
Dean Herbert
2bfb9d5478
Merge pull request #14512 from nekodex/lobby-sounds
...
Add sounds for some lobby events
2021-08-27 19:21:11 +09:00
Salman Ahmed
b7a0316194
Shorten test player count to 4 for less steps
2021-08-27 13:14:56 +03:00
Dean Herbert
97f27897b1
Add test coverage of mass multiplayer event firing
2021-08-27 18:57:35 +09:00
Dean Herbert
2b06dacd0e
Change debounce back to using scheduler
...
Should better allow for adjusting in the future, as well.
2021-08-27 18:57:19 +09:00
Dean Herbert
33aa48bcf6
Merge branch 'master' into lobby-sounds
2021-08-27 18:46:12 +09:00
Dean Herbert
23414b0c63
Combine test scene to avoid huge copy paste
2021-08-27 18:44:44 +09:00
Dean Herbert
34d185d846
Convert final step to until step to avoid unnecessary delays
2021-08-27 18:39:36 +09:00
Dean Herbert
7d9bae4507
Update resources
2021-08-27 18:29:49 +09:00
Dan Balasescu
8e57547ec3
Merge pull request #14510 from peppy/avoid-default-skin-judgement-transform-overhead
...
Change default skin's judgement result transform to reduce allocation overhead
2021-08-27 10:34:44 +09:00
Dan Balasescu
f0296e5d12
Merge branch 'master' into avoid-default-skin-judgement-transform-overhead
2021-08-27 10:02:40 +09:00
Dan Balasescu
4f22acb632
Merge pull request #14507 from peppy/path-control-point-bindable-removal
...
Remove bindable usage in `PathControlPoint`
2021-08-27 10:02:29 +09:00
Dan Balasescu
a28bc9f6b2
Merge branch 'master' into path-control-point-bindable-removal
2021-08-27 09:37:37 +09:00
Bartłomiej Dach
aacca006e4
Merge pull request #14487 from frenzibyte/alternative-difficulty-bindable
...
Fix unbind exception in `DifficultyBindable` due to different bindable type bindings
2021-08-26 23:29:54 +02:00
Bartłomiej Dach
2ef2af17eb
Merge branch 'master' into alternative-difficulty-bindable
2021-08-26 23:07:52 +02:00
Bartłomiej Dach
b2ab670ae4
Merge pull request #14506 from peppy/skip-overlay-optimisations
...
Remove delegate overhead in `SkipOverlay`
2021-08-26 23:00:04 +02:00
Bartłomiej Dach
d71dff4340
Merge branch 'master' into skip-overlay-optimisations
2021-08-26 22:38:17 +02:00
Salman Ahmed
cea632463e
Remove empty newline
2021-08-26 22:30:20 +03:00
Bartłomiej Dach
23df13d6d2
Merge pull request #14495 from frenzibyte/fix-mania-editor
...
Fix osu!mania editor crashing on compose screen load
2021-08-26 21:28:26 +02:00
Bartłomiej Dach
875ef3e68f
Merge branch 'master' into fix-mania-editor
2021-08-26 21:00:20 +02:00
Dean Herbert
90e81a595d
Move DrumSampleTriggerSource into its own class to avoid nested references
2021-08-26 17:19:46 +09:00
Dean Herbert
f078a9d2bf
Fix incorrect step type
2021-08-26 17:17:39 +09:00
Dean Herbert
15aa0458bc
Use PausableSkinnableSound instead
2021-08-26 17:15:36 +09:00
Dean Herbert
ec85d7f356
Remove unused helper method
2021-08-26 17:15:23 +09:00
Dean Herbert
982c4eff14
Merge branch 'master' into taiko-drum-refacor
2021-08-26 17:13:14 +09:00
Salman Ahmed
dc16883681
Merge pull request #14511 from peppy/score-processor-enum-getvalue-overhead-reduction
...
Avoid `Enum.GetValues` allocation overhead in each score population pass
2021-08-26 10:39:11 +03:00
Salman Ahmed
2f26d270a3
Merge branch 'master' into score-processor-enum-getvalue-overhead-reduction
2021-08-26 09:55:09 +03:00
Salman Ahmed
fb732785d6
Merge pull request #14509 from peppy/replay-frame-comparison-array-overhead-reduction
...
Avoid unnecessary array/LINQ operations when replay frames have no action changes
2021-08-26 09:54:36 +03:00
Salman Ahmed
15812520bd
Replace global editor test case with mania compose screen test scene
2021-08-26 09:45:01 +03:00
Salman Ahmed
b0bab4fda6
Merge branch 'master' into replay-frame-comparison-array-overhead-reduction
2021-08-26 09:30:58 +03:00
Jamie Taylor
56baecdde4
Add missing interaction sfx to MatchTypePicker
2021-08-26 15:30:20 +09:00
Salman Ahmed
10f80ddd90
Merge pull request #14508 from peppy/follow-point-lifetime-entry-bind-overhead-reduction
...
Avoid unnecessary unbind operations when constructing `FollowPointLifetimeEntry`
2021-08-26 09:29:28 +03:00
Jamie Taylor
e341f471b0
Add lobby sfx for join/leave/kick/ready/unready events
2021-08-26 15:29:22 +09:00
Salman Ahmed
b9ea984c36
Remove redundant default value
2021-08-26 08:18:58 +03:00
Dean Herbert
17f6efc6fe
Fix missed cases of incorrect .Value usage
...
Changing from `Bindable` to `Nullable` comes with its issues...
2021-08-26 14:02:57 +09:00
Dean Herbert
e633b2716d
Fix regression in outro skip handling logic
2021-08-26 13:58:45 +09:00
Dean Herbert
e15198f077
Update missed tests
2021-08-26 13:47:10 +09:00
Dean Herbert
e32933eb54
Avoid Enum.GetValues in each score population pass
2021-08-26 13:37:53 +09:00
Dean Herbert
8cfb3d456b
Avoid expensive text spacing transforms for now
2021-08-26 13:15:27 +09:00
Dean Herbert
f4199958d9
Avoid unnecessary array/LINQ operations when replay frames have no action changes
2021-08-26 13:03:50 +09:00
Dean Herbert
69064c1938
Avoid unnecessary unbind operations when constructing FollowPointLifetimeEntry
2021-08-26 12:35:31 +09:00
Dean Herbert
6dcd9427ac
Remove bindable usage in PathControlPoint
...
This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.
I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.
2021-08-26 12:33:53 +09:00
