2374 Commits

Author	SHA1	Message	Date
Dan Balasescu	cb23f03d4b	Merge pull request #24109 from Hydria/LNFixHotfix ... Adjust LN value scaling to bring overrated LN maps more in line	2023-08-17 09:30:19 +02:00
Dan Balasescu	7d8cef83e6	Merge branch 'master' into LNFixHotfix	2023-08-15 13:45:06 +02:00
Dan Balasescu	5678db4e70	Fix test + cleanup	2023-08-15 19:42:32 +09:00
Dan Balasescu	e34a9a0001	Disable hold end conversion for mania HoldOff mod	2023-08-15 19:30:40 +09:00
Dan Balasescu	ec9e7f14a8	Disable SVs from being visualised in mania editor	2023-08-15 18:51:24 +09:00
Dean Herbert	3526032c9a	Merge pull request #24544 from smoogipoo/pool-mania-barlines ... Add pooling for mania barlines	2023-08-15 15:21:59 +09:00
Dan Balasescu	6a7b0786c9	Add barline pooling for mania	2023-08-15 13:33:49 +09:00
Bartłomiej Dach	3178865cd3	Fix playfield skinnable layer bounds being incorrectly calculated with multiple stages ... Closes #24514. The original PR was _supposed_ to be handling this, and had code that _looked_ like it would handle it, but was in fact subtly wrong, as the union of `RectangleF.Empty` (initial value of `area`) and an arbitrary other rectangle is _not_ the second rectangle, but rather a rectangle that contains _both_ the second rectangle and the point (0,0), thus leading to the bound calculation fail.	2023-08-12 21:55:20 +02:00
Dean Herbert	06fe5583cb	Expose a new SSDQ from playfield for skinnable area bounds	2023-07-28 15:47:57 +09:00
Hydria	1e19def153	2nd fix to cover all scenarios	2023-07-22 16:44:01 +01:00
Bartłomiej Dach	157aec5144	Fix mania key count slider still using circle size precision	2023-07-22 16:10:58 +02:00
Hydria	ef2134a92a	Fix issue with processing LN orders ... Related Issue: https://github.com/ppy/osu/issues/22756 The trigger in question happens when (1) in a chord: a longer LN, then a shorter LN is processed respectively. (2) in a chord: a long LN, then a note is processed respectively. however, given the opposite processing step, it will fail to trigger. We observe that both situations have the same pattern, however has undeterministic results, which only depends on the order the mapper placed each note.	2023-07-22 10:45:48 +01:00
Dean Herbert	fd2bdc10c7	Fix "key count" setting showing as "circle size" in osu!mania editor ... Closes https://github.com/ppy/osu/issues/12904.	2023-07-21 18:52:29 +09:00
Dean Herbert	e58488d04a	Fix incorrect comparer implementation	2023-07-15 11:19:34 +09:00
Dean Herbert	d4fb0bef95	Fix osu!mania scores failing to convert to new standardised score due to cast failure ... Regressed in https://github.com/ppy/osu/pull/23917. Closes #24217.	2023-07-14 19:38:10 +09:00
Bartłomiej Dach	d5912165e9	Merge branch 'master' into results-screen-component-metrics	2023-07-13 19:53:52 +02:00
Dean Herbert	9ad63bae37	Add missing heading for statistics section in results screen	2023-07-13 18:50:52 +09:00
Dean Herbert	947b40149f	Adjust metrics of SimpleStatisticTable	2023-07-13 18:45:32 +09:00
Dan Balasescu	47a65f8890	Merge branch 'master' into fix-imperfect-simulation	2023-07-13 15:41:54 +09:00
Bartłomiej Dach	7be5e0e978	Implement back-and-forth conversion of ModScoreV2 and LegacyMods	2023-07-09 16:15:21 +02:00
Bartłomiej Dach	9dae806734	Use IsRewinding in a few more places	2023-07-08 13:32:24 +02:00
Dean Herbert	e0fc97bb93	Replace various local implementations of rewinding checks with new property	2023-07-07 15:21:24 +09:00
Dean Herbert	1629024111	ILegacyScoreProcessor -> ILegacyScoreSimulator	2023-07-04 17:32:54 +09:00
Hydria	5d5e6a5ab7	Finalised LN Adjustment Values ... Spent a couple days discussing this on the pp rework server about values that were the most acceptable, these seemed to be the best from the community standpoint of top players. Note: This is more to fix issues with the current system, not to be a final solution. Related Google Sheets Page: https://docs.google.com/spreadsheets/d/1P0AxfdKvMHwWBQder4ZkFGO1fC9eADSGCryA5-UGriU/edit?usp=sharing	2023-07-03 17:45:30 +01:00
Dan Balasescu	426f11b824	Apply a few other code reviews	2023-06-29 17:28:06 +09:00
Dan Balasescu	c6ad184d94	Move Ruleset method to ILegacyRuleset interface	2023-06-29 17:24:37 +09:00
Dan Balasescu	09bc8e45de	Refactoring	2023-06-28 16:14:32 +09:00
Dan Balasescu	a9c65d200a	Initial conversion of scores	2023-06-26 22:19:01 +09:00
Dan Balasescu	e1d723a2cc	Merge branch 'master' into diffcalc-total-scorev1	2023-06-26 14:32:14 +09:00
Bartłomiej Dach	e3a89a6273	Fix remaining obvious CI inspections	2023-06-24 16:07:01 +02:00
Dan Balasescu	5fadadc3d0	Merge branch 'master' into diffcalc-total-scorev1	2023-06-24 02:46:15 +09:00
Dean Herbert	df5b389629	Manual fixes to reduce warnings to zero	2023-06-24 01:52:53 +09:00
Dan Balasescu	06565871d6	Add flag to disable computing legacy scoring values	2023-06-24 01:03:18 +09:00
Dean Herbert	0ab0c52ad5	Automated pass	2023-06-24 01:00:03 +09:00
Dan Balasescu	bfa449e47a	Adjust attribute data	2023-06-19 21:38:13 +09:00
Maksim Kan	f70342bd67	Fix Triangle skin colors with Dual Stage mod	2023-06-17 10:12:26 +03:00
Bartłomiej Dach	b36ded0ba9	Merge pull request #23936 from peppy/fix-mania-hold-note-rewind-visuals ... Fix osu!mania hold notes sometimes looking incorrect after rewind	2023-06-16 20:45:40 +02:00
Dean Herbert	3b1f92d8b8	Fix fix logic causing further regression on release	2023-06-17 01:37:09 +09:00
Dean Herbert	b5de109cb3	Fix osu!mania hold notes sometimes looking incorrect after rewind	2023-06-16 14:54:19 +09:00
Dan Balasescu	145530035c	Optimise mania density calculation during beatmap conversion	2023-06-15 20:00:15 +09:00
Dan Balasescu	975e9baf43	Fix exception with no matching mods	2023-06-15 19:55:51 +09:00
Dan Balasescu	0844a21a51	Merge branch 'master' into diffcalc-total-scorev1	2023-06-15 19:33:29 +09:00
Bartłomiej Dach	0065334241	Fix mania autoplay simulation judging objects in different order to gameplay	2023-06-14 21:50:19 +02:00
Dan Balasescu	13d1f9c902	Add ScoreV1 calculation for ManiaRuleset	2023-06-13 23:28:45 +09:00
Dean Herbert	dbb7ddac52	Change osu!mania scoring ratio to 99% acc (to match previous lazer scoring)	2023-06-08 20:55:13 +09:00
Bartłomiej Dach	c8507837d1	Remove redundant initialisation of Children to empty array	2023-06-07 21:51:46 +02:00
Bartłomiej Dach	8463f5c7dd	Spell out location of external proxy explicitly	2023-06-07 21:50:16 +02:00
Bartłomiej Dach	f069f982d4	Merge branch 'master' into mania-barlines-behind-notes	2023-06-07 21:43:39 +02:00
Bartłomiej Dach	7fa082cc1d	Merge pull request #23770 from peppy/add-catch-beat-snap-grid ... Add beat snap grid for osu!catch editor	2023-06-07 18:35:14 +02:00
Bartłomiej Dach	c50a5498e9	Merge pull request #23769 from peppy/update-mania-colours ... Update argon osu!mania column colours in line with latest proposal	2023-06-07 16:55:54 +02:00
Dean Herbert	d57c2ab7e4	Fix osu!mania barlines showing in front of notes ... Closes #23412.	2023-06-07 14:23:23 +09:00
Salman Ahmed	62cb6a98ca	Remove redundant nullable suppression directives	2023-06-07 08:20:41 +03:00
Dean Herbert	6d446d3e97	Fix incorrect colouring of beat snap grids (mania and catch)	2023-06-07 12:25:34 +09:00
Dean Herbert	cdd931633d	Change 3K middle key to "special" purple colour ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-06-07 12:10:30 +09:00
Bartłomiej Dach	92c2320689	Merge pull request #23776 from peppy/fix-scroll-time-decimal ... Fix osu!mania scroll speed milliseconds having too much precision	2023-06-06 22:34:08 +02:00
Dean Herbert	6b18f2f2bb	Fix osu!mania scroll speed milliseconds having too much precision ... Closes #23750.	2023-06-06 21:43:56 +09:00
Dean Herbert	7a1766e378	Update argon osu!mania column colours in line with latest proposal ... Matches https://github.com/ppy/osu/discussions/21996#discussioncomment-5516872.	2023-06-06 16:42:20 +09:00
Dean Herbert	b8d9c9ff93	Move ApplyGameWideClock to extension method ... I don't see an issue with applying this workaround to more places, even though it is a workaround, because it marks each usage very clearly. If we design a better solution in the future it should be easy to replace the usages.	2023-06-06 16:07:50 +09:00
Bartłomiej Dach	331e90f720	Merge branch 'master' into tidy-results-grid-usage	2023-06-03 19:45:23 +02:00
Dan Balasescu	e402c6d2b4	Write max combo attribute from base class	2023-06-02 21:53:25 +09:00
Bartłomiej Dach	4daf1fcb7d	Merge pull request #23721 from peppy/fix-mania-hold-not-early-hit ... Fix osu!mania hold notes snapping to judgement area too early on early hits	2023-06-01 21:57:36 +02:00
Dean Herbert	00bf79d51f	Merge pull request #23691 from smoogipoo/mania-scroll-speed ... Replace mania scroll "time" with scroll "speed"	2023-06-01 17:23:27 +09:00
Dean Herbert	98f35f7481	Fix osu!mania hold notes snapping to judgement area too early on early hits ... Closes https://github.com/ppy/osu/issues/23515.	2023-06-01 16:06:35 +09:00
Dean Herbert	985604fab5	Return StatisticItems rather than StatisticRows from ruleset ... There were no usages of more than one column being provided per row, so it seemed like unnecessarily complexity. I'm currently trying to reduce complexity so we can improve the layout of the results screen, which currently has up to three levels of nested `GridContainer`s. Of note, I can't add backwards compatibility because the method signature has not changed in `Ruleset` (only the return type). If we do want to keep compatibility with other rulesets, we could designate a new name for the updated method.	2023-06-01 14:35:15 +09:00
Dan Balasescu	b456c36f64	Migrate in InitialiseDefaults()	2023-05-30 17:27:48 +09:00
Dan Balasescu	1c199b83e3	Replace mania scroll "time" with scroll "speed"	2023-05-29 21:22:23 +09:00
Dan Balasescu	fee3d43596	Merge branch 'master' into scorev2	2023-05-23 19:07:54 +09:00
Dan Balasescu	30a296bd09	Rename parameters	2023-05-19 17:27:02 +09:00
Dan Balasescu	d74bf2a096	Refactor for safety	2023-05-19 14:37:26 +09:00
Dan Balasescu	2ae34530f7	Avoid NaN values during ApplyBeatmap processing()	2023-05-19 14:14:34 +09:00
Dan Balasescu	7cbf48ffcf	Fix TestSceneScoring and incorrect combo calculations	2023-05-19 14:09:19 +09:00
Dan Balasescu	8b56a3f87d	Remove ClassicScoreMultiplier and DefaultScoreProcessor	2023-05-19 12:24:52 +09:00
Dean Herbert	f443cfb93e	Move blueprint validity conditions to allow more correct external usage of EndPlacement ... Until now, these were haphazardly enforce inline in blueprint implementations. The only thing stopping complete breakage is that `EndPlacement` wasn't called (too much) from outside the blueprint, leaving them responsible for their own placement. By moving this conditional out of the provided paramters to `EndPlacement`, it allows more flexible usage of that method externally. Coming in a future PR.	2023-05-12 16:02:22 +09:00
Dan Balasescu	a7b623f52a	Reimplement classic scoring mode	2023-05-09 20:21:38 +09:00
Dan Balasescu	3c3c812ed6	Initial implementation of ScoreV2	2023-05-09 19:33:33 +09:00
Bartłomiej Dach	efc4df95eb	Merge pull request #23429 from peppy/fix-incorrect-mania-description-keys ... Fix incorrect special style description text	2023-05-09 07:04:57 +02:00
Bartłomiej Dach	0a47ffcbdd	Match generally used casing ... Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>	2023-05-09 07:03:13 +02:00
Bartłomiej Dach	1ff1730948	Remove no-longer-correct remark	2023-05-08 22:35:41 +02:00
Bartłomiej Dach	3f45948664	Merge branch 'master' into fix-mania-head-note-animation	2023-05-08 22:23:01 +02:00
Dean Herbert	27c10cbdb7	Remove clamping of sizingContainer in DrawableHoldNote to fix head note alignment	2023-05-08 18:14:07 +09:00
Dean Herbert	814f0b3fed	Add back early return in OnReleased for safety	2023-05-08 15:43:11 +09:00
Dean Herbert	85d0c56cd2	Fix incorrect special style description text ... Closes https://github.com/ppy/osu/issues/23428.	2023-05-08 13:00:45 +09:00
Dean Herbert	6a59ded1ba	Move logic to Update instead	2023-05-03 15:18:37 +09:00
Dean Herbert	4013cdcfa8	Merge branch 'master' into mania-fix-hold-note-rewind	2023-05-03 15:04:59 +09:00
OliBomby	e7a478ce9c	Update convert-samples-expected-conversion.json	2023-04-30 16:04:03 +02:00
OliBomby	d97daee96b	remove all non-test usage of SampleControlPoint	2023-04-26 13:55:39 +02:00
OliBomby	39d9f0c3f5	removing using	2023-04-26 13:22:13 +02:00
OliBomby	6c70948681	Remove IContext & add IHasGenerateTicks	2023-04-26 13:10:57 +02:00
OliBomby	e4b64bdc3e	clean up code stuff	2023-04-25 19:06:29 +02:00
OliBomby	ea1e6e9798	Add LegacyContext	2023-04-25 12:12:46 +02:00
OliBomby	a4c6850ab2	made the SampleControlPoint and DifficultyControlPoint obsolete	2023-04-25 11:34:09 +02:00
Dan Balasescu	ad51f880e0	Remove overrides on DC/NC mods	2023-04-10 17:49:29 +09:00
Dan Balasescu	15f6bc155e	Add progressive score multiplier for HT	2023-04-10 13:35:48 +09:00
Dan Balasescu	c923482976	Add progressive score multiplier for DT	2023-04-10 13:31:48 +09:00
Bartłomiej Dach	2b525b626c	Revert to previous conditional style	2023-03-28 06:22:00 +02:00
Bartłomiej Dach	c54934cb45	Fix hit lighting misalignment on argon skin with upscroll	2023-03-27 18:15:01 +02:00
Bartłomiej Dach	b5e04791e9	Merge branch 'master' into mania-shadow-icon-changes	2023-03-20 19:33:52 +01:00
Bartłomiej Dach	fe91f85f6f	Reuse colour constants in fallback path	2023-03-20 18:16:33 +01:00
Dean Herbert	d87f0557ce	Update colours for 3k to not use double-purples	2023-03-15 17:18:45 +09:00
Dean Herbert	5aebbac6c5	Fix osu!mania hold note animations not correctly re-applying after rewind ... There's early exit logic in `OnPressed`/`OnReleased` for the sake of keeping order correct, but this doesn't account for the fact that `DrawableHitObject` resets all animations when the hit state changes. A bit of an ugly workaround, but seems to work as expected.	2023-03-14 18:15:19 +09:00