125 Commits

• Centralise cases of performing actions on the current selection

  By moving this to a central location, we can avoid invoking the
  EditorChangeHandler when there is no selection made. This helps
  alleviate the issue pointed out in
  https://github.com/ppy/osu/issues/11901, but not fix it completely.

  Dean Herbert · 2021-02-26 14:15:13 +09:00
  cd1c1bf534
• Rename and add xmldoc for smooth seeking method
  Dean Herbert · 2021-01-15 16:14:21 +09:00
  04fa32bc34
• Merge branch 'master' into editor-beat-snap-always
  Dean Herbert · 2020-11-30 18:34:38 +09:00
  c17d67bc7d
• Avoid updating hitobjects unnecessarily for start time changes

  This was firing regardless of whether the start time was changed, such
  as where beat snap provided the same time the object already has.
  
  The case where a change actually occurs is already handled by
  EditorBeatmap (see `startTimeBindables`), so it turns out this local
  handling is not required at all.

  Dean Herbert · 2020-11-27 16:31:06 +09:00
  7edbba58f7
• Expose EditorClock for consumption
  Dean Herbert · 2020-11-26 19:20:39 +09:00
  91592cf32d
• Fix incorrect index lookup on non-ordered selections
  Dean Herbert · 2020-11-25 17:25:54 +09:00
  0ddeff648d
• Make all objects in selection candidates for spatial snapping

  Closes #10898.

  Dean Herbert · 2020-11-24 17:35:54 +09:00
  c9a41f9dae
• Add comment + xmldoc
  smoogipoo · 2020-11-18 13:37:15 +09:00
  f00c23b4a0
• Make sealed and cleanup comparator
  smoogipoo · 2020-11-18 13:33:22 +09:00
  783c172b5d
• Define blueprint order similarly to hitobjects
  smoogipoo · 2020-11-17 22:56:31 +09:00
  58c8184ad7
• Merge branch 'master' into fix-quick-delete-crash
  Dean Herbert · 2020-11-16 13:54:54 +09:00
  7b79b9b9c1
• Refactor beginClickSelection in a slightly different way
  Bartłomiej Dach · 2020-11-15 21:06:47 +01:00
  399a1a16a0
• Revert beginClickSelection logic
  kamp · 2020-11-15 16:54:48 +01:00
  1db303b159
• Add null checks to unguarded resolved-as-null fields
  Bartłomiej Dach · 2020-11-14 14:52:58 +01:00
  610ed99ae3
• Fix crash on shift+right-click deleting objects
  kamp · 2020-11-14 13:20:16 +01:00
  4d2bc790fd
• Add timeline visible range adjustment
  smoogipoo · 2020-11-13 17:10:29 +09:00
  0219aff7bc
• Add pooling support to the editor
  smoogipoo · 2020-11-13 17:08:20 +09:00
  3957697c48
• Pass HitObjectComposer to BlueprintContainer via ctor
  smoogipoo · 2020-11-13 16:59:37 +09:00
  4ef2e9548c
• Fix BlueprintContainer triggering assert when left and right mouse button are pressed together
  Dean Herbert · 2020-11-10 17:16:28 +09:00
  de6fcd1792
• Fix editor quick delete being triggerable from left mouse button

  Closes https://github.com/ppy/osu/issues/10629.

  Dean Herbert · 2020-11-10 16:54:37 +09:00
  a012105dac
• Invert boolean logic
  Dean Herbert · 2020-11-04 17:53:03 +09:00
  d19b799f44
• Add the ability to delete slider control points using shift+right click

  Closes https://github.com/ppy/osu/issues/10672.
  
  In two minds about how this should be implemented but went in this
  direction initially. The other way would be to add local handling of
  Shift-Right Click inside PathControlPointPiece (which is already doing
  mouse handling itself).

  Dean Herbert · 2020-11-03 20:46:33 +09:00
  9f333ac58a
• Bind UpdateVisibility() directly to source of truth
  Bartłomiej Dach · 2020-10-31 13:54:02 +01:00
  003994ab75
• Group selection actions back up in SelectionHandler
  Bartłomiej Dach · 2020-10-28 22:06:48 +01:00
  202fe09306
• Merge branch 'master' into editor-fix-button-states-after-paste
  Dean Herbert · 2020-10-09 20:51:09 +09:00
  681e88af40
• Fix missed usages
  Dean Herbert · 2020-10-09 18:50:05 +09:00
  3838f405dd
• Tidy up EditorBeatmap slightly
  Dean Herbert · 2020-10-08 18:06:49 +09:00
  afed832b19
• Add missing UpdateHitObject calls and move local to usages (not via bindables)
  Dean Herbert · 2020-10-08 18:04:07 +09:00
  ef092de9ba
• Trigger a hitobject update after blueprint drag ends
  Dean Herbert · 2020-09-28 15:37:06 +09:00
  a4e9c85333
• Fix set access to SelectionHandler

  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  Dean Herbert · 2020-09-25 17:42:49 +09:00
  51cc644b7b
• Merge branch 'editor-ternary-states' into new-combo-toggle
  Dean Herbert · 2020-09-25 15:36:33 +09:00
  0f8551e9ea
• Use existing method to update combo state of selection
  Dean Herbert · 2020-09-25 14:19:35 +09:00
  a6adf8334e
• Add new combo toggle to main composer interface
  Dean Herbert · 2020-09-25 14:10:30 +09:00
  e009264f10
• Add basic osu! object to object snapping
  Dean Herbert · 2020-09-24 16:24:35 +09:00
  44be0ab762
• Select blueprint if object is already selected at the point of adding
  Dean Herbert · 2020-09-12 21:23:11 +09:00
  81f30cd264
• Fix editor selected hitobjects containing the selection up to five times
  Dean Herbert · 2020-09-11 20:27:07 +09:00
  22e6df02b6
• Rename drag blueprint selection method for discoverability
  Dean Herbert · 2020-09-08 17:22:59 +09:00
  c3123bf117
• Merge branch 'master' into editor-show-selected-count
  Dan Balasescu · 2020-07-17 18:00:35 +09:00
  288c0402ee
• Add a display of count of selected objects in editor
  Dean Herbert · 2020-07-17 17:48:27 +09:00
  ea6f257dc2
• Fix double-click incorrectly firing across disparate targets
  Dean Herbert · 2020-07-17 17:03:57 +09:00
  222a22182e
• Merge branch 'master' into fix-editor-drag-selection-while-playing
  Dan Balasescu · 2020-06-23 21:56:31 +09:00
  fd9ac3503f
• Fix exception when dragging after deleting object
  smoogipoo · 2020-06-23 20:36:09 +09:00
  e7238e25f9
• Make work for all editors based on track running state
  Dean Herbert · 2020-06-23 18:42:56 +09:00
  a5eac716ec
• Fix drag scroll in editor timeline no longer working correctly
  Dean Herbert · 2020-06-14 13:20:58 +09:00
  abe07b742e
• Allow drag selections to occur from outside the playfield
  Dean Herbert · 2020-05-27 20:44:15 +09:00
  9a060cfb3a
• Add tweening seek support to EditorClock
  Dean Herbert · 2020-05-22 16:47:52 +09:00
  d18eb663b1
• Cache and resolve editor clock as EditorClock in all cases
  Dean Herbert · 2020-05-22 16:44:06 +09:00
  dd09d7830d
• Move distance snap grid implementation to OsuHitObjectComposer
  Dean Herbert · 2020-05-21 17:13:22 +09:00
  8a47e2431b
• Create SnapResult class to hold various snapping results
  Dean Herbert · 2020-05-20 21:00:47 +09:00
  c46bfc2532
• Change snapping to be screen space coordinate based
  Dean Herbert · 2020-05-20 21:00:29 +09:00
  3354d48a38