79 Commits

• Fix failing tests after disallowing object placements before first timing point
  Bartłomiej Dach · 2025-12-05 09:52:32 +01:00
  66ebce8c12
• Fix several issues with editor timestamps for objects with fractional start times in osu!mania (#35829)

  * Fix mania editor timestamp generation being culture-dependent
  
  Mostly closes https://github.com/ppy/osu/issues/35809.
  
  * Add failing test for notes with fractions
  
  * Round note time when copying out timestamp & apply half-millisecond tolerance when parsing
  
  Closes the rest of https://github.com/ppy/osu/issues/35809.
  
  One issue here was that while the timestamp generation would allow
  fractional object timestamps to be output, the parsing (via
  `selection_regex`) would *reject* fractional timestamps, therefore
  making lazer incompatible even with itself.
  
  The other is that rounding is probably fine to do anyway for
  interoperability with stable. I'd hope nobody actually *needs*
  sub-millisecond precision but I'm ready to be proven wrong by some
  aspire jokester.
  
  * Specify invariant culture when writing out combo indices to editor timestamp in other rulesets
  
  Pretty sure this is just a much-of-muchness because it's integers but
  might as well if I'm spending time here already.

  Bartłomiej Dach · 2025-11-28 08:21:13 +09:00
  a8f058141b
• refactor issue templates to be more unified
  Hivie · 2025-07-24 13:25:15 +01:00
  c0ba8bc997
• Account for almost concurrent case in concurrent objects check
  Hivie · 2025-07-24 13:12:24 +01:00
  806d3160f8
• Move concurrent hold note tests to mania tests

  The general check no longer considers mania.

  Derrick Timmermans · 2025-05-25 17:33:48 +02:00
  9a254afa0a
• Fix placement blueprint tests
  Bartłomiej Dach · 2025-03-11 07:55:48 +01:00
  c962210b4f
• Add "discard unsaved changes" operation to beatmap editor

  Apparently useful in modding workflows when you want to test out a few
  different variants of a thing.
  
  Re-uses `Ctrl-L` binding from stable. Some folks may argue that the
  dialog makes the hotkey pointless, but I really do want to protect
  users from accidental data loss, and also if you want to power through
  it quickly, you can hit the 1 key when the dialog shows, which will
  bypass the hold-to-activate period (which wasn't intentional, but so
  many people want a bypass at this point that we're probably keeping that
  behaviour for power users).

  Bartłomiej Dach · 2025-03-05 14:34:44 +01:00
  3f461c0734
• Fix tests
  Bartłomiej Dach · 2025-01-24 11:59:07 +01:00
  269ade178e
• Remove dependence of blueprint containers on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:05 +01:00
  15b6e28ebe
• Remove unused using directive
  Bartłomiej Dach · 2024-11-07 08:40:01 +01:00
  fd17966605
• Fix test
  Bartłomiej Dach · 2024-11-05 15:29:52 +01:00
  3d4f5d4d10
• Add failing tests
  Bartłomiej Dach · 2024-10-14 14:48:07 +02:00
  98141430b0
• Fix tests
  Bartłomiej Dach · 2024-10-03 13:11:02 +02:00
  8a650deab6
• Merge pull request #29899 from bdach/mania-selection-dropped

  Ensure selection is preserved when moving selection between columns

  Dean Herbert · 2024-09-27 18:11:23 +09:00
  d9de2ad97b
• Refactor PlacementBlueprint to not be hitobject specific
  OliBomby · 2024-09-24 20:31:00 +02:00
  e3b4483872
• Add test case covering failure
  Bartłomiej Dach · 2024-09-17 13:07:52 +02:00
  e0f92bab6a
• Add failing test case
  Bartłomiej Dach · 2024-07-08 16:28:33 +02:00
  449d50a46a
• Remove redundant qualifier
  Bartłomiej Dach · 2024-06-14 14:12:55 +02:00
  31a8bc7553
• Commit active placement when starting drag selection via timeline

  This was reported in https://github.com/ppy/osu/pull/28474, albeit the
  code changes proposed there did not fix the issue at all.
  
  See 8b6385f7d0 for demonstration of the
  crash scenario. Basically what is happening there is:
  
  - The starting premise is that there is a spinner placement active.
  - At this time, a drag selection is started via the timeline.
  - Once the drag selection finds at least one suitable object to select,
    it mutates `SelectedItems`.
  - When selection changes for any reason, the `HitObjectComposer`
    decides to switch to the "select" tool, regardless of why
    the selection changed.
  - Changing the active tool causes the current placement - if any -
    to be committed, which mutates the beatmap.
  - Back at the drag box selection code, this causes a "collection
    modified when enumerating" exception.
  
  The proposed fix here is to eagerly commit active placement - if any -
  when drag selection is initiated via the timeline, which avoids this
  issue. This also appears to vaguely match stable behaviour and is sort
  of consistent with the logic of committing any outstanding changes upon
  switching to the selection tool.

  Bartłomiej Dach · 2024-06-14 09:32:40 +02:00
  bdeea37a44
• Add test coverage
  Bartłomiej Dach · 2024-06-12 15:43:33 +02:00
  6d2f910813
• Allow modifying hold note start/end time via mania composer playfield
  Bartłomiej Dach · 2024-06-12 15:30:27 +02:00
  feadf7a56e
• Add test coverage
  Bartłomiej Dach · 2024-06-11 12:28:39 +02:00
  e67d73be7d
• Add test coverage
  Bartłomiej Dach · 2024-06-07 09:19:17 +02:00
  f787a29f49
• Fix code quality issues
  Bartłomiej Dach · 2024-03-26 10:55:49 +01:00
  9b923b1909
• Make check ruleset specific
  Arthur Araujo · 2024-03-22 14:48:22 -03:00
  6fa663c8ca
• Remove warning for 10K+
  Arthur Araujo · 2024-03-20 16:51:27 -03:00
  2d6a3b8e2b
• Add mania keycount check
  Arthur Araujo · 2024-03-20 15:52:16 -03:00
  c605e463a4
• Reorder and simplify private helper methods
  Dean Herbert · 2023-11-21 15:05:51 +09:00
  3afaafb1d9
• Update Test cases
  ratinfx · 2023-11-11 14:13:06 +01:00
  6ddecfd806
• Separate Test cases by relevant rulesets
  ratinfx · 2023-11-07 13:02:46 +01:00
  81caa854e6
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Use more generic wording for future-proofing
  Bartłomiej Dach · 2023-02-19 15:06:40 +01:00
  d9ca7102f0
• Rename moved test method to describe its purpose better
  Bartłomiej Dach · 2023-02-19 13:54:48 +01:00
  8b25598d82
• Rewrite test cases

  - Depend less on arbitrary timings
  - Remove unnecessary seeks
  - Change method name to make more sense
  - Use nunit style assertions

  Bartłomiej Dach · 2023-02-19 13:37:06 +01:00
  80ee917c77
• Rename test scene to match contents

  It does not only test "placement before track start" anymore.

  Bartłomiej Dach · 2023-02-19 13:16:40 +01:00
  80b329f069
• fix formating in SeekOnNote test
  Maximilian Kruse · 2023-02-19 10:17:33 +01:00
  025061ba66
• Add test for seeking setting in mania placement test
  Maximilian Kruse · 2023-02-18 20:42:13 +01:00
  55e9a71f38
• Add failing test
  ansel · 2023-01-11 21:20:56 +03:00
  1f129d4e16
• Expose Ruleset from HitObjectComposer instead
  Derrick Timmermans · 2022-11-30 12:17:58 +01:00
  6a61e70766
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Make Column.AccentColour bindable
  Dean Herbert · 2022-10-07 15:24:36 +09:00
  6b79f16461
• Move column initialisation to ctor and fix remaining tests
  Dean Herbert · 2022-10-07 15:24:36 +09:00
  2ae1aef0be
• Cache StageDefinition for consumption (and remove ColumnType)
  Dean Herbert · 2022-10-07 15:24:36 +09:00
  7796a4c109
• Move ColumnType to constructor
  Dean Herbert · 2022-10-07 15:24:36 +09:00
  df3ad618e1
• Remove "default" prefix from naming
  Dean Herbert · 2022-09-18 00:15:26 +09:00
  41e69fbca6
• Rename references to DefaultSkin to have Triangles suffix
  Dean Herbert · 2022-09-17 23:57:25 +09:00
  51841988bf
• Test editor ComposeScreen tests not adding beatmap to hierarchy

  Makes it hard to test anything because `EditorBeatmap`'s `Update` method
  updates whether a beatmap has timing or not (enabling the placement
  controls).
  
  Also adds a basic timing point to allow for better testing.

  Dean Herbert · 2022-08-31 14:07:56 +09:00
  e9463f3c19
• Fix various test scenes not adding EditorClock to the draw hierarchy
  Dean Herbert · 2022-08-26 18:08:43 +09:00
  4b72e55770
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850