14828 Commits

Author	SHA1	Message	Date
Dean Herbert	b6dc483fc1	Add missing change handler to ensure undo/redo works for break removal	2024-07-03 14:23:31 +09:00
Bartłomiej Dach	9414aec8bf	Add capability to remove breaks via context menu	2024-07-02 14:55:04 +02:00
Dan Balasescu	31edca866c	Remove unused code	2024-07-02 12:21:24 +09:00
Dan Balasescu	04da1209f7	Revert "Change breaks list to IReadOnlyList" ... This reverts commit 2c3b411bb5.	2024-07-02 12:16:11 +09:00
Dean Herbert	2c3b411bb5	Change breaks list to IReadOnlyList	2024-07-02 11:59:24 +09:00
Dean Herbert	005af280f2	Isolate bindable breaks list to EditorBeatmap	2024-07-02 11:31:55 +09:00
Dan Balasescu	f942595829	Fix ManiaModInvert permanently messing up the beatmap	2024-07-01 15:02:00 +09:00
Dean Herbert	8bb51d5a4f	Fix summary timeline not correctly updating after changes to breaks ... Closes https://github.com/ppy/osu/issues/28678. Oops.	2024-06-30 20:32:16 +09:00
Bartłomiej Dach	81c6da98c2	Merge pull request #26465 from LeNitrous/fix/editor-test-exit ... Fix editor test play not marking hit objects before its start time as judged.	2024-06-28 12:12:17 +02:00
Dean Herbert	4bb8a45d75	Merge pull request #28636 from bdach/daily-challenge/watch-room ... Add client/server models for allowing clients to receive realtime playlist updates	2024-06-28 17:51:40 +09:00
Bartłomiej Dach	a3ea36d2b2	Fix formatting	2024-06-28 09:45:45 +02:00
Bartłomiej Dach	7ac5bd4d37	Ensure past drawable objects also get their results populated in editor test play	2024-06-28 09:37:10 +02:00
Bartłomiej Dach	b36e0f0875	Merge branch 'master' into fix/editor-test-exit	2024-06-28 09:17:40 +02:00
Bartłomiej Dach	1b741dada3	Show distance in pixels to previous/next object in osu! hitobject inspector	2024-06-27 14:46:57 +02:00
Bartłomiej Dach	e35744118c	Merge pull request #28638 from OliBomby/beat-divisor ... Fix editor not loading arbitrary beat divisors	2024-06-27 13:31:44 +02:00
OliBomby	29412bb29b	Fix editor setting arbitrary beat divisor	2024-06-27 12:22:00 +02:00
Bartłomiej Dach	d6e7781be1	Add client/server models for allowing clients to receive realtime playlist updates	2024-06-27 11:32:18 +02:00
Dean Herbert	76a1f19233	Merge pull request #28613 from bdach/control-point-table-is-bad ... Improve performance of editor tables	2024-06-27 18:22:56 +09:00
Bartłomiej Dach	9384cbcdd8	Fix scroll-into-view on control point table not working as it is supposed to	2024-06-27 09:46:35 +02:00
Bartłomiej Dach	a5aedded16	Remove commented code	2024-06-27 09:44:55 +02:00
Dean Herbert	f07a635447	Merge pull request #28630 from peppy/fix-long-note-break-woes	2024-06-27 15:50:25 +09:00
Bartłomiej Dach	b1baa49459	Add note about implicit reliance on sort by start time	2024-06-27 07:56:57 +02:00
Bartłomiej Dach	ef952bcd65	Use GetLastObjectTime() for safety ... Due to other circumstances this has no real effect, but may as well.	2024-06-27 07:48:06 +02:00
Dean Herbert	8f9b2106d6	Merge pull request #28620 from normalid-awa/ui/mod-select-color-improvement ... Optimize Text Color For Mod Multiplier Text	2024-06-27 13:56:12 +09:00
Dean Herbert	7ef7e5f163	Fix break generation not accounting for concurrent hitobjects correctly	2024-06-27 12:10:26 +09:00
Dean Herbert	ec86cc1333	Merge pull request #28608 from bdach/daily-challenge/carousel ... Implement carousel container for daily challenge screen	2024-06-27 10:45:23 +09:00
normalid	936a8d800d	Swap the low and high multiplier color	2024-06-26 21:39:14 +08:00
Dean Herbert	2a839b3697	Make action required init	2024-06-26 21:50:34 +09:00
Dean Herbert	fd91210c1c	Remove unnecessary setter on bindable	2024-06-26 21:47:33 +09:00
Dean Herbert	6beae91d53	Ensure carousel panel depth is consistent based on vertical position ... I thought this was already being handled, but it turns out that changing sort mode (and potentially other operations) could break the depth of display of panels due to pooling and what not. This ensures consistency and also employs @bdach's suggestion of reversing the depth above and below the current selection for a better visual effect.	2024-06-26 21:10:29 +09:00
Bartłomiej Dach	9dfd6cf9ef	Remove EditorTable ... Begone, foul beast.	2024-06-26 10:40:02 +02:00
Bartłomiej Dach	b12db8fbe2	Rewrite IssueTable to use virtualised list	2024-06-26 10:40:02 +02:00
Bartłomiej Dach	5c2d446767	Rewrite ControlPointTable to use virtualised list	2024-06-26 10:40:02 +02:00
Bartłomiej Dach	006184ed2f	Implement carousel container for daily challenge screen	2024-06-26 08:49:00 +02:00
Dean Herbert	e84daedbea	Reduce length of fade-out when hiding beatmap panels	2024-06-26 12:01:38 +09:00
Dean Herbert	5d4509150b	Adjust beatmap carousel's spacing to remove dead-space ... As discussed in https://github.com/ppy/osu/discussions/28599. I think this feels better overall, and would like to apply the change before other design changes to the carousel.	2024-06-26 11:56:58 +09:00
Dean Herbert	aadb104851	Merge pull request #28589 from bdach/scale-handling-crash ... Fix crashes when opening scale/rotation popovers during selection box operations	2024-06-26 00:11:03 +09:00
Dean Herbert	3d22f700a7	Merge pull request #28561 from bdach/daily-challenge/score-breakdown ... Implement score breakdown display for daily challenge screen	2024-06-25 23:34:47 +09:00
Bartłomiej Dach	2fda45cad4	Fix crashes when opening scale/rotation popovers during selection box operations	2024-06-25 15:20:59 +02:00
Dean Herbert	6cd1367329	Merge pull request #28580 from bdach/fix-breaks ... Fix crash when attempting to adjust duration of break that has no preceding/succeeding objects	2024-06-25 20:24:27 +09:00
Bartłomiej Dach	fae6dcfffa	Remove manual breaks at the start/end of beatmap ... This is the secondary cause of https://github.com/ppy/osu/issues/28577, because you could do the following: - Have a break autogenerate itself - Adjust either end of it to make it mark itself as manually-adjusted - Remove all objects before or after said break to end up in a state wherein there are no objects before or after a break. The direct fix is still correct because it is still technically possible to end up in a state wherein a break is before or after all objects (obvious one is manual `.osu` editing), but this behaviour is also undesirable for the autogeneration logic.	2024-06-25 12:49:17 +02:00
Bartłomiej Dach	03cdfd0660	Fix timeline break piece crashing on drag if there are no objects before start or after end ... This fixes the direct cause of https://github.com/ppy/osu/issues/28577.	2024-06-25 12:25:37 +02:00
Bartłomiej Dach	0d2a47167c	Fix crash on calculating playlist duration when rate-changing mods are present ... Regressed in https://github.com/ppy/osu/pull/28399. To reproduce, enter a playlist that has an item with a rate-changing mod (rather than create it yourself). This is happening because `APIRuleset` has `CreateInstance()` unimplemented: b4cefe0cc2/osu.Game/Online/API/Requests/Responses/APIBeatmap.cs (L159) and only triggers when the playlist items in question originate from web. This is why it is bad to have interface implementations throw outside of maybe mock implementations for tests. `CreateInstance()` is a scourge elsewhere in general, we need way less of it in the codebase (because while convenient, it's also problematic to implement in online contexts, and also expensive because reflection).	2024-06-25 11:28:10 +02:00
Dean Herbert	2de42854c3	Fix corner radius looking bad when graph bars are too short	2024-06-25 15:43:52 +09:00
Bartłomiej Dach	66b093b17e	Implement score breakdown display for daily challenge screen	2024-06-24 10:09:10 +02:00
Dean Herbert	14104e57d4	Merge branch 'master' into timeline-drag-selection-crash	2024-06-20 15:16:10 +09:00
Dean Herbert	0eb533f2fd	Merge pull request #28444 from bdach/scrolling-ruleset-editor-reloads ... Reload scrolling hitobject composer on control point changes	2024-06-20 15:15:26 +09:00
Dean Herbert	a718af8af5	Adjust break colours to match closer to stable	2024-06-19 22:02:10 +08:00
Bartłomiej Dach	617c1341d7	Make (Manual)BreakPeriod a class again ... CodeFileSanity doesn't like records and it being a record wasn't doing much anymore anyway.	2024-06-19 14:53:09 +02:00
Dean Herbert	00443403b6	Merge branch 'master' into break-autogeneration	2024-06-19 21:49:17 +09:00