2153 Commits

• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Don't include spinner types in note sums
  Dean Herbert · 2025-04-14 19:21:36 +09:00
  3d47a2b5b2
• Rename new property to better explain visual-only usage
  Dean Herbert · 2025-04-14 18:38:04 +09:00
  f05a50f4e1
• Introduce numeric value in beatmap hit count statistics
  Salman Alshamrani · 2025-04-12 00:14:53 +09:00
  85556e0c3e
• Shorten beatmap hit statistics names
  Salman Alshamrani · 2025-04-11 02:33:57 +09:00
  1dbcbbde15
• Fix another missing disposal

  This one probably doesn't matter as much because it's used as a single
  instance in `TaikoPlayfield` (so its lifetime should end around the same
  time as the `HealthProcessor`).

  Dan Balasescu · 2025-04-10 16:09:47 +09:00
  d0dddcde78
• Fix progressively worsening performance on taiko argon skin
  Dan Balasescu · 2025-04-10 15:53:14 +09:00
  92c0b3cae2
• Fix editor setup screen sliders not having correct keyboard steps

  Closes https://github.com/ppy/osu/issues/32691.
  
  Fixes some extra cases of failure that aren't pointed out in the issue.

  Dean Herbert · 2025-04-08 14:45:43 +09:00
  f2088496c5
• Merge pull request #32540 from frenzibyte/mod-rich-tooltip

  Display mod tooltips in rich form

  Dean Herbert · 2025-03-25 16:44:43 +09:00
  6dbd6a7e7b
• Fix taiko legacy skins playing scale animations even when skins contain animations

  Closes https://github.com/ppy/osu/issues/32477.
  
  Can be tested using
  https://drive.google.com/drive/folders/1HUCsTL_iqCGPCyruSSfdSoxL19EQuy_a.

  Dean Herbert · 2025-03-24 16:14:32 +09:00
  bb998ad687
• Change SettingDescription to differentiate between settings and values
  Salman Alshamrani · 2025-03-23 13:43:26 -04:00
  6e635f124a
• Move BeatmapVersion from BeatmapInfo to IBeatmap

  Closes https://github.com/ppy/osu/issues/32420.
  
  The failure cause here is that in editor the beatmap version for the
  beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
  probably a regression from https://github.com/ppy/osu/pull/32315, but
  like... can we universally agree that calling that change "a regression"
  in any capacity is dumb? Like what was that code *doing* playing dumb
  reference games and copying stuff into an arbitrary instance that could
  get or not get used later on? And now you have a 50/50 chance of
  accessing the *correct* model's field, depending on whether you go via
  `BeatmapInfo` or `Beatmap.BeatmapInfo`?
  
  Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
  since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
  and materialised" beatmap, fixes this issue.
  
  I probably should have done this as part of
  https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
  for the better too because this change has rather large chances of
  breaking stuff so maybe better to examine it in isolation (via diffcalc
  runs or whatever).
  
  For added humour points, you'd say that the field on `BeatmapInfo` was
  not `[Ignore]`d, so this is a realm schema change, right? No. As far as
  I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
  a listed column` on `Beatmap` models.
  
  I'm also not gonna get into the fact that I think `EditorBeatmap` doing
  dumb games with juggling two `BeatmapInfo` references since
  https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
  have the mental capacity to hotfix this by going down that train of
  thought.

  Bartłomiej Dach · 2025-03-17 15:04:48 +01:00
  91f3be5fea
• Remove JSON property attributes from non-databased taiko difficulty attributes
  tsunyoku · 2025-03-12 19:10:41 +00:00
  db0676d615
• Remove unnecessary DI property
  Salman Alshamrani · 2025-03-12 01:14:40 -04:00
  7f4f92dedf
• Fix osu!taiko mobile scaling not accurate
  Salman Alshamrani · 2025-03-12 00:36:28 -04:00
  54d7a91cab
• Bump difficulty calculator versions in preparation for release
  Dean Herbert · 2025-03-06 16:05:51 +09:00
  bdd2808fb5
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-02-27 00:08:43 +09:00
  87b6dddd11
• Do not give swell ticks any visual representation

  Why is this a thing at all? How has it survived this long? I don't know.
  
  As far as I can tell this only manifests on selected beatmaps with "slow
  swells" that spend the entire beatmap moving in the background. On other
  beatmaps the tick is faded out, probably due to the initial transform
  application that normally "works" but fails hard on these slow swells.
  
  Can be seen on https://osu.ppy.sh/beatmapsets/1432454#taiko/2948222.

  Bartłomiej Dach · 2025-02-24 15:32:17 +01:00
  c82cf40928
• Fix taiko touch controls sizing logic
  Salman Alshamrani · 2025-02-21 01:21:13 +09:00
  b1112623dc
• Scale taiko down to remain playable
  Salman Alshamrani · 2025-02-21 01:21:13 +09:00
  7bd5b745e9
• Ensure EditorBeatmap.PerformOnSelection() marks objects in selection as updated

  Closes https://github.com/ppy/osu/issues/28791.
  
  The reason why nudging was not changing hyperdash state in catch was
  that `EditorBeatmap.Update()` was not being called on the objects that
  were being modified, therefore postprocessing was not performed,
  therefore hyperdash state was not being recomputed.
  
  Looking at the usage sites of `EditorBeatmap.PerformOnSelection()`,
  about two-thirds of callers called `Update()` themselves on the objects
  they mutated, and the rest didn't. I'd say that's the failure of the
  abstraction and it should be `PerformOnSelection()`'s responsibility to
  call `Update()` there. Yes in some of the cases here this will cause
  extraneous calls that weren't done before, but the method is already
  heavily disclaimed as 'expensive', so I'd say usability should come
  first.

  Bartłomiej Dach · 2025-02-18 12:06:42 +01:00
  e6174f195c
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-02-17 11:59:14 +09:00
  ab88ccb081
• Fix clear sample potentially playing multiple times simultaneously
  Bartłomiej Dach · 2025-02-12 13:25:46 +01:00
  d87a775e71
• Add missing animation of warning sprite
  Bartłomiej Dach · 2025-02-12 13:25:46 +01:00
  e385848edc
• Fix transforms from swell progress being cleared on completion by not using transforms
  Bartłomiej Dach · 2025-02-12 13:25:42 +01:00
  0ac08158e3
• Adjust things further
  Bartłomiej Dach · 2025-02-12 13:20:04 +01:00
  96db6964df
• Adjust things to be closer to stable (but not close enough yet)
  Bartłomiej Dach · 2025-02-11 15:29:53 +01:00
  231988bc9d
• Fix remaining hit counter scaling in the incorrect direction
  Bartłomiej Dach · 2025-02-11 14:01:32 +01:00
  be035538c2
• Add note about weird taiko iteration
  Dean Herbert · 2025-02-10 17:57:01 +09:00
  d4ce712672
• Calculate hit windows in performance calculator instead of databased difficulty attributes (#31735)

  * Calculate hit windows in performance calculator instead of databased difficulty attributes
  
  * Apply mods to beatmap difficulty in osu! performance calculator
  
  * Remove `GreatHitWindow` difficulty attribute for osu!mania
  
  * Remove use of approach rate and overall difficulty attributes for osu!
  
  * Remove use of hit window difficulty attributes in osu!taiko
  
  * Remove use of approach rate attribute in osu!catch
  
  * Remove unused attribute IDs
  
  * Code quality
  
  * Fix `computeDeviationUpperBound` being called before `greatHitWindow` is set

  James Wilson · 2025-02-07 19:21:12 +09:00
  9f90ebb2f7
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-02-07 14:09:25 +09:00
  6c069b3373
• Fix inspections
  Dean Herbert · 2025-02-07 13:54:35 +09:00
  4f6fd68a91
• Add better documentation for interval change code
  Dean Herbert · 2025-02-05 18:48:48 +09:00
  40ea7ff238
• Initial tidy-up pass on IntervalGroupingUtils
  Dean Herbert · 2025-02-05 15:47:18 +09:00
  8447679db9
• Tidy up xmldoc and remove another unused field
  Dean Herbert · 2025-02-05 15:33:06 +09:00
  325483192a
• Remove unused HitObjectInterval
  Dean Herbert · 2025-02-05 15:10:15 +09:00
  fc93390284
• Simplify TaikoRhythmData's ratio computation
  Dean Herbert · 2025-02-05 15:09:51 +09:00
  709ad02a51
• Rename Colour / Rhythm related fields and classes
  Dean Herbert · 2025-02-05 15:08:15 +09:00
  fa844b0ebc
• code cleanup
  Nathan Du · 2025-02-04 17:48:44 +08:00
  ccc446a8ca
• further adjust swell behavior

  The outstanding visual issues of the clear animation is fixed. The
  HandleUserInput state management is removed as it no longer seems
  necessary.

  Nathan Du · 2025-02-01 13:34:52 +08:00
  e794389fe8
• fix code style
  Nathan Du · 2025-01-31 20:48:29 +08:00
  a62a84a30f
• change legacy spinner animations to match stable

  Also removed a few fallbacks pointed out in code review that I don't
  understand.

  Nathan Du · 2025-01-31 20:16:28 +08:00
  ac17b4065f
• remove spinner-osu.png workaround

  https://github.com/ppy/osu/issues/22084

  Nathan Du · 2025-01-31 18:52:19 +08:00
  ad2b469b14
• remove ISkinnableSwell

  This commit removes ISkinnableSwell for taiko swell animations. In place
  of it, an event named UpdateHitProgress is added to DrawableSwell, and
  the skin swells are converted to listen to said event and
  ApplyCustomUpdateState, like how spinner skinning is implemented for
  std.

  Nathan Du · 2025-01-31 18:10:50 +08:00
  2a5540b392
• Merge taiko swell components

  Per <https://github.com/ppy/osu/pull/21601/files#r1064167756>, taking a
  variation of the "Make all swell main pieces implement
  ISkinnableSwellPart" path. Should clean the interface up enough for
  further refactors.

  Nathan Du · 2025-01-31 16:55:39 +08:00
  4fd8a4dc5a
• Rename methods and skin component + add comments
  Joppe27 · 2025-01-31 10:24:45 +08:00
  e2196e8b9b
• Add legacy taiko swell
  Joppe27 · 2025-01-31 10:24:45 +08:00
  4a164b7b14
• Use correct English
  tsunyoku · 2025-01-27 12:56:33 +00:00
  f3c17f1c2b
• Rename class, rename children to hit objects and groups, make fields un-settable
  tsunyoku · 2025-01-27 12:54:22 +00:00
  71b89c390f
• Account for floating point errors
  tsunyoku · 2025-01-26 20:15:13 +00:00
  13c956c248