65490 Commits

This Branch

This Branch

All Branches

• Change GameplayClockContainer.Reset to directly call GameplayClock.Stop

  The reasoning is explained in the inline comment, but basically this was
  getting blocked by `isPaused` being in an initial `true` state (as it is
  on construction), while the source clock was still `IsRunning`.
  
  There's no real guarantee of sync between the source and the `isPaused`
  bindable right now. Maybe there should be in the future, but to restore
  sanity, let's ensure that a call to `Reset` can at least stop the track
  as we expect.

  Dean Herbert · 2023-10-10 18:16:14 +09:00
  f0bd975393
• Fix MultiplayerPlayer never calling Reset on GameplayClockContainer

  This call is responsible for ensuring the clock is in a stopped state.

  Dean Herbert · 2023-10-10 17:58:37 +09:00
  100c0cf533
• Reduce severity of clock running check to avoid production crashes
  Dean Herbert · 2023-10-10 17:58:11 +09:00
  eee7dc02da
• Add failing test coverage of player not pausing track correctly
  Dean Herbert · 2023-10-10 17:55:35 +09:00
  4319b22db8
• Merge pull request #25077 from bdach/fix-guest-score-lookup

  Fix score importer looking up guest user by username online

  Dean Herbert · 2023-10-10 17:35:15 +09:00
  1388f7240e
• Merge pull request #25070 from frenzibyte/fix-legacy-catcher-layout

  Adjust legacy catcher display to match 1:1 with osu!(stable)

  Dean Herbert · 2023-10-10 17:31:10 +09:00
  a0bd91f3bb
• Merge pull request #25067 from bdach/approach-circle-cutoff

  Adjust approach circle maximum size limits for backwards compatibility

  Dean Herbert · 2023-10-10 17:05:16 +09:00
  0ca05d986d
• Adjust xmldoc for readability

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2023-10-10 17:04:21 +09:00
  18d20cad8b
• Apply some xmldoc and structural changes
  Dean Herbert · 2023-10-10 16:59:25 +09:00
  8dc9453d8d
• Fix tests
  Dan Balasescu · 2023-10-10 16:54:24 +09:00
  94192644be
• Fix cross-test interference

  `TestLastPlayedUpdated` was implicitly relying on running first.
  `TestGuestScoreIsStoredAsGuest` showing up changed test ordering,
  causing the former test to fail if it didn't get to run first.

  Bartłomiej Dach · 2023-10-10 09:30:51 +02:00
  ea400a9db7
• Fix score importer looking up guest user by username online
  Bartłomiej Dach · 2023-10-10 09:28:01 +02:00
  24956588e9
• Add failing test case for guest user being looked up in API
  Bartłomiej Dach · 2023-10-10 09:18:57 +02:00
  08b1a3cbe2
• Fix Scheduler.AddOnce not working in one location
  Dean Herbert · 2023-10-10 16:17:34 +09:00
  4674f63655
• Avoid running finishInitialAnimation when already finished
  Dean Herbert · 2023-10-10 15:59:48 +09:00
  7e68b64526
• Also debounce updatePathVertices to reduce overhead
  Dean Herbert · 2023-10-10 15:50:42 +09:00
  1eb6c93916
• Add TODO mentioning that ArgonHealthDisplay is doing lerp wrong
  Dean Herbert · 2023-10-10 15:24:54 +09:00
  6c346874d3
• Ensure health displays don't pile up transforms when off-screen
  Dean Herbert · 2023-10-10 15:24:54 +09:00
  57f588fa86
• Merge pull request #25073 from peppy/mania-beat-snap-grid-fix

  Fix osu!mania beat snap grid sometimes not displaying correctly

  Bartłomiej Dach · 2023-10-10 08:21:43 +02:00
  6b38600010
• Adjust glow animation specifics slightly
  Dean Herbert · 2023-10-10 15:10:42 +09:00
  6ee958743e
• Syncrhonise initial colour of glowBar for sanity
  Dean Herbert · 2023-10-10 15:10:27 +09:00
  aeb579eb54
• Fix argon health bar not completing flash animation correctly
  Dean Herbert · 2023-10-10 15:09:33 +09:00
  8e26b3c405
• Use a DrawablePool for mania's beat snap grid

  I'm not sure what the cause of the issue is, but I'm also not sure why
  it wasn't using `DrawablePool` (was it not around back then?).
  
  Either way, switching to a proper pool fixes things just fine.
  
  Resolves https://github.com/ppy/osu/issues/25009.

  Dean Herbert · 2023-10-10 13:36:31 +09:00
  1a60d6ade5
• Remove pairings that shouldn't be valid
  Dan Balasescu · 2023-10-10 10:03:37 +09:00
  04ce223e66
• Add validation test
  Dan Balasescu · 2023-10-10 09:56:35 +09:00
  89a3be11cb
• Apply suggestion to condense method
  Dan Balasescu · 2023-10-10 09:56:26 +09:00
  594bcc2ab5
• Refactor catch playfield size adjustment logic w.r.t. catcher position
  Salman Ahmed · 2023-10-10 02:42:37 +03:00
  6073f3e756
• Make combo assertion actually work as expected
  Dan Balasescu · 2023-10-10 08:32:35 +09:00
  7211c88e83
• Adjust the catch playfield's position to match 1:1 with stable
  Salman Ahmed · 2023-10-10 02:17:43 +03:00
  b2987caf7c
• Fix test catcher sprites in "special skin" incorrectly suffixed as being @2x
  Salman Ahmed · 2023-10-10 01:26:59 +03:00
  693b8d72db
• Add brief explaination of BASE_SIZE
  Salman Ahmed · 2023-10-10 01:26:59 +03:00
  fed0deac02
• Fix legacy catcher sprites getting shrunk
  Salman Ahmed · 2023-10-10 01:26:59 +03:00
  fc63ee43be
• Adjust catcher origin position to match 1:1 with stable

  Change catcher origin position logic to 1:1 match stable on legacy skin

  Salman Ahmed · 2023-10-10 01:26:59 +03:00
  0fb7895a52
• Apply mod multipliers to local score V1/V2 reimplementations
  Bartłomiej Dach · 2023-10-09 13:04:12 +02:00
  d7e891140d
• Apply mods to processor-based score algorithms
  Bartłomiej Dach · 2023-10-09 12:59:02 +02:00
  419cc8784a
• Add mod controls to scoring test scene
  Bartłomiej Dach · 2023-10-09 12:59:02 +02:00
  55064c387d
• Merge pull request #24988 from smoogipoo/fix-legacy-score-multipliers-2

  Fix legacy score calculators using incorrect mod multipliers

  Bartłomiej Dach · 2023-10-09 12:56:39 +02:00
  b3d3ae87be
• Merge branch 'master' into fix-legacy-score-multipliers-2
  Bartłomiej Dach · 2023-10-09 10:53:14 +02:00
  71c4b138fb
• Hotfix approach circle cutoff
  Dean Herbert · 2023-10-09 10:16:57 +02:00
  ad6f04cfb0
• Merge pull request #25063 from peppy/move-download-button

  Move playlist item download button to left

  Bartłomiej Dach · 2023-10-09 10:01:15 +02:00
  ca217094d6
• Remove unused usings
  Dan Balasescu · 2023-10-09 12:22:08 +09:00
  e874ec81c9
• Move playlist item download button to left
  Dean Herbert · 2023-10-09 12:21:56 +09:00
  142c61ab9b
• Add test for the result
  Dan Balasescu · 2023-10-09 12:11:29 +09:00
  b65c70018f
• Update HitResult helpers with new judgement
  Dan Balasescu · 2023-10-09 11:50:17 +09:00
  326702165f
• Actually use the judgement
  Dan Balasescu · 2023-10-09 11:49:54 +09:00
  f0da7f016d
• Revert functional change
  Dan Balasescu · 2023-10-09 10:50:39 +09:00
  d988ef9b22
• Actually validate judgements
  Dan Balasescu · 2023-10-09 10:45:29 +09:00
  65ac617be4
• Add mania hold note body + combo break judgement
  Dan Balasescu · 2023-10-09 09:47:00 +09:00
  9415fe4446
• Remove HoldNoteTickJudgement
  Dan Balasescu · 2023-10-09 09:31:45 +09:00
  b2d9c95441
• Merge branch 'master' into remove-hold-note-ticks
  Dan Balasescu · 2023-10-09 08:15:10 +09:00
  5362902c87