Bartłomiej Dach
e6d5389608
Merge branch 'master' into hover-open-mod-customise
2024-08-07 14:05:19 +02:00
Bartłomiej Dach
518c1aa5a0
Remove weird Expanded / ExpandedState duality
2024-08-07 14:01:30 +02:00
kstefanowicz
775f76f472
Have placeholder text change while focused
2024-08-07 07:47:35 -04:00
Bartłomiej Dach
437812eebe
Merge pull request #29279 from normalid-awa/bugfix/editor/delete-operation-wont-close-the-menu
...
Close context menus when deselecting items in editor
2024-08-07 13:25:13 +02:00
Dean Herbert
e52d80a41b
Add more difficulty information and further tweaks to visuals
2024-08-07 19:08:04 +09:00
Dean Herbert
083fe32d20
Improve feel of animation
2024-08-07 19:07:45 +09:00
Salman Ahmed
a0615a8f18
Frenzi's WIP animation
2024-08-07 19:07:45 +09:00
Dean Herbert
cfccd74441
Add daily challenge intro sequence
2024-08-07 19:07:44 +09:00
Dean Herbert
6870311c1e
Remove requirement of specifying animateOnnter in BackgroundScreen ctor
2024-08-07 19:07:44 +09:00
Dean Herbert
3c05b975a0
Fix clicking the beatmap import notification at the daily challenge screen exiting to main menu
2024-08-07 19:07:43 +09:00
Dean Herbert
43f1fe350d
Fix PresentBeatmap sometimes favouring an already DeletePending beatmap
2024-08-07 19:07:43 +09:00
Dean Herbert
227878b67a
Change default for "automatically download beatmaps" to enabled
2024-08-07 19:06:50 +09:00
Dean Herbert
dccf766ff3
Remove obsoleted download setting
2024-08-07 19:06:50 +09:00
Dean Herbert
b1488fd5b7
Merge pull request #29027 from normalid-awa/feature/skin/legacy-input-overlay
...
Add legacy key counter support
2024-08-07 17:48:30 +09:00
Dean Herbert
5a63c25f49
Fix clicking the beatmap import notification at the daily challenge screen exiting to main menu
2024-08-07 14:42:34 +09:00
Dean Herbert
06ff858256
Fix PresentBeatmap sometimes favouring an already DeletePending beatmap
2024-08-07 14:40:52 +09:00
Dean Herbert
a61bf670d8
Highlight mentions in chat
2024-08-07 01:33:56 +09:00
Dean Herbert
9ccd8c906d
Merge branch 'master' into hover-open-mod-customise
2024-08-06 18:35:35 +09:00
Dean Herbert
725dc4de9b
Use transformers for per-skin key counter implementation
2024-08-06 18:17:21 +09:00
Dean Herbert
8619bbb943
Fix legacy key counter's background being visible when intended to be hidden
2024-08-06 16:12:00 +09:00
Dan Balasescu
41d84ea56b
Revert all SkinEditor changes (none required)
2024-08-06 16:11:29 +09:00
Dan Balasescu
c26a664b84
Use InternalChild directly
2024-08-06 16:08:42 +09:00
Dan Balasescu
c574551ee0
Simplify caching
2024-08-06 16:02:36 +09:00
Dean Herbert
90395aea13
Fix incorrect colour fallback handling
...
Adds a note about `GetConfig` being stupid.
2024-08-06 15:43:39 +09:00
Dan Balasescu
b91461e661
Refactor + CI fixes
2024-08-06 15:17:52 +09:00
Dean Herbert
c4572ec265
Sanitise font sizes / weights
2024-08-06 15:17:43 +09:00
jkh675
cb877b7675
Close the menu when selecting other object
2024-08-06 13:09:48 +08:00
Dean Herbert
60fc02bb9b
Merge branch 'master' into feature/skin/legacy-input-overlay
2024-08-06 14:05:33 +09:00
Dan Balasescu
d637bbf752
Merge pull request #29286 from peppy/middle-click-delete
...
Allow object deletion with middle mouse
2024-08-06 13:38:56 +09:00
jkh675
22ab6f577c
Add back the sample into OsuContextMenu
2024-08-06 12:37:46 +08:00
kstefanowicz
54a8f5b306
Shorten TranslatableString
2024-08-05 11:06:27 -04:00
Dean Herbert
f41bab0eb8
Merge pull request #29210 from normalid-awa/bugfix/visual/long-commet-tooltip-overflow
...
Limiting the `OsuTooltip` maximum width to prevent overflow
2024-08-05 18:09:07 +09:00
jkh675
75c0c6a5f9
Make the OsuContextMenu nullable in SelectionHandler
2024-08-05 16:32:49 +08:00
jkh675
6d385c6510
Remove the meaningless OpenMenu method
2024-08-05 16:31:15 +08:00
Dean Herbert
c37f617e1d
Adjust song select info icon size slightly
...
Not going to PR this it's just a minor tweak.
2024-08-05 17:21:50 +09:00
Dean Herbert
17eb134797
Merge branch 'master' into bugfix/visual/long-commet-tooltip-overflow
2024-08-05 17:01:20 +09:00
Dean Herbert
0557b9ab79
Allow placement deletion with middle mouse
...
This is in addition to Shift + Right-click.
I thik middle mouse feels more natural and is a good permanent solution
to this issue.
Note that this also *allows triggering the context menu from placement
mode*. Until now it's done nothing. This may be annoying to users with
muscle memory but I want to make the change and harvest feedback. I
think showing the context menu is more correct behaviour (although
arguably it should return to placement mode on dismiss?).
2024-08-05 14:25:09 +09:00
Dan Balasescu
136cdcfb29
Merge pull request #29059 from frenzibyte/fix-results-fetching-twice
...
Fix results screen fetching scores twice when scrolled to edge
2024-08-05 14:23:47 +09:00
Dan Balasescu
f92e2094c1
Adjust localisation string name + formatting
2024-08-05 12:34:24 +09:00
Dean Herbert
419d5a76ce
Merge branch 'master' into fix-pause-in-osu-again
2024-08-05 12:00:21 +09:00
AkiraTenchi
a5a392e9fc
Update FilterQueryParser.cs
...
Add sr as an alias for star rating in the search parameters
2024-08-04 19:48:29 +02:00
kstefanowicz
b0757a13c2
Add "enter" hint to chatbox placeholder text while in-game
2024-08-04 12:32:08 -04:00
jkh675
b32d97b4c0
Remove decreapted property
2024-08-04 21:27:25 +08:00
jkh675
2145368d17
Merge EditorContextMenuContainer into OsuContextMenuContainer
2024-08-04 21:00:43 +08:00
jkh675
7c83d6a883
Cleanup code
2024-08-04 19:56:41 +08:00
jkh675
5d31171fb0
Fix code quality
2024-08-04 19:43:43 +08:00
jkh675
3cc5466774
Refactor the code to follow IoC principle and more flexible
2024-08-04 19:39:06 +08:00
jkh675
27d6c4cecb
Implement on beatmap editor
2024-08-04 19:16:14 +08:00
jkh675
5c5fcd7e7e
Allow key event pass through selection handler
2024-08-04 19:11:21 +08:00
jkh675
1ff0c7cb46
Replace original menu container with custom one
2024-08-04 19:10:49 +08:00
jkh675
83aeb27c73
Replace original menu container to the custom one
2024-08-04 19:08:31 +08:00
jkh675
de6d8e7eb7
Add the custom context menu to handle the key event
2024-08-04 19:07:35 +08:00
Joseph Madamba
2daf1b58f2
Allow searching enum descriptions from SettingsEnumDropdowns
2024-08-03 14:48:08 -07:00
Dean Herbert
7765d0ff70
Merge pull request #29157 from frenzibyte/user-profile-daily-challenge-streak-display
...
Add daily challenge stats display to user profile overlay
2024-08-03 23:57:19 +09:00
Dean Herbert
d95d63d7ee
Undo localisation of Daily Challenge string for now
2024-08-03 22:44:51 +09:00
Dan Balasescu
040f65432e
Rename variables a bit
2024-08-03 19:40:06 +09:00
Joseph Madamba
4ef9f335ee
Fix customise button on mod overlay initially showing flash layer indefinitely
2024-08-02 10:19:59 -07:00
jkh675
a8141bf15f
Only wrap by per word
2024-08-02 21:50:24 +08:00
Dan Balasescu
7bf96ce49a
Merge pull request #29231 from peppy/timeline-break-behind-objects
...
Show breaks behind objects in timeline
2024-08-02 21:28:11 +09:00
Dan Balasescu
8a10d63ddf
Merge pull request #29228 from peppy/fix-leaderboard-v2-insane-allocs
...
Fix insane transform allocations in new leaderboard display
2024-08-02 21:28:00 +09:00
Dean Herbert
c27b35ad14
Update framework
2024-08-02 20:58:52 +09:00
Dean Herbert
dc73856f76
Fix original date not being restored when no changes are made on an import-as-update operation
2024-08-02 20:46:03 +09:00
jkh675
8265e7ce31
Reduce the tooltip max width
2024-08-02 19:44:55 +08:00
Caiyi Shyu
c85dc40f91
Merge branch 'master' into hover-open-mod-customise
2024-08-02 19:07:27 +08:00
Dan Balasescu
64b7bab4fb
Fix mod panels overflowing into the column borders
2024-08-02 18:59:21 +09:00
Dean Herbert
76904272e6
Allow horizontal scrolling on mod select overlay anywhere on the screen
...
Closes https://github.com/ppy/osu/issues/29248 .
2024-08-02 16:56:34 +09:00
Dean Herbert
310def64f4
Merge branch 'master' into user-profile-daily-challenge-streak-display
2024-08-02 15:40:46 +09:00
Dean Herbert
729039406b
Add colouring for play count
...
Matches https://github.com/ppy/osu-web/pull/11381 .
2024-08-02 15:38:17 +09:00
Dean Herbert
816dee181a
Rename classes to remove "streak" terminology
...
Since the primary display isn't showing a streak.
2024-08-02 15:33:30 +09:00
Dean Herbert
d76fc34cf8
Update to use localiastions
2024-08-02 15:33:25 +09:00
Dean Herbert
d9c965c47b
Update resources
2024-08-02 15:27:21 +09:00
Dean Herbert
3c1907ced3
Update LocalisationAnalyser to latest version
2024-08-02 14:53:18 +09:00
jkh675
f6ca4b2339
Replace the OsuSpriteText with TextFlowContainer in OsuTooltip and limit the max width
2024-08-02 12:16:50 +08:00
jkh675
5de37f9cd5
Revert changes
2024-08-02 12:02:28 +08:00
jkh675
894c6150c8
Revert "Update resources"
...
This reverts commit cbfb569ad4
2024-08-02 11:59:28 +08:00
Joseph Madamba
1e38d1fa57
Apply corner radius at a higher level so hover click sounds account for it
2024-08-01 18:45:47 -07:00
Joseph Madamba
0fac8148ed
Fix collection delete button not having hover click sounds
2024-08-01 18:30:52 -07:00
Joseph Madamba
b883ff6c7b
Fix click sounds playing twice on OsuRearrangeableListItem
2024-08-01 18:18:00 -07:00
Caiyi Shyu
051d52c23f
Update ModCustomisationPanel to use ExpandedState enum
2024-08-01 19:25:45 +08:00
Dean Herbert
548fd9cbf9
Show breaks behind objects in timeline
...
Closes https://github.com/ppy/osu/issues/29227 .
2024-08-01 19:47:44 +09:00
Caiyi Shyu
188ddbcad6
pass ModCustomisationPanel through ctor
2024-08-01 18:38:01 +08:00
Dean Herbert
dab967e6be
Fix insane transform allocations in new leaderboard display
2024-08-01 18:36:33 +09:00
Bartłomiej Dach
cd28fa7325
Merge pull request #29211 from peppy/always-show-control-points-timing
...
Always show timing points in timeline when at the timing screen
2024-07-31 16:46:55 +02:00
Dean Herbert
5098d637b5
Flash customise button on mod overlay when it becomes available
2024-07-31 19:55:20 +09:00
Dean Herbert
2d52bab77b
Always show timing points in timeline when at the timing screen
...
Supersedes https://github.com/ppy/osu/pull/29196 .
2024-07-31 19:43:08 +09:00
Dean Herbert
e329427d6e
Apply nullability to Timeline
2024-07-31 19:28:32 +09:00
jkh675
54e73acece
Cleanup code
2024-07-31 17:49:03 +08:00
jkh675
04ecefe226
Remove unused using
2024-07-31 17:23:25 +08:00
Caiyi Shyu
5fb364cad6
remove redundant code added accidentally
2024-07-31 16:56:25 +08:00
Caiyi Shyu
5b46597d56
fix click to expand on touch devices
2024-07-31 16:54:32 +08:00
jkh675
9e03dc3b5e
Implement maximum width on CommentTooltip
2024-07-31 16:52:53 +08:00
Dean Herbert
cbfb569ad4
Update resources
2024-07-31 14:37:56 +09:00
Dean Herbert
e9ed9ff58b
Merge pull request #29188 from bdach/daily-challenge/better-messaging
...
Add notification on daily challenge conclusion & start of new one
2024-07-31 13:35:25 +09:00
Dean Herbert
e77489f2a9
Allow notification of new strings
2024-07-31 03:10:36 +09:00
Dean Herbert
bdc465e1c6
Reword notification text slightly
2024-07-31 03:06:35 +09:00
Dean Herbert
5ebb5ad670
Fix test failure due to TestMetadataClient providing null statistics array
2024-07-31 02:53:10 +09:00
Dean Herbert
7f22ade90d
Fix oversight in timekeeping
2024-07-30 21:59:59 +09:00
Dean Herbert
d75c170ba1
Merge branch 'master' into daily-challenge/better-messaging
2024-07-30 19:04:48 +09:00
Dean Herbert
d5f9173288
Remove unused local variable
2024-07-30 19:04:43 +09:00
Dean Herbert
25747fdeb3
Fix edge case where minutes are same but hour is different
2024-07-30 18:06:56 +09:00
Dean Herbert
7229ae83ea
Adjust sizing and distribution of timestamp and username
2024-07-30 18:03:56 +09:00
Dean Herbert
6670f79258
Reduce overall size of chat text
2024-07-30 18:03:56 +09:00
Dean Herbert
4557ad43d5
Reduce padding on chat lines to give more breathing room
2024-07-30 17:52:56 +09:00
Dean Herbert
a2a73232f3
Avoid showing timestamp in chat line when repeated
2024-07-30 17:52:55 +09:00
Dean Herbert
e63080eb2e
Don't show seconds in chat timestamps
2024-07-30 17:52:54 +09:00
Dean Herbert
71acb7e9fc
Merge pull request #29137 from normalid-awa/feature/visual/chatline-background-altering
...
Alternate background colour of chat lines to better visually distinguish wrapped lines
2024-07-30 17:51:41 +09:00
Dean Herbert
c80f338893
Merge pull request #29198 from bdach/fix-difficulty-bindable
...
Fix incorrect `DifficultyBindable` logic
2024-07-30 17:50:58 +09:00
Bartłomiej Dach
1b57a2a136
Show new daily challenge notification globally
2024-07-30 10:36:26 +02:00
Dean Herbert
d48849040b
Merge pull request #29182 from bdach/revert-present-score
...
Force exit to main menu when presenting scores from within playlists / multiplayer
2024-07-30 17:24:27 +09:00
Dean Herbert
fc78dc9f38
Adjust paddings to avoid scrollbar overlap
2024-07-30 16:45:36 +09:00
Dean Herbert
bf10a91082
Adjust colouring to work better across multiple usages
2024-07-30 16:45:35 +09:00
Bartłomiej Dach
6813f5ee0a
Fix incorrect DifficultyBindable logic
2024-07-30 08:39:20 +02:00
Salman Ahmed
91dfe4515b
Fix daily challenge display showing incorrect statistic
2024-07-30 08:12:03 +03:00
Salman Ahmed
dca61eb76c
Remove no longer used dependency
2024-07-30 07:07:11 +03:00
Salman Ahmed
33fc6dfaff
Hide daily challenge display when not selecting osu!
...
Also hide when no user is displayed.
2024-07-30 07:06:59 +03:00
Salman Ahmed
8b910e59f6
Reduce tooltip shadow outline
2024-07-30 06:37:29 +03:00
Salman Ahmed
9868fb4aaa
Remove tier-based colour from the condensed piece to match web
2024-07-30 06:36:02 +03:00
Salman Ahmed
78417db06d
Remove stray line
2024-07-30 06:35:09 +03:00
Salman Ahmed
621f4dfece
Enforce new line between X/Y coordinate in editor position inspector
2024-07-30 02:45:21 +03:00
Dean Herbert
aa2515763c
Merge pull request #29184 from bdach/daily-challenge/wrong-mods-after-replay
...
Fix mods persisting after watching replay from daily challenge screen
2024-07-29 23:23:45 +09:00
Bartłomiej Dach
48e38bd467
Merge pull request #29186 from peppy/fix-status-config
...
Fix online status not persisting correctly
2024-07-29 16:11:05 +02:00
Bartłomiej Dach
5032a149e7
Merge pull request #29187 from peppy/daily-challenge-pieces-not-always-present
...
Favour updating daily challenge statistics when they come on screen
2024-07-29 15:48:26 +02:00
Bartłomiej Dach
3a30ff7817
Merge pull request #29172 from kadambishreyas/handle-timestamp-mod-content
...
Handle timestamp mod content
2024-07-29 15:34:50 +02:00
Bartłomiej Dach
12e553a290
Merge pull request #29166 from normalid-awa/bugfix/visual/mod-preset-tooltips-text-being-cutoff
...
Fix mod preset tooltip's description text being cut off
2024-07-29 15:19:06 +02:00
Bartłomiej Dach
b46f3c97da
Add notification on daily challenge conclusion & start of new one
...
Because I wish to stop seeing "DAILY CHALLENGE WHERE" every day
on #general.
The notifications are constrained to the daily challenge screen only to
not spam users who may not care.
2024-07-29 14:30:10 +02:00
Dean Herbert
7afcd72872
Fix potentially too many scores displaying in breakdown while in gameplay
2024-07-29 20:58:42 +09:00
Dean Herbert
05056f0e8a
Remove no longer required AlwaysPresent definition
...
This also reverts commit 7fedfd368c
2024-07-29 20:43:56 +09:00
Dean Herbert
5a1002c1a0
Ensure score breakdown doesn't spam scores when not visible
2024-07-29 20:43:50 +09:00
Dean Herbert
5bc02cc1c6
Fix background alternating not updating on message removal
2024-07-29 20:25:55 +09:00
Dean Herbert
997b3eb498
Fix typos and visuals
2024-07-29 20:24:51 +09:00
Bartłomiej Dach
8b96b0b9e4
Add logging when starting and stopping watch operations in online metadata client
...
For future use with debugging issues like
https://github.com/ppy/osu/issues/29138 , hopefully.
2024-07-29 13:19:01 +02:00
jkh675
d51a53b051
Preventing the mod icon being squashed up
2024-07-29 19:08:14 +08:00
Dean Herbert
11265538c4
Reset online status on logout
2024-07-29 20:06:30 +09:00
Dean Herbert
c142adf926
Fix online status not persisting correctly
...
Regressed at some point.
I don't see much reason not to link the bindable directly with config.
It seems to work as you'd expect. Tested with logout (resets to
"Online") and connection failure (persists).
Closes https://github.com/ppy/osu/issues/29173 .
2024-07-29 20:06:27 +09:00
Bartłomiej Dach
f1a84a5111
Fix mods persisting after watching replay from daily challenge screen
...
Closes https://github.com/ppy/osu/issues/29133 .
Hope I can be forgiven for no tests. I had a brief try but writing them
is going to take hours.
2024-07-29 12:52:30 +02:00
jkh675
8f86681110
Replace OsuSpriteText with TextFlowContainer
2024-07-29 18:29:44 +08:00
jkh675
90fdf5599f
Revert changes
2024-07-29 18:14:07 +08:00
Bartłomiej Dach
cebd38c6eb
Merge pull request #29163 from Joehuu/copy-lb-mods-daily
...
Add ability to copy leaderboard mods in daily challenge
2024-07-29 12:09:27 +02:00
Bartłomiej Dach
9b96bd1d73
Force exit to main menu when presenting scores from within playlists / multiplayer
...
- Closes https://github.com/ppy/osu/issues/29152
- Partially reverts https://github.com/ppy/osu/pull/29097
- Reopens https://github.com/ppy/osu/issues/26666
When testing I failed to predict that in multiplayer there can be a
different beatmap in the playlist queue. If this is the case,
`PresentScore()` will exit out to `Multiplayer`, whose `RoomSubScreen`
will update the selected item - and thus, the global beatmap - to the
next item in queue, at which point trying to play games with "not
touching the global beatmap bindable if we don't need to" fail to work,
because the bindable *must* be touched for correct operation, yet it
cannot (because `OnlinePlayScreen`s disable it).
I'm not sure what the fix is here:
- making replay player somehow independent of the global beatmap?
- not exiting out to multiplayer, but instead doing the present from the
results screen itself? if so, then how to ensure the screen stack
can't overflow to infinity?
so I'm just reverting the broken part. The daily challenge part is left
in because as is it should not cause issues.
2024-07-29 12:07:45 +02:00
jkh675
5ec46a79b4
Only create a new drawable object when the background is needed
2024-07-29 17:50:23 +08:00
Bartłomiej Dach
2ff0a89b4f
Convert into auto-property even more
2024-07-29 10:59:21 +02:00
Bartłomiej Dach
861b546562
Add vague test coverage
2024-07-29 10:58:05 +02:00
Bartłomiej Dach
54c904d439
Convert into auto-property
2024-07-29 10:40:29 +02:00
Bartłomiej Dach
aa7f6f81ef
Merge pull request #29127 from Joehuu/add-negative-horizontal-padding-daily
...
Fix daily challenge background clipping when settings/notifications is opened
2024-07-29 10:28:48 +02:00
jkh675
63757a77a5
Extract update background method
2024-07-29 13:39:08 +08:00
Shreyas Kadambi
dec6b190f2
Add optional 'suffix' to timestamp
2024-07-28 11:31:36 -04:00
normalid
4e65944609
Make the tooltips width be dyanmic with the content, so the long text wont occurs wierd line break
2024-07-28 16:26:18 +08:00
normalid
5db0e36404
Use the TruncatingSpriteText in ModPresetTooltip
2024-07-28 16:18:43 +08:00
Joseph Madamba
f6eb9037df
Add ability to copy leaderboard mods in daily challenge
2024-07-27 23:55:56 -07:00
Salman Ahmed
7fedfd368c
Fix score breakdown tooltips appearing in other feeds
2024-07-28 07:22:58 +03:00
