1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 13:47:38 +08:00
Commit Graph

449 Commits

Author SHA1 Message Date
Dean Herbert
4a26084df8 Only play results panel animation once (and only for the local user) 2020-10-29 17:04:33 +09:00
Dean Herbert
f1ce09930e Fix panel expanded state being updated multiple times unnecessarily 2020-10-29 17:03:45 +09:00
Dean Herbert
5d5b0221e5 Add skinning support for legacy applause playback 2020-10-29 16:32:29 +09:00
Dean Herbert
fb82c043a5 Add rank appear sound (new default) 2020-10-29 16:11:37 +09:00
Dean Herbert
a8e9c62583 Make results panels aware of whether they are a local score that has just been set 2020-10-29 16:11:25 +09:00
Dean Herbert
9141f48b04 Remove beatmap-based ctor to promote single flow 2020-10-23 14:57:27 +09:00
Lucas A
cf69eacae9 Make StarRatingDisplay dynamic. 2020-10-21 19:05:14 +02:00
Bartłomiej Dach
ba818e3ae0
Merge branch 'master' into results-dynamic-pp-calc 2020-10-19 21:41:07 +02:00
Bartłomiej Dach
68b505ab86 Extract helper function for pp value handling 2020-10-12 22:14:45 +02:00
Joehu
8faa86b048 Add ability to toggle extended statistics using space or enter 2020-10-10 18:32:22 -07:00
Lucas A
e845cc92b8 Round pp values to nearest integer. 2020-10-10 19:58:06 +02:00
Lucas A
de522d53ea Make CalculatePerformanceAsync() nullable. 2020-10-10 19:16:21 +02:00
Dan Balasescu
a6d19cd2d6
Merge pull request #10431 from peppy/fix-distribution-graph-rounding
Fix incorrect timing distribution display due to lack of rounding
2020-10-09 18:12:29 +09:00
Dean Herbert
8be19fd820 Increase height of contracted score panel to fit mods again 2020-10-09 13:26:09 +09:00
Dean Herbert
ff5a1937f5 Fix test logic and stabilise rounding direction 2020-10-09 05:04:03 +09:00
Dean Herbert
a5b2c4195e Fix incorrect timing distribution display due to lack of rounding 2020-10-09 04:41:45 +09:00
Lucas A
a425cf4a31 Fix broken class reference. 2020-10-07 13:29:10 +02:00
Lucas A
7f5cf04b2b Fix merge conflicts. 2020-10-07 13:28:49 +02:00
Dean Herbert
f77ad8cf39 Remove unused using 2020-10-07 17:03:34 +09:00
Dean Herbert
31d347be5c Make extended score panel taller to better fit all information 2020-10-07 16:50:00 +09:00
Dean Herbert
67398b5d95 Move timestamp text out of flow and attach to bottom edge 2020-10-07 16:30:14 +09:00
Dean Herbert
6ac70945f2 Show bonus judgements on expanded panel 2020-10-07 16:17:28 +09:00
Dean Herbert
c0bc6a75b3 Show auxiliary judgements on next line 2020-10-07 16:17:17 +09:00
Dean Herbert
e281d724b8 Consume display name logic 2020-10-07 15:43:52 +09:00
Bartłomiej Dach
2b1ef16f89 Replace comparison references to HitResult.Miss with IsHit 2020-10-02 23:31:24 +02:00
Lucas A
35f7de2084 Apply review suggestions. 2020-09-29 18:08:21 +02:00
Lucas A
6efc4c4250 Cache performance calculations to prevent recomputations. 2020-09-28 19:04:39 +02:00
Lucas A
ddede85704 Split performance calculation to its own class. 2020-09-27 12:44:29 +02:00
Lucas A
3cb9103fe0 Inherit PerformanceStatistic from CounterStatistic 2020-09-27 09:37:57 +02:00
Lucas A
4d94bf3163 Rename CalculateScorePerformance -> CalculatePerformance 2020-09-25 19:16:33 +02:00
Lucas A
77a9d92f42 Add dynamic pp calculation to score panels for local scores 2020-09-25 19:15:40 +02:00
smoogipoo
a07597c369 Adjust displays to use new results/orderings 2020-09-25 20:22:59 +09:00
Dan Balasescu
f84b5087bd
Merge pull request #10226 from peppy/results-fix-relayout-misalignment
Fix score panel being incorrectly vertically aligned on screen resize
2020-09-24 15:50:31 +09:00
Dan Balasescu
02d8355321
Merge pull request #10224 from peppy/results-statistics-replay-button
Add more descriptive description and download button when statistics not available
2020-09-24 14:31:38 +09:00
Dean Herbert
5612357574 Fix score panel being incorrectly vertically aligned on screen resize 2020-09-24 12:49:32 +09:00
Dean Herbert
fda6e88dd3 Fix braces style 2020-09-24 12:39:08 +09:00
Dean Herbert
cb903ec9e2 Fix extended statistics not being vertically centered 2020-09-24 12:21:46 +09:00
Dean Herbert
f4d2c2684d Add more descriptive description and download button when statistics not available 2020-09-24 12:21:08 +09:00
smoogipoo
37a659b2af Refactor/add xmldocs 2020-09-09 17:36:47 +09:00
smoogipoo
117c7ec6b2 Merge branch 'master' into score-recalc 2020-09-09 14:38:36 +09:00
Bartłomiej Dach
3ca2a7767a Exclude misses and empty window hits from UR calculation 2020-08-31 14:29:37 +02:00
Bartłomiej Dach
3b22b891d1 Add failing test cases 2020-08-31 14:29:18 +02:00
Bartłomiej Dach
88ae9ca91d
Merge branch 'master' into fix-unhide-hud-not-updating-stats 2020-08-31 11:48:19 +02:00
Dean Herbert
a171d0e292 Remove unused methods and classes 2020-08-31 18:14:22 +09:00
Dean Herbert
abdb991923 Hide misses from timing distribution graph 2020-08-31 14:15:47 +09:00
Joehu
0a643fd5e5 Fix replay download button always being disabled when initial score's replay is unavailable 2020-08-29 09:33:01 -07:00
smoogipoo
c1838902a6 Add to more places 2020-08-28 22:51:48 +09:00
Bartłomiej Dach
6846a245f4 Reapply lost anchoring fix 2020-08-27 20:51:28 +02:00
Bartłomiej Dach
ea1f07e311 Simplify/rename SimpleStatisticRow mess 2020-08-27 20:37:10 +02:00
Bartłomiej Dach
ce013ac9b4 Make statistic header optional 2020-08-27 20:18:53 +02:00
Bartłomiej Dach
f152e1b924 Revert IStatisticRow changes 2020-08-27 20:13:44 +02:00
Bartłomiej Dach
f8042e6fd3 Add fade to prevent jarring transitions 2020-08-26 22:34:28 +02:00
Bartłomiej Dach
c3197da3da Adjust simple statistic item font sizes 2020-08-26 22:34:28 +02:00
Bartłomiej Dach
d81d538b7e Move out row anchor/origin set to one central place 2020-08-26 22:34:27 +02:00
Bartłomiej Dach
5973e2ce4e Add component for unstable rate statistic 2020-08-26 22:06:27 +02:00
Bartłomiej Dach
7c3368ecbe Reintroduce SimpleStatisticRow as a data class 2020-08-26 19:33:33 +02:00
Bartłomiej Dach
f5e52c80b4 Rename {-> Drawable}SimpleStatisticRow 2020-08-26 19:25:59 +02:00
Bartłomiej Dach
927a2a3d2d Introduce IStatisticRow interface 2020-08-26 19:19:42 +02:00
Bartłomiej Dach
f09f882cc7 Add component for displaying simple statistics on result screen 2020-08-25 22:51:40 +02:00
Salman Ahmed
ee9fa11d14 Use With(s => ...) extension for better readability 2020-08-19 07:47:02 +03:00
Salman Ahmed
9d10658e3c Allow providing custom sprite text for RollingCounter<T> 2020-08-03 20:14:17 +03:00
smoogipoo
308f8bf9bf Fix inverted naming 2020-07-31 23:11:42 +09:00
Dan Balasescu
d63f040477
Merge branch 'master' into multi-position 2020-07-31 23:10:25 +09:00
Dean Herbert
909b38a019
Merge branch 'master' into multi-pagination 2020-07-31 22:41:24 +09:00
smoogipoo
b361761d86 Add position display in contracted score panels 2020-07-31 22:02:25 +09:00
smoogipoo
17018ffa8b Fix potentially triggering new requests too early 2020-07-31 21:33:04 +09:00
smoogipoo
9966d4f3b3 Add more loading spinners 2020-07-31 19:57:05 +09:00
smoogipoo
9f6446d836 Add xmldocs + refactoring 2020-07-28 21:45:12 +09:00
smoogipoo
42e88c53d7 Embed behaviour into UserCoverBackground 2020-07-28 20:50:55 +09:00
smoogipoo
54d2f2c8cd Delay loading of cover backgrounds in score panels 2020-07-28 20:34:09 +09:00
smoogipoo
255b733fe8 Merge branch 'master' into multi-pagination 2020-07-28 20:20:54 +09:00
smoogipoo
46ea775cfb Implement paging 2020-07-22 20:24:55 +09:00
Dean Herbert
cccb47e6e0 Add user cover background to expanded version of score panel 2020-07-22 11:29:23 +09:00
Dean Herbert
0125a7ef3b Fix single-frame glitch in SS grade display animation 2020-07-15 15:36:17 +09:00
Joehu
daa7430fd8 Fix statistics screen blocking retry, home, and alt f4 2020-07-14 00:00:43 -07:00
Joehu
718f06c690 Use Mod.AdjustRank() instead 2020-07-02 12:35:32 -07:00
Joehu
fa252d5e95 Fix score panel not showing silver s/ss badges on hd/fl plays 2020-07-01 17:37:38 -07:00
Joehu
5c1f1ab622 Fix avatar in score panel being unclickable when statistics panel is visible 2020-07-01 14:31:06 -07:00
smoogipoo
1701c844a6 Fix scroll container height on smaller ui scales 2020-06-30 16:36:53 +09:00
Derrick Timmermans
bb81f908fb
Exclude EmptyHitWindow from being considered in TimingDistributionGraph 2020-06-29 15:53:56 +08:00
Dean Herbert
6bcc693c2f Add ability to close statistics by clicking anywhere 2020-06-23 15:21:23 +09:00
smoogipoo
1bf00e0c82 Schedule continuation 2020-06-22 23:22:49 +09:00
smoogipoo
ff2f3a8484 Fix div-by-zero errors with autoplay 2020-06-22 20:32:04 +09:00
smoogipoo
5c4df2e32c Cancel load on dispose 2020-06-22 20:20:42 +09:00
smoogipoo
988baad16f Expand statistics to fill more of the screen 2020-06-22 19:20:43 +09:00
smoogipoo
261adfc4e6 Create a local playable beatmap instead 2020-06-22 18:38:41 +09:00
smoogipoo
3ede095b9c Apply refactorings from review 2020-06-22 15:42:55 +09:00
smoogipoo
33fdd7466c Merge branch 'master' into results-screen-statistics-overlapping-transition 2020-06-22 15:38:48 +09:00
smoogipoo
037bd3b463 Fix possible nullref 2020-06-19 22:48:21 +09:00
smoogipoo
4cb49cd606 Add minimum height to the timing distribution graph 2020-06-19 22:21:34 +09:00
smoogipoo
486b899e8f Rename method 2020-06-19 22:11:29 +09:00
smoogipoo
25abdc2903 General cleanups 2020-06-19 21:41:48 +09:00
smoogipoo
8aea8267fb Add some padding 2020-06-19 20:58:05 +09:00
smoogipoo
5ce2c712d3 Fix statistics not being wrapped by containers 2020-06-19 20:53:43 +09:00
smoogipoo
34a8fcfd2f Fix potential off-by-one 2020-06-19 20:53:30 +09:00
smoogipoo
83e6c3efdb Adjust API for returning statistics 2020-06-19 20:31:52 +09:00
smoogipoo
1cbbd6b442 Move timing distribution graph to osu.Game 2020-06-19 20:03:18 +09:00
smoogipoo
a3ff25177a Asyncify statistics load 2020-06-19 19:12:55 +09:00
smoogipoo
55196efe6e Fix panel depth ordering 2020-06-19 18:02:54 +09:00
smoogipoo
ec16b0fc5a Rework score panel tracking to fix visual edge cases 2020-06-19 17:28:35 +09:00
smoogipoo
85a0f78600 Hide statistics panel on first exit 2020-06-18 22:48:52 +09:00
smoogipoo
53f507f51a Fade background 2020-06-18 22:27:10 +09:00
smoogipoo
ecdfcb1955 Display placeholder if no statistics available 2020-06-18 22:21:30 +09:00
smoogipoo
6c8a24260b Add padding 2020-06-18 17:06:05 +09:00
smoogipoo
c31a05977d Re-implement statistics as a click-in panel 2020-06-18 16:50:45 +09:00
smoogipoo
725b2e540b wip 2020-06-17 22:29:00 +09:00
smoogipoo
5e74985eda Add scrolling capability to results screen 2020-06-17 19:28:40 +09:00
smoogipoo
e7687a0927 Temporary placement inside results screen 2020-06-16 17:49:43 +09:00
smoogipoo
a2ddb4edb4 Change interface for creating statistic rows 2020-06-16 17:49:28 +09:00
smoogipoo
89b54be673 Add initial implementation of the statistics panel 2020-06-15 22:45:18 +09:00
Dean Herbert
c3c5a99a22 Load imported scores to results screen rather than gameplay 2020-06-15 20:23:35 +09:00
smoogipoo
7b012f1def Fix test failures 2020-06-11 14:55:49 +09:00
smoogipoo
05b1edb9d8 Fix incorrect beatmap showing 2020-06-09 19:01:02 +09:00
Dean Herbert
5d1770dec8
Merge pull request #9212 from smoogipoo/fix-scorepanel-input
Fix score panel not receiving input in some places
2020-06-05 00:26:02 +09:00
smoogipoo
afcefe01bf Fix score panel not receiving input in some places 2020-06-04 21:48:55 +09:00
smoogipoo
5d7bb8cb4e Change format of date on score panel 2020-06-04 21:33:38 +09:00
Shane Woolcock
b174daa94a Remove unused using 2020-06-03 11:58:56 +09:30
Shane Woolcock
96e3c6e8e8 Move check to SoloResultsScreen 2020-06-03 11:36:47 +09:30
Shane Woolcock
90213d079d Include submission status in check 2020-06-03 10:48:27 +09:30
Shane Woolcock
f4f84ede6a Fix results screen crashing for beatmaps with no online ID 2020-06-03 10:43:16 +09:30
Dean Herbert
f2dadeeeb5 Allow horizontal scroll on results screen when not hovering expanded panel 2020-05-31 13:50:42 +09:00
smoogipoo
013461377e Fix potential nullref 2020-05-28 21:46:02 +09:00
smoogipoo
47d5974f04 Improve results screen behaviour when changing selected score 2020-05-28 21:40:01 +09:00
smoogipoo
ad99d85468 Resolve several positioning errors 2020-05-28 21:29:16 +09:00
smoogipoo
666cbd0f40 Allow selected score to be programmatically changed 2020-05-28 21:09:03 +09:00
smoogipoo
a55ce26130 Allow null score 2020-05-28 20:46:17 +09:00
smoogipoo
c07a33b24f Fix ctor accessibility 2020-05-26 17:31:50 +09:00
smoogipoo
de0b6ec9f1 Create abstract implementation 2020-05-26 17:00:41 +09:00
smoogipoo
c86a003ef9 Adjust transition for smaller sizes 2020-05-26 16:27:41 +09:00
smoogipoo
906a317a3d Reduce casting 2020-05-26 16:26:53 +09:00
smoogipoo
1768cbd131 Format score same as expanded panel 2020-05-26 15:56:56 +09:00
smoogipoo
80388feac4 Disable scroll user scroll controls in list 2020-05-22 20:39:02 +09:00
smoogipoo
6bcc4c95cc Schedule api callback 2020-05-22 20:19:23 +09:00
smoogipoo
899b9f8060 Fix incorrect sorting order 2020-05-21 22:26:04 +09:00
smoogipoo
45244683de Fix scrolling (1-frame + maintain scroll position) 2020-05-21 22:07:06 +09:00
smoogipoo
d0f74c2b68 Refactor initial state 2020-05-21 20:48:25 +09:00
smoogipoo
7b82a5d792 Fix score order 2020-05-21 20:48:08 +09:00
smoogipoo
717869225e Rework list to use a scroll container + add spacing 2020-05-21 19:51:36 +09:00
smoogipoo
b6a1d1a2fc Improve transforms between state changes 2020-05-21 18:07:31 +09:00
smoogipoo
700b5e0c73 Adjust design 2020-05-21 17:47:27 +09:00
smoogipoo
acba1f3ad6 Integrate score panel list into results screen 2020-05-20 23:46:54 +09:00
smoogipoo
1b8d657ead Implement score panel list 2020-05-20 23:46:47 +09:00
smoogipoo
e3c1112b5a Initial integration into results screen 2020-05-16 19:00:20 +09:00
smoogipoo
8c5ccf574b Add better fix for 1px bleed 2020-05-16 18:33:21 +09:00
smoogipoo
2bde4fc3ee Initial implementation of contracted score panel 2020-05-16 18:20:19 +09:00
Joehu
700214d249 Truncate beatmap title and artist on score panel 2020-04-30 22:13:38 -07:00
Joehu
88cc552534 Fix results star rating display not being centered when no mods are present
Needed or the spacing will apply to the fill flow container, causing alignment issues.
2020-04-03 11:30:22 -07:00
Joehu
493b654011 Remove horizontal margin from mod display
Can skew center alignment on fill flow containers.

Fixes affected areas. Vector2(5, 0) is similar to MarginPadding { Left = 10 }.
2020-04-03 11:30:02 -07:00
Dean Herbert
113660b621 Merge if statements 2020-03-30 18:56:35 +09:00
Dean Herbert
6e68b968f8 Hide "retry" button on results screen after watching a replay 2020-03-29 23:52:50 +09:00