Bartłomiej Dach
9cc2150b5a
Fix mixed [cC]urrent usage
2023-07-13 22:00:21 +02:00
Bartłomiej Dach
3ca767b7a2
Remove outdated comment
2023-07-13 21:58:55 +02:00
Bartłomiej Dach
6b9dabbd3c
Rewrite test scene to show non-themed and themed variants
2023-07-13 21:54:30 +02:00
Bartłomiej Dach
eeb50e2700
Do not rely on OverlayColourProvider presence
2023-07-13 21:45:06 +02:00
Dean Herbert
94201579f6
Update design of "revert to default" button
...
I keep getting feedback that the old design looked like anything *but* a
button to revert defaults. Including people clicking it expecting
opposite behaviour.
This is intended to be a temporary design until we get the full new UI
components online (where this is moved to the right-hand-side).
2023-07-13 14:26:03 +09:00
Dean Herbert
1bfe5a18cb
Rename RestoreDefaultValueButton to RevertToDefaultButton
...
Because I can't find it every time I search.
2023-07-13 13:46:50 +09:00
Bartłomiej Dach
a891dcd9e6
Merge pull request #24188 from peppy/fix-legacy-old-stacking-wang
...
Fix incorrect slider stacking on very old beatmaps
2023-07-12 23:51:00 +02:00
Bartłomiej Dach
b30ccc6d42
Merge pull request #24181 from peppy/fix-blueprint-end-placement
...
Fix slider blueprint placement when ending placement outside the playfield
2023-07-12 22:23:35 +02:00
Dean Herbert
547f247669
Fix test to work regardless of screen sizes
2023-07-12 17:41:58 +09:00
Dean Herbert
d12845d7b1
Remove no-longer-necessary ReceivePositionalInputAt overide in CatchPlacementBlueprint
2023-07-12 17:39:54 +09:00
Dean Herbert
b20190ed4f
Merge branch 'master' into fix-blueprint-end-placement
2023-07-12 17:38:47 +09:00
Dean Herbert
4f5137f893
Merge pull request #24187 from smoogipoo/update-localisation-packages
...
Update localisation analyser packages
2023-07-12 17:36:31 +09:00
Dean Herbert
87570ed238
Fix incorrect slider stacking on very old beatmaps
...
Closes https://github.com/ppy/osu/issues/24185
The stable code has had a bug in this logic forever. So we'll need to
reimplement the bug.
Basically, sliders have to have `UpdateCalculations` run in order to
have a correct `Position2` and `EndTime`, but this wasn't being called
in the inner loop before use of `EndTime` at
1531237b63/osu
2023-07-12 17:35:03 +09:00
Dan Balasescu
41d3924326
Update localisation analyser packages
2023-07-12 16:30:26 +09:00
Dean Herbert
8e1e8a2807
Merge pull request #24169 from bdach/legacy-score-v2
...
Backpopulate stable ScoreV2 scores with ScoreV2 system mod (and don't recalculate their total score)
2023-07-12 12:44:04 +09:00
Bartłomiej Dach
5bc1f2702c
Merge pull request #24175 from NiceAesth/verify-drain-time
...
Add beatmap drain time check
2023-07-12 01:04:25 +02:00
Bartłomiej Dach
851e6d111a
Merge branch 'master' into verify-drain-time
2023-07-11 23:29:18 +02:00
Bartłomiej Dach
a1da0b58db
Improve negative test case without breaks too
2023-07-11 23:22:37 +02:00
Bartłomiej Dach
d927cb3f1c
Actually cover cases with breaks in tests
2023-07-11 23:21:03 +02:00
Bartłomiej Dach
9a3cb624a8
Rewrite tests to be less aggressively DRY
...
Four of six helper methods defined in the test were used exactly once;
the remaining two were used two times. Splitting helpers there is just
too much.
2023-07-11 23:18:52 +02:00
NiceAesth
d75887bb3b
Apply feedback to tests
2023-07-11 13:40:27 +03:00
NiceAesth
1dae1d8f0a
Account for break time
2023-07-11 13:40:19 +03:00
Dean Herbert
a0e6748882
Fix slider blueprint placement when ending placement outside the playfield
...
As mentioned in https://github.com/ppy/osu/discussions/24161
2023-07-11 17:29:53 +09:00
Dean Herbert
ca9c31b492
Add test coverage of slider blueprint end placement failing outside playfield
2023-07-11 17:29:28 +09:00
Dean Herbert
0dd4ad8c5d
Merge branch 'master' into legacy-score-v2
2023-07-11 16:56:49 +09:00
Dean Herbert
99d4d2be37
Merge pull request #24178 from Zyfarok/scoring-test-scene-processor
...
Use OsuScoreProcessor in the scoring test scene
2023-07-11 16:45:23 +09:00
Dean Herbert
4ee1f6a49f
Merge pull request #24092 from Susko3/fix-manifest-dpi
...
Merge `app.manifest`s and let framework set DPI awareness options
2023-07-11 14:12:28 +09:00
Zyf
82364b4f9f
Use OsuScoreProcessor in the scoring test scene
2023-07-11 02:46:32 +02:00
Bartłomiej Dach
9e4ffc8c12
Split helper method for populations from replay
2023-07-10 21:10:01 +02:00
Bartłomiej Dach
24d9520af6
Merge pull request #24174 from peppy/update-framework
...
Update framework
2023-07-10 19:46:03 +02:00
NiceAesth
c972a4195c
Add tests
2023-07-10 17:29:59 +03:00
NiceAesth
9a2915f423
Add beatmap minimum length checks
2023-07-10 17:29:49 +03:00
Dean Herbert
89b110e3aa
Update framework
2023-07-10 21:26:20 +09:00
Dean Herbert
8b222dc42b
Merge pull request #24171 from bdach/editor-timestamp-copy-without-selection
...
Fix pressing Ctrl-C in composer not copying timestamp to system clipboard with empty selection
2023-07-10 15:27:42 +09:00
Dean Herbert
8d09049a52
Merge pull request #24173 from bdach/use-channel-msg-length-limit
2023-07-10 10:44:52 +09:00
Bartłomiej Dach
91e286560e
Fix search being broken in channel listing "channel"
2023-07-09 21:51:08 +02:00
Bartłomiej Dach
6453ab6049
Set chat text box message length limit based on channel
2023-07-09 21:42:13 +02:00
Bartłomiej Dach
2af8c7bc24
Add failing test case for chat message length limit enforcement
2023-07-09 21:40:27 +02:00
Bartłomiej Dach
d135b3f6f5
Add message length limit field to API response
2023-07-09 21:27:33 +02:00
Bartłomiej Dach
45194b2b4a
Fix pressing Ctrl-C in composer not copying timestamp to system clipboard
2023-07-09 18:21:43 +02:00
Bartłomiej Dach
e12255bbe5
Do not run legacy conversion with ScoreV2 mod present
2023-07-09 17:48:25 +02:00
Bartłomiej Dach
9377622cd4
Add backwards migration to populate ScoreV2 mod for already-imported scores
2023-07-09 17:48:24 +02:00
Bartłomiej Dach
7be5e0e978
Implement back-and-forth conversion of ModScoreV2 and LegacyMods
2023-07-09 16:15:21 +02:00
Bartłomiej Dach
2cd5fd5944
Add failing legacy mod conversion test cases
2023-07-09 16:09:25 +02:00
Bartłomiej Dach
10ba04512d
Add ScoreV2 to LegacyMods
2023-07-09 16:06:05 +02:00
Bartłomiej Dach
ae05df3b8c
Add ModScoreV2
2023-07-09 15:56:51 +02:00
Dean Herbert
40f537ea00
Merge pull request #24165 from bdach/generate-ticks-dropped
2023-07-09 09:34:34 +09:00
Bartłomiej Dach
56a2ba4ac0
Fix GenerateTicks being lost during osu! beatmap conversion process
2023-07-08 23:24:38 +02:00
Bartłomiej Dach
e9ecad9839
Add failing test cases covering NaN-timing-point sliders
2023-07-08 23:24:38 +02:00
Bartłomiej Dach
b9eee29442
Merge pull request #24119 from peppy/taiko-hitsounding-final-attempt
...
Implement new argon osu!taiko hitsounds
2023-07-08 20:19:45 +02:00
