h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-18 20:22:56 +08:00
Code Issues Releases Wiki Activity
60,288 Commits 4 Branches 661 Tags 359 MiB
9915fac2c8
Commit Graph

296 Commits

Author SHA1 Message Date
Bartłomiej Dach
9915fac2c8
Fix sample silence being one level too low 
4a7b011a53 inadvertently unearthed that
nested strong hits could play samples of their own accord, rather than
delegating to `DrumSampleTriggerSource` as they were supposed to. This
was an unfortunate omission due to how the inheritance structure of
`TaikoHitObject` looks like (some irrelevant classes omitted for
brevity):

	DrawableTaikoHitObject
		DrawableTaikoHitObject<TObject> <-- `GetSamples()` was overridden to empty here
			DrawableTaikoStrongableHitObject
				DrawableHit
				DrawableDrumRoll
				DrawableDrumRollTick
			DrawableSwell
			DrawableSwellTick
		DrawableStrongNestedHit <-- all strong nested hits are here => didn't receive `GetSamples()` override
			DrawableHit.StrongNestedHit
			DrawableDrumRoll.StrongNestedHit
			DrawableDrumRollTick.StrongNestedHit

To fix, move the `GetSamples()` override one level higher, to the
non-generic `DrawableTaikoHitObject`, to suppress the spurious sample
playbacks.

The stale reference in the comment was also updated to match current
code.
 2023-05-21 18:58:26 +02:00
Dean Herbert
da8ab7143b
Merge branch 'master' into maximum-judgement-offset-in-hit-object 2023-02-15 14:48:15 +09:00
Bartłomiej Dach
67b6df3172
Reword ambiguous xmldoc 2023-02-12 13:31:29 +01:00
Dean Herbert
9d09141ab7 Move taiko-specific property out of DrawableHitObject 2023-02-12 16:09:28 +09:00
Dean Herbert
34d1890f1c Change snapping to only apply to classic mod 2023-02-09 18:22:14 +09:00
OpenSauce
df1355ea4b Taiko hit objects now snap to hit target 2023-02-08 10:59:08 +00:00
ekrctb
11e1b22bf5 Move MaximumJudgementOffset to HitObject 
We want to access this property for computing lifetime
 2023-01-19 21:23:55 +09:00
Dan Balasescu
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
Bartłomiej Dach
7379f6fe20
Merge branch 'master' into argon-taiko 2022-11-12 01:56:30 +09:00
Dan Balasescu
8063dcd74a
Merge pull request #21148 from peppy/taiko-barline-separation 
Move major barline portion to default implementation to allow for further customisation
 2022-11-11 16:40:51 +09:00
Dan Balasescu
1a1a186d22 Merge branch 'master' into taiko-barline-separation 2022-11-11 15:47:06 +09:00
Dan Balasescu
f25a8ee4a6 Merge branch 'master' into taiko-tick-trackiung 2022-11-11 15:41:06 +09:00
Dan Balasescu
606d42c679
Merge pull request #21184 from peppy/skinnable-things-cleanup 
Skinnable class naming pass
 2022-11-10 12:52:08 +09:00
Dean Herbert
1aa0e40f2f Add "Component" prefix to lookup naming 2022-11-09 17:46:43 +09:00
Dean Herbert
c908969d9b Rename ISkinComponent to ISkinLookup 2022-11-09 17:46:43 +09:00
Dean Herbert
aa7d0e2c96 Remove triangles skin specific implementation from base DrawableHit 2022-11-08 15:22:00 +09:00
Dean Herbert
aa61eb8f4b Add note about taiko pooling oversight 2022-11-07 18:32:12 +09:00
Dean Herbert
938a8f865b Adjust transform of taiko drum roll ticks to not scale to 0 (looks bad) 2022-11-07 18:32:12 +09:00
Dean Herbert
2648175275 Merge branch 'taiko-barline-separation' into taiko-fixes-combined 2022-11-07 18:32:09 +09:00
Dean Herbert
1975385cc7 Move first tick tracking logic inside TickPiece 2022-11-07 15:26:34 +09:00
Dean Herbert
c69a4f9333 Move major barline portion to default implementation to allow for further customisation 
Of note, this removes the "major" barline triangles from legacy skins. I
think this is more correct, as they did not display in stable.
 2022-11-07 14:29:58 +09:00
sw1tchbl4d3
0cffbb7562 Clamp LifetimeStart of HitObject's to their judgement windows 2022-09-27 16:54:24 +02:00
Dan Balasescu
792b410c04 Merge branch 'master' into classic_drumrolls 2022-09-06 16:29:45 +09:00
sw1tchbl4d3
b185194d07 Apply comments by smoogi 2022-08-30 14:44:44 +02:00
Dean Herbert
a215d009fe Update Remove/RemoveRange/RemoveAll calls in line with framework changes 2022-08-29 15:57:40 +09:00
Dean Herbert
ad28bfc9b2 Fix taiko blueprints displaying incorrectly for drum rolls 2022-08-18 17:18:11 +09:00
sw1tchbl4d3
e0426836c1 Make swells and drumrolls optional by default 2022-08-05 16:30:07 +02:00
sw1tchbl4d3
0a0f3c93dd Rename OkResult, rephrase "strong bonus" 2022-07-24 20:55:13 +02:00
Bartłomiej Dach
f47b74a938
Move OkResult from drawable swell to judgement 2022-06-24 13:00:12 +02:00
sw1tchbl4d3
6c8042642a Reduce code duplication 2022-06-20 17:22:41 +02:00
sw1tchbl4d3
98527fec26 Make mod selfcontained 2022-06-19 15:11:12 +02:00
sw1tchbl4d3
a5bf16e873 Make drum rolls and swells optional with Classic mod 2022-06-19 02:10:23 +02:00
Dan Balasescu
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Bartłomiej Dach
c6adbdd46f
Fix drum rolls nested objects not applying min result on kill 2022-01-16 17:53:37 +01:00
Dean Herbert
6944151486 Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
smoogipoo
f9d5abff8a Update with keybinding changes 2021-09-16 18:26:12 +09:00
PercyDan54
e1c646b9b2
Remove redundant arguments 2021-07-05 23:52:39 +08:00
Dean Herbert
6471ce902d Run RecreatePieces using AddOnce to avoid multiple unnecessary calls 2021-05-21 16:45:28 +09:00
Dean Herbert
0bcd0cda6b Fix taiko drawable hit content not correctly being removed on regeneration 2021-05-21 16:41:40 +09:00
Dean Herbert
7bc8a4bb5f Apply same logic changes to IsStrong status 2021-05-21 16:15:27 +09:00
Dean Herbert
a5ca736e37 Fix RecreatePieces being called more than once 2021-05-21 16:10:48 +09:00
Dean Herbert
40c8378d81 Fix type-to-sample mapping being applied too late 2021-05-21 14:37:22 +09:00
Bartłomiej Dach
370f56eadb Make strong hit DHOs public for pool registration 2020-12-20 18:02:34 +01:00
Bartłomiej Dach
0c5333bd58 Adjust top-level hitobjects to support nested pooling 2020-12-20 17:57:19 +01:00
Bartłomiej Dach
ae6dedacaf Implement nested strong hit application 2020-12-20 16:26:39 +01:00
Bartłomiej Dach
d823c77a63 Implement swell tick application 2020-12-20 16:26:39 +01:00
Bartłomiej Dach
3bd4279589 Implement drum roll tick application 2020-12-20 16:26:39 +01:00
Bartłomiej Dach
e3b6eaa390 Implement swell application 
Also removes a weird sizing application that seems to have no effect
(introduced in 27e63eb; compare removals for other taiko DHO types in
9d00e5b and 58bf288).
 2020-12-20 16:26:39 +01:00
Bartłomiej Dach
8b6bc09b8f Implement drum roll application 2020-12-20 16:26:16 +01:00
Bartłomiej Dach
e32b1c34ca Implement hit application 2020-12-20 16:26:16 +01:00