509 Commits

Author	SHA1	Message	Date
Naxesss	b888185799	Properly dispose of Stream in bg quality check	2021-11-10 05:06:11 +01:00
Dean Herbert	e43d91ad5d	Fix another case of incorrect null checking in editor verification processing	2021-11-04 15:18:10 +09:00
Dean Herbert	1e73b09e57	Fix another couple of cases of incorrect string null/empty checking	2021-11-04 14:22:28 +09:00
Dean Herbert	6944151486	Apply batch fixing of built-in types using var	2021-10-27 13:04:41 +09:00
smoogipoo	aa380a11c1	Merge branch 'master' into no-more-difficulty-control-points-info	2021-10-14 12:02:10 +09:00
Bartłomiej Dach	c7db286b94	Merge branch 'master' into file-sanity-checks	2021-10-14 00:17:29 +02:00
Dean Herbert	82f7f99f37	Refactor to use scoped using (and also correctly dispose TagLib portion)	2021-10-12 10:46:26 +09:00
Naxesss	f2f97602f2	Dispose of video resource later ... We need the Stream to stay open here because `StreamFileAbstraction` uses it later in the block.	2021-10-12 00:40:39 +02:00
Naxesss	47b4d03145	Dispose of Streams when used	2021-10-12 00:13:38 +02:00
Naxesss	ce69dd3588	Use Prescan flag for audio length check	2021-10-11 23:57:23 +02:00
Naxesss	8f093b9a11	Use TagLib instead of ManagedBass	2021-10-11 13:56:26 +02:00
Naxesss	f0cd18a721	Only check each video file once	2021-10-11 13:55:50 +02:00
Naxesss	6aa054b5fa	Change to non-BASS error template	2021-10-11 13:53:23 +02:00
smoogipoo	bc37cb6f43	Merge branch 'master' into no-more-difficulty-control-points-info	2021-10-08 18:41:17 +09:00
Dean Herbert	b339c149d8	Copy BaseDifficulty to Beatmap<T> and move all write operations across	2021-10-06 15:10:45 +09:00
Dean Herbert	a92d499d7a	Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo	2021-10-01 16:55:50 +09:00
Dean Herbert	693ecdf62a	Refactor some incorrect/outdated terminology	2021-09-06 21:32:43 +09:00
Dean Herbert	d4e5a612ea	Update IPositionalSnapProvider to take a HitObject as reference, rather than raw time ... This allows fetching the correct `DifficultyControlPoint` from the hitobject. Nothing more.	2021-09-03 17:11:12 +09:00
Dean Herbert	a3d9ab1e2e	Move approach rate to EffectControlPoint	2021-09-03 16:58:16 +09:00
Dean Herbert	b29209d13f	Ensure tool is always set back to select tool when beatmap becomes untimed	2021-07-19 17:08:40 +09:00
Dean Herbert	bde35d9f21	Rename radio button classes to be local to editor	2021-07-19 16:57:12 +09:00
Dean Herbert	eac9b1ec7e	Disable toolbox composition buttons when beatmap is not timed	2021-07-17 02:30:13 +09:00
Naxess	3a5912e35e	Add new checks to verifiers	2021-07-13 10:53:25 +02:00
Naxess	6da2a3d51f	Add zero-length objects check and tests	2021-07-13 10:50:11 +02:00
Naxess	dc4285582b	Fix misplaced "f" in issue message	2021-07-13 06:07:04 +02:00
Naxess	c8f58cbf6c	Add audio in video check and tests	2021-07-13 04:17:41 +02:00
Naxess	a4a1919842	Add too short audio files check and tests	2021-07-13 03:46:45 +02:00
Naxess	0a8fd01b99	Add zero byte check and tests	2021-07-13 03:45:21 +02:00
ekrctb	663ffae42f	Fix hit object selection blueprint potential null reference	2021-07-08 14:19:00 +09:00
Naxess	9f9e96ce9e	Add check for spanDuration <= 0 prior to division	2021-06-27 15:40:09 +02:00
Naxess	a4a5325b73	Improve acceptable difference for repeat edges ... Likelihood that `spanDuration` is greater than E+7 is quite low in any realistic case, so this should work fine.	2021-06-27 15:39:31 +02:00
Naxess	4cfa0ae5ec	Improve precision for repeat edges	2021-06-27 03:26:35 +02:00
Naxess	2cd7eda3c4	Add "or equal to" to volume threshold xmldocs	2021-06-27 02:30:12 +02:00
Naxess	0c0fd291d9	Order hitobjects by endtime	2021-06-27 01:25:03 +02:00
Naxess	4796b1b208	Use local variables for hasHitsound & couldHaveHitsound	2021-06-27 00:04:30 +02:00
Naxess	5bc08ebadb	Rename hasHitsounds -> mapHasHitsounds	2021-06-26 23:49:25 +02:00
Naxess	d29e6f4695	Add negligible template to PossibleTemplates	2021-06-26 23:49:06 +02:00
Naxess	1913084342	Use HitSampleInfo.AllAdditions instead of new list	2021-06-26 23:48:28 +02:00
Naxess	f78cc9397e	Factor out edge type logic	2021-06-26 20:45:31 +02:00
Naxess	51147405c5	Make || and && priority explicit	2021-06-26 20:44:39 +02:00
Naxess	4b436b774d	Add few hitsounds check	2021-06-26 19:20:46 +02:00
Naxess	d8117fa730	Add muted objects check	2021-06-26 19:20:34 +02:00
ekrctb	9dcd0bf311	Remove IPlayfieldProvider by caching Playfield	2021-06-17 10:15:24 +09:00
ekrctb	ef96ceb4ab	Introduce IPlayfieldProvider	2021-06-15 14:43:04 +09:00
Dean Herbert	8a76d97b63	Remove replay logic from DrawableRuleset (and implement in DrawableEditorRulesetWrapper)	2021-06-02 11:06:30 +09:00
Dean Herbert	bbfd7ea23f	Ensure RegenerateAutoplay is only run once per frame	2021-05-23 21:20:08 +09:00
Dean Herbert	6c4709e7b4	Fix PlacementBlueprint using the wrong beatmap when applying defaults ... Closes #12855.	2021-05-19 18:34:07 +09:00
Dean Herbert	a96603f025	Merge pull request #12782 from smoogipoo/rework-hitobject-blueprints ... Rename hitobject blueprints and tie them to HitObjects	2021-05-18 16:30:58 +09:00
smoogipoo	882d54a8f8	Remove now unnecessary Apply() method	2021-05-18 14:26:26 +09:00
smoogipoo	e621cfc4ea	Add Apply() method for applying new DHOs	2021-05-18 14:14:10 +09:00