Dean Herbert
8d913e8971
Fix multiple animation inconsistencies pointed out in review
2025-01-07 16:54:11 +09:00
Dean Herbert
794765ba85
Remove use of Loop
(and transforms) for slider repeat arrow animations
...
Less transforms in gameplay is always better.
This fixes repeat arrows animating completely incorrectly in the editor
(and probably gameplay when rewinding).
2025-01-02 18:36:58 +09:00
Dean Herbert
b8d6bba039
Fix legacy hitcircle fallback logic being broken with recent fix
...
I was a bit too eager to replace all calls with the new `provider`
in
dae380b7fa
,
while it doesn't actually make sense.
To handle the case that was trying to be fixed, using the `provider` to
check whether the *prefix* version of the circle sprite is available is
enough alone.
Closes https://github.com/ppy/osu/issues/31200
2024-12-24 16:05:44 +09:00
Dean Herbert
dae380b7fa
Fix lookups of hit circle slider pieces potentially using wrong source skin
...
Addresses https://github.com/ppy/osu/discussions/30927 .
2024-12-10 22:03:07 +09:00
Dean Herbert
312336de24
Fix classic skin spinner's middle pieces displaying in the wrong order
...
Closes https://github.com/ppy/osu/issues/30873 .
See [stable
reference](3ea48705eb/osu
!/GameplayElements/HitObjects/Osu/SpinnerOsu.cs#L148-L158).
2024-11-26 18:12:28 +09:00
Dean Herbert
48cfd77ee8
Component
-> Lookup
2024-08-23 14:48:50 +09:00
Dean Herbert
1435fe24ae
Remove requirement of base
calls to ensure user skin container layouts are retrieved
2024-08-22 19:14:30 +09:00
Dean Herbert
b57b8168a6
Rename Target
lookup to Component
2024-08-22 19:00:28 +09:00
Dean Herbert
9a21174582
Move GlobalSkinnableContainers
to global scope
2024-08-22 18:46:07 +09:00
Dean Herbert
36b4013fa6
Rename GameplaySkinComponentLookup
-> SkinComponentLookup
2024-08-22 18:46:03 +09:00
Dean Herbert
f37cab0c6e
Rename SkinComponentsContainerLookup
to GlobalSkinnableContainerLookup
2024-08-22 18:39:36 +09:00
Salman Ahmed
20658ef4ee
Fix legacy key counter position not matching stable
2024-08-21 00:10:16 +09:00
Dean Herbert
5710f0f302
Merge pull request #26254 from frenzibyte/mania-combo-counter
...
Add argon/classic osu!mania combo counter
2024-08-15 17:56:28 +09:00
Salman Ahmed
49c71f7863
Fix beatmap skin always overriding ruleset HUD components
2024-08-15 16:47:10 +09:00
Dean Herbert
d2eb6ccb8c
Standardise skin transformer code structure
2024-08-12 14:27:21 +09:00
Dean Herbert
80c814008f
Update in line with new changes
2024-08-09 14:55:01 +09:00
Dean Herbert
60d383448f
Avoid making non-ruleset transformers in Ruleset.CreateSkinTransformer
...
This didn't make any sense, so let's do it a better way.
2024-08-08 16:29:54 +09:00
Dean Herbert
3c572abaa7
Merge branch 'master' into ruleset-specific-combo-counter
2024-08-08 03:21:52 +09:00
Dean Herbert
725dc4de9b
Use transformers for per-skin key counter implementation
2024-08-06 18:17:21 +09:00
Bartłomiej Dach
5fcea01c13
Merge branch 'master' into ruleset-specific-combo-counter
2024-06-04 15:44:11 +02:00
Dan Balasescu
b1c7afd75b
Move to ctor
2024-05-23 23:45:04 +09:00
Aurelian
f17f70dca7
Changed Size to be handled by AutoSizeAxes
2024-05-23 14:36:49 +02:00
Aurelian
c3a2a1361d
SliderBody's Size getter updates size to the body/path's Size
2024-05-22 18:42:23 +02:00
Dean Herbert
fb1d20bd39
Comment in some clarification
2024-04-22 15:07:11 +08:00
Dan Balasescu
0170c04baf
Fix cursormiddle
not using the same source as cursor
2024-04-22 15:01:28 +09:00
Dan Balasescu
40c48f903b
Add failing test
2024-04-22 15:01:28 +09:00
Dean Herbert
b53b752e54
Update usage of MathUtils
2024-03-06 12:13:12 +08:00
Dean Herbert
6455c0583b
Update usage of CircularProgress.Current
2024-03-06 12:13:10 +08:00
Bartłomiej Dach
71b1fbb9d0
Merge pull request #27383 from Detze/slider-border-thickness
...
Rewrite legacy slider path rendering to match stable better
2024-02-28 10:02:46 +01:00
Salman Ahmed
b3aa9e25d2
Disable legacy slider AA for now
2024-02-27 23:18:29 +03:00
Salman Ahmed
83af9dfb39
Fix aa_width
being incorrect
2024-02-27 02:43:02 +03:00
Salman Ahmed
18e26e39fe
Remove SliderBorderSize
for simplicity
2024-02-27 02:20:34 +03:00
Salman Ahmed
2f54775182
Add stable code references
2024-02-27 02:17:02 +03:00
Salman Ahmed
81e6a6d96a
Rewrite LegacySliderBody
rendering to perfectly match stable
2024-02-27 02:11:32 +03:00
Salman Ahmed
e01722a266
Revert "Match stable's slider border thickness more closely"
...
This reverts commit 3502ec456d
.
2024-02-27 01:30:20 +03:00
Salman Ahmed
8363c39da8
Revert "Match stable's slider border thickness perfectly"
...
This reverts commit 8032ce9225
.
2024-02-27 01:30:20 +03:00
Detze
8032ce9225
Match stable's slider border thickness perfectly
2024-02-26 18:37:27 +01:00
Detze
3502ec456d
Match stable's slider border thickness more closely
2024-02-26 04:36:09 +01:00
Dean Herbert
e8d2abc4f7
Merge pull request #27364 from EVAST9919/spinner-alloc
...
Reduce osu spinner allocations
2024-02-25 09:36:02 +08:00
Dean Herbert
e12f8c03ee
Reset lastRecord
on resetState
for good measure
2024-02-25 08:18:19 +08:00
Andrei Zavatski
9e90f7fb0d
Store last enqueued RotationRecord in SpinnerSpmCalculator
2024-02-24 20:36:06 +03:00
Dean Herbert
a3429986bc
Merge branch 'master' into spinner-stutter
2024-02-25 00:13:48 +08:00
Dean Herbert
824d671cce
Simplify implementation
2024-02-25 00:12:20 +08:00
Andrei Zavatski
2696620d12
Completely remove transform flow for spm counter
2024-02-24 17:09:49 +03:00
Andrei Zavatski
4bba0eaf4b
Remove repeated TimeStarted check
2024-02-24 16:42:44 +03:00
Andrei Zavatski
9b526912e9
Fix incorrect operator
2024-02-24 16:41:53 +03:00
Andrei Zavatski
e7d8ca3292
Fix Argon and Trianles spinner stutter
2024-02-24 14:22:34 +03:00
Andrei Zavatski
31dabaefaa
Reduce smoke allocations
2024-02-23 18:21:11 +03:00
Salman Ahmed
bbf3f6b56c
Fix old-style legacy spinner fade in not matching stable
2024-02-22 16:31:13 +03:00
Bartłomiej Dach
cd1acf1ef9
Merge pull request #27288 from peppy/fix-follow-circle-animation
...
Fix classic skin follow circles animating from incorrect starting point
2024-02-21 10:53:56 +01:00