93 Commits

• Use empty string instead of null because issue template not accept null.
  andy840119 · 2022-10-30 16:31:07 +08:00
  a1a9238bd1
• File name should be nullable.
  andy840119 · 2022-10-30 16:29:54 +08:00
  505ec800da
• Remove nullable disable annotation in some checks class.
  andy840119 · 2022-10-30 16:28:49 +08:00
  db48a57fa7
• Remove nullable disable annotation in the issue and issue template-related class.
  andy840119 · 2022-10-30 16:25:15 +08:00
  24c27e62f6
• Migrate the majority of existing file lookups to use new extension methods
  Dean Herbert · 2022-08-10 16:01:16 +09:00
  ac99c1ad69
• Replace usages of string.To{Lower,Upper}()
  Bartłomiej Dach · 2022-06-24 11:57:45 +02:00
  26c5b59f6d
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix CI reported warnings
  Dean Herbert · 2022-01-12 22:39:00 +09:00
  51251e3204
• Replace compatibility properties with direct references
  Dean Herbert · 2022-01-12 18:13:14 +09:00
  eb70a1eeb7
• Fix some null inspections
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  3811bd8520
• Move StoragePath implementation to an extension method
  Dean Herbert · 2021-11-19 16:08:38 +09:00
  59e763467f
• Properly dispose of Stream in bg quality check
  Naxesss · 2021-11-10 05:06:11 +01:00
  b888185799
• Fix another case of incorrect null checking in editor verification processing
  Dean Herbert · 2021-11-04 15:18:10 +09:00
  e43d91ad5d
• Fix another couple of cases of incorrect string null/empty checking
  Dean Herbert · 2021-11-04 14:22:28 +09:00
  1e73b09e57
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Merge branch 'master' into file-sanity-checks
  Bartłomiej Dach · 2021-10-14 00:17:29 +02:00
  c7db286b94
• Refactor to use scoped using (and also correctly dispose TagLib portion)
  Dean Herbert · 2021-10-12 10:46:26 +09:00
  82f7f99f37
• Dispose of video resource later

  We need the Stream to stay open here because `StreamFileAbstraction` uses it later in the block.

  Naxesss · 2021-10-12 00:40:39 +02:00
  f2f97602f2
• Dispose of Streams when used
  Naxesss · 2021-10-12 00:13:38 +02:00
  47b4d03145
• Use Prescan flag for audio length check
  Naxesss · 2021-10-11 23:57:23 +02:00
  ce69dd3588
• Use TagLib instead of ManagedBass
  Naxesss · 2021-10-11 13:56:26 +02:00
  8f093b9a11
• Only check each video file once
  Naxesss · 2021-10-11 13:55:50 +02:00
  f0cd18a721
• Change to non-BASS error template
  Naxesss · 2021-10-11 13:53:23 +02:00
  6aa054b5fa
• Add zero-length objects check and tests
  Naxess · 2021-07-13 10:50:11 +02:00
  6da2a3d51f
• Fix misplaced "f" in issue message
  Naxess · 2021-07-13 06:07:04 +02:00
  dc4285582b
• Add audio in video check and tests
  Naxess · 2021-07-13 04:17:41 +02:00
  c8f58cbf6c
• Add too short audio files check and tests
  Naxess · 2021-07-13 03:46:45 +02:00
  a4a1919842
• Add zero byte check and tests
  Naxess · 2021-07-13 03:45:21 +02:00
  0a8fd01b99
• Add check for spanDuration <= 0 prior to division
  Naxess · 2021-06-27 15:40:09 +02:00
  9f9e96ce9e
• Improve acceptable difference for repeat edges

  Likelihood that `spanDuration` is greater than E+7 is quite low in any realistic case, so this should work fine.

  Naxess · 2021-06-27 15:39:31 +02:00
  a4a5325b73
• Improve precision for repeat edges
  Naxess · 2021-06-27 03:26:35 +02:00
  4cfa0ae5ec
• Add "or equal to" to volume threshold xmldocs
  Naxess · 2021-06-27 02:30:12 +02:00
  2cd7eda3c4
• Order hitobjects by endtime
  Naxess · 2021-06-27 01:25:03 +02:00
  0c0fd291d9
• Use local variables for hasHitsound & couldHaveHitsound
  Naxess · 2021-06-27 00:04:30 +02:00
  4796b1b208
• Rename hasHitsounds -> mapHasHitsounds
  Naxess · 2021-06-26 23:49:25 +02:00
  5bc08ebadb
• Add negligible template to PossibleTemplates
  Naxess · 2021-06-26 23:49:06 +02:00
  d29e6f4695
• Use HitSampleInfo.AllAdditions instead of new list
  Naxess · 2021-06-26 23:48:28 +02:00
  1913084342
• Factor out edge type logic
  Naxess · 2021-06-26 20:45:31 +02:00
  f78cc9397e
• Make || and && priority explicit
  Naxess · 2021-06-26 20:44:39 +02:00
  51147405c5
• Add few hitsounds check
  Naxess · 2021-06-26 19:20:46 +02:00
  4b436b774d
• Add muted objects check
  Naxess · 2021-06-26 19:20:34 +02:00
  d8117fa730
• Add local variable for regular access to HitObjects
  Dean Herbert · 2021-05-14 16:23:45 +09:00
  fcb226bd20
• Move IBeatmap arg into context
  Naxess · 2021-05-13 11:24:22 +02:00
  19800f5f7f
• Rename "playableBeatmap" check arg to "beatmap"

  The working beatmap is now in the context, so it's easier to distinguish beatmap type, hence no need for this prefix.

  Naxess · 2021-05-12 02:34:16 +02:00
  b7bc42e0d3
• Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks

  This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.
  
  See next commit for example.

  Naxess · 2021-05-12 02:29:18 +02:00
  c13b93e6f1
• Remove negligible default hidden TODO
  Naxess · 2021-05-12 01:31:16 +02:00
  75adec57eb
• Rename methods to match generally how these find-methods are named elsewhere
  Dean Herbert · 2021-04-28 16:57:52 +09:00
  f3c7694eeb
• Move snap/divisor helper methods to inside ControlPointInfo
  Dean Herbert · 2021-04-28 16:47:30 +09:00
  48d6c9ac4b
• Rename unsnap check templates
  Naxess · 2021-04-27 13:56:05 +02:00
  200352b750
• Change category of unsnap check to timing

  Makes more sense, as this is typically the result of timing changes.

  Naxess · 2021-04-27 02:32:57 +02:00
  7a6e9e5070