1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-21 10:32:55 +08:00
Commit Graph

144 Commits

Author SHA1 Message Date
ekrctb
abf96db545 Add regression test for the pattern of using DHO proxy in LifetimeManagementContainer 2021-05-20 15:27:08 +09:00
Salman Ahmed
cd6d070b4a Consider "combo offsets" as legacy logic and separate from combo information 2021-05-05 07:43:08 +03:00
Salman Ahmed
78794935b4 Handle combo colour lookups in other skins 2021-05-05 07:15:11 +03:00
ekrctb
39bccc5048 Revert "Adopt HitObjectContainer change in a test"
This reverts commit f55aa016
2021-05-04 16:45:24 +09:00
ekrctb
5aa522b1c2 Completely delegate DHO lifetime to Entry lifetime
A downside is lifetime update is not caught by LifetimeManagementContainer if used.
2021-04-29 14:38:01 +09:00
ekrctb
f55aa016be Adopt HitObjectContainer change in a test
Non-pooled objects are attached as children only while alive
2021-04-29 14:38:01 +09:00
ekrctb
003553aba3 Add test of HitObjectLifetimeEntry.KeepAlive behavior 2021-04-27 18:10:44 +09:00
ekrctb
7980d16b4c Add failing test showing the issue of DHO lifetime 2021-04-27 14:26:12 +09:00
smoogipoo
f144661c31 Fix storyboard sample test scene 2021-04-20 18:26:30 +09:00
smoogipoo
5da18c51a4 Fix compile error 2021-04-20 17:27:37 +09:00
smoogipoo
80473a356e Merge branch 'fix-pre-seek-sample-lifetime' into gcc-abstraction 2021-04-20 17:27:01 +09:00
smoogipoo
281c2041b2 Add failing test 2021-04-20 16:51:00 +09:00
smoogipoo
88ded95e75 Ensure clock is set in GCC.Start() 2021-04-20 13:56:13 +09:00
smoogipoo
44e13a91ad Rename test scene to match class 2021-04-16 20:51:42 +09:00
smoogipoo
1aa36818df Abstractify GameplayClockContainer 2021-04-14 17:47:11 +09:00
Bartłomiej Dach
aec859b4d1 Merge branch 'master' into fix-unsafe-skinnable-sample-play 2021-03-18 19:51:46 +01:00
Ronnie Moir
f6d3cd6413 Change SamplePlaybackWithRateMods to use rate calulated from the sample
Replace hardcoded numbers
2021-02-23 21:25:59 +00:00
Ronnie Moir
dbde47fe94 Fix test failure 2021-02-23 19:43:04 +00:00
Dean Herbert
00574a5288 Use ISample everywhere in Skin GetSample lookup path 2021-02-18 18:32:28 +09:00
smoogipoo
de9d075f94 Initial sample + samplechannel rework 2021-01-19 17:11:40 +09:00
Dean Herbert
10c2745682 Add region specifications around implicit interface implementations 2020-12-22 12:01:09 +09:00
Dean Herbert
a5bcf1dc20 Expose resources to skin via interface (and share common pieces with beatmap) 2020-12-21 15:18:52 +09:00
smoogipoo
832d52a056 Fix hitobject sample tests 2020-11-13 18:19:07 +09:00
Bartłomiej Dach
164370bc7d Resolve more CA1805 inspections 2020-11-01 20:51:23 +01:00
smoogipoo
cb6b35116a Merge branch 'master' into scoring-standardisation 2020-10-01 12:28:51 +09:00
smoogipoo
4ef7ab2872 Fix tests 2020-09-29 16:33:38 +09:00
smoogipoo
bad48d6d44 Merge branch 'master' into scoring-standardisation 2020-09-29 16:33:38 +09:00
smoogipoo
31fae045fa Update judgement processors with new hit results 2020-09-29 16:33:38 +09:00
Dean Herbert
136843c8e4 Make DrawableStoryboardSample a SkinnableSound
Allows sharing pause logic with gameplay samples.
2020-09-29 14:25:39 +09:00
smoogipoo
9a24346a00 Fix HP drain edgecase potentially causing insta-fails 2020-09-25 23:29:40 +09:00
Dean Herbert
a1ec167982 Add the ability to toggle new combo state from composer context menu 2020-09-23 16:38:16 +09:00
smoogipoo
447fd07b4e Fix maps with only bonus score having NaN scores 2020-09-11 01:13:55 +09:00
Dean Herbert
357fb3a10e Merge branch 'master' into beatmap-track-rework 2020-08-21 12:53:09 +09:00
smoogipoo
a4ad0bd174 Ensure 0 score from miss judgements, add test 2020-08-18 19:51:26 +09:00
Dean Herbert
93a8bc3d5a Remove local reset method in GameplayClockContainer 2020-08-17 22:36:09 +09:00
Dean Herbert
d9debef156 Add explicit LoadTrack method 2020-08-17 15:38:16 +09:00
smoogipoo
e87f50f74f Rename method 2020-08-07 22:31:41 +09:00
smoogipoo
2e3ecf71c7 Pass track from Player to components 2020-08-06 18:31:08 +09:00
Dan Balasescu
b448ca3efe
Merge branch 'master' into merge-global-to-legacy 2020-08-03 16:00:52 +09:00
Bartłomiej Dach
2df5fafea0 Add failing test case 2020-07-30 21:39:45 +02:00
Bartłomiej Dach
5af45bcdcc Expand tests to cover non-bank sample lookups 2020-07-30 20:10:41 +02:00
Salman Ahmed
5439099b7c Merge GlobalSkinConfiguration settings into the LegacySetting enum 2020-07-29 10:35:51 +03:00
smoogipoo
9f7750e615 Add texture wrapping support to skins 2020-07-17 16:54:30 +09:00
smoogipoo
acfb6eecc6 Fix bonus judgements being required toward HP 2020-07-11 20:17:40 +09:00
Dan Balasescu
7a6098bfb7
Merge branch 'master' into layered-hit-sounds 2020-06-26 18:38:32 +09:00
Dan Balasescu
1eaa25e75e
Merge branch 'master' into storyboard-sample-rate 2020-06-26 17:29:38 +09:00
Bartłomiej Dach
c7d2ce12eb Add failing test cases 2020-06-22 20:08:32 +02:00
Bartłomiej Dach
4bba0c7359 Move abstract sample test to main game project 2020-06-21 22:28:19 +02:00
Bartłomiej Dach
4a8a673d41 Decouple abstract sample test from TestResources 2020-06-21 22:28:19 +02:00
Bartłomiej Dach
599543acb6 Extract abstract hitobject sample test class 2020-06-21 22:28:19 +02:00
Bartłomiej Dach
34476f6c2f Delegate to base in a more consistent manner 2020-06-19 20:12:17 +02:00
Bartłomiej Dach
1d5084c355 Use {Initial,Final}Rate instead of SpeedChange 2020-06-19 20:11:12 +02:00
Ronnie Moir
0046cc08e9 Add test cases for different mods and rates.
Cleanup test scene.
2020-06-19 18:40:36 +01:00
smoogipoo
22f3fd487b Mark test as headless 2020-06-19 22:43:25 +09:00
Ronnie Moir
f04f2d2175 Add test scene 2020-06-18 21:46:32 +01:00
Salman Ahmed
eb64c4752c
Merge remote-tracking branch 'upstream/master' into cache-ruleset-dependencies-for-tests 2020-06-15 11:31:12 +03:00
Dan Balasescu
904b688b4b
Merge branch 'master' into test-scene-create-ruleset 2020-06-15 16:40:02 +09:00
Dan Balasescu
6d38c4003e
Merge pull request #9287 from peppy/fix-zero-time-storyboard-sample
Fix storyboard sample playback failing when expected to play at 0ms
2020-06-15 12:13:08 +09:00
Dean Herbert
fdf7c56ba2 Add test coverage 2020-06-15 11:20:20 +09:00
Dean Herbert
1164a10483 Add test coverage 2020-06-14 11:35:49 +09:00
Dean Herbert
9746e24d1e Rename abstract TestScene 2020-06-12 19:40:54 +09:00
Salman Ahmed
84b40ea2c6
Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset
# Conflicts:
#	osu.Game.Rulesets.Catch.Tests/TestSceneBananaShower.cs
#	osu.Game.Rulesets.Catch.Tests/TestSceneHyperDash.cs
#	osu.Game/Tests/Visual/ModTestScene.cs
#	osu.Game/Tests/Visual/OsuTestScene.cs
2020-06-03 22:00:02 +03:00
Bartłomiej Dach
e650b10b5e Add test case for maximal break 2020-05-11 19:03:41 +02:00
Bartłomiej Dach
ee2ff77b89 Merge branch 'master' into fix-draining-in-between-break-sections 2020-05-10 17:57:44 +02:00
Salman Ahmed
92df4e3a9e Remove PlayerTestScene constructor and use CreateRuleset method instead 2020-04-17 11:17:51 +03:00
smoogipoo
72707a9973 Fix OS-dependent substring 2020-04-15 13:54:23 +09:00
smoogipoo
10486a0ad2 Fix potential dependency-related issues 2020-04-14 23:10:14 +09:00
smoogipoo
64d44dedcd Make testscene headless 2020-04-14 22:39:51 +09:00
smoogipoo
00d564d29c Add tests 2020-04-14 21:18:28 +09:00
Salman Ahmed
e10c973aa6 Add test cases for behaviour of ruleset dependencies caching on tests 2020-04-11 04:24:34 +03:00
Salman Ahmed
c902ba4086 Add test cases for HP draining not applied before a break and after it 2020-04-05 21:46:07 +03:00
Dean Herbert
d99b445720 Move non-headless tests to correct namespace 2020-03-30 10:00:28 +09:00
Dean Herbert
4070b2b75f Merge branch 'basic-replay-recorder' into replay-recording 2020-03-24 16:31:14 +09:00
Dean Herbert
417ff837ac Add basic tests 2020-03-24 16:22:54 +09:00
Dean Herbert
8484d201d1 Nest and rename test classes 2020-03-24 15:54:04 +09:00
Dean Herbert
2735a2250c Move replay recorder to final location 2020-03-24 15:49:52 +09:00
Dean Herbert
388cf5c83a Fix catch positional data being incorrectly recorded 2020-03-24 15:38:54 +09:00
Dean Herbert
14a85a84bf Add proper screen space - gamefield mapping 2020-03-23 20:06:18 +09:00
Dean Herbert
6d48068061 Move replay recorder to final location 2020-03-23 20:04:15 +09:00
Dean Herbert
d5bc4915e6 Add "important" frames and record rate options 2020-03-23 19:02:45 +09:00
Dean Herbert
467066112f Initial record/playback implementation 2020-03-23 18:50:16 +09:00
Dean Herbert
232c255986 Basic test scene setup 2020-03-23 17:33:02 +09:00
Dean Herbert
a047456354 Revert changes to make HitObject abstract 2020-02-25 19:07:15 +09:00
Dean Herbert
ffc7eaa3f2 Fix hitobjects with unknown lifetimes by enforcing non-null judgement
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.

This fixes BananaShower and JuiceStreams in osu!catch.

This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
Dean Herbert
7460018cd3 Move combo colours to GlobalSkinColours 2020-02-07 14:58:07 +09:00
smoogipoo
91735ff367 Update MathUtils namespace usages 2020-01-09 13:43:44 +09:00
Bartłomiej Dach
49c252ec78 Mark storyboard sample retrieval test headless 2020-01-06 07:33:59 +01:00
smoogipoo
878e9f182e Add storyboard sample test scene 2020-01-02 15:23:41 +09:00
smoogipoo
7507fee9f9 Add test for HP rewind 2019-12-27 16:55:46 +09:00
smoogipoo
7ee0370d23 Add some tests 2019-12-26 17:48:46 +09:00
Salman Ahmed
55be4478aa Merge remote-tracking branch 'upstream/master' into fallback-to-skin-combo-colours 2019-12-21 12:36:09 +03:00
smoogipoo
5664ce3109 Add hitobject container regression test 2019-12-18 18:51:12 +09:00
iiSaLMaN
517f547590 Fix failing test 2019-11-07 19:12:18 +03:00
smoogipoo
89f50b26f7 Fix hitobject combo colour potentially not getting adjusted 2019-10-18 17:32:11 +09:00