Joseph Madamba
c36232bc02
Fix results screen accuracy circle not showing correctly for failed S with no flair
2024-03-07 00:10:30 -08:00
Dan Balasescu
e0fe33a7a7
Merge pull request #27513 from bdach/osu-score-conversion-bad-very-not-good
...
Fix osu! standardised score estimation algorithm violating basic invariants
2024-03-07 17:05:32 +09:00
Bartłomiej Dach
aa3cd402ca
Fix broken english
2024-03-06 21:30:31 +01:00
Bartłomiej Dach
3121cf81e6
Bump score version
2024-03-06 21:30:09 +01:00
Dean Herbert
13f7480d79
Merge branch 'master' into sb-lifetime-improvements
2024-03-06 19:27:40 +08:00
Dean Herbert
5b6703ec0d
Move optimisation to isolated method
2024-03-06 19:25:13 +08:00
Dean Herbert
29a37e3585
Merge pull request #27491 from bdach/f-rank-appearance
...
Update F rank badge colours to match latest designs
2024-03-06 18:55:20 +08:00
Bartłomiej Dach
08609e19d6
Fix osu! standardised score estimation algorithm violating basic invariants
...
As it turns out, the "lower" and "upper" estimates of the combo portion
of the score being converted were misnomers. In selected cases
(scores with high accuracy but combo being lower than max by more than
a few objects) the janky score-based math could overestimate the count
of remaining objects in a map. For instance, in one case the numbers
worked out something like this:
- Accuracy: practically 100%
- Max combo on beatmap: 571x
- Max combo for score: 551x
The score-based estimation attempts to extract a "remaining object
count" from score, by doing something along of sqrt(571^2 - 551^2). That
comes out to _almost 150_. Which leads to the estimation overshooting
the total max combo count on the beatmap by some hundred objects.
To curtail this nonsense, enforce some basic invariants:
- Neither estimate is allowed to exceed maximum achievable
- Ensure that lower estimate is really lower and upper is really upper
by just looking at the values and making sure that is so rather than
just saying that it is.
2024-03-06 11:40:10 +01:00
Dan Balasescu
d8003ab8e8
Merge pull request #27489 from bdach/fix-catch-pp-mismatch
...
Fix catch pp calculator not matching live with respect to miss handling
2024-03-06 19:39:20 +09:00
Bartłomiej Dach
b740481eaf
Merge pull request #27504 from peppy/replay-state-sanity-1
...
Never set `waitingOnFrames` if a replay is not attached
2024-03-06 09:51:09 +01:00
Bartłomiej Dach
53fffc6a75
Remove unused using directives
2024-03-06 07:57:59 +01:00
Dean Herbert
06c7483347
Merge branch 'master' into update-framework
2024-03-06 12:36:05 +08:00
Dean Herbert
85364d25dc
Merge pull request #27276 from bdach/medals
...
Add flow for displaying achieved medals
2024-03-06 12:31:55 +08:00
Dean Herbert
3a224211aa
Update various packages which shouldn't cause issues
2024-03-06 12:17:00 +08:00
Dean Herbert
4c7678225e
Update framework
2024-03-06 12:13:41 +08:00
Dean Herbert
0696e7de52
Update ImageSharp usages
2024-03-06 12:13:12 +08:00
Dean Herbert
b53b752e54
Update usage of MathUtils
2024-03-06 12:13:12 +08:00
Dean Herbert
6455c0583b
Update usage of CircularProgress.Current
2024-03-06 12:13:10 +08:00
Dean Herbert
65ce4ca390
Never set waitingOnFrames if a replay is not attached
2024-03-06 04:37:11 +08:00
Dean Herbert
57daaa7fed
Add logging for GameplayClockContainer starting or stopping
2024-03-06 04:37:11 +08:00
Bartłomiej Dach
09c6c5d79b
Merge pull request #27497 from frenzibyte/mod-select-overlay-fix-ux
...
Fix mod select overlay settings order not always matching mod panels
2024-03-05 19:40:13 +01:00
Bartłomiej Dach
429fa8dfae
Merge pull request #27242 from Susko3/log-global-statistics
...
Log `GlobalStatistics` when exporting logs from settings
2024-03-05 19:32:54 +01:00
Berkan Diler
6fabbe2616
Use new ToDictionary() overload without delegates
2024-03-05 10:27:12 +01:00
Salman Ahmed
9543908c7a
Fix mod select overlay settings order not always matching panels order
2024-03-04 23:36:45 +03:00
Bartłomiej Dach
6080c14dd5
Update F rank badge colours to match latest designs
2024-03-04 14:47:49 +01:00
Bartłomiej Dach
dcd6b02809
Fix incorrect implementation of GetCountMiss() for catch
2024-03-04 11:49:12 +01:00
Dan Balasescu
5bd037fe8f
Merge branch 'master' into catch-fail-on-banana
2024-03-04 13:13:26 +09:00
Salman Ahmed
85f131d2f8
Fix "unranked explaination" tooltip text using incorrect translation key
2024-03-02 22:45:15 +03:00
Andrei Zavatski
77b3055978
Improve sb sprite end time guessing
2024-03-01 22:30:44 +03:00
Salman Ahmed
17e167cc1e
Merge branch 'master' into hide-beatmap-details
2024-03-01 16:21:03 +03:00
Dean Herbert
c6201ea5de
Remove unused ruleset parameter when testing beatmap in editor
2024-03-01 20:28:52 +08:00
Dan Balasescu
14519b9982
Merge pull request #27426 from peppy/disallow-backwards-seeks-gameplay
...
Fix gameplay seeking backwards for a single frame for some users
2024-03-01 20:08:23 +09:00
Dean Herbert
963c0af814
Fix beatmap information still showing when testing a beatmap
2024-03-01 16:43:47 +08:00
Dean Herbert
19ed78eef5
Log backwards seeks to sentry
2024-03-01 12:40:05 +08:00
cdwcgt
4ad8bbb9e2
remove useless DrawablePool
2024-03-01 13:20:37 +09:00
Dean Herbert
00527da27d
When discord is set to privacy mode, don't show beatmap being edited
2024-03-01 11:42:35 +08:00
Dean Herbert
91483bdc2f
Merge pull request #27001 from Susko3/windows-file-uri-association
...
Associate with files and URIs on windows
2024-03-01 11:26:44 +08:00
Dean Herbert
4b3a5bde28
Merge pull request #27424 from frenzibyte/taiko-slider-storyboard
...
Hide osu!taiko scroller when the beatmap has storyboard
2024-03-01 10:49:12 +08:00
Andrei Zavatski
eb0933c3a5
Fix allocations in EffectPointVisualisation
2024-02-29 20:35:20 +03:00
Dean Herbert
cc8b838bd4
Add comprehensive log output to help figure out problematic clocks
2024-02-29 23:05:28 +08:00
Dean Herbert
4184a5c1ef
Add flag to allow backwards seeks in tests
2024-02-29 23:05:28 +08:00
Dean Herbert
3a780e2b67
Add logging when workaround is hit
2024-02-29 18:27:50 +08:00
Dean Herbert
3355764a68
"Fix" tests
2024-02-29 18:21:44 +08:00
Bartłomiej Dach
ee2dac35e0
Merge branch 'master' into taiko-slider-storyboard
2024-02-29 08:50:58 +01:00
Dean Herbert
76e8aee9cc
Disallow backwards seeks during frame stable operation when a replay is not attached
2024-02-29 14:15:32 +08:00
Dean Herbert
f44aadaaa8
Merge pull request #27331 from bdach/statistics-updates-in-multi
...
Show user statistics updates on multiplayer and playlists results screens
2024-02-29 12:26:48 +08:00
Dean Herbert
5c404d0f61
Merge pull request #27361 from bdach/difficulty-peppy-stars-zero-osu
...
Fix incorrect standardised score estimation on selected beatmaps in osu! ruleset
2024-02-29 11:45:53 +08:00
Salman Ahmed
7f5f3804f1
Expose beatmap storyboard as part of GameplayState
2024-02-29 05:39:36 +03:00
Salman Ahmed
a7a758400c
Merge branch 'master' into fix-wireframe
2024-02-29 01:56:50 +03:00
Salman Ahmed
8f97f0503f
Move away from Solo namespace
2024-02-29 01:21:17 +03:00
