5400 Commits

Author	SHA1	Message	Date
smoogipoo	c138e3907e	Move methods below ctor	2020-02-06 14:35:45 +09:00
Dean Herbert	fd71a53717	Fix test regression	2020-02-06 14:28:09 +09:00
Dean Herbert	a84386ba01	Merge branch 'simplify-mp-subscreen-disables' into lounge-ruleset-filtering	2020-02-06 14:22:52 +09:00
Dean Herbert	81cadb7875	Simplify the way multiple subscreens handle their disable states via a custom stack	2020-02-06 14:22:01 +09:00
Dean Herbert	114fd967c1	Revert "Remove leasing at a Multiplayer screen level" ... This reverts commit 304a071e39.	2020-02-06 13:47:34 +09:00
Dean Herbert	d00b61de99	Merge branch 'master' into lounge-ruleset-filtering	2020-02-06 13:38:27 +09:00
Dean Herbert	e548a4b8dd	Fix missing bind causing regression in filter	2020-02-06 13:36:49 +09:00
Dean Herbert	94b6564b98	Merge branch 'master' into editor-slider-repeat	2020-02-06 13:16:39 +09:00
Dean Herbert	75eb9ca040	Merge pull request #7739 from peppy/fix-rooms-test-scene ... Fix rooms test scene not displaying anything	2020-02-06 13:12:10 +09:00
Dean Herbert	061b8c389f	Fix null search string causing an exception	2020-02-06 13:03:04 +09:00
Dean Herbert	1dc7fc4a33	Fix case where playlist is empty	2020-02-06 13:01:48 +09:00
Dan Balasescu	38bf14a06c	Merge branch 'master' into editor-beatmap-component	2020-02-06 12:25:33 +09:00
Dean Herbert	a79d6ff27a	Change transition to better handle mass filter cases	2020-02-06 12:17:20 +09:00
Dean Herbert	304a071e39	Remove leasing at a Multiplayer screen level	2020-02-06 12:17:20 +09:00
Dean Herbert	50c4e34c92	Add ruleset to multiplayer filter criteria	2020-02-06 12:17:20 +09:00
Dean Herbert	00edc7e66f	Fix RoomsContainer test scene not displaying	2020-02-06 12:14:17 +09:00
Dean Herbert	f5edad16e6	Improve visuals	2020-02-05 19:43:13 +09:00
Dean Herbert	98ab1f9862	Fix negative spinners	2020-02-05 18:35:31 +09:00
Dean Herbert	3d42973764	Allow scrolling via drag while dragging a hold note handle	2020-02-05 18:35:31 +09:00
Dean Herbert	cef45afbc8	Add a simple hover state	2020-02-05 18:35:31 +09:00
Dean Herbert	d56accaef1	Disallow negative / zero repeat counts (and fix off-by-one)	2020-02-05 18:35:31 +09:00
Dean Herbert	d04cc0123d	Initial implementation of timeline blueprint dragbars	2020-02-05 18:35:31 +09:00
Dean Herbert	96986bf5fc	Remove beat divisor from ctor and use DI instead	2020-02-05 17:48:21 +09:00
Dean Herbert	63c595ed97	Make EditorBeatmap a component and move UpdateHitObject to it	2020-02-05 17:48:21 +09:00
Dan Balasescu	27c24fb08a	Merge pull request #7721 from recapitalverb/display-accuracy ... Add {ScoreInfo,UserStatistics}.Accuracy	2020-02-04 16:16:33 +09:00
Dan Balasescu	0e3c1ed0f7	Merge branch 'master' into fix-key-counter-visible-on-reshowing-hud	2020-02-04 14:06:23 +09:00
recapitalverb	79bb476f4c	Merge branch 'master' into display-accuracy	2020-02-04 11:39:47 +07:00
Dan Balasescu	3600b0daf0	Merge branch 'master' into fix-mod-select-overflowing	2020-02-04 11:57:54 +09:00
Joehu	22e3150f68	Fix comment and remove magic numbers	2020-02-03 17:21:06 -08:00
Salman Ahmed	4cd4055e7c	Rename to AlwaysVisible and add XMLDoc	2020-02-03 20:00:43 +03:00
Salman Ahmed	51ed289c59	Revert namings and behaviour changes	2020-02-03 19:59:58 +03:00
recapitalverb	9898a926b2	Use ScoreInfo.DisplayAccuracy everywhere	2020-02-03 22:11:36 +07:00
Salman Ahmed	351cb8ac1a	Rename Visible to HasReplayLoaded and change default value ... Doesn't make sense to be true by default	2020-02-03 15:47:52 +03:00
Salman Ahmed	443063263e	Merge remote-tracking branch 'upstream/master' into fix-key-counter-visible-on-reshowing-hud	2020-02-03 15:18:25 +03:00
Dan Balasescu	c6e7603e5e	Merge branch 'master' into safe-screen-lease	2020-02-03 18:18:13 +09:00
Dan Balasescu	93952d438f	Merge pull request #7677 from peppy/decouple-mod-select-bindable ... Decouple ModSelectOverlay from global SelectedMods	2020-02-03 16:27:47 +09:00
Dean Herbert	591c7b6250	Merge pull request #7682 from peppy/fix-timeline-tick-overrun ... Fix too many ticks being displayed on beatmaps with multiple timing sections	2020-02-03 16:16:23 +09:00
Dean Herbert	9183c78319	Fix crash on exiting song select with ctrl-enter autoplay	2020-02-03 16:04:32 +09:00
Salman Ahmed	4cdf4b223c	Rename to alwaysShow and add XMLDoc	2020-02-02 18:47:12 +03:00
Salman Ahmed	28e340c486	Inherit Container and fade the key flow instead of individual children	2020-02-02 18:46:27 +03:00
Dean Herbert	aa1daa0ad5	Merge pull request #7703 from bdach/beatmap-stats-precision ... Apply precision when determining bar colour in difficulty statistics	2020-02-02 22:31:52 +09:00
Salman Ahmed	6a11c3a8f9	Expose ConfigVisibility bindable for testing purposes	2020-02-02 14:48:07 +03:00
Salman Ahmed	abccf05155	Update visibility of each key counter instead of this container ... For isolating changing visibility of the key counter display based on config and internal values from just fading the container.	2020-02-02 14:47:14 +03:00
Bartłomiej Dach	434c0d92e4	Use Bindable{Float,Double}s everywhere ... To avoid further floating-point comparison bugs, remove all usages of Bindable<{float,double}>, replacing them with their Bindable<Float,Double> counterparts.	2020-02-01 22:50:29 +01:00
Bartłomiej Dach	e894acf53c	Make star filter range bindables BindableDoubles ... Due to using Bindable<double>s previously, song select's filter control would not apply tolerance when checking IsDefault, therefore wrongly hiding maps with star ratings above 10.1.	2020-02-01 22:48:46 +01:00
Joehu	609ee26030	Fix mod select overlay not showing up in test	2020-02-01 11:41:41 -08:00
Joehu	2d42a83bb9	Fix mod select overlay overflowing toolbar at max ui scale	2020-02-01 11:24:29 -08:00
Bartłomiej Dach	0bfadfbbf1	Apply precision when comparing adjusted values ... In some cases, applying the Difficulty Adjust mod without actually changing any of the settings previously caused the bar in song select beatmap details to appear red/blue instead of staying white. This was caused by not accounting for floating-point imprecisions when determining bar colour in AdvancedStats. To resolve, first check equality with tolerance, and only then apply blue/red colours if that equality check does not hold.	2020-02-01 16:16:15 +01:00
Bartłomiej Dach	a74d22d9e5	Extract beatmap stats test to separate scene	2020-02-01 15:50:33 +01:00
Dean Herbert	ed368e44ea	Merge branch 'master' into safe-screen-lease	2020-02-01 02:11:18 +09:00
Dean Herbert	c5422743e2	Merge branch 'master' into decouple-mod-select-bindable	2020-02-01 02:06:23 +09:00
Dean Herbert	90caa61245	Reverse comparison for readability ... Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-02-01 02:05:26 +09:00
Dean Herbert	a66cdee5e9	Fix missed issues	2020-01-31 21:36:19 +09:00
Dean Herbert	19f516e710	Ensure OsuScreen level leases are taken out synchronously	2020-01-31 19:10:44 +09:00
Dean Herbert	a547d2ed5c	Don't least at Player just yet	2020-01-31 18:37:16 +09:00
Dean Herbert	2f61d3f5ad	Fix song select remaining issue locally	2020-01-31 17:35:53 +09:00
Dean Herbert	5f48affcba	Centralise screen exit logic to ScreenTestScene	2020-01-31 14:19:29 +09:00
Dean Herbert	f51cfa2220	Fix too many ticks being displayed on beatmaps with multiple timing sections ... Closes https://github.com/ppy/osu/issues/7681.	2020-01-31 00:24:00 +09:00
Dean Herbert	7bf2e9b369	Decouple ModSelectOverlay from global SelectedMods	2020-01-30 17:38:15 +09:00
Dan Balasescu	09f6c57b0f	Merge branch 'master' into fix-import-different-ruleset	2020-01-30 15:08:25 +09:00
Dan Balasescu	c18b1b302c	Merge branch 'master' into editor-match-accessibility	2020-01-30 13:49:56 +09:00
Dean Herbert	c158570249	Fix typo in comment ... Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-01-30 11:31:34 +09:00
Dean Herbert	f72de235cc	Remove unnecessary length specifications	2020-01-30 11:00:14 +09:00
Dean Herbert	37ecf8a060	Remove commented line	2020-01-30 10:50:48 +09:00
Dean Herbert	bea20efb64	Merge branch 'master' into mod_content_centering	2020-01-30 10:34:46 +09:00
Bartłomiej Dach	f130e48c9e	Remove leftover negative margin	2020-01-29 19:17:07 +01:00
Bartłomiej Dach	c9dda78ded	Refactor drawable hierarchy to center properly ... * Use FillFlowContainer.Spacing instead of manually applying margins. * Use Update() for calculating button padding to preserve it after mod button expansion and adjust FooterButtonRandom to use this method while avoiding flickering. * Expose mod display margin to clear it in the footer button.	2020-01-29 18:59:51 +01:00
Dean Herbert	da6952407e	Allow null DI	2020-01-29 23:01:57 +09:00
Dean Herbert	13eb32fea2	Fix editor being accessible for multiplayer song select	2020-01-29 22:20:34 +09:00
smoogipoo	76af8bea5d	Fix percentage-formatted displays containing a space	2020-01-29 19:51:24 +09:00
Dean Herbert	7588c574a2	Fix presenting a beatmap from a different ruleset not working	2020-01-29 19:37:54 +09:00
Dan Balasescu	db3e360229	Merge branch 'master' into fix-carousel-missing-import	2020-01-29 18:06:27 +09:00
Dean Herbert	77c06b1c6e	Fix beatmap carousel potentially missing beatmap imports	2020-01-29 17:09:12 +09:00
Dan Balasescu	66b8d38d42	Merge branch 'master' into selection-composition-conformity	2020-01-29 16:52:45 +09:00
Dan Balasescu	e553a9b9e0	Merge branch 'master' into distance-snap-grid-correct-colouring	2020-01-29 16:09:35 +09:00
Dan Balasescu	63501c188a	Merge pull request #7644 from peppy/standardise-zoom-levels ... Standardise editor timeline zoom across maps of all lengths	2020-01-29 16:04:25 +09:00
Dan Balasescu	018c005c71	Merge branch 'master' into distance-snap-grid-correct-colouring	2020-01-29 15:33:07 +09:00
Dan Balasescu	0d6fd0a54a	Merge branch 'master' into standardise-zoom-levels	2020-01-29 15:32:57 +09:00
Dan Balasescu	65ac412ff8	Merge branch 'master' into fix-beat-snap	2020-01-29 15:32:27 +09:00
smoogipoo	391681b7af	Separate calculation to follow other examples	2020-01-29 15:16:48 +09:00
Dean Herbert	7d05840ee0	Merge branch 'master' into select-tool	2020-01-29 15:04:22 +09:00
Dan Balasescu	ea2ee53ee3	Merge branch 'master' into timline-beat-lines	2020-01-29 14:44:07 +09:00
smoogipoo	9a47428bfd	Remove out of date comment	2020-01-29 14:40:42 +09:00
Dan Balasescu	abe0041b65	Merge branch 'master' into select-tool	2020-01-29 14:29:12 +09:00
Dan Balasescu	4d43833db4	Merge branch 'master' into timline-beat-lines	2020-01-29 14:12:00 +09:00
Dan Balasescu	b10143fdf2	Merge branch 'master' into fix-key-count-mod-affect	2020-01-29 14:11:59 +09:00
Dean Herbert	12ff51f686	Fix key count being incorrectly adjusted by hard/easy mods	2020-01-28 17:21:50 +09:00
Dean Herbert	40379a5e22	Use foreach	2020-01-28 16:04:13 +09:00
Dean Herbert	dbb89cfde7	Merge remote-tracking branch 'upstream/master' into timline-beat-lines	2020-01-28 16:03:50 +09:00
Dean Herbert	8e2159e4eb	Ensure selection tool correctly matches selection state ... - When a selection is made (via the timeline) the selection tool should become the select tool. - When the selection tool is changed to anything *but* the select tool, the selection should be cleared.	2020-01-28 15:13:12 +09:00
Dean Herbert	e81d3c51ed	Move select tool to an actual tool implementation ... Also tidies up radio button action firing so calling Select actually fires the associated action in all cases.	2020-01-28 15:05:29 +09:00
Dean Herbert	596a01661c	Remove 1ms offset and update tests	2020-01-28 13:42:22 +09:00
unknown	aa264cd2a8	allow tooltip to show as percentage as needed	2020-01-28 12:32:30 +08:00
Dean Herbert	4bb33046ca	Standardise editor timeline zoom across maps of all lengths	2020-01-28 13:03:06 +09:00
Dean Herbert	58654f28b6	Fix beat snap implementation being incorrect	2020-01-28 12:48:24 +09:00
Dean Herbert	29daabb40a	Fix distance snap grid showing incorrect colouring ... Now matches timeline colours (based on timing point).	2020-01-28 11:59:21 +09:00
Dean Herbert	d5fda053f4	Use centre origin/anchors	2020-01-27 18:09:54 +09:00
Dean Herbert	493390b750	Rename class to TimelineTickDisplay	2020-01-27 18:08:01 +09:00
Dean Herbert	084fa2f04a	Add timeline beat display	2020-01-27 17:38:50 +09:00
Dean Herbert	e24c4ab901	Adjust zoom defaults for timeline to be more useful	2020-01-27 17:34:40 +09:00