Dean Herbert
5350945340
Update HasFlag usages
2024-07-03 00:19:04 +09:00
Salman Ahmed
48bf3f1385
Migrate mod select overlay footer content
2024-06-30 06:50:36 +03:00
Dean Herbert
8f9b2106d6
Merge pull request #28620 from normalid-awa/ui/mod-select-color-improvement
...
Optimize Text Color For Mod Multiplier Text
2024-06-27 13:56:12 +09:00
normalid
936a8d800d
Swap the low and high multiplier color
2024-06-26 21:39:14 +08:00
Dean Herbert
6beae91d53
Ensure carousel panel depth is consistent based on vertical position
...
I thought this was already being handled, but it turns out that changing
sort mode (and potentially other operations) could break the depth of
display of panels due to pooling and what not.
This ensures consistency and also employs @bdach's suggestion of
reversing the depth above and below the current selection for a better
visual effect.
2024-06-26 21:10:29 +09:00
Dean Herbert
e84daedbea
Reduce length of fade-out when hiding beatmap panels
2024-06-26 12:01:38 +09:00
Dean Herbert
5d4509150b
Adjust beatmap carousel's spacing to remove dead-space
...
As discussed in https://github.com/ppy/osu/discussions/28599 .
I think this feels better overall, and would like to apply the change
before other design changes to the carousel.
2024-06-26 11:56:58 +09:00
Bartłomiej Dach
659505f711
Adjust calls to GetContainingInputManager()
2024-06-18 07:41:19 +02:00
Bartłomiej Dach
8a4ae5d23d
Null-propagate all calls to GetContainingFocusManager()
2024-06-18 07:30:46 +02:00
Salman Ahmed
6201220994
Merge branch 'master' into footer-v2-become-global
2024-06-08 14:13:05 +03:00
Dean Herbert
dd3f4bcdab
Fix code quality and null handling
2024-06-07 00:01:50 +08:00
Xesquim
860afb8123
Creating method in ModUtils to calculate the rate for the song
2024-06-06 10:06:07 -03:00
Bartłomiej Dach
c800bb5339
Merge branch 'master' into lazer-speedkeys
2024-05-24 13:19:26 +02:00
Bartłomiej Dach
b1b207960a
Actually use return value
2024-05-24 13:09:44 +02:00
Bartłomiej Dach
63406b6feb
Rewrite implementation
2024-05-24 13:03:42 +02:00
Dean Herbert
66ceda1d67
Update focus specifications in line with framework changes
2024-05-22 21:32:49 +08:00
Fabian van Oeffelt
0df634574f
Improve readability
2024-05-22 13:59:33 +02:00
Dean Herbert
1fdebe94ac
Merge branch 'master' into lazer-speedkeys
2024-05-22 12:05:04 +08:00
Dean Herbert
02a388cba6
Fix enum not being at end (and adjust naming)
2024-05-22 12:03:48 +08:00
Dean Herbert
99d99cede0
Basic cleanup
...
Before I gave up on attempting to fix the method.
2024-05-22 11:59:34 +08:00
Fabian van Oeffelt
3403789c6f
Toast now only shows when speed is actually changed
2024-05-21 16:11:20 +02:00
Fabian van Oeffelt
148afd1201
Change Speedchange behaviour to keep changing while holding key, Add Toast to nofity user what just happend
2024-05-21 14:47:34 +02:00
Fabian van Oeffelt
3fdbd735ce
change to single Function,
...
Nightcore now switches into Daycore, keep Adjustpitch after change
2024-05-18 18:40:51 +02:00
Salman Ahmed
03220598b8
Move screen footer to OsuGame
2024-05-16 07:48:58 +03:00
Salman Ahmed
21f5d891bb
Rename and move footer classes to appropriate places
2024-05-16 04:41:16 +03:00
Dean Herbert
5a362be190
Merge branch 'master' into glow
2024-05-12 12:58:57 +08:00
Salman Ahmed
fa6ccc854d
Revert behavioural changes on options button
2024-05-12 05:24:45 +03:00
Thomas Mok
5e8f6df799
Add glow to footerV2 buttons
2024-05-12 01:55:18 +01:00
Dean Herbert
69d699a218
Merge branch 'master' into footer-v2-button-animation
2024-05-11 21:41:50 +08:00
Dean Herbert
a988bbd3cb
Tidy up UnrankedBadge implementation
2024-05-11 20:58:51 +08:00
Dean Herbert
ac7598cb68
Move localisation to existing file to avoid silly new class
2024-05-11 20:25:47 +08:00
Salman Ahmed
da096376af
Fix DI error in mod tooltip
2024-05-11 09:31:36 +03:00
Salman Ahmed
f64cf5c037
Fix button extending beyond unranked indicator width
2024-05-11 09:29:09 +03:00
Salman Ahmed
09c52f03d8
Fix "options" button behaving weirdly when clicking on it while open
2024-05-10 08:25:16 +03:00
Salman Ahmed
b6d6a8940b
Improve animation of new song select footer buttons
2024-05-10 08:24:39 +03:00
Salman Ahmed
0392f7b04c
Add tooltip to unranked indicator
2024-05-10 07:37:08 +03:00
Salman Ahmed
f5ab9a7ff8
Make unranked indicator orange to match mod select overlay
2024-05-10 07:12:28 +03:00
Salman Ahmed
e5b2023155
Remove unappealing fade transition between mod display and count text
...
Fading out the mod display looks quite ugly, since alpha is applied per mod sprite, introducing bad visual on the intersection between mods.
2024-05-10 07:05:36 +03:00
Salman Ahmed
6ddf8f8498
Few cleanups
2024-05-10 06:55:02 +03:00
Salman Ahmed
c1ea9d2c9f
Adjust unranked badge height
2024-05-10 06:48:18 +03:00
Salman Ahmed
bff34a1c04
Add localisation and tooltip for mods count text
2024-05-10 06:48:18 +03:00
Salman Ahmed
6b91b4abf4
Add simple implementation for extended mods display in new footer design
2024-05-10 02:20:48 +03:00
Fabian van Oeffelt
4b5ea6bd0b
Fix Code Inspection
2024-05-02 19:41:00 +02:00
Fabian van Oeffelt
fa0b6311b0
Merge branch 'master' into osu-lazer-speedkeys
2024-05-02 19:17:15 +02:00
Fabian van Oeffelt
7527ddbc68
Comment, make code more readable, functions are now private
2024-05-02 19:05:43 +02:00
Fabian van Oeffelt
f534c4aada
Initial implementation
2024-05-02 18:42:35 +02:00
Dean Herbert
387fcb8781
Add a brief inline comment to make sure we don't undo the fix
2024-04-25 21:31:36 +08:00
Bartłomiej Dach
c1107d2797
Fully refetch working beatmap when entering editor
...
Closes https://github.com/ppy/osu/issues/21794 .
I'm not actually super sure as to what the exact mode of failure is
here, but it's 99% to do with working beatmap cache invalidation. Likely
this can be even considered as another case of
https://github.com/ppy/osu/issues/21357 , but because this is a one-liner
"fix," I'm PRing it anyways.
The issue is confusing to understand when working with the swap scenario
given in the issue, but it's a little easier to understand when
performing the following:
1. Have a beatmap set with 2 difficulties. Let's call them "A" and "B".
2. From song select, without ever exiting to main menu, edit "A". Change
the difficulty name to "AA". Save and exit back to song select; do
not exit out to main menu.
3. From song select, edit "B". Change the difficulty name to "BB". Save
and exit back to song select.
4. The difficulty names will be "A" and "BB".
Basically what I *think* is causing this, is the fact that even though
editor invalidates the working beatmap by refetching it afresh on exit,
song select is blissfully unaware of this, and continues working with
its own `BeatmapInfo` instances which have backlinks to
`BeatmapSetInfo`.
When editing the first of the two difficulties and then the second,
the editing of the first one only invalidates the first one rather than
the entire set, and the second difficulty continues to have a stale
reference to the first one via the beatmap set, and as such ends up
overwriting the changes from the first save when passed into the editor
and modified again.
2024-04-25 14:31:13 +02:00
Dan Balasescu
343b3ba0e6
Don't re-filter unless mods may change the filter
2024-04-15 21:07:36 +09:00
Dan Balasescu
d12a2e7df7
Replace schedule with SequenceEqual()
2024-04-01 17:02:02 +09:00
Dan Balasescu
6e746a0fa0
Fix carousel reoder on initial enter
2024-03-28 23:56:46 +09:00
Dan Balasescu
9fd6449fd8
Add mods to FilterCriteria, pass to ruleset method
2024-03-28 23:03:26 +09:00
Dan Balasescu
10edb54614
Add ability to query key count with mods
2024-03-28 22:51:12 +09:00
Bartłomiej Dach
56dc6bb192
Merge branch 'master' into feat/support-filtering-for-multiple-types
2024-03-26 12:39:51 +01:00
Bartłomiej Dach
e52d51cd0a
Update OptionalSet implementation to intersect across multiple filters rather than union
2024-03-26 12:32:03 +01:00
Bartłomiej Dach
a1880e89c2
Use title as tiebreaker when sorting beatmap carousel by artist
...
Closes https://github.com/ppy/osu/issues/27548 .
Reference: e53980dd76/osu
2024-03-22 08:41:10 +01:00
Bartłomiej Dach
af3f7dcbbf
Retouch update criteria method
2024-03-19 18:33:35 +01:00
Bartłomiej Dach
320373e3e0
Rename method to match convention better
2024-03-19 18:28:13 +01:00
Bartłomiej Dach
feaf59e15f
Use HashSet instead of SortedSet
...
No need for it to be sorted.
2024-03-19 18:26:58 +01:00
Vlad Frangu
77119b2cdb
chore: correct doc string
2024-03-18 16:44:42 +02:00
Vlad Frangu
d0678bfbee
chore: requested changes
2024-03-18 15:30:43 +02:00
Vlad Frangu
e1c1609271
chore: correct equal logic
2024-03-16 21:48:44 +02:00
Vlad Frangu
0a6960296e
feat: Support filtering for multiple statuses
2024-03-16 21:32:55 +02:00
Dean Herbert
f44aadaaa8
Merge pull request #27331 from bdach/statistics-updates-in-multi
...
Show user statistics updates on multiplayer and playlists results screens
2024-02-29 12:26:48 +08:00
Bartłomiej Dach
a5948d38ac
Merge pull request #27380 from frenzibyte/fix-advanced-stats-display
...
Fix advanced stats in beatmap info overlay showing "key count" on non-mania beatmaps
2024-02-28 18:02:48 +01:00
Bartłomiej Dach
6a3a7cca58
Merge branch 'master' into adjust-carousel-padding
2024-02-28 16:00:43 +01:00
Dean Herbert
8e336610d0
Add xmldoc explaining Ruleset bindable's usage
2024-02-26 18:31:40 +08:00
Salman Ahmed
5c049feca1
Fix advanced stats in beatmap info overlay showing "key count" on non-mania beatmaps
2024-02-25 21:18:15 +03:00
Bartłomiej Dach
869f0a82de
Use hashset for faster lookup
2024-02-23 15:38:52 +01:00
Dean Herbert
157819c199
Materialise realm collection hashes during song select search process
...
Without this, there's a large overhead to do a realm-live `Contains`
search when a collection is selected.
This may also help considerably alleviate
https://github.com/ppy/osu/discussions/27298#discussioncomment-8552508
as we will be performing the native realm search much less.
2024-02-23 11:41:27 +08:00
Bartłomiej Dach
0074bdc5a1
Change ResultsScreen constructor boolean params to init-only properties
2024-02-22 20:15:03 +01:00
Bartłomiej Dach
46c8560ca5
Merge branch 'master' into multiplayer-difficulty-tooltip
2024-02-22 12:08:29 +01:00
Bartłomiej Dach
d06c67ad8f
Substitute two jank interdependent bool flags for single tri-state enums
2024-02-22 12:05:50 +01:00
Bartłomiej Dach
1a831145ce
Merge branch 'master' into fix-bpm-differences
2024-02-22 10:41:22 +01:00
Bartłomiej Dach
81a9908c60
Extract common helper for BPM rounding
2024-02-22 10:27:37 +01:00
Dean Herbert
fb593470d5
Use DEFAULT instead of INSTANCE or static field
...
Matches other similar comparers.
2024-02-21 21:02:20 +08:00
Bartłomiej Dach
929858226a
Use custom comparer in beatmap carousel for expected sort behaviour
2024-02-21 12:43:18 +01:00
Andrei Zavatski
2543a48ac8
Apply padding to GridContainers directly
2024-02-20 23:18:37 +03:00
Dean Herbert
6960f87509
Merge pull request #26895 from vmfunc/ordinal-sorting
...
Consider case sensitivity when sorting beatmaps in song select
2024-02-18 04:05:22 +08:00
Dean Herbert
674ee91bb5
Define aggregate max delegates as static to further reduce allocations
2024-02-15 11:40:50 +08:00
Dean Herbert
80abf6aab3
Avoid some further enumerator allocations
2024-02-15 09:45:24 +08:00
Andrei Zavatski
6e1b4152c0
Redice allocations during aggregate beatmap sort
2024-02-15 00:01:55 +03:00
Bartłomiej Dach
ae9a2661ac
Sprinkle some raw string prefixes
2024-02-14 16:20:47 +01:00
Bartłomiej Dach
414066fd34
Inline problematic function (and rename things to make more sense)
2024-02-14 16:07:42 +01:00
Bartłomiej Dach
a8ae0a032f
Simplify parsing
2024-02-14 15:58:38 +01:00
Bartłomiej Dach
c24328dda3
Abandon date filter if no meaningful time bound found during parsing
2024-02-14 15:56:32 +01:00
Bartłomiej Dach
f0f37df67f
Revert unnecessary change
2024-02-14 15:37:02 +01:00
Bartłomiej Dach
1113355753
Merge branch 'master' into add-last-played-filter
2024-02-14 15:36:19 +01:00
Stoppedpuma
ca0819cf7a
Alias "mapper" as well
2024-02-11 20:28:16 +01:00
Stoppedpuma
7c04e8bfba
Alias author to creator
...
Allows "author" to show the results of "creator"
2024-02-10 07:48:24 +01:00
Bartłomiej Dach
865f4d76ff
Add unranked indicator to song select footer too
2024-02-01 21:51:41 +01:00
Bartłomiej Dach
f87ab19731
Apply NRT to FooterButtonMods
2024-02-01 21:32:38 +01:00
syscats
0407b5d84a
use ordinal sorting on each method
2024-02-01 14:03:59 +01:00
syscats
7165511754
Use ordinal sorting for artist string comparison
2024-01-31 15:49:31 +01:00
Bartłomiej Dach
acc2614090
Apply alternative solution
...
Fixes the logo flying out of the wrong corner when transitioning from
song select to gameplay.
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-01-29 20:07:27 +01:00
Dean Herbert
f2546d72c2
Fix osu! logo being mispositioned in song select on very wide resolutions
2024-01-29 20:45:51 +09:00
Dean Herbert
cc341b4119
Adjust beatmap carousel padding to avoid scrollbar disappearing underneath logo
2024-01-25 15:21:19 +09:00
Dean Herbert
02bb506cce
Avoid using .Children for enumeration in other locations
2024-01-23 05:32:11 +09:00
Dean Herbert
1f0ad5cff2
Apply same fix in more places
2024-01-22 15:56:16 +09:00
Dean Herbert
74f05a5c4b
Use container itself rather than ScrollContent
2024-01-22 15:54:24 +09:00
