193 Commits

Author	SHA1	Message	Date
Henry Lin	261fae6873	Move checks out of PopIn()	2022-01-20 08:39:33 +08:00
Henry Lin	0d708efb73	Split off PerformanceBreakdown and its own calculation logic	2022-01-19 15:33:33 +08:00
Henry Lin	31e03e99cd	Improve display of "total PP"	2022-01-18 22:11:43 +08:00
Henry Lin	a5b53c01c8	Add comments and tidy up	2022-01-18 21:59:51 +08:00
Henry Lin	43e5bd731c	Compare performance to a perfect play	2022-01-18 21:57:12 +08:00
Henry Lin	83387cb00b	Add a comment	2022-01-17 21:41:17 +08:00
Henry Lin	eddf453294	Fix code quality issues	2022-01-17 21:32:13 +08:00
Henry Lin	c49cd60487	Add bar chart to tooltip	2022-01-17 21:26:55 +08:00
Henry Lin	85c60bfc2d	Improve tooltip design	2022-01-17 20:36:18 +08:00
Henry Lin	511a607599	Display performance breakdown in a tooltip	2022-01-17 18:28:17 +08:00
Susko3	19467e58c1	Remove unused params from BDL methods	2022-01-15 01:06:39 +01:00
Dean Herbert	00177a3ae1	Update usages to new naming	2022-01-06 22:54:43 +09:00
Dean Herbert	3ea7588a91	Update continuation usages to use GetCompletedResult	2022-01-06 22:53:07 +09:00
Dean Herbert	73b40e6833	Replace usage of .Result with .WaitSafelyForResult	2022-01-04 11:51:41 +09:00
Bartłomiej Dach	15feb17da8	Change difficulty cache storage type to nullable ... The recent changes related to adding support for working beatmap load cancellation exposed a flaw in the beatmap difficulty cache. With the way the difficulty computation logic was written, any error in the calculation process (including beatmap load timeout, or cancellation) would result in a 0.00 star rating being permanently cached in memory for the given beatmap. To resolve, change the difficulty cache's return type to nullable. In failure scenarios, `null` is returned, rather than `default(StarDifficulty)` as done previously.	2021-11-20 17:00:50 +01:00
Dean Herbert	51a353e12d	Rename BeatmapInfo.Version to DifficultyName to match underlying interface	2021-11-11 17:20:53 +09:00
Dean Herbert	62600b47b1	Merge branch 'master' into user-class-cleanup	2021-11-08 12:51:12 +09:00
Bartłomiej Dach	6d30248cef	Merge branch 'master' into use-class-rename	2021-11-07 15:41:00 +01:00
Dean Herbert	0ecf5f201c	Rename User to APIUser and move to correct namespace	2021-11-07 11:26:01 +09:00
Dean Herbert	6399c695e8	Update usages of BufferedContainer in line with framework changes	2021-11-05 15:54:49 +09:00
Dean Herbert	86540d1fb6	Update existing usages of Author as string to access Username directly	2021-11-04 18:57:54 +09:00
Dean Herbert	b9983add15	Rename User to APIUser and move to correct namespace	2021-11-04 18:21:31 +09:00
Dean Herbert	6944151486	Apply batch fixing of built-in types using var	2021-10-27 13:04:41 +09:00
Dean Herbert	853cf6feaa	Rename last remaining BeatmapInfo Beatmap usage	2021-10-04 17:35:53 +09:00
Salman Ahmed	d4399f10f9	Merge both variants of the star rating display	2021-08-04 18:19:28 +03:00
Salman Ahmed	b5970d5cdc	Handle pitch black background case	2021-08-04 01:52:48 +03:00
Salman Ahmed	9a5e052dc0	Use star difficulty colour spectrum game-wide	2021-08-03 15:02:18 +03:00
Lucas A	ff3d38de6f	Localise accuracy display.	2021-07-23 22:37:08 +02:00
Dean Herbert	8e1f8c28bd	Use default value to denote no play date, rather than null	2021-07-20 19:05:08 +09:00
Dean Herbert	662822a40c	Avoid showing time of play on results screen when autoplay ... Closes https://github.com/ppy/osu/issues/13940.	2021-07-20 15:19:44 +09:00
PercyDan54	e1c646b9b2	Remove redundant arguments	2021-07-05 23:52:39 +08:00
smoogipoo	a78d1b4c2e	Update SR colours to match osu-web	2021-07-01 19:37:21 +09:00
Dean Herbert	4a4a561ca4	Merge pull request #13330 from nekodex/results-screen-sfx ... Add sound effects to the results screen	2021-06-10 18:27:17 +09:00
Dean Herbert	0667354fbd	Remove unused resolved skin	2021-06-10 17:30:04 +09:00
Dean Herbert	4f8000a574	Combine cases which return the same value	2021-06-10 17:29:36 +09:00
Dean Herbert	31b46afa71	Fix wrong naming scheme for applause samples	2021-06-09 19:35:05 +09:00
Dean Herbert	7d86dafd4f	Simplify tick calculation/playback method	2021-06-09 19:31:53 +09:00
Dean Herbert	57bc34f224	Move consts closer to usage	2021-06-09 19:24:35 +09:00
Dean Herbert	cb4f366651	Move forgotten private function down more	2021-06-09 19:15:55 +09:00
Dean Herbert	81cecac90b	Move tick rate initialisation to earlier	2021-06-09 19:09:00 +09:00
Dean Herbert	499aba95c0	Simplify sample construction logic and move private functions down	2021-06-09 19:06:37 +09:00
Dean Herbert	21a63efd78	Rename variable back to withFlair to match parent class	2021-06-09 18:55:29 +09:00
Dean Herbert	330bb7cb45	Remove unnecessary skin lookup logic	2021-06-09 18:55:29 +09:00
Dean Herbert	7774344f0e	Remove "Unranked" text from ModDisplay	2021-06-09 13:45:09 +09:00
Jamie Taylor	054de675ff	allow skinned 'applause' sample to override results screen sfx	2021-06-03 18:35:55 +09:00
Jamie Taylor	582360d0c8	only load the required impact/applause samples	2021-06-03 18:35:51 +09:00
Jamie Taylor	ed012a724b	refactor from using public variables	2021-06-03 18:35:46 +09:00
Jamie Taylor	8dc595d201	move result screen samples to DefaultSkin	2021-06-03 18:35:27 +09:00
Jamie Taylor	63e5bc4543	update sample names and timings	2021-06-03 18:34:33 +09:00
Jamie Taylor	9ad87ee5dc	add sfx for results screen + sound design tool	2021-06-03 18:34:22 +09:00
Dean Herbert	b2c736b42a	Combine and move const closer to usage	2021-05-19 18:09:46 +09:00
Vinicius Barbosa	d05ffdf120	Added constants for delay value	2021-05-18 20:19:18 +02:00
Vinicius Barbosa	06fffc499b	Removed unused variables and directives	2021-05-18 16:56:07 +02:00
Vinicius Barbosa	76a377f3e0	Fixed applause sound stopping after switching scores	2021-05-18 15:30:45 +02:00
Bartłomiej Dach	8b4e6d2911	Remove no longer necessary FinishTransforms(true) call ... As the component no longer has any transition transforms applied.	2021-05-14 22:03:35 +02:00
Salman Ahmed	6cc678f497	Remove nullability and transition support from star rating display	2021-05-14 16:05:40 +03:00
Salman Ahmed	afc9a1bf23	Remove rolling support and apply few adjustments	2021-05-10 10:16:52 +03:00
Salman Ahmed	1c49590ba2	Apply further refactoring to star rating display UX-wise	2021-05-10 08:56:30 +03:00
Salman Ahmed	301dab1ce8	Refactor StarRatingDisplay to be mutable with a current bindable	2021-05-10 08:56:30 +03:00
Dean Herbert	e82eaffaed	Flip order back to original for romanisable strings	2021-02-25 14:14:07 +09:00
Dean Herbert	8a97e2e28d	Update LocalisedString usages to RomanisedString	2021-02-22 19:01:42 +09:00
Dean Herbert	1fd76ea3fb	Apply changes to UI components overriding functions with changing signatures	2021-02-22 19:01:42 +09:00
Dean Herbert	c5b172d0dd	Remove synchronous lookup path from BeatmapDifficultyCache	2020-11-06 14:53:15 +09:00
Dean Herbert	0103b12575	Add basic base class to begin to standardise function across caching components	2020-11-06 13:26:39 +09:00
Dean Herbert	14bb079feb	Rename ScorePerformanceManager to ScorePerformanceCache	2020-11-06 13:15:33 +09:00
Dean Herbert	5113d4af8f	Rename BeatmapDifficultyManager to BeatmapDifficultyCache	2020-11-06 13:14:29 +09:00
Dean Herbert	73b290aca3	Merge branch 'master' into results-dynamic-pp-calc	2020-11-02 14:47:33 +09:00
Lucas A	6bfff43634	Extract StatisticCounter to a separate class and use it instead.	2020-11-01 13:25:36 +01:00
Dean Herbert	6a293dd536	Add missing ctor parameters back	2020-10-31 18:56:30 +09:00
Dean Herbert	979eb1685b	Merge branch 'master' into results-screen-applause	2020-10-31 18:47:49 +09:00
Dean Herbert	0c1d12460f	Remove unused parameter	2020-10-30 10:30:11 +09:00
Dean Herbert	f1b8a8f7f5	Remove unused using	2020-10-29 18:16:04 +09:00
Dean Herbert	0a0239a7c7	Only play results panel animation once (and only for the local user)	2020-10-29 17:08:59 +09:00
Dean Herbert	71e373ff51	Make results panels aware of whether they are a local score that has just been set	2020-10-29 17:08:59 +09:00
Dean Herbert	4a26084df8	Only play results panel animation once (and only for the local user)	2020-10-29 17:04:33 +09:00
Dean Herbert	5d5b0221e5	Add skinning support for legacy applause playback	2020-10-29 16:32:29 +09:00
Dean Herbert	fb82c043a5	Add rank appear sound (new default)	2020-10-29 16:11:37 +09:00
Dean Herbert	a8e9c62583	Make results panels aware of whether they are a local score that has just been set	2020-10-29 16:11:25 +09:00
Dean Herbert	9141f48b04	Remove beatmap-based ctor to promote single flow	2020-10-23 14:57:27 +09:00
Lucas A	cf69eacae9	Make StarRatingDisplay dynamic.	2020-10-21 19:05:14 +02:00
Bartłomiej Dach	ba818e3ae0	Merge branch 'master' into results-dynamic-pp-calc	2020-10-19 21:41:07 +02:00
Bartłomiej Dach	68b505ab86	Extract helper function for pp value handling	2020-10-12 22:14:45 +02:00
Lucas A	e845cc92b8	Round pp values to nearest integer.	2020-10-10 19:58:06 +02:00
Lucas A	de522d53ea	Make CalculatePerformanceAsync() nullable.	2020-10-10 19:16:21 +02:00
Lucas A	a425cf4a31	Fix broken class reference.	2020-10-07 13:29:10 +02:00
Lucas A	7f5cf04b2b	Fix merge conflicts.	2020-10-07 13:28:49 +02:00
Dean Herbert	67398b5d95	Move timestamp text out of flow and attach to bottom edge	2020-10-07 16:30:14 +09:00
Dean Herbert	c0bc6a75b3	Show auxiliary judgements on next line	2020-10-07 16:17:17 +09:00
Dean Herbert	e281d724b8	Consume display name logic	2020-10-07 15:43:52 +09:00
Lucas A	35f7de2084	Apply review suggestions.	2020-09-29 18:08:21 +02:00
Lucas A	6efc4c4250	Cache performance calculations to prevent recomputations.	2020-09-28 19:04:39 +02:00
Lucas A	ddede85704	Split performance calculation to its own class.	2020-09-27 12:44:29 +02:00
Lucas A	3cb9103fe0	Inherit PerformanceStatistic from CounterStatistic	2020-09-27 09:37:57 +02:00
Lucas A	4d94bf3163	Rename CalculateScorePerformance -> CalculatePerformance	2020-09-25 19:16:33 +02:00
Lucas A	77a9d92f42	Add dynamic pp calculation to score panels for local scores	2020-09-25 19:15:40 +02:00
smoogipoo	a07597c369	Adjust displays to use new results/orderings	2020-09-25 20:22:59 +09:00
smoogipoo	37a659b2af	Refactor/add xmldocs	2020-09-09 17:36:47 +09:00
smoogipoo	117c7ec6b2	Merge branch 'master' into score-recalc	2020-09-09 14:38:36 +09:00
Dean Herbert	a171d0e292	Remove unused methods and classes	2020-08-31 18:14:22 +09:00
smoogipoo	c1838902a6	Add to more places	2020-08-28 22:51:48 +09:00